tun: call dev_get_valid_name() before register_netdevice()
authorCong Wang <xiyou.wangcong@gmail.com>
Fri, 13 Oct 2017 18:58:53 +0000 (11:58 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Oct 2017 20:02:54 +0000 (21:02 +0100)
commit0ad646c81b2182f7fa67ec0c8c825e0ee165696d
tree82aef9de787aa5f334a4802314385d8e8e443138
parent2459b4c635858094df78abb9ca87d99f89fe8ca5
tun: call dev_get_valid_name() before register_netdevice()

register_netdevice() could fail early when we have an invalid
dev name, in which case ->ndo_uninit() is not called. For tun
device, this is a problem because a timer etc. are already
initialized and it expects ->ndo_uninit() to clean them up.

We could move these initializations into a ->ndo_init() so
that register_netdevice() knows better, however this is still
complicated due to the logic in tun_detach().

Therefore, I choose to just call dev_get_valid_name() before
register_netdevice(), which is quicker and much easier to audit.
And for this specific case, it is already enough.

Fixes: 96442e42429e ("tuntap: choose the txq based on rxq")
Reported-by: Dmitry Alexeev <avekceeb@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c
include/linux/netdevice.h
net/core/dev.c