openwrt/staging/blogic.git
17 years agoPatch to work arounf flex issues with newer version of flex with some distros.
Hamish Guthrie [Mon, 7 May 2007 14:32:00 +0000 (14:32 +0000)]
Patch to work arounf flex issues with newer version of flex with some distros.

SVN-Revision: 7123

17 years agoFix some HCD driver warnings
Florian Fainelli [Mon, 7 May 2007 11:17:22 +0000 (11:17 +0000)]
Fix some HCD driver warnings

SVN-Revision: 7120

17 years agoar7: Fix volatile usage. Thanks Christopher Pascoe.
Eugene Konev [Mon, 7 May 2007 05:17:26 +0000 (05:17 +0000)]
ar7: Fix volatile usage. Thanks Christopher Pascoe.

SVN-Revision: 7119

17 years agorevert to the previous version of the flash map driver - committed the wrong one...
Felix Fietkau [Sun, 6 May 2007 18:30:53 +0000 (18:30 +0000)]
revert to the previous version of the flash map driver - committed the wrong one in [7092]

SVN-Revision: 7118

17 years agoprevent dropbear from closing the tty prematurely if the readfd closes
Felix Fietkau [Sun, 6 May 2007 17:53:16 +0000 (17:53 +0000)]
prevent dropbear from closing the tty prematurely if the readfd closes

SVN-Revision: 7117

17 years agoFix ipv6 address assignment (#1622).
Eugene Konev [Sun, 6 May 2007 16:52:46 +0000 (16:52 +0000)]
Fix ipv6 address assignment (#1622).

SVN-Revision: 7116

17 years agofix firmware loading
Felix Fietkau [Sun, 6 May 2007 16:03:38 +0000 (16:03 +0000)]
fix firmware loading

SVN-Revision: 7115

17 years agoMark script as executable.
Eugene Konev [Sun, 6 May 2007 16:02:54 +0000 (16:02 +0000)]
Mark script as executable.

SVN-Revision: 7114

17 years agoar7: fix adam2patcher.
Eugene Konev [Sun, 6 May 2007 15:30:04 +0000 (15:30 +0000)]
ar7: fix adam2patcher.

SVN-Revision: 7110

17 years agoar7: Add minimal kgdb implementation (#114).
Eugene Konev [Sun, 6 May 2007 15:25:02 +0000 (15:25 +0000)]
ar7: Add minimal kgdb implementation (#114).

SVN-Revision: 7109

17 years agoDrop ar7-net, not used in ar7-2.6.
Eugene Konev [Sun, 6 May 2007 15:06:10 +0000 (15:06 +0000)]
Drop ar7-net, not used in ar7-2.6.

SVN-Revision: 7108

17 years agoUse console config from adam2/pspboot environment (#1623).
Eugene Konev [Sun, 6 May 2007 13:30:38 +0000 (13:30 +0000)]
Use console config from adam2/pspboot environment (#1623).

SVN-Revision: 7107

17 years agoEnable ide compilation and support for aec62xx and pdc20xx modules
Florian Fainelli [Sun, 6 May 2007 12:02:54 +0000 (12:02 +0000)]
Enable ide compilation and support for aec62xx and pdc20xx modules

SVN-Revision: 7106

17 years agoar7: cpmac better reset handling and napi implementation.
Eugene Konev [Sun, 6 May 2007 11:37:41 +0000 (11:37 +0000)]
ar7: cpmac better reset handling and napi implementation.

SVN-Revision: 7105

17 years agoCosmetic fixes for the ADM5120 description, both have pci and usb
Florian Fainelli [Sun, 6 May 2007 11:28:36 +0000 (11:28 +0000)]
Cosmetic fixes for the ADM5120 description, both have pci and usb

SVN-Revision: 7104

17 years agoEnable USB support for au1000
Florian Fainelli [Sun, 6 May 2007 09:05:50 +0000 (09:05 +0000)]
Enable USB support for au1000

SVN-Revision: 7103

17 years agoAdd some diagnostic stuff for ar7
Florian Fainelli [Sun, 6 May 2007 08:58:04 +0000 (08:58 +0000)]
Add some diagnostic stuff for ar7

SVN-Revision: 7102

17 years agoAdd some diagnostic stuff for au1000, failsafe will need system button driver rewrite
Florian Fainelli [Sun, 6 May 2007 08:55:41 +0000 (08:55 +0000)]
Add some diagnostic stuff for au1000, failsafe will need system button driver rewrite

SVN-Revision: 7101

17 years agoUpdate the watchdog driver to make it more linux look alike
Florian Fainelli [Sun, 6 May 2007 08:47:38 +0000 (08:47 +0000)]
Update the watchdog driver to make it more linux look alike

SVN-Revision: 7100

17 years agoau1000 has pci and usb
Florian Fainelli [Sun, 6 May 2007 08:10:06 +0000 (08:10 +0000)]
au1000 has pci and usb

SVN-Revision: 7099

17 years agouse hotplug2 for serializing hotplug events on 2.6
Felix Fietkau [Sat, 5 May 2007 18:33:18 +0000 (18:33 +0000)]
use hotplug2 for serializing hotplug events on 2.6

SVN-Revision: 7097

17 years agosimplify handling of zcat - always use gzip -dc. zcat and gzcat are either broken...
Felix Fietkau [Sat, 5 May 2007 10:35:12 +0000 (10:35 +0000)]
simplify handling of zcat - always use gzip -dc. zcat and gzcat are either broken or nonexistant on some systems

SVN-Revision: 7096

17 years agoMake UCI preconfiguration optional and disabled by default
Felix Fietkau [Sat, 5 May 2007 10:06:10 +0000 (10:06 +0000)]
Make UCI preconfiguration optional and disabled by default

SVN-Revision: 7095

17 years agofix make kernel_menuconfig (#1637)
Felix Fietkau [Sat, 5 May 2007 08:53:34 +0000 (08:53 +0000)]
fix make kernel_menuconfig (#1637)

SVN-Revision: 7094

17 years agoadd wl-hdd ide workaround from #272
Felix Fietkau [Fri, 4 May 2007 22:14:14 +0000 (22:14 +0000)]
add wl-hdd ide workaround from #272

SVN-Revision: 7093

17 years agoconvert brcm-2.4 to the new target structure
Felix Fietkau [Fri, 4 May 2007 22:13:42 +0000 (22:13 +0000)]
convert brcm-2.4 to the new target structure

SVN-Revision: 7092

17 years agoadd qos-scripts connbytes match from #1618
Felix Fietkau [Fri, 4 May 2007 22:10:40 +0000 (22:10 +0000)]
add qos-scripts connbytes match from #1618

SVN-Revision: 7091

17 years agofix gpio interrupts on broadcom (thanks, jpcass)
Felix Fietkau [Fri, 4 May 2007 17:35:58 +0000 (17:35 +0000)]
fix gpio interrupts on broadcom (thanks, jpcass)

SVN-Revision: 7090

17 years agoChanged partitioning not to use at91part.c as opposed to using command-line partitioning.
Hamish Guthrie [Fri, 4 May 2007 11:29:40 +0000 (11:29 +0000)]
Changed partitioning not to use at91part.c as opposed to using command-line partitioning.

SVN-Revision: 7089

17 years agomake sure the ramdisk generation will work when you have defined a special TIMEFMT
Florian Fainelli [Thu, 3 May 2007 17:21:08 +0000 (17:21 +0000)]
make sure the ramdisk generation will work when you have defined a special TIMEFMT

SVN-Revision: 7088

17 years agonuke ar7-2.4 (old code, dsl driver no longer compiles, replaced by ar7-2.6)
Felix Fietkau [Thu, 3 May 2007 16:42:37 +0000 (16:42 +0000)]
nuke ar7-2.4 (old code, dsl driver no longer compiles, replaced by ar7-2.6)

SVN-Revision: 7087

17 years agoAdd support for Sierra Wireless (#1620)
Florian Fainelli [Thu, 3 May 2007 10:58:50 +0000 (10:58 +0000)]
Add support for Sierra Wireless (#1620)

SVN-Revision: 7086

17 years agoReduce the probing time, should fix #1212
Florian Fainelli [Thu, 3 May 2007 10:23:05 +0000 (10:23 +0000)]
Reduce the probing time, should fix #1212

SVN-Revision: 7085

17 years agospiflash cleanup
Felix Fietkau [Thu, 3 May 2007 09:50:20 +0000 (09:50 +0000)]
spiflash cleanup

SVN-Revision: 7084

17 years agoModified GPIO allocation per rev1.02 board
Hamish Guthrie [Thu, 3 May 2007 05:11:34 +0000 (05:11 +0000)]
Modified GPIO allocation per rev1.02 board

SVN-Revision: 7083

17 years agoupgrade npe microcode to v2.4
Imre Kaloz [Wed, 2 May 2007 12:03:43 +0000 (12:03 +0000)]
upgrade npe microcode to v2.4

SVN-Revision: 7079

17 years agobuggy script; nolonger used
Mike Baker [Tue, 1 May 2007 22:28:55 +0000 (22:28 +0000)]
buggy script; nolonger used

SVN-Revision: 7078

17 years agobackport a few usb device ids from 2.6.21 for airprime
Mike Baker [Tue, 1 May 2007 21:57:03 +0000 (21:57 +0000)]
backport a few usb device ids from 2.6.21 for airprime

SVN-Revision: 7077

17 years agovarious patches to add support for ppp over evdo or character devices
Mike Baker [Tue, 1 May 2007 21:53:32 +0000 (21:53 +0000)]
various patches to add support for ppp over evdo or character devices

SVN-Revision: 7076

17 years agoI got the first one wrong. Spacing isn't quite right. oops. (sorry Kaloz)
Mike Albon [Tue, 1 May 2007 18:59:44 +0000 (18:59 +0000)]
I got the first one wrong. Spacing isn't quite right. oops. (sorry Kaloz)

SVN-Revision: 7075

17 years agoPatch to add wait support to broadcom cpu's. This reduces the power consumption and...
Mike Albon [Tue, 1 May 2007 17:55:51 +0000 (17:55 +0000)]
Patch to add wait support to broadcom cpu's. This reduces the power consumption and heat generated on the wgt634u. Needs testing on other devices.

SVN-Revision: 7074

17 years agoAdded dependency to package IP required by Openswan
Hamish Guthrie [Tue, 1 May 2007 08:30:20 +0000 (08:30 +0000)]
Added dependency to package IP required by Openswan

SVN-Revision: 7073

17 years agomove the last change to the right place
Imre Kaloz [Mon, 30 Apr 2007 11:11:05 +0000 (11:11 +0000)]
move the last change to the right place

SVN-Revision: 7069

17 years agoset $HOME to /tmp on bootup
Imre Kaloz [Mon, 30 Apr 2007 09:59:40 +0000 (09:59 +0000)]
set $HOME to /tmp on bootup

SVN-Revision: 7068

17 years agomadwifi: fix static bssid setting for ad-hoc mode
Felix Fietkau [Sun, 29 Apr 2007 20:50:42 +0000 (20:50 +0000)]
madwifi: fix static bssid setting for ad-hoc mode

SVN-Revision: 7067

17 years agocreate /dev/root on boot - fixes cf2nand on rb532
Felix Fietkau [Sun, 29 Apr 2007 16:57:55 +0000 (16:57 +0000)]
create /dev/root on boot - fixes cf2nand on rb532

SVN-Revision: 7066

17 years agofixes for a few build errors on osx without fink
Felix Fietkau [Sun, 29 Apr 2007 01:30:48 +0000 (01:30 +0000)]
fixes for a few build errors on osx without fink

SVN-Revision: 7065

17 years agoixp4xx-2.6/npe-ucode: Updated to version 2.3.2 of the microcode.
Rod Whitby [Fri, 27 Apr 2007 23:15:55 +0000 (23:15 +0000)]
ixp4xx-2.6/npe-ucode: Updated to version 2.3.2 of the microcode.

SVN-Revision: 7063

17 years agoUpdated support for Zynos/adm5120eb boards, thanks Gabor
Florian Fainelli [Fri, 27 Apr 2007 08:29:19 +0000 (08:29 +0000)]
Updated support for Zynos/adm5120eb boards, thanks Gabor

SVN-Revision: 7061

17 years agoSmall bugfix for dependency handling - mostly for base-files and symlinks
Felix Fietkau [Thu, 26 Apr 2007 18:04:16 +0000 (18:04 +0000)]
Small bugfix for dependency handling - mostly for base-files and symlinks

SVN-Revision: 7058

17 years agoremove led fix again - seems like gpio handling is really broken in the original...
Felix Fietkau [Thu, 26 Apr 2007 16:53:58 +0000 (16:53 +0000)]
remove led fix again - seems like gpio handling is really broken in the original madwifi hal

SVN-Revision: 7057

17 years agofix for the wifi led on atheros SoC
Felix Fietkau [Thu, 26 Apr 2007 11:34:56 +0000 (11:34 +0000)]
fix for the wifi led on atheros SoC

SVN-Revision: 7053

17 years agofix kmod-* build error when wildcards are being used in $(FILES)
Felix Fietkau [Thu, 26 Apr 2007 08:06:52 +0000 (08:06 +0000)]
fix kmod-* build error when wildcards are being used in $(FILES)

SVN-Revision: 7052

17 years agofix busybox rebuild when config changes
Mike Baker [Wed, 25 Apr 2007 22:33:38 +0000 (22:33 +0000)]
fix busybox rebuild when config changes

SVN-Revision: 7051

17 years agoadd workaround for occasional kernel module build failures related to kernel config...
Felix Fietkau [Wed, 25 Apr 2007 22:26:40 +0000 (22:26 +0000)]
add workaround for occasional kernel module build failures related to kernel config changes

SVN-Revision: 7050

17 years agordc-2.6 has pci support and rt61 should be built only along with rdc-2.6
Florian Fainelli [Wed, 25 Apr 2007 11:24:06 +0000 (11:24 +0000)]
rdc-2.6 has pci support and rt61 should be built only along with rdc-2.6

SVN-Revision: 7049

17 years agoqos-scripts update - fix enabling/disabling of interfaces, make the overhead calculat...
Felix Fietkau [Tue, 24 Apr 2007 19:24:08 +0000 (19:24 +0000)]
qos-scripts update - fix enabling/disabling of interfaces, make the overhead calculation optional

SVN-Revision: 7048

17 years agofix a small typo
Felix Fietkau [Tue, 24 Apr 2007 16:54:18 +0000 (16:54 +0000)]
fix a small typo

SVN-Revision: 7047

17 years agoclean up version control junk in the rootfs directory
Felix Fietkau [Tue, 24 Apr 2007 16:29:07 +0000 (16:29 +0000)]
clean up version control junk in the rootfs directory

SVN-Revision: 7045

17 years agouse separate sysctl.conf files for 2.4 and 2.6 - fixes some boot message spam
Felix Fietkau [Tue, 24 Apr 2007 12:05:52 +0000 (12:05 +0000)]
use separate sysctl.conf files for 2.4 and 2.6 - fixes some boot message spam

SVN-Revision: 7043

17 years agoadd tcp syn cookies support (fixes one of the sysctl error messages at boot time)
Felix Fietkau [Tue, 24 Apr 2007 11:51:35 +0000 (11:51 +0000)]
add tcp syn cookies support (fixes one of the sysctl error messages at boot time)

SVN-Revision: 7042

17 years agoMake only on ar7 platforms.
Mike Albon [Tue, 24 Apr 2007 11:01:04 +0000 (11:01 +0000)]
Make only on ar7 platforms.

SVN-Revision: 7041

17 years agoAdd the adm5120eb config not as symlink
Florian Fainelli [Mon, 23 Apr 2007 06:39:38 +0000 (06:39 +0000)]
Add the adm5120eb config not as symlink

SVN-Revision: 7038

17 years agoRevert config change for adm5120, messed up things with symlinks
Florian Fainelli [Mon, 23 Apr 2007 06:38:08 +0000 (06:38 +0000)]
Revert config change for adm5120, messed up things with symlinks

SVN-Revision: 7037

17 years agoFix prompt on kernel config for brcm-2.4
Florian Fainelli [Sun, 22 Apr 2007 15:51:54 +0000 (15:51 +0000)]
Fix prompt on kernel config for brcm-2.4

SVN-Revision: 7034

17 years agoCreate /lib/firmware
Florian Fainelli [Sun, 22 Apr 2007 15:00:19 +0000 (15:00 +0000)]
Create /lib/firmware

SVN-Revision: 7033

17 years agoThe kernel should be compiled big-endian
Florian Fainelli [Sun, 22 Apr 2007 14:44:48 +0000 (14:44 +0000)]
The kernel should be compiled big-endian

SVN-Revision: 7032

17 years agoReturn -ENODEV, when device is absent. This should fix lockups on boot.
Eugene Konev [Sun, 22 Apr 2007 05:27:28 +0000 (05:27 +0000)]
Return -ENODEV, when device is absent. This should fix lockups on boot.

SVN-Revision: 7031

17 years agoAdd build-depends on linux-atm
Eugene Konev [Sun, 22 Apr 2007 04:51:16 +0000 (04:51 +0000)]
Add build-depends on linux-atm

SVN-Revision: 7030

17 years agofix host header files installation for tools (closes: #1604)
Nicolas Thill [Sat, 21 Apr 2007 22:23:33 +0000 (22:23 +0000)]
fix host header files installation for tools (closes: #1604)

SVN-Revision: 7029

17 years agofix start_pppd for pptp (closes: #1612)
Nicolas Thill [Sat, 21 Apr 2007 20:19:54 +0000 (20:19 +0000)]
fix start_pppd for pptp (closes: #1612)

SVN-Revision: 7027

17 years agoar7: add jffs2 eof marks to squashfs image
Felix Fietkau [Sat, 21 Apr 2007 17:35:20 +0000 (17:35 +0000)]
ar7: add jffs2 eof marks to squashfs image

SVN-Revision: 7026

17 years agoChanged default rootfs size for at91 to 2112k
Hamish Guthrie [Sat, 21 Apr 2007 15:01:45 +0000 (15:01 +0000)]
Changed default rootfs size for at91 to 2112k

SVN-Revision: 7025

17 years agoadd better default config for ar7, add br2684ctl init script, add a missing setting...
Felix Fietkau [Sat, 21 Apr 2007 09:37:13 +0000 (09:37 +0000)]
add better default config for ar7, add br2684ctl init script, add a missing setting for pppoa

SVN-Revision: 7024

17 years agoremove the symlink as well when removing the adam2 patcher
Felix Fietkau [Sat, 21 Apr 2007 09:34:28 +0000 (09:34 +0000)]
remove the symlink as well when removing the adam2 patcher

SVN-Revision: 7023

17 years agoadd missing dependencies for autorebuild
Felix Fietkau [Sat, 21 Apr 2007 09:21:51 +0000 (09:21 +0000)]
add missing dependencies for autorebuild

SVN-Revision: 7022

17 years agoremove debug junk
Felix Fietkau [Sat, 21 Apr 2007 00:10:28 +0000 (00:10 +0000)]
remove debug junk

SVN-Revision: 7021

17 years agoadd new ar7 dsl driver (thanks, matteo), mark ar7-2.4 as broken and enable ar7-2.6
Felix Fietkau [Fri, 20 Apr 2007 23:48:26 +0000 (23:48 +0000)]
add new ar7 dsl driver (thanks, matteo), mark ar7-2.4 as broken and enable ar7-2.6

SVN-Revision: 7020

17 years agomdev fix
Felix Fietkau [Fri, 20 Apr 2007 23:46:17 +0000 (23:46 +0000)]
mdev fix

SVN-Revision: 7019

17 years agoar7-2.6: make cpmac robust against hardware quirks when the tx or rx dma ring runs...
Felix Fietkau [Fri, 20 Apr 2007 23:43:18 +0000 (23:43 +0000)]
ar7-2.6: make cpmac robust against hardware quirks when the tx or rx dma ring runs over

SVN-Revision: 7018

17 years agoadd missing -prepare target
Felix Fietkau [Fri, 20 Apr 2007 19:04:23 +0000 (19:04 +0000)]
add missing -prepare target

SVN-Revision: 7017

17 years agofix minor bugs in the patcher init script
Felix Fietkau [Fri, 20 Apr 2007 15:17:47 +0000 (15:17 +0000)]
fix minor bugs in the patcher init script

SVN-Revision: 7015

17 years agocopy adam2 patch from ar7-2.4 to ar7-2.6
Felix Fietkau [Fri, 20 Apr 2007 15:16:51 +0000 (15:16 +0000)]
copy adam2 patch from ar7-2.4 to ar7-2.6

SVN-Revision: 7014

17 years agoremove bluetooth from kernel config
Felix Fietkau [Fri, 20 Apr 2007 15:12:26 +0000 (15:12 +0000)]
remove bluetooth from kernel config

SVN-Revision: 7013

17 years agoremove __init from prom_getenv()
Felix Fietkau [Fri, 20 Apr 2007 15:12:12 +0000 (15:12 +0000)]
remove __init from prom_getenv()

SVN-Revision: 7012

17 years agoupgrade to new version of br2684ctl
Felix Fietkau [Fri, 20 Apr 2007 15:11:18 +0000 (15:11 +0000)]
upgrade to new version of br2684ctl

SVN-Revision: 7011

17 years agoChanged the default ipkg download location for at91 platforms to my web server
Hamish Guthrie [Fri, 20 Apr 2007 14:01:12 +0000 (14:01 +0000)]
Changed the default ipkg download location for at91 platforms to my web server

SVN-Revision: 7010

17 years agoFix a typo
Florian Fainelli [Thu, 19 Apr 2007 13:24:13 +0000 (13:24 +0000)]
Fix a typo

SVN-Revision: 7008

17 years agoAdd admswconfig until we add support for adm5120 switch in kmod-switch, thanks Thomas...
Florian Fainelli [Thu, 19 Apr 2007 13:19:37 +0000 (13:19 +0000)]
Add admswconfig until we add support for adm5120 switch in kmod-switch, thanks Thomas Langer for the makefile.

SVN-Revision: 7007

17 years agowe don't need the shared library there
Imre Kaloz [Thu, 19 Apr 2007 12:06:39 +0000 (12:06 +0000)]
we don't need the shared library there

SVN-Revision: 7006

17 years agodon't try to set up wpa if hostapd is not installed
Felix Fietkau [Thu, 19 Apr 2007 11:42:39 +0000 (11:42 +0000)]
don't try to set up wpa if hostapd is not installed

SVN-Revision: 7005

17 years agothe default_subtargets template was a bad idea, since different makefiles require...
Felix Fietkau [Wed, 18 Apr 2007 17:35:46 +0000 (17:35 +0000)]
the default_subtargets template was a bad idea, since different makefiles require different types of dependencies for subtargets. nuke it...

SVN-Revision: 7003

17 years agofix up dependencies
Felix Fietkau [Wed, 18 Apr 2007 17:09:34 +0000 (17:09 +0000)]
fix up dependencies

SVN-Revision: 7002

17 years agomove the lzma decompressor out of squashfs-lzma patch and into a new patch (i want...
Felix Fietkau [Wed, 18 Apr 2007 16:03:43 +0000 (16:03 +0000)]
move the lzma decompressor out of squashfs-lzma patch and into a new patch (i want to use it for initramfs in the future)

SVN-Revision: 7001

17 years agomove hostapd setup script from wireless-tools to hostapd package
Felix Fietkau [Wed, 18 Apr 2007 12:40:27 +0000 (12:40 +0000)]
move hostapd setup script from wireless-tools to hostapd package

SVN-Revision: 7000

17 years agominor cleanup
Felix Fietkau [Wed, 18 Apr 2007 12:40:20 +0000 (12:40 +0000)]
minor cleanup

SVN-Revision: 6999

17 years agoImproved autorebuild for kernel related stuff. - make modules_install in the kernel...
Felix Fietkau [Wed, 18 Apr 2007 12:28:38 +0000 (12:28 +0000)]
Improved autorebuild for kernel related stuff. - make modules_install in the kernel tree is no longer called - make modules is called on every target/compile run - kmod packages pull the kernel modules directly out of the kernel tree and have proper file depends on them

SVN-Revision: 6998

17 years agoignore errors in the find command for dep checks
Felix Fietkau [Wed, 18 Apr 2007 10:12:50 +0000 (10:12 +0000)]
ignore errors in the find command for dep checks

SVN-Revision: 6997

17 years agoRemove this target since rb-2.6 will build both rb532 and adm5120 later on
Florian Fainelli [Tue, 17 Apr 2007 22:16:28 +0000 (22:16 +0000)]
Remove this target since rb-2.6 will build both rb532 and adm5120 later on

SVN-Revision: 6992

17 years agoMove NAND driver from rb1xx to adm5120, rbmipsnand fixed by David Goodenough, thanks !
Florian Fainelli [Tue, 17 Apr 2007 22:15:50 +0000 (22:15 +0000)]
Move NAND driver from rb1xx to adm5120, rbmipsnand fixed by David Goodenough, thanks !

SVN-Revision: 6991