Amber N. Adams [Sun, 20 Sep 2015 16:32:06 +0000 (11:32 -0500)]
staging: skein: Adds * on subsequent lines in block comment
This patch fixes the checkpatch.pl warning:
WARNING: Block comments use * on subsequent lines
+/*
+Copyright (c) 2010 Werner Dittmann
Signed-off-by: Amber N. Adams <amber@amberadams.co>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Mon, 21 Sep 2015 13:27:10 +0000 (18:57 +0530)]
Staging: fbtft: Remove debug messages
Remove debug messages related to fbtft_par_dbg(DEBUG_INIT_DISPLAY.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ting-Chih Hsiao [Mon, 21 Sep 2015 06:58:09 +0000 (14:58 +0800)]
staging: lustre-mgc: make mgc_obd_ops static
Fix sparse warnings of the following type:
warning: symbol '....' was not declared. Should it be static?
Signed-off-by: Ting-Chih Hsiao <s894330@hotmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:16 +0000 (15:51 +0900)]
staging: wilc1000: rename WILC_WFI_frame_register
This patch replaces WILC_WFI_frame_register with
wilc_mgmt_frame_register to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:15 +0000 (15:51 +0900)]
staging: wilc1000: remove declaration of WILC_WFI_frame_register
This patch removes function declaration of WILC_WFI_frame_register in
linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file.
The compilation warning occurs because it is assigned to incorrect
pointer type of second parameter of WILC_WFI_frame_register.
It is assigned with struct wireless_dev pointer type.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:17:03 +0000 (12:17 +0900)]
staging: wilc1000: delete unnecessary comments and dead code
The comments in union message_body are not essential and cross 80 ending
line, so they are deleted and also a dead code commented out in the union
is deleted.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:17:02 +0000 (12:17 +0900)]
staging: wilc1000: remove u32Intialized which is unnecessary
This patch removes the global variable, u32Intialized which is not necessary
from the host_interface.c file.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:17:01 +0000 (12:17 +0900)]
staging: wilc1000: remove unnecessary global variable
The global variable msgQ_created is removed because it is not necessary.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:17:00 +0000 (12:17 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFDelAllSta
This patch removes typedef from the struct tstrHostIFDelAllSta and
renames it to del_all_sta in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:59 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfRegisterFrame
This patch removes typedef from the struct tstrHostIfRegisterFrame and
renames it to reg_frame in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:58 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfRemainOnChan
This patch removes typedef from the struct tstrHostIfRemainOnChan and
renames it to remain_ch in order to comply with the Linux coding style
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:57 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFDelSta
This patch removes typedef from the struct tstrHostIFDelSta and renames
it del_sta in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:56 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfBASessionInfo
This patch removes typedef from the struct tstrHostIfBASessionInfo and
renames it to ba_session_info in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:55 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfGetMacAddress
This patch removes typedef from the struct tstrHostIfGetMacAddress and
renames it get_mac_addr in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:54 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfSetMacAddress
This patch removes typedef from the struct tstrHostIfSetMacAddress and
renames it set_mac_addr in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:53 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfSetOperationMode
This patch removes typedef from the struct tstrHostIfSetOperationMode
and renames it to op_mode in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:52 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFSetMulti
This patch removes typedef from the struct tstrHostIFSetMulti and
renames it to set_multicast in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:51 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfSetDrvHandler
This patch removes typedef from the struct tstrHostIfSetDrvHandler and
renames it to drv_handler in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:50 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFSetIPAddr
This patch removes typedef from the struct tstrHostIFSetIPAddr and
renames it to set_ip_addr in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:49 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfStaInactiveT
This patch removes typedef from the struct tstrHostIfStaInactiveT and
renames it to sta_inactive_t in oder to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:48 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIfPowerMgmtParam
This patch removes typedef from the struct tstrHostIfPowerMgmtParam and
renames it to power_mgmt_param in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:47 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrTimerCb
This patch removes typedef from the tstrTimerCb and renames it to
timer_cb in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:46 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrWILC_AddStaParam
This patch removes typedef from the struct tstrWILC_AddStaParam and
renames it to add_sta_param in oder to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:45 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFDelBeacon
This patch removes typedef from the struct tstrHostIFDelBeacon and
renames it to del_beacon in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:44 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFSetBeacon
This patch removes typedef from the struct tstrHostIFSetBeacon and
renames it to set_beacon in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:43 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFGetChan
This patch removes typedef from the struct tstrHostIFGetChan and renames
it to get_channel in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:42 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFSetChan
This patch removes typedef from the struct tstrHostIFSetChan and ranames
it to set_channel in order to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:41 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFCfgParamAttr
This patch removes typedef from the struct tstrHostIFCfgParamAttr and
renames it to cfg_param_attr in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:40 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFkeyAttr
This patch removes typedef from the struct tstrHostIFkeyAttr and renames
it to key_attr in oder to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:39 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrRcvdGnrlAsyncInfo
This patch removes typedef from the struct tstrRcvdGnrlAsyncInfo and
renames it to rcvd_async_info in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:38 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrRcvdNetworkInfo
This patch removes typedef from the struct tstrRcvdNetworkInfo and
renames it to rcvd_net_info in order to comply with the Linux coding
style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:37 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFconnectAttr
This patch removes typedef from the struct tstrHostIFconnectAttr and
renames it to connect_attr to comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:36 +0000 (12:16 +0900)]
staging: wilc1000: remove typedef from the struct tstrHostIFscanAttr
This patch removes typedef from the structure tstrHostIFscanAttr and
changes the camelcase name, tstrHostIFscanAttr to scan_attr in order to
comply with the Linux coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:35 +0000 (12:16 +0900)]
staging: wilc1000: rename uniHostIFmsgBody
This patch changes the camelcase notation, uniHostIFmsgBody which is a member
variable of structure host_if_msg to body in order to comply with the Linux
coding style.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:34 +0000 (12:16 +0900)]
staging: wilc1000 remove typedef from the union
This patch gets rid of typedef from the union and renames tuniHostIFmsgBody
with simply message_body because the Linux coding style does not recommend
camelcase notation and typedef for structure, enmu and also union.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:33 +0000 (12:16 +0900)]
staging: wilc1000: rename u16MsgId
This patch changes the name, u16MsgId simply to id to avoid the camelcase
notation.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Mon, 21 Sep 2015 03:16:32 +0000 (12:16 +0900)]
staging: wilc1000: rename strHostIFmsg
This patch changes the name, strHostIFmsg simply to msg because the
camelcase notation is not recommended in Linux.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Raphaël Beamonte [Sun, 20 Sep 2015 17:14:13 +0000 (13:14 -0400)]
staging: rtl8192u: r8192U_core: add line breaks to keep lines under 80 characters
Add line breaks in multiple lines to keep them under 80 characters,
as to follow the kernel code style.
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Punit Vara [Sun, 20 Sep 2015 11:25:29 +0000 (16:55 +0530)]
Staging: rtl8712: Coding style warning fix for block comment
This is a patch to mlme_linux.c that fixes up following warning
reported by checkpatch.pl :
-Block comments use a trailing */ on a separate line
Signed-off-by: Punit Vara <punitvara@gmailc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:25 +0000 (15:51 +0900)]
staging: wilc1000: rename WILC_WFI_InitHostInt
This patch replaces WILC_WFI_InitHostInt with wilc_init_host_int to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:24 +0000 (15:51 +0900)]
staging: wilc1000: rename WILC_WFI_DeInitHostInt
This patch replaces WILC_WFI_DeInitHostInt with wilc_deinit_host_int to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:23 +0000 (15:51 +0900)]
staging: wilc1000: replace s32 with int
This patch changes date type of s32Error as int.
The return type of WILC_WFI_InitHostInt and WILC_WFI_DeInitHostInt is int
so that data type of this variable is changed by int.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:22 +0000 (15:51 +0900)]
staging: wilc1000: remove braces for single statement blocks
This patch removes braces for single if statement blocks found by
checkpatch.pl
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:21 +0000 (15:51 +0900)]
staging: wilc1000: remove useless #if 1
This patch removes #if 1, which is encapsulated some codes.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:20 +0000 (15:51 +0900)]
staging: wilc1000: wilc_msgqueue.c: replace s32RetStatus with result
This patch replaces s32RetStatus with result to avoid CamelCase in
wilc_msgqueue.c
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:19 +0000 (15:51 +0900)]
staging: wilc1000: remove useless comment
This patch removes useless comment that is containing "BugXXXX"
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:12 +0000 (15:51 +0900)]
staging: wilc1000: remove blank line before a close brace '{'
This patch removes blank line before a close brace '{' found by checkpatch.pl
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:11 +0000 (15:51 +0900)]
staging: wilc1000: remove blank line after an open brace '{'
This patch removes blank line after an open brace '{' found by checkpatch.pl.
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:10 +0000 (15:51 +0900)]
staging: wilc1000: fix NULL comparison style
This patch fixes NULL comparison style found by checkpatch.pl.
CHECK: Comparison to NULL could be written "!net"
CHECK: Comparison to NULL could be written "!net->ieee80211_ptr"
CHECK: Comparison to NULL could be written "!net->ieee80211_ptr->wiphy"
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:09 +0000 (15:51 +0900)]
staging: wilc1000: rename WILC_WFI_WiphyRegister
This patch replaces WILC_WFI_WiphyRegister with wilc_create_wiphy to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:08 +0000 (15:51 +0900)]
staging: wilc1000: rename WILC_WFI_WiphyFree
This patch replaces WILC_WFI_WiphyFree with wilc_free_wiphy to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Tue, 25 Aug 2015 21:52:35 +0000 (17:52 -0400)]
staging: unisys: add visorhid driver
This driver provides mouse and keyboard input to Unisys s-Par
Partition Desktop application. This device is created by the
visorbus device.
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Fri, 18 Sep 2015 09:11:04 +0000 (18:11 +0900)]
staging: wilc1000: remove typedef from the struct
The Linux kernel coding style does not recommend to use typedef for the
structure. This patch removes typedef from the host_if_msg structure.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Fri, 18 Sep 2015 09:11:03 +0000 (18:11 +0900)]
staging: wilc1000: rename tstrHostIFmsg
This patch changes the name, tstrHostIFmsg to host_if_msg not to use
camelcase notation in the Linux.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Fri, 18 Sep 2015 14:46:23 +0000 (15:46 +0100)]
staging: comedi: comedi_fops.c: remove bogus kernel-doc for runflags
The comment before the `COMEDI_SRF_...` macros starts with a kernel-doc
mark but isn't valid kernel-doc. There isn't a kernel-doc template for
a group of macro constants. These macros are all private anyway, so
don't really need to be in kernel-doc. Just change it to a normal
comment.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 17 Sep 2015 16:44:35 +0000 (22:14 +0530)]
staging: slicoss: use status in isr
If we are not able to setup the LINK UP command then don't increment the
interrupt count.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 17 Sep 2015 16:44:34 +0000 (22:14 +0530)]
staging: slicoss: use status in slic_ioctl
In the ioctl function if we are not able to UP the link after setting
the new parameters then return an error code to the userspace.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 17 Sep 2015 16:44:33 +0000 (22:14 +0530)]
staging: slicoss: use status in slic_if_init
While initializing the interface if we are not able to setup the command
to UP the link then we release everything and return the error code.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 17 Sep 2015 16:44:32 +0000 (22:14 +0530)]
staging: slicoss: return status of slic_link_event_handler
slic_link_event_handler() issues command READ_LINK_STATUS to be executed
asynchronously, which is followed by UP configuration write command. But
it can fail while setting up the command and in that case the link will
not be up. Lets check the status and return it.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jakub Sitnicki [Fri, 18 Sep 2015 06:13:00 +0000 (08:13 +0200)]
staging: rtl8188eu: Introduce monitor interface for IEEE 802.11 frames
This adds support for monitoring IEEE 802.11 Data and Management frames
received or transmitted by a RTL8188EU-based device handled by this
driver.
The monitor interface is not enabled by default and will be registered
only if monitor_enable module parameter is set to 1. When enabled it
will show up as a monX network device, which can be used by the
userspace programs for monitoring network traffic.
It is intended as an exploratory/debugging tool for rtl8188eu driver.
Signed-off-by: Jakub Sitnicki <jsitnicki@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 17 Sep 2015 08:47:25 +0000 (17:47 +0900)]
staging: wilc1000: remove do-nothing ifdef statement
This patch removes do-nothing ifdef, else statement and add ifdef WILC_SDIO
for disable_sdio_interrupt().
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 17 Sep 2015 08:47:24 +0000 (17:47 +0900)]
staging: wilc1000: remove define RX_BH_TYPE
This patch removes the preprocessor definition, RX_BH_TYPE and uses the
request_threaded_irq instead of kernel thread to execute the interrupt
handler.
As a result, linux_wlan_enable_irq() and linux_wlan_disable_irq() are also
removed from the linux_wlan.c file.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:49 +0000 (16:48 +0900)]
staging: wilc1000: remove declaration of wilc_get_chipid
This patch removes the declaration of wilc_get_chipid function.
It is included wilc_wlan_if.h that has declaration of wilc_get_chipid.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:48 +0000 (16:48 +0900)]
staging: wilc1000: remove useless comment
This patch removes useless comment that is included "BugID_xxxx"
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:47 +0000 (16:48 +0900)]
staging: wilc1000: remove WILC_TIME typedef
This patch removes WILC_TIME typedef that is not used anymore.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:46 +0000 (16:48 +0900)]
staging: wilc1000: remove unused defines
This patch removes unused defines.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:45 +0000 (16:48 +0900)]
staging: wilc1000: linux_wlan_spi.c: fix kzalloc error check
This patch fixes error check of kzalloc.
If kzalloc is failed, return type is used as -ENOMEM.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:43 +0000 (16:48 +0900)]
staging: wilc1000: replace __inline with inline
This patch replaces __inline with inline. plain inline is more
preferred than __inline.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:42 +0000 (16:48 +0900)]
staging: wilc1000: remove INLINE macro
This patch removes INLINE macro that is used anymore.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Raphaël Beamonte [Fri, 11 Sep 2015 07:29:09 +0000 (03:29 -0400)]
staging: rtl8192u: r8192U_core: fix comments lines over 80 characters
Move, replace and reorganize comments to stay under 80 characters
per line, as to follow the kernel code style. Some unuseful comments
have been removed.
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marcos Canán [Wed, 16 Sep 2015 20:48:57 +0000 (17:48 -0300)]
staging: comedi: drivers: coding style: fixed block comment style
This is a patch to the drivers.c file that fixes
a block comment style.
Signed-off-by: Marcos Canán <mcanan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:49 +0000 (16:32 -0400)]
staging: rtl8723au: Clean up getPowerBase()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:48 +0000 (16:32 -0400)]
staging: rtl8723au: TurboScanOff is always true
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:47 +0000 (16:32 -0400)]
staging: rtl8723au: Tidy up SetTxPowerLevel8723A()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:46 +0000 (16:32 -0400)]
staging: rtl8723au: Fold getTxPowerIndex() into PHY_SetTxPowerLevel8723A()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:45 +0000 (16:32 -0400)]
staging: rtl8723au: Eliminate dummy ccxPowerIndexCheck()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:44 +0000 (16:32 -0400)]
staging: rtl8723au: Simplify eeprom content checking
This eliminates the ugly Hal_EEValueCheck() function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:26 +0000 (18:53 +0900)]
staging: wicl1000: remove function pointer wlan_handle_rx_que
The function pointer wlan_handle_rx_que is not called anywhere. Delete
wlan_handle_rx_que and it's assignment code.
But the function wilc_wlan_handle_rxq in assignment code is used. So leave it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Wed, 16 Sep 2015 11:11:27 +0000 (20:11 +0900)]
staging: wilc1000: replace INLINE with static inline
INLINE macro is defined as static __inline so that it is replaced by
static inline.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Wed, 16 Sep 2015 11:11:26 +0000 (20:11 +0900)]
staging: wilc1000: wilc_wlan.c: use BIT(x) macro
Remove bit shift macro that is custom defined, then replace BIT(x)
macro.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:27 +0000 (18:53 +0900)]
staging: wilc1000: remove unused variable rxq_thread
The rxq_thread never runs since it's kthread_run code was delete in a previous
patch. Remove kthread_run and it's related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:25 +0000 (18:53 +0900)]
staging: wilc1000: remove unused semaphore and it's related codes
Variable rxq_event, rxq_wait_event and rxq_wait have the same pointer.
nwi->os_context.rxq_wait_event = (void *)&g_linux_wlan->rxq_event;
g_wlan.rxq_wait = inp->os_context.rxq_wait_event;
They are never aquired(down) since down function was only called in
linux_wlan_rxq_task which was deleted in a previous patch.
So delete variable rxq_event, rxq_wait_event, rxq_wait and it's related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:24 +0000 (18:53 +0900)]
staging: wilc1000: remove variable rxq_thread_started
rxq_thread_started is initiallized but never used in the driver. Remove
the variable and init code line.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:23 +0000 (18:53 +0900)]
staging: wilc1000: remove function linux_wlan_rxq_task
linux_wlan_rxq_task is not used in the driver. Just remove it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:22 +0000 (18:53 +0900)]
staging: wilc1000: remove define TCP_ENHANCEMENTS and it's related code
TCP_ENHANCEMENTS is always in use. Remove define TCP_ENHANCEMENTS, ifdef line,
ifndef line and codes inside ifndef.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:21 +0000 (18:53 +0900)]
staging: wilc1000: remove define WILC_P2P and ifdef line
WILC_P2P is always used in the driver. So delete define WILC_P2P and ifdef line.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:20 +0000 (18:53 +0900)]
staging: wilc1000: remove define WILC_AP_EXTERNAL_MLME and ifdef line
This driver use WILC_AP_EXTERNAL_MLME define always. Delete define
WILC_AP_EXTERNAL_MLME and ifdef line.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:04 +0000 (18:36 +0900)]
staging: wilc1000: remove wilc_errorsupport.h
This patch removes the wilc_errorsupport.h which is not used anymore and
also deletes #include "wilc_errorsupport.h" from the source code.
In addition, adds linux_wlan_common.h file in the wilc_msgqueue.c file
in order to use PRINT macros defined in the linux_wlan_common.h file.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:03 +0000 (18:36 +0900)]
staging: wilc1000: replace wilc error types with the generic error types
This patch replaces the error types defined by wilc driver with the
generic error types provided by the Linux kernel.
- WILC_SUCCESS 0
- WILC_FAIL -EFAULT
- WILC_BUSY -EBUSY
- WILC_INVALID_ARGUMENT -EINVAL
- WILC_INVALID_STATE -EINVAL
- WILC_BUFFER_OVERFLOW -EOVERFLOW
- WILC_NULL_PTR -EFAULT
- WILC_TIMEOUT -ETIMEDOUT
- WILC_NOT_FOUND -ENOENT
- WILC_NO_MEM -ENOMEM
After then removes all wilc definitions.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:02 +0000 (18:36 +0900)]
staging: wilc1000: remove definitions unused
Remove the definitions which are not used anywhere.
- WILC_ALREADY_EXSIT
- WILC_EMPTY
- WILC_FULL
- WILC_CANCELED
- WILC_INVALID_FILE
- WILC_UNSUPPORTED_VERSION
- WILC_FILE_EOF
Remove the definition which is not used anymore.
- WILC_CATCH
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:01 +0000 (18:36 +0900)]
staging: wilc1000: remove the macro WILC_ERRORREPORT
This patch removes the macro WILC_ERRORREPORT which is not used
anymore by replacing it with the plain statements.
The compiler complains the build warnings in some functions for WILC_CATCH and
ERRORHANDLER as unused definitions. So, this patch also removes WILC_CATCH and
ERRORHANDLER from some of functions.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:00 +0000 (18:36 +0900)]
staging: wilc1000: remove the macro WILC_ERRORCHECK
This patch removes the macro WILC_ERRORCHECK which is not used
anymore by replacing it with the plain statements.
This patch also removes the WILC_CATCH macros from some of functions not
to make the build warnings.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:35:59 +0000 (18:35 +0900)]
staging: wilc1000: remove a macro WILC_NULLCHECK
This patch replaces WILC_NULLCHECK with the plain statements and then removes
the macro WILC_NULLCHECK in wilc_errorsupport.h which is not used anymore.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:55 +0000 (10:43 +0900)]
staging: wilc1000: remove unused variable g_flushing_in_progress
g_flushing_in_progress is never used so just delete it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:54 +0000 (10:43 +0900)]
staging: wilc1000: coreconfigurator.h: remove unused defines
The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver.
Delete two defines.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:53 +0000 (10:43 +0900)]
staging: wilc1000: delete function declaration SendRawPacket
SendRawpacket is declared but not implemented. It is not used also.
So just delete it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:52 +0000 (10:43 +0900)]
staging: wilc1000: remove unused variables
Variable g_num_total_switches is never used so just remove it.
gastrWIDs is also not used because g_num_total_switches is deleted.
Remove gastrWIDs also.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:51 +0000 (10:43 +0900)]
staging: wilc1000: delete unused global variables.
gstrConfigPktInfo, SemHandleSendPkt and SemHandlePktResp are never used in
the drivers. So just delete the variables and it's related code.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:50 +0000 (10:43 +0900)]
staging: wilc1000: remove unnecessary extern function declaration
Function NetworkInfoReceived, GnrlAsyncInfoReceived and
host_int_ScanCompleteReceived are declared in the header file already.
Just removes the declaration and comments.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:49 +0000 (10:43 +0900)]
staging: wilc1000: remove unused defines
This patch removes follwing unused defines.
MAX_CFG_PKTLEN
MSG_HEADER_LEN
QUERY_MSG_TYPE
WRITE_MSG_TYPE
RESP_MSG_TYPE
WRITE_RESP_SUCCESS
INVALID
MAC_ADDR_LEN
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>