navin patidar [Wed, 11 Jun 2014 17:21:36 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_read8()
_rtw_read8() is a wrapper function, being used to call usb_read8().
Call usb_read8() directly and drop _rtw_read8().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:35 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_read16()
_rtw_read16() is a wrapper function, being used to call usb_read16().
Call usb_read16() directly and drop _rtw_read16().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:34 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_read32()
_rtw_read32() is a wrapper function, being used to call usb_read32().
Call usb_read32() directly and drop _rtw_read32().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:33 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_write8()
_rtw_write8() is a wrapper function, being used to call usb_write8().
Call usb_write8() directly and drop _rtw_write8().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:32 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_write16()
_rtw_write16() is a wrapper function, being used to call usb_write16().
Call usb_write16() directly and drop _rtw_write16().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:31 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_write32()
_rtw_write32() is a wrapper function, being used to call usb_write32().
Call usb_write32() directly and drop _rtw_write32().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:30 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_write_port_cancel()
_rtw_write_port_cancel() is a wrapper function, being used to call
usb_write_port_cancel().
Call usb_write_port_cancel() directly and drop _rtw_write_port_cancel().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:29 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_write_port()
_rtw_write_port() is a wrapper function, being used to call usb_write_port().
Call usb_write_port() directly and drop _rtw_write_port().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:28 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_read_port_cancel()
_rtw_read_port_cancel() is a wrapper function, being used to call
usb_read_port_cancel().
Call usb_read_port_cancel() directly and drop _rtw_read_port_cancel().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:27 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_read_port()
_rtw_read_port() is a wrapper function, being used to call usb_read_port().
use usb_read_port() directly and drop _rtw_read_port().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:26 +0000 (22:51 +0530)]
staging: rtl8188eu: Remove function _rtw_writeN()
_rtw_writeN() is a wrapper function, being used to call usb_writeN().
Call usb_writeN() directly and drop _rtw_writeN().
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:25 +0000 (22:51 +0530)]
staging: rtl8188eu: Instead of intf_hdl pass adapter in read & write functions
intf_hdl is passed in usb_[read,write][8,16,32]() functions, which
is then passed to vender_request() there it's used to get adapter pointer,
so instead of passing intf_hdl we can directly pass adapter.
This change will also help in removing rtw_[read,write][8,16,32]() wrapper
functions being used to call usb_[read,write][8,16,32]() functions.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:24 +0000 (22:51 +0530)]
staging: rtl8188eu: rtw_io.h: Remove unused function declarations
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:23 +0000 (22:51 +0530)]
staging: rtl8188eu: rtw_io.c: Remove unused function _rtw_write_port_and_wait()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:22 +0000 (22:51 +0530)]
staging: rtl8188eu: rtw_io.c: Remove unused function _rtw_write32_async()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:21 +0000 (22:51 +0530)]
staging: rtl8188eu: rtw_io.c: Remove unused function rtw_write16_async()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Wed, 11 Jun 2014 17:21:20 +0000 (22:51 +0530)]
staging: rtl8188eu: rtw_io.c: Remove unused function _rtw_write8_async()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 17:43:18 +0000 (23:13 +0530)]
staging: rtl8188eu: rtw_io.h: Remove unused members from struct _io_ops
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 17:04:28 +0000 (22:34 +0530)]
staging: rtl8188eu: rtw_io.h: Remove unused macros
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:19 +0000 (21:45 +0530)]
staging: rtl8188eu: HalPhyRf_8188e.c: Remove unnecessary comments
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:18 +0000 (21:45 +0530)]
staging: rtl8188eu: HalPhyRf_8188e.c: Remove unused macro
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:17 +0000 (21:45 +0530)]
staging: rtl8188eu: rtw_io.h: Remove unused structures
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:16 +0000 (21:45 +0530)]
staging: rtl8188eu: Remove unused function declaration and macro
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:15 +0000 (21:45 +0530)]
staging: rtl8188eu: Remove unused function _rtw_write_mem()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:14 +0000 (21:45 +0530)]
staging: rtl8188eu: Remove unused funtion _rtw_read_mem()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:13 +0000 (21:45 +0530)]
staging: rtl8188eu: Remove unused struct intf_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:12 +0000 (21:45 +0530)]
staging: rtl8188eu:Move rtw_hw_[suspend, resume]() to rtw_pwrctrl.c
rtw_hw_[suspend,resume]() functions are used only in rtw_pwrctrl.c,
so move these functions there.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:11 +0000 (21:45 +0530)]
staging: rtl8188eu: Remove rtw_init_intf_priv()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 16:15:10 +0000 (21:45 +0530)]
staging: rtl8188eu: Remove rtw_deinit_intf_priv()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 6 Jun 2014 17:24:33 +0000 (22:54 +0530)]
staging: rtl8188eu: usb_halinit.c: Remove ReadAdapterInfo8188EU()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sun, 1 Jun 2014 16:32:37 +0000 (18:32 +0200)]
staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code
Removes unnecessary code that does not do anything useful.
This was partly found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:52 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove function with empty defination()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 8 Jun 2014 14:04:33 +0000 (19:34 +0530)]
staging: rtl8188eu: Remove unused function nat25_handle_frame()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:50 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove bCardDisableWOHSM from struct adapter
driver doesn't use value stored in bCardDisableWOHSM.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:49 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove pbuddy_adapter from struct adapter
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:48 +0000 (17:46 +0530)]
staging: rtl8188eu:Remove EepromAddressSize from struct adapter
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:47 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove unused member variable of struct adapter
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:46 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove hal_data_sz from struct adapter
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:45 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove unused function rtl8188e_clone_haldata()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:44 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove DriverState from struct adapter
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:43 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove enum driver_state
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:42 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove unused enum _IFACE_TYPE
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:41 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove unused enum _ADAPTER_TYPE
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:40 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove usb_alloc_vendor_req_buf from struct dvobj_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:39 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove usb_suspend_sema from struct dvobj_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:38 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove unused members of struct dvobj_priv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:37 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove unused enum
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:36 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove unused stucture defination struct specific_device_id
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:35 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove function declarations in usb_intf.c
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:34 +0000 (17:46 +0530)]
staging: rtl8188eu: Use module_usb_driver() macro
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:33 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove struct rtw_usb_drv
struct rtw_usb_drv contains only one member usb_driver structure,
so no use of keeping it.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:32 +0000 (17:46 +0530)]
staging : rtl8188eu: Remove drv_registered from struct rtw_usb_drv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:31 +0000 (17:46 +0530)]
staging: rtl8188eu: Use unregistering flag from struct usb_interface
Use unregistering flag from struct usb_interface to find
driver registration status.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:30 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove hw_init_mutex from struct rtw_usb_drv
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:29 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove header file rtw_version.h
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:28 +0000 (17:46 +0530)]
staging :rtl8188eu: Remove HalPhyRf.[h|c] files.
Move ODM_GetRightChnlPlaceforIQK() from HalPhyRf.c to HalPhyRf_8188e.c.
Move ODM_TARGET_CHNL_NUM_2G_5G from HalPhyRf.h to HalPhyRf_8188e.h.
After the movement of function and macro HalPhyRf.[h|c] files are redundant.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Sun, 1 Jun 2014 12:16:27 +0000 (17:46 +0530)]
staging: rtl8188eu: Remove function with empty defination ODM_ResetIQKResult()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:58 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove usb_vendor_req.h header file
driver doesn't need usb_vendor_req.h.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:57 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove unused function declaration
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:56 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove Hal8188EReg.h file
Driver doesn't need Hal8188EReg.h file.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:55 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove "last_tx_complete_time" from struct sreset_priv
value stored in variable last_tx_complete_time isn't being used
by driver.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:54 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove "last_tx_time" from struct sreset_priv
value stored in variable last_tx_time isn't being used
by driver.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:53 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove empty files rtl8188e_sreset.[c|h]
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:52 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove function rtl8188e_silentreset_for_specific_platform()
Remove rtl8188e_silentreset_for_specific_platform() and function pointer
->silentreset pointing to it.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:51 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove function rtw_hal_sreset_reset()
rtw_hal_sreset_reset() is a wrapper to call
rtl8188e_silentreset_for_specific_platform(), which has empty defination.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:50 +0000 (23:20 +0530)]
staging:rtl8188eu: Remove function rtl8188e_sreset_linked_status_check()
Remove rtl8188e_sreset_linked_status_check() and function pointer
->sreset_linked_status_check pointing to it.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:49 +0000 (23:20 +0530)]
staging:rtl8188eu: Remove function rtw_hal_sreset_linked_status_check()
rtw_hal_sreset_linked_status_check() is a wrapper to call
rtl8188e_sreset_linked_status_check(), which doesn't do anything
useful.
rtl8188e_sreset_linked_status_check() will also be removed later.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:48 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove unused function rtl8188e_sreset_xmit_status_check()
Remove rtl8188e_sreset_xmit_status_check() and function pointer
->sreset_xmit_status_check pointing to it.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:47 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove function rtw_hal_sreset_xmit_status_check()
rtw_hal_sreset_xmit_status_check() is a wrapper to call
rtl8188e_sreset_xmit_status_check(), which calls
rtl8188e_silentreset_for_specific_platform() in case of transmission has
stopped to do a silent reset and restore the transmission but
rtl8188e_silentreset_for_specific_platform() has empty defination,
so we can remove rtw_hal_sreset_xmit_status_check() because it doesn't
serve its purpose.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:46 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove unused function reset_reset_value()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:45 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove unused function pointer ->sreset_reset_value
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:44 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove unused function rtw_hal_sreset_reset_value()
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:43 +0000 (23:20 +0530)]
staging: rtl8188eu: Use rtw_hal_sreset_init() in rtw_reset_drv_sw()
We can replace rtw_hal_sreset_reset_value() with rtw_hal_sreset_init() because
both function call sreset_reset_value() and sreset_init_value() respectively at
the end of code path, and function defination of sreset_reset_value() and
sreset_init_value() is identical.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:42 +0000 (23:20 +0530)]
staging: rtl8188eu:Remove "silent_reset_inprogress" from struct sreset_priv
psrtpriv->silent_reset_inprogress is always false.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Thu, 29 May 2014 17:50:41 +0000 (23:20 +0530)]
staging: rtl8188eu: Remove "silentreset_mutex" from struct sreset_priv
silentreset_mutex initialized but not being used.
Signed-off-by: navin patidar <navin.patidar@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fengguang Wu [Thu, 19 Jun 2014 22:26:29 +0000 (15:26 -0700)]
staging: r8192ee: fix coccinelle warnings
drivers/staging/rtl8192ee/btcoexist/halbtc8821a2ant.c:2491:3-4: Unneeded semicolon
Removes unneeded semicolon.
Generated by: /kbuild/src/linux/scripts/coccinelle/misc/semicolon.cocci
CC: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Koch [Tue, 3 Jun 2014 19:56:31 +0000 (21:56 +0200)]
Staging: octeon: minor style cleanups
Done as task 10 of the eudyptula challenge.
Signed-off-by: Nicolas Koch <nioko1337@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Daney [Thu, 29 May 2014 10:10:02 +0000 (11:10 +0100)]
staging: octeon-ethernet: Move PHY activation to .ndo_open().
This prevents PHY not found types of errors for PHY drivers that are
probed after the Ethernet driver is probed, because the ifconfig UP is
done from userspace after all drivers have been probed.
Also avoid the cvmx-helper-board.c PHY code if a real PHY driver is
present, this allows a bootloader supplied device tree to specify the
PHY information rather than having to modify the code for each
different board.
Tested-by: Alex Smith <alex.smith@imgtec.com>
Signed-off-by: David Daney <david.daney@cavium.com>
Signed-off-by: Alex Smith <alex.smith@imgtec.com>
Cc: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 13 Jun 2014 09:23:15 +0000 (18:23 +0900)]
staging: dgap: unwind on error in dgap_init_one()
The dgap_init_one() needs to handle error properly
if one of functions in dgap_init_one() is failed.
Introduce some functions for handling error in dgap_init_one()
- dgap_tty_unregister() : unregister tty driver
- dgap_free_flipbuf() : free flip buffer
- dgap_release_remap() : release memory region and unmapped memory.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 13 Jun 2014 09:22:40 +0000 (18:22 +0900)]
staging: dgap: move unrelated functions in dgap_firmware_load()
The dgap_firmware_load() has a lot of stuff which are
unrelated with loading firmware.
So just moved to dgap_init_one().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 13 Jun 2014 09:22:05 +0000 (18:22 +0900)]
staging: dgap: rename dgap_after_config_loaded() to dgap_alloc_flipbuf()
dgap_after_config_loaded() as function name doesn't tell
what it does.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 13 Jun 2014 09:21:04 +0000 (18:21 +0900)]
staging: dgap: introduce dgap_free_irq()
dgap_free_irq() will free the irq which is requested in
dgap_request_irq().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 13 Jun 2014 09:19:55 +0000 (18:19 +0900)]
staging: dgap: introduce dgap_tty_free() for freeing channels.
It should be called after dgap_tty_register_ports() is failed.
So channels which are allocated in dgap_tty_init() will be freed.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 13 Jun 2014 09:19:03 +0000 (18:19 +0900)]
staging: dgap: get rid of brd->firstminor because it is 0
firstminor in struct borad_t is always zero, so it
can be removed.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Fri, 13 Jun 2014 09:18:04 +0000 (18:18 +0900)]
staging: dgap: remove unused paramter in dgap_parsefile()
"remove" parameter is not used in dgap_parsefile().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Tue, 3 Jun 2014 06:28:42 +0000 (15:28 +0900)]
staging: dgap: rename dgap_tty_uninit() to dgap_cleanup_tty()
- dgap_tty_uninit() doesn't match dgap_tty_init() at all.
so rename it. It is just used for cleanup when this module is
exited or failed to initialize by dgap_init_module.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Tue, 3 Jun 2014 06:28:08 +0000 (15:28 +0900)]
staging: dgap: rename dgap_finalize_board_init() to dgap_request_irq()
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Tue, 3 Jun 2014 08:01:31 +0000 (17:01 +0900)]
staging: dgap: pass "brd" as a paramter to dgap_after_config_loaded()
Pass "brd" to dgap_after_config_loaded() instead of passing
"dgap_numboards" and looking up brd again.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Tue, 3 Jun 2014 06:26:53 +0000 (15:26 +0900)]
staging: dgap: pass "dgap_numboards" as a paramter to dgap_found_board()
- Pass "dgap_numboards" to dgap_found_board() instead of
using a global variable.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 2 Jun 2014 05:09:04 +0000 (14:09 +0900)]
staging: dgap: make dgap_config_buf a local buffer
The dgap_config_buf is only used in dgap_firmware_load().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 2 Jun 2014 05:08:24 +0000 (14:08 +0900)]
staging: dgap: unwind on error in dgap_tty_register_ports()
- The dgap_tty_register_ports() needs to handle if the
tty_port_register_device() fails.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 2 Jun 2014 05:07:46 +0000 (14:07 +0900)]
staging: dgap: unwind on error in dgap_tty_init()
If the kzalloc() fails for channels, it need to handle
that error. It should free channels which were already
allocated.
And also removes the call to dgap_tty_uninit() in
dgap_firmware_load().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Mon, 2 Jun 2014 05:06:53 +0000 (14:06 +0900)]
staging: dgap: remove bogus null test in dgap_tty_init()
- The channels array were set to NULL in dgap_found_board().
- Removes redundant null check for channels array in for loop,
if one of the channel cannot be allocated, dgap_tty_init() just returns
an error.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 29 May 2014 09:11:09 +0000 (18:11 +0900)]
staging: dgap: unwind on error in dgap_found_board()
Adds a label for "kfree(brd)". And also remove
a state value as BOARD_FAILED in brd when dgap_do_remap() is failed.
Because "brd" will free after failure.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 29 May 2014 09:10:27 +0000 (18:10 +0900)]
staging: dgap: remove useless dgap_probe1() function
The dgap_probe1() function is just calling dgap_found_board().
So it is removed and dgap_found_board() is called directly.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist [Sun, 15 Jun 2014 15:14:06 +0000 (17:14 +0200)]
staging: rtl8192u: r8192U_core.c: Cleaning up unclear and confusing code
Removes confusing and unclear code.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaitanya Hazarey [Wed, 11 Jun 2014 17:26:44 +0000 (10:26 -0700)]
Staging: rtl8192u: r8192U_core.c Converted a C99 comment to fix code-style error
Converted a C99 comment to fix the following error:
ERROR: trailing statements should be on next line
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaitanya Hazarey [Wed, 11 Jun 2014 17:26:43 +0000 (10:26 -0700)]
Staging: rtl8192u: r8192U_core.c Fixed open brace { placement
Fixed open brace placement to address the following code-style errors:
ERROR: that open brace { should be on the previous line
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaitanya Hazarey [Thu, 5 Jun 2014 20:25:58 +0000 (13:25 -0700)]
Staging: rtl8192u: r8192U_core.c Converted some C99 comments to fix code-style errors
Converted some C99 warnings to fix the following error:
ERROR: trailing statements should be on next line
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaitanya Hazarey [Thu, 5 Jun 2014 20:25:57 +0000 (13:25 -0700)]
Staging: rtl8192u: r8192U_core.c Rearranged statements to fix code-style errors
Rearranged statements around if and switch statements to address the following error:
ERROR: trailing statements should be on next line
Signed-off-by: Chaitanya Hazarey <c@24.io>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / openwrt / staging / blogic.git / log