Jes Sorensen [Tue, 15 Apr 2014 17:43:58 +0000 (19:43 +0200)]
staging: rtl8723au: Make rtw_check_bcn_info23() take a ieee80211_mgmt pointer
Clean up the code by passing a struct ieee80211_mgmt pointer instead
of a raw frame pointer. In addition check we receive a beacon frame,
anything else here is an error.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:57 +0000 (19:43 +0200)]
staging: rtl8723au: OnBeacon23a(): Use ieee80211_mgmt to calculate ie location
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:56 +0000 (19:43 +0200)]
staging: rtl8723au: OnBeacon23a(): Use struct ieee80211_mgmt
We always receive a struct ieee80211_mgmt frame here, using just
ieee80211_hdr doesn't make sense.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:55 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_get_cur_max_rate23a(): use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:54 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_update_protection23a(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:53 +0000 (19:43 +0200)]
staging: rtl8723au: Make mlme_handlers and action_handlers return int
In addition, make them all static and move the prototypes to
rtw_mlme_ext.c.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:52 +0000 (19:43 +0200)]
staging: rtl8723au: OnAssocReq23a(): Clean up and use more ieee80211.h
This converts it to use struct ieee80211_mgmt and cfg80211_find_ie().
In addition fix a potential buffer overrun in the last loop searching
through list WLAN_EID_VENDOR_SPECIFIC elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:51 +0000 (19:43 +0200)]
staging: rtl8723au: issue_probersp23a(): various cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:50 +0000 (19:43 +0200)]
staging: rtl8723au: issue_asocrsp23a(): Use cfg80211_find_ie() and cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:49 +0000 (19:43 +0200)]
staging: rtl8723au: issue_assocreq23a(): General cleanups and use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:48 +0000 (19:43 +0200)]
staging: rtl8723au: issue_action_BSSCoexistPacket(): Clean + use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:47 +0000 (19:43 +0200)]
staging: rtl8723au: collect_bss_info23a(): Convert to use cfg80211_fine_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:46 +0000 (19:43 +0200)]
staging: rtl8723au: process_80211d() use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:45 +0000 (19:43 +0200)]
staging: rtl8723au: OnAction23_back23a() Use ieee80211_mgmt and bug fixes
This converts OnAction23a_back23a() to using struct ieee80211_mgmt to
parse the response packet. In addition this revealed a bug which has
been fixed:
case WLAN_ACTION_ADDBA_RESP: /* ADDBA response */
status = get_unaligned_le16(&frame_body[3]);
tid = ((frame_body[5] >> 2) & 0x7);
The above masks the tid to 3 bits, however per ieee80211.h, the tid is
in fact 4 bits wide, as defined by IEEE80211_ADDBA_PARAM_TID_MASK (0x3c)
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:44 +0000 (19:43 +0200)]
staging: rtl8723au: OnDisassoc23(): Use ieee80211_mgmt
Use proper kernel ieee80211.h defined headers to parse the response.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:43 +0000 (19:43 +0200)]
staging: rtl8723au: OnDeAuth23a() use ieee80211 header defines
Use the proper ieee80211.h structs to parse the response instead of
hard coded offsets.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:42 +0000 (19:43 +0200)]
staging: rtl8723au: OnAssocRsp23a() use ieee80211 header defines
Use the proper ieee80211.h structs to parse the response instead of
hard coded offsets.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:41 +0000 (19:43 +0200)]
staging: rtl8723au: OnAuth23aClient23a() Use cfg80211_find_ie()
Use cfg80211_find_ie() and tidy up the code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:40 +0000 (19:43 +0200)]
staging: rtl8723au: OnAuth23() Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:39 +0000 (19:43 +0200)]
staging: rtl8723au: OnProbeReq23a() Use cfg80211_find_ie()
Switch to using cfg80211_find_ie() and tidy of the code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:38 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_update_ht_ie23a(): use cfg80211_find_ie()
Switch to using cfg80211_find_ie() and remove commented out code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:37 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_restructure_ht_ie23a(): use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:36 +0000 (19:43 +0200)]
staging: rtl8723au: Remove another stack of unused P2P related #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:35 +0000 (19:43 +0200)]
staging: rtl8723au: Remove P2P/WiFiDirect/WiFiDisplay code
Discussing with Johannes Berg and Larry Finger, we have concluded that
this code really should be handled through wpa_supplicant, and not in
the kernel.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:34 +0000 (19:43 +0200)]
staging: rtl8723au: Remove obsolete local defines matching WLAN_EID_*
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:33 +0000 (19:43 +0200)]
staging: rtl8723au: Fixup last users to use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:32 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_recv.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:31 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_xmit.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:30 +0000 (19:43 +0200)]
staging: rtl8723au: rtl8723a_cmd.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:29 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_wlan_util.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:28 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_ieee80211.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:27 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_p2p.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:26 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_ap.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:25 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_mlme.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:24 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_mlme_ext.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:23 +0000 (19:43 +0200)]
staging: rtl8723au: make source * argument const
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:22 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_security.h - remove some unused macros
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:21 +0000 (19:43 +0200)]
staging: rtl8723au: Remove duplicate #defines for WLAN_EID_VENDOR_SPECIFIC
Lets not keep one local copy ... no lets keep two ... no lets keep three!
Rip them all out and use the kernel provided one.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:20 +0000 (19:43 +0200)]
staging: rtl8723au: Fix buffer overflow in rtw_get_wfd_ie()
Add bounds checking to not allow WFD Information Elements larger than
128, and make sure we use the correct buffer size MAX_WFD_IE_LEN
instea of hardcoding the size.
This also simplifies rtw_get_wfd_ie() by using the cfg80211
infrastructure.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Mon, 14 Apr 2014 20:42:43 +0000 (16:42 -0400)]
staging: dgap: remove uchar typedef and replace use with u8
This patch removes the uchar typedef in dgap.h
and changes all uses of it to u8.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 28 Mar 2014 13:30:15 +0000 (09:30 -0400)]
staging: dgap: rename and fixup dgap_wait_for_xxx functions
This patch renames and changes the dgap_wait_for_bios and
dgap_wait_for_fep functions from boolean functions to return
zero on success and a negative error code on error.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:17 +0000 (16:38 -0400)]
staging: dgap: fix/change a pr_info
This patch just fixes a pr_info. brd->state is not proper
at this point in time.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:16 +0000 (16:38 -0400)]
staging: dgap: remove volatiles from dgap.h
This patch fixes checkpatch warnings about using volatiles in dgap.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:15 +0000 (16:38 -0400)]
staging: dgap: Macros with complex values should be enclosed in parenthesis
This patch fixes a checkpatch warning
"Macros with complex values should be enclosed in parenthesis"
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:14 +0000 (16:38 -0400)]
staging: dgap: Only read config file dgap.conf once
The config file is currently read for each board found.
It only needs to be read one time. The buffer it is read
into can now be freed immediately after it is parsed
instead of at driver unload time.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Mar 2014 20:38:13 +0000 (16:38 -0400)]
staging: dgap: Removes excessive empty lines from dgap.h
This patch removes excessive empty lines from dgap.h
not previously caught.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:14 +0000 (10:41 -0400)]
staging: dgap: remove some unused code in dgap.h
This patch removes some unused code in dgap.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:13 +0000 (10:41 -0400)]
staging: dgap: Fix several 80+ line warnings in dgap.h
This patch fixes several 80+ char line warnings as reported
by checkpatch in dgap.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:12 +0000 (10:41 -0400)]
staging: dgap: fix some whitespace warnings in dgap.h
This patch fixes some whitespace warnings as reported
by checkpatch in dgap.h.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:11 +0000 (10:41 -0400)]
staging: dgap: Remove some unneeded comments
This patch removes some unneeded comments from dgap.c
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 21 Mar 2014 14:41:10 +0000 (10:41 -0400)]
staging: dgap: Remove some unused code in dgap.c
This patch removes some unused code in dgap.c.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Einon [Thu, 10 Apr 2014 12:35:00 +0000 (13:35 +0100)]
staging: rtl8821ae: Fix rtl8821ae/hw.h pointer declaration style
Fix all occurences of the checkpatch error:
ERROR: "foo* bar" should be "foo *bar"
Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Einon [Thu, 10 Apr 2014 12:34:59 +0000 (13:34 +0100)]
staging: rtl8821ae: Remove FSF mailing address from rtl8821ae/hw.h header
Fix checkpatch check:
CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.
Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Einon [Thu, 10 Apr 2014 12:34:58 +0000 (13:34 +0100)]
staging: rtl8821ae: Fix whitespace in rtl8821ae/hw.h
Fix checkpatch warnings, lines over 80 chars using tabs where possible.
Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Thu, 10 Apr 2014 02:26:45 +0000 (21:26 -0500)]
Staging: iio: Switch from msleep to usleep range per timers-howto.txt
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Thu, 10 Apr 2014 02:26:44 +0000 (21:26 -0500)]
Staging: iio: Remove quoted string split across lines warnings
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Thu, 10 Apr 2014 02:26:43 +0000 (21:26 -0500)]
Staging: iio: Removes unwanted space before semicolon
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joel Porquet [Wed, 9 Apr 2014 18:09:45 +0000 (20:09 +0200)]
staging: iio: fix coding style
As suggested by checkpatch.pl, use dev_info() instead of
printk(KERN_INFO ...) to print message.
Signed-off-by: Joel Porquet <joel@porquet.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luis Ortega [Wed, 9 Apr 2014 11:56:09 +0000 (13:56 +0200)]
Staging: bcm: Qos: fixed braces' coding style
Fixed badly placed and unnecessary braces.
PS: Performed as task 10 of the Eudyptula Challenge.
Signed-off-by: Luis Ortega <luiorpe1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jake Edge [Fri, 4 Apr 2014 18:25:55 +0000 (12:25 -0600)]
staging/bcm fix hostmibs.c checkpatch problems
Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c
Signed-off-by: Jake Edge <jake@edge2.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gary Rookard [Fri, 21 Mar 2014 03:28:43 +0000 (23:28 -0400)]
Staging: bcm: CmHost: remove temp bracing from switch/cases.
Remove the temp bracing afixed to case labels.
Properly indent switch/case breaks.
Signed-off-by: Gary Alan Rookard <garyrookard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michele Curti [Thu, 10 Apr 2014 14:38:00 +0000 (16:38 +0200)]
staging: comedi: declare das6402_boards as static
das6402_boards array is used in das6402.c only, so declare it as static.
Signed-off-by: Michele Curti <michele.curti@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Leitner [Wed, 9 Apr 2014 16:27:13 +0000 (18:27 +0200)]
staging: comedi: adl_pci9118: fix whitespace issues
Removed not needed spaces and fixed too long lines
Signed-off-by: Richard Leitner <me@g0hl1n.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georg Gast [Tue, 8 Apr 2014 16:52:58 +0000 (18:52 +0200)]
staging: comedi: more descriptive names for addi-data drivers
- more descriptive module description for following boards:
ADDI-DATA APCI 1032/1500/1564/2032/3120
Signed-off-by: Georg Gast <georg@schorsch-tech.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumar Amit Mehta [Fri, 4 Apr 2014 15:44:44 +0000 (18:44 +0300)]
staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
Kernel style is that if one side of the if else statement gets has curly
braces then both side should have them.
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Thu, 3 Apr 2014 23:43:27 +0000 (18:43 -0500)]
staging: comedi: s626: use comedi_timeout() on remaining loops
There were just a handful of more while loops in this file that needed
timeouts, and this patch takes care of them. One new callback is
introduced, and all of the proper comedi_timeout() calls are then used.
The return type of s626_i2c_handshake() has been changed from uint32_t to
int so that a negative error code from comedi_timeout() can be propagated
if necessary.
Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yves Deweerdt [Mon, 31 Mar 2014 20:55:44 +0000 (22:55 +0200)]
staging: comedi: drivers.c: Fix missing a blank line, after declarations warning
Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yves Deweerdt [Mon, 31 Mar 2014 20:55:39 +0000 (22:55 +0200)]
staging: comedi: comedy_fops.c: fix line over 80, characters warnings
Signed-off-by: Yves Deweerdt <yves.deweerdt.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Mon, 31 Mar 2014 07:50:36 +0000 (10:50 +0300)]
staging: comedi: remove an unneeded variable
"chanlist" was left over, we don't need it any more.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:23 +0000 (23:21 +0200)]
staging: rtl8723au: Simplify retrieving the ether_type in portctrl()
This renders the last element in include/ethernet.h unnecessary, so
remove it as well.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:22 +0000 (23:21 +0200)]
staging: rtl8723au: Calling rtw_get_stainfo() with a NULL sta_addr will return NULL
This makes the follow-on check for psta != NULL pointless and makes
the whole exercise rather pointless. This is another case of why
blindly zero-initializing variables when they are declared is bad.
This bug seems to be present in multiple drivers provided by Realtek.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:21 +0000 (23:21 +0200)]
staging: rtl8723au: Fix case where ethtype was never obtained and always be checked against 0
Zero-initializing ether_type masked that the ether type would never be
obtained for 8021x packets and the comparition against eapol_type
would always fail.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:20 +0000 (23:21 +0200)]
staging: rtl8723au: Use proper ETH_P_* types in rtw_recv.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:19 +0000 (23:21 +0200)]
staging: rtl8723au: Call do_div() directly and get rid of unnecessary wrapper functions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Wed, 9 Apr 2014 21:21:18 +0000 (23:21 +0200)]
staging: rtl8723au: Fix build error due to bad commit
6c89f82
Two routines are missing includes of a necessary header.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:17 +0000 (23:21 +0200)]
staging: rtl8723au: Remove unused bitshift() function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:16 +0000 (23:21 +0200)]
staging: rtl8723au: Remove a couple of unused prototypes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:15 +0000 (23:21 +0200)]
staging: rtl8723au: No need to include header files for unused circ_buf and old iwpriv bits
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:14 +0000 (23:21 +0200)]
staging: rtl8723au: Remove unnecessary forward struct declarations from xmit_osdep.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:13 +0000 (23:21 +0200)]
staging: rtl8723au: Remove ugly pktfile interface
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:12 +0000 (23:21 +0200)]
staging: rtl8723au: Don't use pktfile interface in rtw_xmitframe_coalesce23a()
The pktfil interface is horrible, no idea where it came from, but not
using it is a win.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:11 +0000 (23:21 +0200)]
staging: rtl8723au: Make rtw_xmitframe_coalesce23a() more readable
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:10 +0000 (23:21 +0200)]
staging: rtl8723au: Fix update_attrib() and set_qos() to not use pktfile nonsense
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:09 +0000 (23:21 +0200)]
staging: rtl8723au: Use proper ETH_P_* types instead of hard coded constants in rtw_xmit.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:08 +0000 (23:21 +0200)]
staging: rtl8723au: Fold rtw_remainder_len23a() into _rtw_open_pktfile23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:07 +0000 (23:21 +0200)]
staging: rtl8723au: Remove last remnants of CONFIG_BR_EXT
Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:06 +0000 (23:21 +0200)]
staging: rtl8723au: rtw_report_sec_ie23a() is only called from rtw_mlme.c
Move it there and declare it static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:05 +0000 (23:21 +0200)]
staging: rtl8723au: Remove unused functions rtw_indicate_sta_{dis,}assoc_event23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:04 +0000 (23:21 +0200)]
staging: rtl8723au: Fix hopeless brackets for declaring a variable mid-function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:03 +0000 (23:21 +0200)]
staging: rtl8723au: Remove unnecessary memset() followed by a memcpy() into the same space
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:02 +0000 (23:21 +0200)]
staging: rtl8723au: rtw_os_indicate_connect23a() is only called from one place - fold it in
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:01 +0000 (23:21 +0200)]
staging: rtl8723au: Don't wrap kill_pid() in an unnecessary macro
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:21:00 +0000 (23:21 +0200)]
staging: rtl8723au: Remove two layers of wrappers around rtw_cfg80211_indicate_scan_done()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:20:59 +0000 (23:20 +0200)]
staging: rtl8723au: Remove #ifdef CONFIG_DEBUG_CFG80211
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:20:58 +0000 (23:20 +0200)]
staging: rtl8723au: Remove unused is_boot_from_eeprom() macro
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:20:57 +0000 (23:20 +0200)]
staging: rtl8723au: Remove obsolete HW_VARIABLES enum
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:20:56 +0000 (23:20 +0200)]
staging: rtl8723au: Kill off ugly GetHwReg*() interface
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:20:55 +0000 (23:20 +0200)]
staging: rtl8723au: Eliminate HW_WAR_CHK_HI_QUEUE_EMPTY usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:20:54 +0000 (23:20 +0200)]
staging: rtl8723au: Eliminate HW_VAR_FWLPS_RF_ON usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Wed, 9 Apr 2014 21:20:53 +0000 (23:20 +0200)]
staging: rtl8723au: Eliminate HW_VAR_RF_TYPE usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / openwrt / staging / blogic.git / log