openwrt/staging/blogic.git
13 years agostaging: brcm80211: removed function brcms_c_wme_initparams_sta()
Roland Vossen [Tue, 13 Sep 2011 07:49:47 +0000 (09:49 +0200)]
staging: brcm80211: removed function brcms_c_wme_initparams_sta()

since its variable assignment can be done in a more straightforward
manner.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: cleanup of softmac macro EDCF_ENAB()
Roland Vossen [Tue, 13 Sep 2011 07:49:46 +0000 (09:49 +0200)]
staging: brcm80211: cleanup of softmac macro EDCF_ENAB()

Since structure member pub->_wme is set to AUTO early in init, macro
EDCF_ENAB is always 'true' after that. All code that uses ECDF_ENAB()
appears in the code flow after the init.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: macro cleanup in softmac dma
Roland Vossen [Tue, 13 Sep 2011 07:49:45 +0000 (09:49 +0200)]
staging: brcm80211: macro cleanup in softmac dma

Substituted macro's by functions. Renamed several struct members in dma.c
to get rid of a set of macro's.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: fix for fullmac build problem
Roland Vossen [Tue, 13 Sep 2011 07:49:44 +0000 (09:49 +0200)]
staging: brcm80211: fix for fullmac build problem

Fullmac had a build error for CONFIG_PM_SLEEP=n

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove function ieee_set_channel()
Arend van Spriel [Tue, 13 Sep 2011 07:49:43 +0000 (09:49 +0200)]
staging: brcm80211: remove function ieee_set_channel()

The function ieee_set_channel() provides very little functionality
so it has been removed.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove ioctl layer from brcmsmac
Arend van Spriel [Thu, 15 Sep 2011 08:06:21 +0000 (10:06 +0200)]
staging: brcm80211: remove ioctl layer from brcmsmac

The ioctl layer in brcmsmac only provided an interface layer that
was internal to the driver. This is considered pointless and has
been removed.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove static function declaration in dhd_sdio
Franky Lin [Tue, 13 Sep 2011 07:49:41 +0000 (09:49 +0200)]
staging: brcm80211: remove static function declaration in dhd_sdio

Reshuffle function order in dhd_sdio of fullmac to get rid of
static function declaration

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove continuous tx test
David Kilroy [Thu, 15 Sep 2011 23:20:57 +0000 (00:20 +0100)]
staging: wlags49_h2: Remove continuous tx test

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Reformat TX_CNTL comment
David Kilroy [Thu, 15 Sep 2011 23:20:56 +0000 (00:20 +0100)]
staging: wlags49_h2: Reformat TX_CNTL comment

This tabular comment is useful, but the original tabbed layout
is for a tab-wdth of 4. Reformat with spaces.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove HCF_EXT_MB from code.
David Kilroy [Thu, 15 Sep 2011 23:20:55 +0000 (00:20 +0100)]
staging: wlags49_h2: Remove HCF_EXT_MB from code.

The HII and HII.5 configurations both use the mailboxes.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove CKIP support from hcf
David Kilroy [Thu, 15 Sep 2011 23:20:54 +0000 (00:20 +0100)]
staging: wlags49_h2: Remove CKIP support from hcf

CKIP is a Cisco proprietary alternative to TKIP. Support removed to
simplify code - the defines to interact with the firmware are left in
place.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove MUL/DIV_BY_2
David Kilroy [Thu, 15 Sep 2011 23:20:53 +0000 (00:20 +0100)]
staging: wlags49_h2: Remove MUL/DIV_BY_2

Only used in one place, so just inline and get rid of the macro.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove references to SSN
David Kilroy [Thu, 15 Sep 2011 23:20:52 +0000 (00:20 +0100)]
staging: wlags49_h2: Remove references to SSN

SSN seems to be an old abbreviation for WPA. Remove all references.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove some unused defines
David Kilroy [Thu, 15 Sep 2011 23:20:51 +0000 (00:20 +0100)]
staging: wlags49_h2: Remove some unused defines

HCF_INT_OFF, _TCHAR_DEFINED, HCF_LITTLE_ENDIAN, HCF_TALLIES_EXTRA
HCF_ENTRY, HCF_EXIT, OUTPUTDEBUGMSG, ASSERTDEBUGMSG

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Simplify HCF_ENCAP usage
David Kilroy [Thu, 15 Sep 2011 23:20:50 +0000 (00:20 +0100)]
staging: wlags49_h2: Simplify HCF_ENCAP usage

Encapsulation should always be enabled. Support is either via firmware
or in the driver, so we need to keep the macro. The driver can stop
exporting hcf_encap

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove HCF_DL_ONLY
David Kilroy [Thu, 15 Sep 2011 23:20:49 +0000 (00:20 +0100)]
staging: wlags49_h2: Remove HCF_DL_ONLY

This is supposed to profile the code so that you can build a driver
that will only update the firmware. We don't need to support this
configuration.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Reindent hcf.c
David Kilroy [Thu, 15 Sep 2011 23:20:48 +0000 (00:20 +0100)]
staging: wlags49_h2: Reindent hcf.c

Untabify with tab-width set to 4 (to match VI header). Then reindent
with tab-width reset to 8.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Fix macro termination
David Kilroy [Thu, 15 Sep 2011 23:20:47 +0000 (00:20 +0100)]
staging: wlags49_h2: Fix macro termination

Semi-colon terminate various macros (HCFASSERT, IF_PROT_TIME, IF_DMA,
PROT_CNT_INI, HCFLOGENTRY, HCFLOGEXIT, DAWA_ACK, DAWA_ZERO_FID) so
auto-indent will work correctly. Add appropriate do {} while
protection to the macros.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Reindent hcfdef.h
David Kilroy [Thu, 15 Sep 2011 23:20:46 +0000 (00:20 +0100)]
staging: wlags49_h2: Reindent hcfdef.h

Untabified with tab-width set to 4. Reindented with linux style.

Also remove BITN macros.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove non-linux configurations
David Kilroy [Thu, 15 Sep 2011 23:20:45 +0000 (00:20 +0100)]
staging: wlags49_h2: Remove non-linux configurations

For now just remove from hcfcfg.h, we will slowly remove the unused
configurations as we go

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio: move id and device name setting to iio_device_allocate.
Jonathan Cameron [Wed, 14 Sep 2011 12:01:25 +0000 (13:01 +0100)]
staging:iio: move id and device name setting to iio_device_allocate.

The recent reorganization of the sysfs attribute registration had
the side effect of moving iio_device_register after registration of
triggers etc.  The side effect of this is that the id hadn't been
allocated by the time of trigger registration. Thus all triggers
based on device got the name <dev_name>-dev0 instead of <dev_name>-devN
where N is the iio device id.

This should also fix the lack of device name for some error messages
that we have been seeing (and I'd been meaning to track down) as
that has now moved earlier as well.

Reported-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Tested-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:adc:ad7606 add channel type specification to range attributes.
Jonathan Cameron [Wed, 14 Sep 2011 12:01:24 +0000 (13:01 +0100)]
staging:iio:adc:ad7606 add channel type specification to range attributes.

Cleaner and more consistent naming + makes one abi element we don't need
go away.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:tree wide. abi fixup for in_ out_ prefix introduction.
Jonathan Cameron [Wed, 14 Sep 2011 12:01:23 +0000 (13:01 +0100)]
staging:iio:tree wide. abi fixup for in_ out_ prefix introduction.

This patch set should bring all the attributes created outside
of chan_spec registration inline with the new abi.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: update TODO
Aaro Koskinen [Tue, 13 Sep 2011 19:49:35 +0000 (22:49 +0300)]
staging: xgifb: update TODO

There are no build warnings at the moment.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: add missing #include
Aaro Koskinen [Tue, 13 Sep 2011 19:49:34 +0000 (22:49 +0300)]
staging: xgifb: add missing #include

Add a missing include to eliminate the following sparse warning:

drivers/staging/xgifb/vb_table.h:2572:28: warning: symbol 'XGI21_LCDCapList' was not declared. Should it be static?

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: vb_init: use readl()/writel() to access iomapped memory
Aaro Koskinen [Tue, 13 Sep 2011 19:49:33 +0000 (22:49 +0300)]
staging: xgifb: vb_init: use readl()/writel() to access iomapped memory

Use readl() and writel() in FB memory test instead of direct pointer
access, and also add iomem annotations for the FB memory.

The patch eliminates the following sparse warnings:

drivers/staging/xgifb/XGI_main_26.c:2113:69: warning: incorrect type in assignment (different address spaces)
drivers/staging/xgifb/XGI_main_26.c:2113:69:    expected unsigned char *static [addressable] [toplevel] [assigned] pjVideoMemoryAddress
drivers/staging/xgifb/XGI_main_26.c:2113:69:    got void [noderef] <asn:2>*
drivers/staging/xgifb/XGI_main_26.c:2399:30: warning: incorrect type in assignment (different address spaces)
drivers/staging/xgifb/XGI_main_26.c:2399:30:    expected char [noderef] <asn:2>*screen_base
drivers/staging/xgifb/XGI_main_26.c:2399:30:    got char *[addressable] [toplevel] [assigned] video_vbase
drivers/staging/xgifb/XGI_main_26.c:2430:31: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/xgifb/XGI_main_26.c:2430:31:    expected void volatile [noderef] <asn:2>*addr
drivers/staging/xgifb/XGI_main_26.c:2430:31:    got char *[addressable] [toplevel] [assigned] video_vbase
drivers/staging/xgifb/XGI_main_26.c:2454:31: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/xgifb/XGI_main_26.c:2454:31:    expected void volatile [noderef] <asn:2>*addr
drivers/staging/xgifb/XGI_main_26.c:2454:31:    got char *[addressable] [toplev

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: unify #include order
Aaro Koskinen [Tue, 13 Sep 2011 19:49:32 +0000 (22:49 +0300)]
staging: xgifb: unify #include order

Include Linux headers before driver's own headers.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: main: use readb()/readw() to access iomapped memory
Aaro Koskinen [Tue, 13 Sep 2011 19:49:31 +0000 (22:49 +0300)]
staging: xgifb: main: use readb()/readw() to access iomapped memory

Use readb()/readw() instead of direct pointer access to read I/O mapped
memory and also add __iomem annotation.

The patch eliminates the following sparse warnings:

drivers/staging/xgifb/XGI_main_26.c:2125:35: warning: incorrect type in assignment (different address spaces)
drivers/staging/xgifb/XGI_main_26.c:2125:35:    expected char *[addressable] [toplevel] [assigned] mmio_vbase
drivers/staging/xgifb/XGI_main_26.c:2125:35:    got void [noderef] <asn:2>*
drivers/staging/xgifb/XGI_main_26.c:2439:31: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/xgifb/XGI_main_26.c:2439:31:    expected void volatile [noderef] <asn:2>*addr
drivers/staging/xgifb/XGI_main_26.c:2439:31:    got char *[addressable] [toplevel] [assigned] mmio_vbase
drivers/staging/xgifb/XGI_main_26.c:2463:31: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/xgifb/XGI_main_26.c:2463:31:    expected void volatile [noderef] <asn:2>*addr
drivers/staging/xgifb/XGI_main_26.c:2463:31:    got char *[addressable] [toplevel] [assigned] mmio_vbase

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: crystalhd/bc_dts_types.h: typedef cleanup
Arvydas Sidorenko [Mon, 12 Sep 2011 15:16:39 +0000 (17:16 +0200)]
staging: crystalhd/bc_dts_types.h: typedef cleanup

Not much left out of this header file. All these typedefs can be found in stdint.h

Signed-off-by: Arvydas Sidorenko <asido4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: irq: Remove IRQF_DISABLED
Yong Zhang [Wed, 7 Sep 2011 08:10:22 +0000 (16:10 +0800)]
staging: irq: Remove IRQF_DISABLED

This flag is a NOOP and can be removed now.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: netvsc: Cleanup the name and type of link_stat variable
K. Y. Srinivasan [Tue, 13 Sep 2011 22:21:27 +0000 (15:21 -0700)]
Staging: hv: netvsc: Cleanup the name and type of link_stat variable

Consistently name the variable tracking the link status. Use a consistent
type for this variable and get rid of some unnecessary parentheses as well.
I would like to thank Joe Perches <joe@perches.com> for suggesting these
changes and patiently helping me get here!

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: netvsc: Rename deviceInfo as device_info
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:56 +0000 (10:59 -0700)]
Staging: hv: netvsc: Rename deviceInfo as device_info

Rename deviceInfo as device_info.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: netvsc: Rename rndisDevice to rndis_device
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:55 +0000 (10:59 -0700)]
Staging: hv: netvsc: Rename rndisDevice to rndis_device

Rename rndisDevice to rndis_device.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: netvsc: Rename netDevice as net_device
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:54 +0000 (10:59 -0700)]
Staging: hv: netvsc: Rename netDevice as net_device

Rename netDevice as net_device.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Get rid of the module dependency
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:53 +0000 (10:59 -0700)]
Staging: hv: vmbus: Get rid of the module dependency

Hyper-V modules can be built as part of the kernel (not just as modules).
Get rid of the module dependency in Kconfig.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Do not allocate struct hv_device_info on the stack
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:52 +0000 (10:59 -0700)]
Staging: hv: vmbus: Do not allocate struct hv_device_info on the stack

struct hv_device_info is about 101 bytes in size. Do not allocate this structure
on the stack.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Get rid of the ext field in struct hv_device
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:51 +0000 (10:59 -0700)]
Staging: hv: vmbus: Get rid of the ext field in struct hv_device

Now that we have eliminated all uses of the ext field in struct hv_device,
get rid of the ext field.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: mousevsc: Get rid of the usage of the ext field in struct hv_device
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:50 +0000 (10:59 -0700)]
Staging: hv: mousevsc: Get rid of the usage of the ext field in struct hv_device

Get rid of the usage of the ext field in struct hv_device for the mouse driver.
We do this by using the newly introduced functions to set and and get driver
specific data.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: netvsc: Get rid of the usage of the ext field in struct hv_device
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:49 +0000 (10:59 -0700)]
Staging: hv: netvsc: Get rid of the usage of the ext field in struct hv_device

Now, eliminate the usage of ext field in struct  hv_device for netvsc driver.
We do this by registering pointer to struct netvsc_device as the driver
specific data and eliminating the current usage of driver specific data
to save and retrieve the pointer to struct net_device.
Additionally, all access to the driver specific data is through
the vmbus wrapper functions. As part of this cleanup, we also get rid
of some unnecessary debug print statements.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: storvsc: Eliminate the usage of ext field in struct hv_device
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:48 +0000 (10:59 -0700)]
Staging: hv: storvsc: Eliminate the usage of ext field in struct hv_device

Now, eliminate the usage of ext field in struct  hv_device for storvsc driver.
We do this by registering pointer to struct storvsc_device as the driver
specific data and eliminating the current usage of driver specific data to
save and retrieve the pointer to struct Scsi_Host.
Additionally, all access to the driver specific data is through
the vmbus wrapper functions. Note that function to allocate the host
gives us a reference on the host object.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: storvsc: Get rid of some unnecessary state and definitions
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:47 +0000 (10:59 -0700)]
Staging: hv: storvsc: Get rid of some unnecessary state and definitions

Now, get rid of some unnecessary state and definitions.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: storvsc: Get rid of alloc_stor_device() by inlining the code
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:46 +0000 (10:59 -0700)]
Staging: hv: storvsc: Get rid of alloc_stor_device() by inlining the code

Get rid of alloc_stor_device() by inlining the code.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: storvsc: Get rid of storvsc_dev_add() by inlining the code
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:45 +0000 (10:59 -0700)]
Staging: hv: storvsc: Get rid of storvsc_dev_add() by inlining the code

Get rid of storvsc_dev_add() by inlining the code.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Cleanup vmbus_remove()
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:44 +0000 (10:59 -0700)]
Staging: hv: vmbus: Cleanup vmbus_remove()

vmbus_remove() cannot fail; clean it up accordingly.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Introduce functions for setting and getting driver data
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:40 +0000 (10:59 -0700)]
Staging: hv: vmbus: Introduce functions for setting and getting driver data

Introduce vmbus specific wrapper functions to set/get driver specific data.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: storvsc: Use the driver_data to identify ide
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:39 +0000 (10:59 -0700)]
Staging: hv: storvsc: Use the driver_data to identify ide

Use the driver_data to identify ide devices in storvsc_probe().

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Change the signature of struct hv_driver probe function
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:38 +0000 (10:59 -0700)]
Staging: hv: vmbus: Change the signature of struct hv_driver probe function

In preparation to leveraging the driver_data field in struct
hv_vmbus_device_id, change the signature of struct hv_driver probe function.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Introduce a utility function to match hv_vmbus_device_id
K. Y. Srinivasan [Tue, 13 Sep 2011 17:59:37 +0000 (10:59 -0700)]
Staging: hv: vmbus: Introduce a utility function to match hv_vmbus_device_id

Introduce a utility function to match hv_vmbus_device_id.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: intel_sst: fix comment typo
Mark Brown [Thu, 8 Sep 2011 22:43:08 +0000 (15:43 -0700)]
staging: intel_sst: fix comment typo

Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
Acked-by: Liam Girdwood <lrg@ti.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove static function declaration in wl_cfg80211
Franky Lin [Mon, 12 Sep 2011 10:15:04 +0000 (12:15 +0200)]
staging: brcm80211: remove static function declaration in wl_cfg80211

Reshuffle function order in wl_cfg80211 of fullmac to get rid of
static function declaration

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed softmac files alloc.c/alloc.h
Roland Vossen [Mon, 12 Sep 2011 10:15:03 +0000 (12:15 +0200)]
staging: brcm80211: removed softmac files alloc.c/alloc.h

Alloc.c does not contain enough functionality anymore to warrant
its own file. Moved functionality into main.c

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed more unused softmac main.h struct members
Roland Vossen [Mon, 12 Sep 2011 10:15:02 +0000 (12:15 +0200)]
staging: brcm80211: removed more unused softmac main.h struct members

Members were always set to zero, or set but never read.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed unused softmac transmit power variables
Roland Vossen [Mon, 12 Sep 2011 10:15:01 +0000 (12:15 +0200)]
staging: brcm80211: removed unused softmac transmit power variables

Struct member variables were only set to '0'. As a result, function
brcms_c_local_constraint_qdbm() always returned BRCMS_TXPWR_MAX and
thus could be removed.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed several unused softmac main.h struct members
Roland Vossen [Mon, 12 Sep 2011 10:15:00 +0000 (12:15 +0200)]
staging: brcm80211: removed several unused softmac main.h struct members

Members were always set to zero, or set but never read.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed unused softmac struct brcms_c_if
Roland Vossen [Mon, 12 Sep 2011 10:14:59 +0000 (12:14 +0200)]
staging: brcm80211: removed unused softmac struct brcms_c_if

Nothing useful was done with this struct.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed unused softmac code after macro cleanup
Roland Vossen [Mon, 12 Sep 2011 10:14:58 +0000 (12:14 +0200)]
staging: brcm80211: removed unused softmac code after macro cleanup

Since the macro's IS_MCS(0), RSPEC_STF(0) and PHY_TXC1_MODE_SISO all
expand to 0, inactive code could be removed.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed softmac ratespec override functionality
Roland Vossen [Mon, 12 Sep 2011 10:14:57 +0000 (12:14 +0200)]
staging: brcm80211: removed softmac ratespec override functionality

This was unused.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: cleaned up unused softmac struct members
Roland Vossen [Mon, 12 Sep 2011 10:14:56 +0000 (12:14 +0200)]
staging: brcm80211: cleaned up unused softmac struct members

Struct members were unused or only written but never read.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed softmac 'tunable' functionality
Roland Vossen [Mon, 12 Sep 2011 10:14:55 +0000 (12:14 +0200)]
staging: brcm80211: removed softmac 'tunable' functionality

Removed unused mechanism as part of code cleanup.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed unused encryption/security functionality
Roland Vossen [Mon, 12 Sep 2011 10:14:54 +0000 (12:14 +0200)]
staging: brcm80211: removed unused encryption/security functionality

Softmac relies on Mac80211 for this.

Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove static variables from wl_cfg80211.c
Arend van Spriel [Mon, 12 Sep 2011 10:14:53 +0000 (12:14 +0200)]
staging: brcm80211: remove static variables from wl_cfg80211.c

The source file contained two static variable which were used by
the driver instance. This makes having multiple instances of the driver
on one system impossible. This patch removes the use of these static
variables allowing multiple driver instances.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove static function variable in brcmfmac
Arend van Spriel [Mon, 12 Sep 2011 10:14:52 +0000 (12:14 +0200)]
staging: brcm80211: remove static function variable in brcmfmac

The static local variable save_ms in brcmf_sdbrcm_wd_timer() has been
removed and placed in the structure brcmf_bus definition.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed fullmac function brcmf_sdcard_iovar_op()
Roland Vossen [Mon, 12 Sep 2011 10:14:51 +0000 (12:14 +0200)]
staging: brcm80211: removed fullmac function brcmf_sdcard_iovar_op()

brcmf_sdcard_iovar_op was only called with iovar "sd_rxchain", and
always returns 'false' as the queried value. Thus, the entire
function, related iovar tables and related functions could be
removed.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed fullmac BRCMF_IOCTL_MAGIC support
Roland Vossen [Mon, 12 Sep 2011 10:14:50 +0000 (12:14 +0200)]
staging: brcm80211: removed fullmac BRCMF_IOCTL_MAGIC support

Linux will never call brcmf_netdev_ioctl_entry() with the value
BRCMF_IOCTL_MAGIC in a user space buffer. Thus, unused code could be
removed.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: cleaned up fullmac macro's
Roland Vossen [Mon, 12 Sep 2011 10:14:49 +0000 (12:14 +0200)]
staging: brcm80211: cleaned up fullmac macro's

Substituted/moved/removed macro's.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: cleaned up brcmu_wifi.h macro's
Roland Vossen [Mon, 12 Sep 2011 10:14:48 +0000 (12:14 +0200)]
staging: brcm80211: cleaned up brcmu_wifi.h macro's

Substituted/removed macro's.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: cleaned up brcmu_utils.h macro's
Roland Vossen [Mon, 12 Sep 2011 10:14:47 +0000 (12:14 +0200)]
staging: brcm80211: cleaned up brcmu_utils.h macro's

Substituted/removed macro's.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: cleaned up softmac types.h macro's
Roland Vossen [Mon, 12 Sep 2011 10:14:46 +0000 (12:14 +0200)]
staging: brcm80211: cleaned up softmac types.h macro's

Substituted/removed macro's.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: stop using kthread for iscan status check in fullmac
Franky Lin [Mon, 12 Sep 2011 10:14:45 +0000 (12:14 +0200)]
staging: brcm80211: stop using kthread for iscan status check in fullmac

Use work queue instead.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Howard Harte <hharte@broadcom.com>
Signed-off-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: delete redundant casts from mtrr_add() call
Aaro Koskinen [Sat, 10 Sep 2011 21:29:55 +0000 (00:29 +0300)]
staging: xgifb: delete redundant casts from mtrr_add() call

Delete redundant casts from mtrr_add() call.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: fix up MTRR printk
Aaro Koskinen [Sat, 10 Sep 2011 21:29:54 +0000 (00:29 +0300)]
staging: xgifb: fix up MTRR printk

The condition for printk() is wrong. Also change it to dev_info().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: properly delete MTRR region
Aaro Koskinen [Sat, 10 Sep 2011 21:29:53 +0000 (00:29 +0300)]
staging: xgifb: properly delete MTRR region

MTRR region should be deleted on probe failure and driver removal.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agodrivers/staging/crystalhd/: Fix a coding style issues
Arvydas Sidorenko [Thu, 8 Sep 2011 16:46:08 +0000 (18:46 +0200)]
drivers/staging/crystalhd/: Fix a coding style issues

crystalhd_fw_if.h: indentation fix (spaces to tabs)
The rest are brackets.

NOTE: there are quite some 80 character warnings, but they look in place,
comments mostly on the right next to the constants and stuff like that. I
haven't touched them, since this rule is 'going away', but in case you would
like it to be fixed, let me know.

I'm sending 2 patches, but it they aren't connected in any way, so doesn't
matter the apply order. It's just a cleanup.

P.S sorry for the first lame patches a couple of days ago

Signed-off-by: Arvydas Sidorenko <asido4@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix long lines in cx25821-video-upstream.h
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:47 +0000 (11:55 +0800)]
Staging: cx25821: Fix long lines in cx25821-video-upstream.h

Fix long lines in cx25821-video-upstream.h

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix long lines in cx25821-video-upstream.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:46 +0000 (11:55 +0800)]
Staging: cx25821: Fix long lines in cx25821-video-upstream.c

Fix long lines in cx25821-video-upstream.c

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix long lines in cx25821-video-upstream-ch2.h
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:45 +0000 (11:55 +0800)]
Staging: cx25821: Fix long lines in cx25821-video-upstream-ch2.h

Fix long lines in cx25821-video-upstream-ch2.h

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix long lines in cx25821-video-upstream-ch2.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:44 +0000 (11:55 +0800)]
Staging: cx25821: Fix long lines in cx25821-video-upstream-ch2.c

Fix long lines in cx25821-video-upstream-ch2.c

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix wrong line endings in cx25821-video-upstream-ch2.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:43 +0000 (11:55 +0800)]
Staging: cx25821: Fix wrong line endings in cx25821-video-upstream-ch2.c

Change obscure line endings to less obscure ones. Rationale: improve
readability.

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix labels' placement in cx25821-video-upstream-ch2.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:42 +0000 (11:55 +0800)]
Staging: cx25821: Fix labels' placement in cx25821-video-upstream-ch2.c

Delete whitespace characters before labels.

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Replace :? by if-else in cx25821-video-upstream-ch2.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:41 +0000 (11:55 +0800)]
Staging: cx25821: Replace :? by if-else in cx25821-video-upstream-ch2.c

Replace :? operator by if-else equivalent where it improves readability.

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix long lines in cx25821-audio-upstream.h
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:40 +0000 (11:55 +0800)]
Staging: cx25821: Fix long lines in cx25821-audio-upstream.h

Fix long lines in cx25821-audio-upstream.h

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix long lines in cx25821-audio-upstream.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:39 +0000 (11:55 +0800)]
Staging: cx25821: Fix long lines in cx25821-audio-upstream.c

Fix long lines in cx25821-audio-upstream.c

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix obscure line endings in cx25821-audio-upstream.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:38 +0000 (11:55 +0800)]
Staging: cx25821: Fix obscure line endings in cx25821-audio-upstream.c

Change obscure line endings to less obscure ones. Rationale: more
readable.

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix too long lines in cx25821-audio.h
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:37 +0000 (11:55 +0800)]
Staging: cx25821: Fix too long lines in cx25821-audio.h

Fix too long lines in cx25821-audio.h

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix wrong statement indent in cx25821-i2c.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:36 +0000 (11:55 +0800)]
Staging: cx25821: Fix wrong statement indent in cx25821-i2c.c

Fix wrong brace placement and statement indent in cx25821-i2c.c

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix wrong statement indent in cx25821-core.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:35 +0000 (11:55 +0800)]
Staging: cx25821: Fix wrong statement indent in cx25821-core.c

Fix wrong brace placement and statement indent in cx25821-core.c

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Fix wrong statement indent in cx25821-cards.c
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:34 +0000 (11:55 +0800)]
Staging: cx25821: Fix wrong statement indent in cx25821-cards.c

Fix wrong brace placement and statement indent in cx25821-cards.c

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:33 +0000 (11:55 +0800)]
Staging: cx25821: Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl

Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Move EXPORT_SYMBOL() to the right place
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:32 +0000 (11:55 +0800)]
Staging: cx25821: Move EXPORT_SYMBOL() to the right place

Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place.

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Delete file cx25821-gpio.h
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:31 +0000 (11:55 +0800)]
Staging: cx25821: Delete file cx25821-gpio.h

Delete file cx25821-gpio.h since it is not used.

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Rename member name in struct cx25821_dev
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:30 +0000 (11:55 +0800)]
Staging: cx25821: Rename member name in struct cx25821_dev

Rename _audio_upstream_channel_select to _audio_upstream_channel in
in struct cx25821_dev in cx25821.h and all usages of that struct member
as well, because _audio_upstream_channel_select is seems to be too long
for a variable name.

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: cx25821: Get rid of typedef in cx25821.h
Leonid V. Fedorenchik [Fri, 2 Sep 2011 03:55:29 +0000 (11:55 +0800)]
Staging: cx25821: Get rid of typedef in cx25821.h

Get rid of typedef in cx25821.h

Signed-off-by: Leonid V. Fedorenchik <leonidsbox@gmail.com>
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agozram: Fix sparse warnings
Nitin Gupta [Fri, 9 Sep 2011 23:01:00 +0000 (19:01 -0400)]
zram: Fix sparse warnings

Fixes sparse warning:
zram_drv.c:666:6: warning: symbol 'zram_slot_free_notify' was not
declared. Should it be static?

Also, max_zpage_size is now size_t just to be consistent with data-type
of other variables maintaining sizes of various kinds.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:light: V3 fix out of bounds reg_cache[] access
Jonathan Cameron [Fri, 9 Sep 2011 08:53:05 +0000 (09:53 +0100)]
staging:iio:light: V3 fix out of bounds reg_cache[] access

V3 is a straightforward forward port to teh current tree of V2.

Simple fix is to just not cache REG_TEST (offset 8).
Cache doesn't help REG_TEST anyway since we write all 8 bits exactly once
(at resume/init time).

Also fix an "off-by-one" allocation of reg_cache[] array size that
was in the original code before I touched it.

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Cleanup dated comments in channel_mgmt.c
K. Y. Srinivasan [Thu, 8 Sep 2011 14:24:15 +0000 (07:24 -0700)]
Staging: hv: vmbus: Cleanup dated comments in channel_mgmt.c

Cleanup dated comments in channel_mgmt.c.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Rename vmbus_child_device_unregister
K. Y. Srinivasan [Thu, 8 Sep 2011 14:24:14 +0000 (07:24 -0700)]
Staging: hv: vmbus: Rename vmbus_child_device_unregister

The vmbus devices are NOT child devices; rename vmbus_child_device_unregister
to reflect this.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Rename vmbus_child_device_register
K. Y. Srinivasan [Thu, 8 Sep 2011 14:24:13 +0000 (07:24 -0700)]
Staging: hv: vmbus: Rename vmbus_child_device_register

The vmbus devices are NOT child devices; rename vmbus_child_device_register
to reflect this.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Rename vmbus_child_device_create
K. Y. Srinivasan [Thu, 8 Sep 2011 14:24:12 +0000 (07:24 -0700)]
Staging: hv: vmbus: Rename vmbus_child_device_create

The vmbus devices are NOT child devices; rename vmbus_child_device_create
to reflect this.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: dt3155v4l: remove irq_handler from struct dt3155_priv
H Hartley Sweeten [Wed, 7 Sep 2011 21:37:59 +0000 (14:37 -0700)]
staging: dt3155v4l: remove irq_handler from struct dt3155_priv

There is no reason to cache the irq_handler in struct dt3155_priv.  Just pass
the function directly in request_irq.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: dt3155v4l: pci_iomap returns a void __iomem * not a void *
H Hartley Sweeten [Wed, 7 Sep 2011 21:46:05 +0000 (14:46 -0700)]
staging: dt3155v4l: pci_iomap returns a void __iomem * not a void *

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>