luci-mod-system: fix reference to undefined variable

Fixes: 24550446c ("luci-mod-system: fix parsing SSH pubkeys with options")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>

luci-mod-system: fix parsing SSH pubkeys with options

Also eliminate some duplicate code while we're at it.

Fixes: #4684
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit 846b89c5bf07100f9bf1e46bcac55acab5535e26)

luci-app-noddos: remove

The 'noddos' package itself was removed with commit
https://github.com/openwrt/packages/commit/eb9d5bbf39e89909283c431ae981feac39b02d95

Remove also the corresponding LuCI app.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(backported from commit b06bc2c9ef2bd30271afe80a28197a352d15a93f)

Merge pull request #4682 from stangri/19.07-luci-app-simple-adblock

[19.07] luci-app-simple-adblock: README URL update

luci-app-simple-adblock: README URL update

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #4679 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: WebUI for dnsmasq config update, quad9 bootstrap IPv6

luci-app-https-dns-proxy: WebUI for dnsmasq config update, quad9 bootstrap IPv6

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci.mk: correcting a misspell for Brazilian Portuguese

Reported-by: Wellington Uemura
* update message header
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit 151787b561bce39f505d0f5753d0f80d2b796ba3)

treewide: Backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-app-firewall: map proto '*' and 'any' to all on rule config

Before the change, the options '*' and 'any' in the drop down were not
recognized as valid options, when loaded from the uci. With this change,
the options '*' and 'any' are mapped to 'all' and saved as such. This
change is especially important if the proto option is changed manually
to '*' or 'any' in shell and then further configured via LuCI.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit 972096bf39c932ad007fb431c81a2f5fab64649f)

luci-app-statistics: Adjust UI defaults to match config file

Adjust the defaults shown in the LuCI user interface to match
the real default values in the default config file.

(If a plugin is disabled and config values get deleted from
the config file, user has been offered incorrect default
values from UI defaults when the plugin is later re-enabled.)

* email: socket in /var/run/collectd/ dir
* ping: TTL 127
* rrdtool: 3600 sec (1hour) as shortest period, 144 RRArows
* unixsock: socket in /var/run/collectd/ dir

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(Backported and adapted from commit f7e5b56649)

luci-app-statistics: correct/tidy default config

Tidy up the current default config for statistics:

* df: use /overlay as the example mount point instead of /jffs
* openvpn: add missing section

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(backported and adapted from commit c052818ee9)

treewide: i18n - backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-app-adblock: update dns report page

* add search anchor to all listed domains on dns report page
* small wording changes & cosmetics
* update translations

Signed-off-by: Dirk Brenken <dev@brenken.org>

treewide: i18n - backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

treewide: i18n - backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-app-firewall: fix removing networks from zone

Fixes: #4608
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 4dbf600de61c0db9052343f0447ee31db79a8346)

treewide: i18n - backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-app-statistics: CPU plugin: backport defaults from master

Backport from master the current defaults based on 1cff1002.
(The part related to 'idle' state is not backported, yet)

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

rpcd-mod-luci: bump version

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit d9b4f036eae3fd13a9769b9d55435f8de883e8bb)

luci-base: tools.widgets.NetworkSelect: properly validate multi select

Fixes: 2b99473f2 ("luci-base: tools.widget.NetworkSelect: disallow invalid network names")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 5c5b1340e5541d6283b825f7756812fc1784756f)

luci-base: tools.widget.NetworkSelect: disallow invalid network names

Fixes: #4523, #4573
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 2b99473f2cd3321ecf96e92606c3263c2941eb7b)

luci-app-aria2: fix incorrect "Extra Settings" section option name

The "Extra Settings" section `extra_setting` option name does not match what
the `net/aria2` package expects.

See:

- https://github.com/openwrt/packages/blob/openwrt-19.07/net/aria2/files/aria2.init#L311
- https://github.com/openwrt/packages/blob/openwrt-19.07/net/aria2/files/aria2.conf#L31

Causing the luci UI "Extra Settings" option to have no effect. This fix
renames `extra_setting` => `extra_settings`.

Signed-off-by: Raymond Wanyoike <raymond.wanyoike@gmail.com>
(cherry picked from commit 6709d3a355e6723b8a2ae4f5354c3e917d1b7ac8)

rpcd-mod-luci: handle lease files from all dnsmasq/odhcpd sections

Fixes: #911, #4303, #4308
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 0c7a33523027e2241d4ff93dc987c97ce233912e)

luci-app-adblock: extend the download queue scale

* see https://forum.openwrt.org/t/adblock-support-thread/507/1646 for
  details

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit 0cdad3834fdd2180771a8dfb8f29f6369ce3799a)

luci-app-hd-idle: rename .po files to match app name

Rename .po(t) files from hd_idle.po to hd-idle.po
in order to get them noticed in weblate.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(cherry picked from commit 74c17ea84ce55baccdc7be986216fd03865edf7d)

timezone data: update to 2020d

Update timezone data to 2020d

2020b: http://mm.icann.org/pipermail/tz-announce/2020-October/000059.html
     Macquarie Island has stayed in sync with Tasmania since 2011.
     Casey, Antarctica is at +08 in winter and +11 in summer.

2020c: http://mm.icann.org/pipermail/tz-announce/2020-October/000060.html

2020d: http://mm.icann.org/pipermail/tz-announce/2020-October/000062.html
     Palestine ends DST earlier than predicted, on 2020-10-24.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(cherry picked from commit ce3402a4530e06b1b5479e56caf9b8bb3a07dc15)

Merge pull request #4420 from etactica/mos-nlocal-only-1907

19.07: mosquitto: support notifications_local_only flag

Merge pull request #4486 from Robby-/openwrt-19.07-luci-app-firewall-packettoobig

[19.07] luci-app-firewall: rules: add ICMPv6 Packet Too Big (Type 2)

luci-app-adblock: change "refresh" action

* change "refresh" action to fix potential white-/blacklist issues

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit a392dbf888f0cdaee211eca9b58becc804ee3458)

treewide: i18n - backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-base: set the fallback default of rollback timeout to 90s

Set the fallback value of the config change rollback timeout
to 90 seconds to match the change in /etc/config/luci by commit
81cf99a50.

That commit changed the value in the config file, but did
not change the underlying fallback values that do get applied
when there is no proper config item in etc/config/luci.

Users sysupgrading from old systems may have carried an ancient
/etc/config/luci (without rollback config) with them, so this
change should help them to see the intended user experience.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(cherry picked from commit b0fe11ffc4921c606b78ceb9756cc44579689005)

treewide: i18n - backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-app-firewall: rules: add ICMPv6 Packet Too Big (Type 2)

The "Match ICMP type" drop-down menu was missing this ICMPv6 type. According to RFC 4890 section 4.3.1 it is essential for communications and must not be dropped. This patch allows for doing this through LuCI.

Signed-off-by: Robby K <robbyke@gmail.com>

treewide: i18n - backport and sync translations

Backport transations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

Merge pull request #4458 from stangri/19.07-luci-app-vpnbypass

[19.07] luci-app-vpnbypass: ACL-related update

Merge pull request #4461 from stangri/19.07-luci-app-vpn-policy-routing

[19.07] luci-app-vpn-policy-routing: ACL-related update

luci-app-vpn-policy-routing: ACL-related update

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-vpnbypass: ACL update

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #4449 from stangri/19.07-luci-app-simple-adblock

[19.07] luci-app-simple-adblock: support for config auto-update

luci-app-simple-adblock: support for config auto-update

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-base: tweak busybox top regex to accept 'm' in large VSZ

Tweak the lua regex string for process list, so that processes
with extremely large memory sizes (over 100 MB) are matched.
For those large processes busybox top shows a MB value like '234m'
instead of a normal kB value like 234000.

Fixes #4425

Reference to https://github.com/openwrt/luci/issues/4425#issuecomment-694073479

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(cherry picked from commit 4f2ecd88fd02c1279041f45ccd758184b153c875)

treewide: i18n - backport and sync translations

Backport transations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-app-nextdns: fix invalid XHTML

Fixes: #4423
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit 233cacd9eb6919569f40d346901099956a3111d6)

luci-base: dhcp.js: allow hostname to be "*"

Fixes: #4430
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit bdcd09496342d3b8609e718e289656427fa0b28c)

mosquitto: support notifications_local_only flag

Supported since mosquitto 1.5 released in May 2018, and has long
been supported in the init scripts.

Signed-off-by: Karl Palsson <karlp@etactica.com>

luci-app-opkg: flush menu cache after opkg actions

This is a partial backport of dc57e4bc6c83d6c869c318256057e3636bfc5d66

Fixes: #4077
Signed-off-by: Baptiste Jonglez <git@bitsofnetworks.org>

treewide: i18n - backport and sync translations

Backport transations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

Merge pull request #4392 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: add DNSPod.cn DoH

luci-app-https-dns-proxy: add DNSPod.cn DoH

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #4339 from EricLuehrsen/unbound_20200806_1907

[19.07] luci-app-unbound: add rate_limit and dns_assist option support

treewide: i18n - backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-base i18n: fix translations related to password-SSH linkage

Fix translations of themes' headers related to password & SSH.

Adapted backport of commit 641c3b88ae.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

themes: remove deprecated reference to enabling SSH

Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)

Backport of commit 258e74c1c

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

Merge pull request #4340 from plm/remove-rrd-path-double-escape

luci-app-statistics: remove rrd path double escape

luci-app-statistics: remove rrd path double escape

Fixes rendering errors when RRD file names contain IPv6 addresses and the
colon (":") characters are double-escaped.

Reverts escaping added in #2286 in favor of escaping added in #2657.

Signed-off-by: Philip L. McMahon <philip.l.mcmahon@gmail.com>

luci-app-unbound: add rate_limit and dns_assist option support

Signed-off-by: Eric Luehrsen <ericluehrsen@gmail.com>

treewide: backport and sync translations

Backport translations from master.
Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

Merge pull request #4318 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: fix bootstrap_dns for cloudflare security

luci-app-https-dns-proxy: fix bootstrap_dns for cloudflare security

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #4311 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: add OpenDNS servers

luci-app-https-dns-proxy: add OpenDNS servers

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-mod-system: ignore empty /proc/mtd on flash page

A present, but empty /proc/mtd causes validation on the flash page to fail,
preventing any other operation.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit d2d3738d9046339d6374a5957cb790d0d9d62456)

treewide: i18n - backport translations

Backport translations from master and sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

Merge pull request #4262 from TDT-AG/pr/20200713-luci-app-mwan3

luci-app-mwan3: sync changes with mwan3

luci-app-mwan3: fix diagnostics status page style issues

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit 9daf129cbaf6d15716abf77517e4b7ea5d5f8249)

luci-app-mwan3: use ucitrack is now done with mwan3 procd

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit 40957b1c7851cd12833003496cd396ef9a687fcc)

luci-app-mwan3: fix diagnostics status page style issues

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit 9daf129cbaf6d15716abf77517e4b7ea5d5f8249)

luci-app-mwan3: use ucitrack is now done with mwan3 procd

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit 40957b1c7851cd12833003496cd396ef9a687fcc)

luci-app-firewall: migrate syn_flood option to synflood_protect on save

Fixes: #4220
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 0abcb39b623f0eff0fbcdfb99fca8f3224701e86)

luci-base: ui.js: order menu entries with the same weight by name

The previous server side menu rendering ordered items first by their order
weight value, then by their internal name.

Do the same for client side menu rendering.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 0c479891ae31bbe308c4d6e181c118ec3d65c05f)

luci-base: allow themes to provide sysauth.htm

Support for sysauth_template was (inadvertently) dropped in refactorings
to support the json menu construction.  This does not restore that
functionality, which allowed different templates for every node in the
dispatcher tree, but provides an alternative mechanism that allows a
theme to provide a sysauth.htm template file instead.

Tested-by: Karl Palsson <karlp@etactica.com>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 8f9433127e5d2a576a1207da46d02389b82041a5)

luci-app-travelmate: qrcode fix

* escape more special chars which disturb qrcode generation

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit 06ce62b65d05806d39099b46102579eeff66aad2)

luci-app-https-dns-proxy: bugfix: remove eDNS support

Signed-off-by: Stan Grishin <stangri@melmac.net>

treewide: i18n - backport translations

Backport translations from master.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

treewide: i18n - backport translations

Backport translations from master.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-base: form.js: fix handling of array sections in JSONMap forms

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 682f628ea611d8d12a2a4b5925851f99c5a4bd20)

luci-app-simple-adblock: racially-neutral names

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #4168 from dibdot/adb-19.07

luci-app-adblock [19.07]: sync with adblock 4.0.6

luci-app-adblock [19.07]: sync with adblock 4.0.6

* made SafeSearch provider configurable, you can limit
  SafeSearch to certain providers
* add an explanation paragraph to report settings
  tab (regarding restart requirement)
* sync translations

Signed-off-by: Dirk Brenken <dev@brenken.org>

Merge pull request #4153 from stangri/19.07-luci-app-advanced-reboot

[19.07] luci-app-advanced-reboot: bugfix: new board names for Linksys WRT-devices

luci-app-advanced-reboot: bugfix: support new board names for Linksys WRT-devices

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci(-ssl)-nginx: depend on luci-app-opkg

Commit 391e82d6a3 in 2018 added luci-app-opkg dependency to
the 'luci' collection and its derivatives, but as nginx collections
do not depend on main 'luci', they did not get the intended change.

Fixes #4148

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(cherry picked from commit 219f0ce891a2e59d28a2dd8a1d14a29e35a81185)

Merge pull request #4102 from stangri/19.07-luci-app-simple-adblock

[19.07] luci-app-simple-adblock: bugfix: proper processing of failed downloads; decrease reliance on shell commands; proper acl.d file

treewide: i18n - backport translations

Backport translations from master.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

Merge pull request #4118 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: decrease reliance on shell commands; proper acl.d file; add cloudflare family/protect

luci-app-https-dns-proxy: decrease reliance on shell commands; proper acl.d file; add cloudflare family/protect

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-openvpn: fix recipe selection

* add read acl for 'openvpn_recipes', fixed #4112

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit b6465766966c9e1d06778eb6d3d0a4be3920606d)

luci-base: luci.js: properly skip comments when finding require tokens

Fixes: #4020, #4022, #4111
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 6be8f8dbaee90a8a7e8bc87350f21793b9aed35c)

luci-app-simple-adblock: bugfix: proper processing of failed dowloads; decrease reliance on shell commands; proper acl.d file

Signed-off-by: Stan Grishin <stangri@melmac.net>

treewide: i18n - backport translations from master

Backport translations from master.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

luci-base: ui.js: fix function declaration in nested statement

Fix "SyntaxError: Strict mode does not allow function declarations
in a lexically nested statement" error that may occur in some old
browsers (detected on QtWebKit 5.212).

Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
(cherry picked from commit c00d0d9473803eec3248f0f6d7f3404923c80514)

luci-app-mwan3: Remove unnecessary dependency

There is no need to depend on luci-app-firewall, so remove the dependency.

I have examined the code and cannot see any reason for the dependency
and I have built a router with luci-app-mwan3, and without firewall,
luci-app-firewall and it all functions just fine.

Signed-off-by: Brian J. Murrell <brian@interlinx.bc.ca>
(cherry picked from commit 70089cc212f92ee5660db69e32b10e552df3c1c5)

luci-base: firewall.js: remove further zone network/name fallback logic

Fixes: #4093
Fixes: 4052436d8 ("luci-base: firewall.js: don't treat zone name as network fallback")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit f6f4005d0baf70f04752747822cda9f1248c47ca)

luci-app-statistics: modify default amount of data items in RRD

Increase the default number of data items in the RRD database
from 100 to 144. That leads to better matching summarising/averaging
moments between day & week and week & month at the averaging intervals:
30sec, 10min, 70 min, 5h10min, 2d13h

Previous 100 led too easily to situations, where the longer period's
more scarce data gets selected for displaying in the graph. That could
happen if the longer period's last data point was stored more recently
than the last data item in the originally required period.
(E.g. if the last "week data item" was more recent than the last
"day data item", the week data was used for the day chart.)

(Note: this change only applies in a live router if the RRD database is
empty. E.g after reboot or after emptying the RRD database dir.)

Reference to discussion at #4065

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(cherry picked from commit 591b918ea4e67d863c74d3d99bd5878c38d06761)

luci-app-vpnbypass: don't clobber permissions of VPN menu

Ref: https://github.com/openwrt/luci/issues/4066
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 7f4de85b0b9c4f6bd9a19bf5a44af3825b31e8c1)

luci-app-vpn-policy-routing: don't clobber permissions of VPN menu

Ref: https://github.com/openwrt/luci/issues/4066
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 4dcab51ca522407cf63a51883bc6505cf24fbd64)

build: reload rpcd in package postinstall

Send a SIGHUP to rpcd after installing LuCI packages to reload ACL rules.

Also remove redundant code while we're at it.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit ca558f4f93451de7afb2a85c017051cb807b3329)

treewide: stage ACL rules for legacy applications

Fixes: #3866
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 43e872871a85dce70509c3c97c10e9c61788c378)

luci-mod-system: make dropbear pages depend on dropbear executable

Fixes: #4052
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit c7686d4b3c660dfe44eb2decbedce89c0873649e)