Jo-Philipp Wich [Fri, 23 Nov 2018 14:10:54 +0000 (15:10 +0100)]
luci-mod-network: wifi scan CSS tweaks
Hide less important fields for mobile views.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Fri, 23 Nov 2018 14:10:16 +0000 (15:10 +0100)]
luci-mod-system: sshkeys CSS tweak
Overflow pubkey preview to the left, not to the right.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Fri, 23 Nov 2018 14:08:50 +0000 (15:08 +0100)]
luci-theme-bootstrap: add responsive CSS
Add responsive CSS to improve the rendering on small screen devices.
Tested on Mobile Safari using an iPhone 5 and iPhone 6, ymmv for other
platforms.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Fri, 23 Nov 2018 09:14:49 +0000 (10:14 +0100)]
Merge pull request #2328 from tano-systems/fix-translate-arg
luci-mod-network: fix invalid translate() argument pass
Anton Kikin [Thu, 22 Nov 2018 21:46:51 +0000 (00:46 +0300)]
luci-mod-network: fix invalid translate() argument pass
We must pass to the translate() a string without substituted zone name.
Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
Jo-Philipp Wich [Thu, 22 Nov 2018 17:51:12 +0000 (18:51 +0100)]
Merge pull request #2325 from YuriPet/master
luci-base & luci-app-opkg: update Ukrainian translation
Jo-Philipp Wich [Thu, 22 Nov 2018 13:47:56 +0000 (14:47 +0100)]
luci-base: do not trigger form action when revealing password
Ref: https://github.com/openwrt/luci/issues/2327
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Yurii [Thu, 22 Nov 2018 12:09:12 +0000 (14:09 +0200)]
luci-app-opkg: update Ukrainian translation
Signed-off-by: Yurii yuripet@gmail.com
Yurii [Thu, 22 Nov 2018 12:07:45 +0000 (14:07 +0200)]
luci-base: update Ukrainian translation
Signed-off-by: Yurii yuripet@gmail.com
Jo-Philipp Wich [Wed, 21 Nov 2018 19:16:06 +0000 (20:16 +0100)]
luci-mod-status: move index and iptables page JS code into external files
Also adjust the Bootstrap and OpenWrt themes accordingly
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Thu, 22 Nov 2018 11:56:05 +0000 (12:56 +0100)]
luci-mod-network: move wifi overview markup and JS code into external files
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 21 Nov 2018 20:07:34 +0000 (21:07 +0100)]
luci-mod-network: move interface overview JS into external file
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Thu, 22 Nov 2018 07:52:14 +0000 (08:52 +0100)]
luci-base: move DOM manipulation functions to luci.js
Introduce a new luci.dom class which groups the DOM manipulation helpers
such as E(), findParent(), matchesElem() etc.
Provide wrappers for the old functions to ease the transition to the new
functions.
Also add a new widget helper function L.itemlist() which consolidates
the item enumeration formatting code found on various pages.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Thu, 22 Nov 2018 07:57:09 +0000 (08:57 +0100)]
luci-app-opkg: allow presetting filter via query attribute
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 21 Nov 2018 19:04:55 +0000 (20:04 +0100)]
luci-mod-system: move password and sshkey JS code into external files
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 21 Nov 2018 19:01:54 +0000 (20:01 +0100)]
luci-app-opkg: move JS code into external file
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 21 Nov 2018 19:27:08 +0000 (20:27 +0100)]
luci-base: cbi.js: remove functions moved to luci.js
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 21 Nov 2018 17:44:59 +0000 (18:44 +0100)]
luci-base: introduce common JavaScript api
Introduce a new script file luci.js which is included by default and
intended to be the common location of functions currently scattered
in cbi.js and xhr.js.
The luci.js file provides a LuCI() class which - among other things -
implements helpers to construct URL paths and making HTTP requests.
A singleton instance of the class is instantiated as window.L upon
load and preset with the necessary environment information.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 21 Nov 2018 17:30:14 +0000 (18:30 +0100)]
build: add build option to minify *.js files
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Dirk Brenken [Thu, 22 Nov 2018 11:09:52 +0000 (12:09 +0100)]
Merge pull request #2323 from musashino205/l10n/base-upd-ja
luci-base: update Japanese translation
Dirk Brenken [Thu, 22 Nov 2018 11:09:19 +0000 (12:09 +0100)]
Merge pull request #2317 from TDT-AG/pr/
20181121-luci-app-openvpn
luci-app-openvpn: redirect to overview page on save/apply, hide boolean by default and cleanup code
Florian Eckert [Thu, 22 Nov 2018 09:53:55 +0000 (10:53 +0100)]
luci-app-openvpn: do not show all boolean option by default
If a new instance is edit then all boolean option are shown on the LuCI.
This is confusing. To fix this hide all boolean ellements on the config
page which are not enabled by default. They must be add first.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
INAGAKI Hiroshi [Thu, 22 Nov 2018 07:27:00 +0000 (16:27 +0900)]
luci-base: update Japanese translation
Updated Japanese translations.
Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
Florian Eckert [Wed, 21 Nov 2018 12:15:29 +0000 (13:15 +0100)]
luci-app-openvpn: On apply/save redirect to OpenVPN overview page
This change will redirect on apply/save to the OpenVPN overview page.
This is the default behaviour on LuCI.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Florian Eckert [Wed, 21 Nov 2018 11:46:29 +0000 (12:46 +0100)]
luci-app-openvpn: sync code style with openvpn-advanced
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Florian Eckert [Wed, 21 Nov 2018 11:42:10 +0000 (12:42 +0100)]
luci-app-openvpn: fix whitespaces in openvpn-basic
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Anton Kikin [Wed, 21 Nov 2018 19:24:00 +0000 (22:24 +0300)]
luci-app-statistics: update and fix Russian translation
Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
[ Fixed too wide line lengths with i18n-sync.pl ]
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Hannu Nyman [Wed, 21 Nov 2018 17:17:57 +0000 (19:17 +0200)]
Merge pull request #2319 from tano-systems/luci-base-upd-rus-i18n
luci-base: update Russian translation
Dirk Brenken [Wed, 21 Nov 2018 14:51:19 +0000 (15:51 +0100)]
Merge pull request #2307 from dibdot/ovpn
luci-app-openvpn: more changes & fixes
Dirk Brenken [Mon, 19 Nov 2018 20:20:22 +0000 (21:20 +0100)]
luci-app-openvpn: more changes & fixes
* fix possible exception in template based ovpn creation
* remove needless shellquote function in controller,
the filename will be checked on client side with JS
* enhance FileUpload behaviour in basic/advanced mode:
- change "auth_user_pass" to FileUpload
- cfg entries (even with default values) will be shown
- existing entries are now removable (incl. file unlink),
simply clear the appropriate textbox
* change "key_direction" option to boolean ListValue
* add "config" option to basic/advanced edit,
to make it possible to change the upload path in LuCI
Signed-off-by: Dirk Brenken <dev@brenken.org>
Anton Kikin [Tue, 20 Nov 2018 16:59:48 +0000 (19:59 +0300)]
luci-base: update Russian translation
Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
Jo-Philipp Wich [Wed, 21 Nov 2018 10:21:55 +0000 (11:21 +0100)]
Merge pull request #2316 from sotux/master-aria2
luci-app-aria2: add button for to AriaNg
Zheng Qian [Wed, 21 Nov 2018 02:48:32 +0000 (10:48 +0800)]
luci-app-aria2: add a button to open ariang
Signed-off-by: Zheng Qian <sotux82@gmail.com>
Hannu Nyman [Wed, 21 Nov 2018 05:41:19 +0000 (07:41 +0200)]
Merge pull request #2313 from sotux/master
i18n: luci-base: update Simplified Chinese translation
Hannu Nyman [Wed, 21 Nov 2018 05:39:45 +0000 (07:39 +0200)]
Merge pull request #2315 from musashino205/l10n/opkg-upd-ja
luci-app-opkg: fix and update Japanese translation
INAGAKI Hiroshi [Wed, 21 Nov 2018 03:30:36 +0000 (12:30 +0900)]
luci-app-opkg: fix and update Japanese translation
Fixed and updated Japanese translations.
Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
Zheng Qian [Wed, 21 Nov 2018 00:40:52 +0000 (08:40 +0800)]
i18n: luci-base: update Simplified Chinese translation
Signed-off-by: Zheng Qian <sotux82@gmail.com>
Jo-Philipp Wich [Tue, 20 Nov 2018 12:31:58 +0000 (13:31 +0100)]
luci-theme-bootstrap, luci-theme-openwrt: allow dynlist .add-item to expand
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Tue, 20 Nov 2018 12:20:52 +0000 (13:20 +0100)]
luci-app-opkg: use a more appropriate german translation for "clear"
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Tue, 20 Nov 2018 10:54:22 +0000 (11:54 +0100)]
luci-mod-system: submit password change on enter
Allow to submit the password change form by pressing enter in the second
input field.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Tue, 20 Nov 2018 10:46:17 +0000 (11:46 +0100)]
luci-base: resync translations
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Tue, 20 Nov 2018 10:45:43 +0000 (11:45 +0100)]
luci-app-opkg: resync translations
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Tue, 20 Nov 2018 10:43:20 +0000 (11:43 +0100)]
luci-base: fix apply/rollback strings
Commit
94d8c9a7a accidentally overwrite the rewording of strings made in
an earlier commit.
Fixes: 94d8c9a7a ("luci-base: simplify apply widget code")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Tue, 20 Nov 2018 09:50:03 +0000 (10:50 +0100)]
luci-mod-system: restructure administration pages
Split password, dropbear and SSH key configuration into separate pages in
order to improve the form layout and to simplify the code.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Tue, 20 Nov 2018 07:18:27 +0000 (08:18 +0100)]
Merge pull request #2308 from YuriPet/master
opkg.po: update Ukrainian translation
Yurii [Mon, 19 Nov 2018 22:51:38 +0000 (00:51 +0200)]
opkg.po: update Ukrainian translation
Signed-off-by: Yurii yuripet@gmail.com
Dirk Brenken [Mon, 19 Nov 2018 15:51:44 +0000 (16:51 +0100)]
Merge pull request #2304 from ryu0/master
luci-app-lxc: add i686 to target map
James Buren [Sun, 18 Nov 2018 20:57:37 +0000 (14:57 -0600)]
luci-app-lxc: add i686 to target map
Add i686 to target map so i386 container templates are usable.
Signed-off-by: James Buren <ryuo@ryuo.xyz>
Jo-Philipp Wich [Mon, 19 Nov 2018 12:28:52 +0000 (13:28 +0100)]
luci-base: further hash calculation signedness bugfixes
- cbi.js: make sure to treat single bytes as signed char when
handling end cases
- template_lmo.c: make sure to treat single bytes as signed
char when handling end cases, avoids hash miscalculations
on ARM
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Mon, 19 Nov 2018 10:58:17 +0000 (11:58 +0100)]
luci-base: cbi.js: fix sfh() signedness bug for strings with 3 trailing bytes
Replace a sign-propagating right shift by a zero-filling right shift to avoid
calculating a wrong hash code in the three-trailing-bytes case.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Mon, 19 Nov 2018 10:47:18 +0000 (11:47 +0100)]
luci-base: cbi.js: fix sfh() hash calculation over multibyte sequences
The C side implementation of the hash operates on bytes while the JS variant
operated on UTF-16 codepoints, leading to miscalculations on input strings
containing multibyte sequences.
Recode the given string to an internal UTF-8 byte representation and
calculate the hash over that.
Fixes client side mapping of translation strings containing non-ASCII
characters.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Mon, 19 Nov 2018 08:26:27 +0000 (09:26 +0100)]
luci-app-opkg: accesibility fixes
- Use semantic button markup for buttons
- Add ARIA labels to page forward/backward buttons
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Mon, 19 Nov 2018 06:51:06 +0000 (07:51 +0100)]
Merge pull request #2306 from yglb/master
luci-theme-rosy: Repair form bug
Yanlan Shen [Mon, 19 Nov 2018 05:37:36 +0000 (13:37 +0800)]
luci-theme-luci: Match css to implement related styles
Signed-off-by: Yanlan Shen <yanlan.shen.@rosinson.com>
Yanlan Shen [Mon, 19 Nov 2018 05:34:31 +0000 (13:34 +0800)]
luci-theme-rosy: Modifying the form does not fully display the bug of the dropdown box
Signed-off-by: Yanlan Shen <yanlan.shen.@rosinson.com>
Dirk Brenken [Sat, 17 Nov 2018 15:57:55 +0000 (16:57 +0100)]
Merge pull request #2299 from dibdot/banip
luci-app-banip: sync with update 0.0.6
Jo-Philipp Wich [Sat, 17 Nov 2018 13:54:43 +0000 (14:54 +0100)]
luci-mod-status: fix average calculations
Calculate the average over the actual data and not over the entire timeframe.
Fixes #2301
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Hannu Nyman [Fri, 16 Nov 2018 21:00:02 +0000 (23:00 +0200)]
Merge pull request #2298 from YuriPet/master
luci-base: update Ukrainian translation
Jo-Philipp Wich [Fri, 16 Nov 2018 20:37:35 +0000 (21:37 +0100)]
Merge pull request #2297 from tano-systems/fix-fstab-mount-table
luci-mod-system: fstab: fix table cell rendering without unmount button
Anton Kikin [Fri, 16 Nov 2018 18:13:14 +0000 (21:13 +0300)]
luci-mod-system: fstab: fix table cell rendering without unmount button
Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
Jo-Philipp Wich [Fri, 16 Nov 2018 18:31:07 +0000 (19:31 +0100)]
luci-base: xhr.js: rework class, handle expired session
Drop very old IE compat code, restructure class, align code style with
other files and properly handle JSON mimetypes with charset trailer.
Also detect session related 403 errors and show a modal prompting
to re-login.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Fri, 16 Nov 2018 18:33:39 +0000 (19:33 +0100)]
luci-base: dispatcher: add login indication on 403 errors
Send a custom LuCI X-Header to indicate that a login is required to access
the requested resource. This is mainly intended for xhr.js to be able to
intercept such responses and popup an authentication dialog.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Fri, 16 Nov 2018 18:29:33 +0000 (19:29 +0100)]
luci-theme-bootstrap: remove redundant rules
Drop rules specific to the old status page progress bars and rework the
cbi element rules to work independently of a parent form tag.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Dirk Brenken [Fri, 16 Nov 2018 20:09:14 +0000 (21:09 +0100)]
luci-app-banip: sync with update 0.0.6
* add a manual interface selection to support
multiple WAN interfaces in iptables rules
Signed-off-by: Dirk Brenken <dev@brenken.org>
Yurii [Fri, 16 Nov 2018 19:59:41 +0000 (21:59 +0200)]
luci-base: update Ukrainian translation
Signed-off-by: Yurii yuripet@gmail.com
Hannu Nyman [Fri, 16 Nov 2018 16:57:15 +0000 (18:57 +0200)]
Merge pull request #2296 from tano-systems/luci-base-upd-rus-i18n
luci-base: update Russian translation
Anton Kikin [Fri, 16 Nov 2018 16:50:46 +0000 (19:50 +0300)]
luci-base: update Russian translation
Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
Hannu Nyman [Fri, 16 Nov 2018 16:27:50 +0000 (18:27 +0200)]
Merge pull request #2293 from musashino205/l10n/opkg-upd-ja
luci-app-opkg: update Japanese translation
Jo-Philipp Wich [Fri, 16 Nov 2018 14:17:25 +0000 (15:17 +0100)]
Merge pull request #2295 from musashino205/l10n/base-upd-ja
luci-base: update Japanese translation
INAGAKI Hiroshi [Fri, 16 Nov 2018 14:09:24 +0000 (23:09 +0900)]
luci-base: update Japanese translation
Updated Japanese translations.
Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
INAGAKI Hiroshi [Fri, 16 Nov 2018 10:59:41 +0000 (19:59 +0900)]
luci-app-opkg: update Japanese translation
Updated Japanese translations.
Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
Dirk Brenken [Fri, 16 Nov 2018 08:07:11 +0000 (09:07 +0100)]
Merge pull request #2292 from dibdot/banip
luci-app-banip: adapt latest css changes
Dirk Brenken [Fri, 16 Nov 2018 08:06:54 +0000 (09:06 +0100)]
Merge pull request #2291 from dibdot/adblock
luci-app-adblock: adapt latest css changes
Dirk Brenken [Fri, 16 Nov 2018 08:06:38 +0000 (09:06 +0100)]
Merge pull request #2290 from dibdot/travelmate
luci-app-travelmate: adapt latest css changes
Dirk Brenken [Fri, 16 Nov 2018 08:03:41 +0000 (09:03 +0100)]
luci-app-travelmate: adapt latest css changes
Signed-off-by: Dirk Brenken <dev@brenken.org>
Dirk Brenken [Fri, 16 Nov 2018 07:56:32 +0000 (08:56 +0100)]
luci-app-adblock: adapt latest css changes
Signed-off-by: Dirk Brenken <dev@brenken.org>
Dirk Brenken [Fri, 16 Nov 2018 07:55:46 +0000 (08:55 +0100)]
luci-app-banip: adapt latest css changes
Signed-off-by: Dirk Brenken <dev@brenken.org>
Jo-Philipp Wich [Thu, 15 Nov 2018 22:00:34 +0000 (23:00 +0100)]
luci-theme-openwrt: modal display fixes
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Angus Ding [Thu, 15 Nov 2018 18:26:12 +0000 (19:26 +0100)]
luci-base: rename "Design" to "Theme" in translation files
Signed-off-by: Angus Ding <angus.ding@gmail.com>
[squash commits, reword commit message, rebase, msgmerge]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Angus Ding [Mon, 22 Oct 2018 05:40:51 +0000 (13:40 +0800)]
luci-mod-system: rename "Design" to "Theme"
This provides a more accurate description for the theme selection.
Signed-off-by: Angus Ding <angus.ding@gmail.com>
[reword commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Thu, 15 Nov 2018 18:14:56 +0000 (19:14 +0100)]
treewide: resync translation files
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Darius [Fri, 9 Nov 2018 10:38:33 +0000 (12:38 +0200)]
luci-mod-network: function name mismatch fixed
Signed-off-by: Darius <jok.darius@gmail.com>
Matthias84 [Sun, 11 Nov 2018 17:30:34 +0000 (18:30 +0100)]
luci-app-vpnbypass: add german translation
Submitted-by: Matthias Meißer <Matthias84@users.noreply.github.com>
[slightly reword subject]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Matthias84 [Sat, 10 Nov 2018 19:43:04 +0000 (20:43 +0100)]
luci-app-wireguard: add german translation
Submitted-by: Matthias84 <Matthias84@users.noreply.github.com>
[reword commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Wang805447391 [Mon, 12 Nov 2018 07:03:31 +0000 (15:03 +0800)]
luci-base: support disconnecting (deauthenticating) wireless clients
Add a button to each row in the wireless assoclist table to allow
disconnecting clients using the ubus del_client method if the underlying
radio interface supports it.
Ref: https://github.com/openwrt/luci/pull/2271
Submitted-by: Wang805447391 <805447391@qq.com>
[move deauth function to luci-base next to the existing assoclist function,
require post security, fix parameter check condition, hide button if not
supported by the radio, disable button after call, squash commits, fix
whitespace, reword subject, add commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
alphakk [Thu, 15 Nov 2018 04:06:09 +0000 (12:06 +0800)]
luci-app-https_dns_proxy: fix datatype of subnet address option
The datatype ip4prefix only accept numbers from 0 to 32, not subnet/mask
(i.e. 192.168.1.0/24), this affects option "-e".
https://github.com/openwrt/luci/wiki/Datatypes#ip4prefix the description
is wrong, according to src
http://luci.subsignal.org/trac/browser/luci/branches/luci-0.10/libs/web/luasrc/cbi/datatypes.lua#L76
Submitted-by: alphakk <kkspaces@mail.com>
[slightly reword commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Whitronic [Thu, 8 Nov 2018 11:25:43 +0000 (11:25 +0000)]
luci-proto-vpnc: expose defaultroute option in proto_vpnc.lua
Sometimes people only want the VPN connection to be a route to a specific
network, not the default gateway for all traffic.
I've tested this on my router and works fine!
Submitted-by: Whitronic <joao.f.vieira@gmail.com>
[reword commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Thu, 15 Nov 2018 06:14:06 +0000 (07:14 +0100)]
Merge pull request #2286 from kevinoid/fix_statistics_filename_quoting
luci-app-statistics: quote : in filenames for DEF
Kevin Locke [Wed, 14 Nov 2018 23:55:24 +0000 (16:55 -0700)]
luci-app-statistics: quote : in filenames for DEF
: is used to delimit fields in DEF: rrd instructions, so when it appears
in a filename it must be escaped using \.[1] This commit adds the
escaping.
I discovered the issue after configuring collectd-mod-ping to monitor an
IPv6 host (2001:19f0:5:727:5b56:205d:ff55:2208). Accessing
https://192.168.0.1/cgi-bin/luci/admin/statistics/graph/ping would cause
the following messages to be logged:
Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_avg_raw=/tmp/rrd/openwrthost/ping/ping-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2
Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_droprate_avg_raw=/tmp/rrd/openwrthost/ping/ping_droprate-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2
and the graphs would not display. After applying this commit, the
graphs display correctly and no messages are logged.
1. https://oss.oetiker.ch/rrdtool/doc/rrdgraph_data.en.html#IDEF
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Jo-Philipp Wich [Wed, 14 Nov 2018 20:03:40 +0000 (21:03 +0100)]
luci-base: fix some long standing german mistranslations
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 14 Nov 2018 19:59:26 +0000 (20:59 +0100)]
luci-mod-network: require unique MACs for DHCP leases
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 14 Nov 2018 19:58:32 +0000 (20:58 +0100)]
luci-base: datatypes: add "unique" dummy validator
Add a dummy validator for the server side so that we can start using unique
in client side JS code.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 14 Nov 2018 19:50:03 +0000 (20:50 +0100)]
Merge pull request #2259 from pmelange/luci-app-olsr-new-json-lib
update luci-app-olsr to the new jsoninfo library
Jo-Philipp Wich [Wed, 14 Nov 2018 19:48:15 +0000 (20:48 +0100)]
Merge pull request #2282 from TDT-AG/pr/
20181114-luci-base
luci-base: allow optional default value for file browser
Jo-Philipp Wich [Wed, 14 Nov 2018 13:35:01 +0000 (14:35 +0100)]
luci-lib-ipkg: move out of luci-base
Move the old luci.model.ipkg utility class into a separate package and
let the components using it depend on the new library package.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 14 Nov 2018 13:07:41 +0000 (14:07 +0100)]
luci-mod-system: replace builtin opkg support with luci-app-opkg
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 14 Nov 2018 12:48:59 +0000 (13:48 +0100)]
luci-mod-system: use luci.sys.process.exec() in system controller
Switch the system controller to the common luci.sys.process.exec() function
and drop the local ltn12_popen() and fork_exec() helpers.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 14 Nov 2018 12:37:51 +0000 (13:37 +0100)]
luci-mod-system: prevent comment injection in mtdbackup endpoint
Rework the parameter handling to both prevent a crash when no parameter is
given and to prevent root command injection through the mtd index part of
the parameter value.
Fixes: 9840d310e ("modules: add backup module for mtdblock devices")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Wed, 14 Nov 2018 08:53:15 +0000 (09:53 +0100)]
applications: add luci-app-opkg
Add a new luci-app-opkg which is a feature-complete replacement for the
builtin opkg functionality of luci-mod-system using mostly client side
JavaScript to reduce the amount of server side processing.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Jo-Philipp Wich [Tue, 13 Nov 2018 19:01:32 +0000 (20:01 +0100)]
luci-app-firewall: remove references to cbi_bind()
Use the standard addEventListener() instead. Also remove an old
cbi_validate_field() call referencing a not existing field.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
projects / project / luci.git / log