Tapasweni Pathak [Wed, 8 Oct 2014 18:03:40 +0000 (23:33 +0530)]
staging: wlan-ng: replace kmalloc and memset with kzalloc
Replace kmalloc and memset with a single call of kzalloc in
file of wlan-ng.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Wed, 8 Oct 2014 15:11:26 +0000 (20:41 +0530)]
staging: rtl8712: Remove unnecessary cast for argument of kfree
This patch removes all occurrences of unnecessary cast on the
argument to kfree, all over in rtl8712.
There is no need of the cast on the argument to kfree.
Greped to find occurrences.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Mon, 6 Oct 2014 23:50:28 +0000 (02:50 +0300)]
staging: slicoss: Fix warning of prefer ether_addr_copy().
This patch fixes the following checkpatch.pl warnings:
WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet
addresses are __aligned(2)" in file slicoss.c
Pahole shows that the addresses are aligned.
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumari Radha [Wed, 8 Oct 2014 09:18:44 +0000 (14:48 +0530)]
staging: vme: devices: Added a paragraph to describe Kconfig symbol
This patch adds module name information about config symbol fixing the following checkpatch.pl warning in Kconfig:
WARNING: please write a paragraph that describes the config symbol fully
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Veronika Kabatova [Wed, 8 Oct 2014 01:47:35 +0000 (03:47 +0200)]
staging: unisys: Union ULTRA_COMPONENT_VERSION not used, removed
Remove unused union ULTRA_COMPONENT_VERSION
Signed-off-by: Veronika Kabátová <veronicca114@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Veronika Kabatova [Wed, 8 Oct 2014 01:59:55 +0000 (03:59 +0200)]
staging: unisys: Remove typedef and rename enum to lowercase
Remove typedef and rename enum to lowercase (control_vm_id)
Signed-off-by: Veronika Kabátová <veronicca114@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Sun, 5 Oct 2014 18:55:51 +0000 (00:25 +0530)]
staging: gdm72xx: Removed unnecesarry out of memory usage
WARNING: Possible unnecessary out of memory usage
checkpatch.pl warning in gdm_wimax.c
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Tue, 7 Oct 2014 08:41:08 +0000 (11:41 +0300)]
staging: gdm724x: Fix incorrect type in assignment
This patch fixes following sparse warnings:
drivers/staging/gdm724x/gdm_mux.c:389:32: warning: incorrect type in assignment (different base types)
drivers/staging/gdm724x/gdm_mux.c:389:32: expected unsigned int [unsigned] start_flag
drivers/staging/gdm724x/gdm_mux.c:389:32: got restricted __le32 [usertype] <noident
drivers/staging/gdm724x/gdm_mux.c:390:29: warning: incorrect type in assignment (different base types)
drivers/staging/gdm724x/gdm_mux.c:390:29: expected unsigned int [unsigned] seq_num
drivers/staging/gdm724x/gdm_mux.c:390:29: got restricted __le32 [usertype] <noident>
drivers/staging/gdm724x/gdm_mux.c:391:34: warning: incorrect type in assignment (different base types)
drivers/staging/gdm724x/gdm_mux.c:391:34: expected unsigned int [unsigned] payload_size
drivers/staging/gdm724x/gdm_mux.c:391:34: got restricted __le32 [usertype] <noident>
drivers/staging/gdm724x/gdm_mux.c:392:33: warning: incorrect type in assignment (different base types)
drivers/staging/gdm724x/gdm_mux.c:392:33: expected unsigned short [unsigned] packet_type
drivers/staging/gdm724x/gdm_mux.c:392:33: got restricted __le16 [usertype] <noident>
Sparse found above warnings, so this patch changes variable types of
structs. Because expected and got variable types are different.
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Reviewed-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Tue, 7 Oct 2014 12:26:23 +0000 (15:26 +0300)]
staging: gdm724x: Fix warning of prefer ether_addr_copy.
This patch fixes the following checkpatch.pl warnings:
WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet
addresses are __aligned(2)" in file gdm_lte.c
Pahole shows that the addresses are aligned.
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Wed, 8 Oct 2014 10:49:51 +0000 (13:49 +0300)]
staging: dgnc: Remove space before tabs
This patch fixes the warning of "Please, no space before tab" produced
by checkpatch.pl. The modified file: dgnc_tty.c
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roberta Dobrescu [Tue, 7 Oct 2014 10:08:12 +0000 (13:08 +0300)]
staging: dgnc: Remove non-standard APR/RAPR printing macros
This patch removes non-standard macros used by dgnc driver for printing error
or debugging messages. These are replaced by dev_err/dev_dbg (when possible)
or pr_err. There were cases where the message is completely removed since is
not adding any useful information.
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 04:49:09 +0000 (10:19 +0530)]
Staging: dgnc: Compress two lines of code into one.
The following patch merges two lines of code into one using coccinelle
and removes unused variables. The semantic patch used is as follows:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Sat, 4 Oct 2014 22:05:57 +0000 (01:05 +0300)]
staging: vt6656: remove unnecessary 'out of memory' message
This patch fixes "Possible unnecessary 'out of memory' message"
checkpatch.pl warning in main_usb.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:56:39 +0000 (11:26 +0530)]
staging: android: ion: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Fri, 3 Oct 2014 23:30:35 +0000 (02:30 +0300)]
staging: wlan-ng: remove unnecessary 'out of memory' message
This patch fixes "Possible unnecessary 'out of memory' message"
checkpatch.pl warning in hfa384x_usb.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Veronika Kabatova [Sun, 5 Oct 2014 08:33:56 +0000 (10:33 +0200)]
staging: wlan-ng: add blank lines after declarations
Fixes "missing blank line after declaration" warnings by checkpatch.pl
Signed-off-by: Veronika Kabátová <veronicca114@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Wed, 8 Oct 2014 17:26:44 +0000 (22:56 +0530)]
staging: lustre: lustre: llite: use DIV_ROUND_UP
The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
(d)) but is perhaps more readable.
Coccinelle script used :
// <smpl>
@haskernel@
@@
@depends on haskernel@
expression n,d;
@@
(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tina Johnson [Wed, 8 Oct 2014 06:50:23 +0000 (12:20 +0530)]
Staging: lustre: Fix checkpatch error: Unnecessary comparison
Removed unnecessary comparison against NULL to remove following
checkpatch error:
ERROR: spaces required around that '!='
Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumari Radha [Fri, 3 Oct 2014 19:15:14 +0000 (00:45 +0530)]
staging: ft1000: ft1000-pcmcia: Replace printks with netdev_<level> and dev_<level>
This patch replaces printk(KERN_INFO ... with dev_info and printk(KERN_ERR ... with netdev_err fixing following checkpatch.pl warnings in ft1000_hw.c:
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Signed-off-by: Kumari Radha <kumari.radha3@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Wed, 8 Oct 2014 04:45:42 +0000 (10:15 +0530)]
staging: rtl8723au: core: Replace open coded version with existing hweight function
This patch replaces the open coded version with Linux's existing hweight
functions.
The original version checked each of the low four bits, accumulating and
returning the result. Instead, use a mask to select those four bits, and
pass the result to hweight8.
It also makes the code in this function simpler.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Wed, 8 Oct 2014 14:25:16 +0000 (19:55 +0530)]
Staging: rtl8723au: include: Remove unused macros
This patch removes macros that are never used.
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Wed, 8 Oct 2014 03:42:17 +0000 (09:12 +0530)]
staging: media: davinci_vpfe: Replace *__iomem with __iomem *
This patch fixes defective positional use of __iomem, wherever
present in media: davinci_vpfe.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Wed, 8 Oct 2014 05:47:28 +0000 (11:17 +0530)]
staging: media: cxd2009: use usleep_range()
This patch fixes checkpatch.pl warning in file cxd2099.c
WARNING : msleep < 20ms can sleep for up to 20ms; see
Documentation/timers/timers-howto.txt
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Tue, 7 Oct 2014 17:50:07 +0000 (23:20 +0530)]
staging: media: ompa4iss: Replace sprintf with snprintf
This patch replaces sprintf with snprintf as sprintf does
not check for buffer overflow.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumari Radha [Wed, 8 Oct 2014 07:15:44 +0000 (12:45 +0530)]
staging: media: omap4iss: Remove unnecessary 'out of memory' message
This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in iss.c:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Kumari Radha <kumari.radha3@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumari Radha [Wed, 8 Oct 2014 07:14:57 +0000 (12:44 +0530)]
staging: media: omap24xx: Remove unnecessary 'out of memory' message
This patch removes unnecessay out of memory message fixing the following checkpach.pl warning in omap24xxcam.c:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Kumari Radha <kumari.radha3@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Wed, 8 Oct 2014 13:05:47 +0000 (16:05 +0300)]
staging: vt6655: Use ether_addr_copy function
This patch fixes the following checkpatch.pl warnings:
WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet
addresses are __aligned(2)" in file iwctl.c
Pahole shows that the addresses are aligned
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Wed, 8 Oct 2014 15:25:31 +0000 (18:25 +0300)]
staging: vt6655: Use ether_addr_copy function
This patch fixes the following checkpatch.pl warnings:
WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet
addresses are __aligned(2)" in file device_main.c
Pahole shows that the addresses are aligned
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Wed, 8 Oct 2014 15:38:51 +0000 (18:38 +0300)]
staging: vt6655: Use ether_addr_copy function
This patch fixes the following checkpatch.pl warnings:
WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet
addresses are __aligned(2)" in file key.c
Pahole shows that the addresses are aligned
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Wed, 8 Oct 2014 16:01:47 +0000 (19:01 +0300)]
staging: vt6655: Removing else after break statement to fix warning
This patch fixes the checkpatch.pl warning in key.c file
WARNING: else is not useful after a break or return
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Wed, 8 Oct 2014 15:11:48 +0000 (20:41 +0530)]
staging: vt6655: Remove unnecessary cast for argument of kfree
This patch removes all occurrences of unnecessary cast on the
argument to kfree, all over in rtl8712.
There is no need of the cast on the argument to kfree.
Greped to find occurrences.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Wed, 8 Oct 2014 12:46:53 +0000 (15:46 +0300)]
staging: vt6655: Remove unnecessary else after return
This patch fixes checkpatch.pl warning in files of vt6655
WARNING: else is not generally useful after a break or return
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Mon, 6 Oct 2014 20:26:50 +0000 (23:26 +0300)]
staging: vt6655: fix do not use // c99 comments.
This patch fixes "do not use // C99 comments" checkpatch.pl errors in
hostap.h
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Mon, 6 Oct 2014 13:21:46 +0000 (16:21 +0300)]
staging: vt6655: Fixed else after return or break warning.
This patch fixes multiple instances of checkpatch.pl
WARNING : else is not generally useful after a break or return in
device_main.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Mon, 6 Oct 2014 10:23:35 +0000 (13:23 +0300)]
staging: vt6655: Fix do not use // c99 comments.
This patch fixes "do not use // C99 comments" errors in datarate.h
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeliz Taneroglu [Fri, 3 Oct 2014 14:09:49 +0000 (17:09 +0300)]
staging: vt6655: Fixed else after return or break warning
The following patch fixes the checkpatch.pl warning:
drivers/staging/vt6655/vntwifi.c warning: else is not generally useful after a break or return
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeliz Taneroglu [Fri, 3 Oct 2014 13:13:06 +0000 (16:13 +0300)]
staging: vt6655: Fixed else after return or break warning
The following patch fixes the checkpatch.pl warning:
drivers/staging/vt6655/hostap.c warning: else is not generally useful after a break or return
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Tue, 7 Oct 2014 12:16:17 +0000 (15:16 +0300)]
staging: rtl8192u: Add space after enum definition
Fix checkpatch.pl warning:
WARNING:missing space after enum definition
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Tue, 7 Oct 2014 17:51:07 +0000 (23:21 +0530)]
staging: rtl8192u: ieee80211: Indent if statement
This patch indents single statement below if statement
in files of rtl8192u: ieee80211.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Mon, 6 Oct 2014 21:05:45 +0000 (00:05 +0300)]
staging: rtl8192u: Missing a blank line after declarations.
Missing a blank line after declarations" checkpatch.pl warning in
r819xU_phy.c
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Sat, 4 Oct 2014 19:25:47 +0000 (22:25 +0300)]
staging: rtl8192u: Fixes symbol as static
This patch fixes "symbol 'ieee80211_send_probe_requests_rsl'
was not declared. Should it be static?" sparse warning
in ieee80211_softmac.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Sat, 4 Oct 2014 19:25:46 +0000 (22:25 +0300)]
staging: rtl8192u: Remove defined but unused function
This patch fixes "symbol 'dm_change_rxpath_selection_setting'
was not declared. Should it be static?" sparse warning in
r8192U_dm.c After setting it as static, it causes to unused
function sparse warning, because it is not used anywhere.
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roxana Blaj [Fri, 3 Oct 2014 12:36:13 +0000 (15:36 +0300)]
staging: rtl8192u: add intermediate variable
This use for more readability.
It also fixes checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roxana Blaj [Fri, 3 Oct 2014 12:36:12 +0000 (15:36 +0300)]
staging: rtl8192u: remove unnecessary line continuations
This fixes the checkpatch.pl warning:
WARNING: Avoid unnecessary line continuations
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roxana Blaj [Fri, 3 Oct 2014 12:36:11 +0000 (15:36 +0300)]
staging: rtl8192u: add spaces around '=', '+=', '<', '||'
This fixes the checkpatch.pl errors:
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '+=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '||' (ctx:VxE)
Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Tue, 7 Oct 2014 11:37:31 +0000 (14:37 +0300)]
staging: bcm: Fixed else after return or break warning
This patch fixes checkpatch.pl warning in files of bcm
WARNING : else is not generally useful after a break or return
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Tue, 7 Oct 2014 12:29:24 +0000 (17:59 +0530)]
staging: bcm: Removed unnecessary braces after return
WARNING: else is generally not useful after return
checkpatch.pl warning in PHSModule.c
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Tue, 7 Oct 2014 00:39:19 +0000 (06:09 +0530)]
staging: bcm: Removed unnecessary else after return
WARNING: else is generally not required after return
chaeckpatch.pl warning in led_control.c
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Mon, 6 Oct 2014 19:56:00 +0000 (01:26 +0530)]
staging: bcm: Removed else which was not required after return
WARNING:else is generally not required after return
checkpatch.pl warning in LeakyBucket.c
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Donald [Thu, 2 Oct 2014 23:10:23 +0000 (18:10 -0500)]
drivers: staging: lustre: Fix "'foo* bar' should be 'foo *bar'" errors
Fix checkpatch.pl "'foo* bar' should be 'foo *bar'" errors
Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Donald [Fri, 3 Oct 2014 15:17:22 +0000 (10:17 -0500)]
drivers: staging: lustre: Fix "else should follow close brace '}'" errors
Fix checkpatch.pl "else should follow close brace '}'" errors
Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thomas Gummerer [Tue, 7 Oct 2014 08:10:32 +0000 (10:10 +0200)]
staging: lustre: fix sparse errors
Mark functions static that are not used or declared outside of lo.c.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Tue, 7 Oct 2014 17:50:24 +0000 (23:20 +0530)]
staging: comedi: Remove unecessary function and it's call
Function aref_invalid has unreachable code as it right now
just returns 0 after declaring a variable.
This patch removes this function and it's single call.
As it is static so it's obvious that it is not used anywhere
other than this file or somewhere, where this is included.
I also build tested it.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 08:16:09 +0000 (13:46 +0530)]
Staging: comedi: Compressed two lines of code into one.
The following patch compressed two lines of code into one using
coccinelle and removed an unused variable.
The semantic patch used is as follows:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 06:29:29 +0000 (11:59 +0530)]
Staging: comedi: drivers: Compressed two lines of code into one.
The following patch compresses two lines of code into one using
coccinelle and removes an unused variable.
The following semantic patch was used:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:56:49 +0000 (11:26 +0530)]
staging: comedi: drivers: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Sat, 4 Oct 2014 22:47:37 +0000 (01:47 +0300)]
staging: comedi: Fix cast to restricted __be32
This patch fixes "cast to restricted __be32"
sparse warning in ni_stc.h
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Veronika Kabatova [Tue, 7 Oct 2014 22:41:10 +0000 (00:41 +0200)]
staging: unisys: Remove typedef and rename struct to lowercase
Remove typedef and rename struct to lowercase (ultra_segment_state) in unisys
Signed-off-by: Veronika Kabátová <veronicca114@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Tue, 7 Oct 2014 12:58:48 +0000 (15:58 +0300)]
staging: octeon: Fix warning of prefer ether_addr_copy.
This patch fixes the following checkpatch.pl warnings:
WARNING: "Prefer ether_addr_copy() over memcpy() if the Ethernet
addresses are __aligned(2)" in file ethernet.c
Pahole shows that the addresses are aligned.
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Tue, 7 Oct 2014 01:03:54 +0000 (06:33 +0530)]
staging: octeon-usb: Removed unnessecary else after return
WARNING: else is generally not useful after return or break
checkpatch.pl warning in octeon-hcd.c
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Esra Altintas [Tue, 7 Oct 2014 19:45:55 +0000 (22:45 +0300)]
staging: speakup: remove jiffies comparison using time_after_eq() in speakup_dtlk.c
The following patch fixes the checkpatch.pl warning:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: Esra Altintas <es.altintas@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Tue, 7 Oct 2014 07:59:18 +0000 (10:59 +0300)]
staging: speakup: Change char * array type as static const
This patch fixes "char * array declaration might be better as static
const" checkpatch.pl warning in main.c
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Sat, 4 Oct 2014 10:36:27 +0000 (13:36 +0300)]
staging: speakup: Change char * array type as static const
This patch fixes "char * array declaration might be better as static const"
checkpatch.pl warning in kobjects.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yeliz Taneroglu [Fri, 3 Oct 2014 11:04:25 +0000 (14:04 +0300)]
staging: speakup: Fixed else after return or break warning
The following patch fixes the checkpatch.pl warning:
drivers/staging/speakup/kobjects.c:812 warning: else is not generally useful after a break or return
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 3 Oct 2014 10:23:00 +0000 (13:23 +0300)]
staging: gs_fpgaboot: remove unnecessary 'out of memory' message
This patch fixes "Possible unnecessary 'out of memory' message"
checkpatch.pl warning in gs_fpgaboot.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 13:09:47 +0000 (18:39 +0530)]
Staging: rtl8188eu: core: Remove variable that is not very useful.
The following patch removes a variable which is not very useful using
coccinelle.
The following semaintic patch was used:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Mon, 6 Oct 2014 16:37:17 +0000 (22:07 +0530)]
Staging: rtl8188eu: include: Remove unused macros
This patch removes macros that are never used.
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:21 +0000 (11:27 +0530)]
staging: rtl8188eu: core: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Sat, 4 Oct 2014 16:27:02 +0000 (21:57 +0530)]
Staging: rtl8188eu: include: Remove unnecessary macro
This patch removes a macro which is not used anywhere except in the header
file. The existing usage in the header file is replaced with the actual value.
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 3 Oct 2014 10:08:21 +0000 (13:08 +0300)]
staging: rtl8188eu: Fix prefer ether_addr_copy() over memcpy()
This patch fixes "Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)" in rtw_ap.c
Pahole showed that the addresses are aligned.
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 09:16:30 +0000 (14:46 +0530)]
Staging: rtl8723au: core: Removed variable that is always 0.
The following patch removes a variable that is always 0 using
coccinelle.
The following semantic patch was used:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 09:15:56 +0000 (14:45 +0530)]
Staging: rtl8723au: os_dep: Removed variable that is always 0.
The following patch removes a variable that is always 0 using
coccinelle.
The semaintic patch used is as follows:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mahati Chamarthy [Sun, 5 Oct 2014 07:41:39 +0000 (13:11 +0530)]
Staging: rtl8723au: include: Remove unnecessary macro
This patch removes a macro which is not used anywhere except in the header
file. Existing usage in the header file is replaced with the actual value.
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Melike Yurtoglu [Sat, 4 Oct 2014 22:41:58 +0000 (01:41 +0300)]
staging: rtl8723au: include: fix space prohibited before
Fix checkpatch.pl issues with space prohibited before semicolon in
Hal8723UHWImg_CE.h
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 08:53:18 +0000 (14:23 +0530)]
staging: rtl8712: Delete explicit comparison with false and NULL
This patch delete explicit comparison to false and NULL in files of
rtl8712.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sarah Khan [Fri, 3 Oct 2014 14:03:39 +0000 (19:33 +0530)]
staging: rtl8712: Fixed else not required after return
WARNING: else is generally not required after return
checkpatch.pl warning in osdep_service.h
Signed-off-by: Sarah Khan <sarahjmi07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:30 +0000 (11:27 +0530)]
staging: rtl8712: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tina Johnson [Tue, 7 Oct 2014 19:12:06 +0000 (00:42 +0530)]
Staging: lustre: Fix checkpatch warning: Unnecessary braces
The following checkpatch warning was fixed :
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tina Johnson [Tue, 7 Oct 2014 19:12:05 +0000 (00:42 +0530)]
Staging: lustre: Fix checkpatch warning: Missing blank line
The following checkpatch warning was fixed :
WARNING: Missing a blank line after declarations
Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:59:11 +0000 (17:29 +0530)]
Staging: lustre: lustre: osc: Changed the return code of a function from int to void.
The following patch changes the return code of a function from int to void
as the return value was not used by the callers.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Reviewed-by: Octavian Purdila <octavian.purdila@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:58:30 +0000 (17:28 +0530)]
Staging: lustre: lustre: osc: Remove variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:57:54 +0000 (17:27 +0530)]
Staging: lustre: lustre: osc: Remove variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:57:18 +0000 (17:27 +0530)]
Staging: lustre: lustre: lov: Remove variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:56:47 +0000 (17:26 +0530)]
Staging: lustre: lustre: mgc: Remove variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Tue, 7 Oct 2014 11:56:14 +0000 (17:26 +0530)]
Staging: lustre: lustre: lmv: Removed variable that is not very useful.
The following patch removes a variable that is not very useful using
coccinelle.
The semantic patch used was:
@@
identifier ret;
@@
-int ret = 0;
... when != ret
when strict
-return ret;
+return 0;
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:00 +0000 (11:27 +0530)]
staging: lustre: lustre: llite: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumari Radha [Sun, 5 Oct 2014 14:52:54 +0000 (20:22 +0530)]
staging: lustre: lustre: obdclass: Added missing line after declaration
Added missing line after declaration fixing the following checkpatch.pl warning in dt_object.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Kumari Radha <kumari.radha3@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tapasweni Pathak [Mon, 6 Oct 2014 05:57:10 +0000 (11:27 +0530)]
staging: lustre: lustre: ptlrpc: Replace "the the " with "the"
This patch replace "the the " with "the".
The replacement couldn't be automated because sometimes
the first "the" was meant to be another word.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Sun, 5 Oct 2014 11:58:18 +0000 (17:28 +0530)]
Staging: lustre: Remove non-standard spinlock macro definitions
This patch removes non-standard spinlock's macros as they are no longer
used by this driver.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Sun, 5 Oct 2014 11:58:12 +0000 (17:28 +0530)]
Staging: lustre: Replace non-standard spinlock macro definations
This patch replaces non-standard spin lock macro with standard linux function.
This is done using Coccinelle and semantic patch used is as follows:
@@
expression x;
@@
- TREE_READ_LOCK_IRQ(x)
+ spin_lock_irq(&(x)->tree_lock)
@@
expression x;
@@
- TREE_READ_UNLOCK_IRQ(x)
+ spin_unlock_irq(&(x)->tree_lock)
Also semantic patch result is modified by droping ->,
inner & and adding . for simplification of code.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Sun, 5 Oct 2014 11:58:06 +0000 (17:28 +0530)]
Staging: lustre: Replace non-standard spin-lock's macro
This patch replaces non-standard spin lock macro with standard linux function.
This is done using Coccinelle and semantic patch used is as follows:
@@
expression x;
@@
- TREE_READ_LOCK_IRQ(x)
+ spin_lock_irq(&x->tree_lock)
@@
expression x;
@@
- TREE_READ_UNLOCK_IRQ(x)
+ spin_unlock_irq(&x->tree_lock)
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Fri, 3 Oct 2014 05:16:09 +0000 (10:46 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_server_handle' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Fri, 3 Oct 2014 05:15:38 +0000 (10:45 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_bulk_ready' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Fri, 3 Oct 2014 05:14:58 +0000 (10:44 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_server_rpc_done' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Fri, 3 Oct 2014 05:14:25 +0000 (10:44 +0530)]
Staging: lustre: lnet: selftest: Made a function static.
The following patch makes a function static as it is not used by other
files.
The patch fixes the warning:
WARNING: symbol 'brw_check_bulk' was not declared. Should it be static?
The above warning was reported by sparse.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vaishali Thakkar [Fri, 3 Oct 2014 03:57:18 +0000 (09:27 +0530)]
Staging: lustre: lnet: Declare ping_srv_workitems static
This patch makes ping_srv_workitems static as it is
used only in the file ping_test.c
This problem is detected by sparse.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Sat, 4 Oct 2014 16:25:27 +0000 (21:55 +0530)]
Staging: iio: trigger: Break line over 80 characters
This patch breaks a line that is over 80 characters as reported by checkpatch.pl
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Darshana Padmadas [Sat, 4 Oct 2014 16:25:26 +0000 (21:55 +0530)]
Staging: iio: trigger: Add module name information in Kconfig
This patch updates Kconfig with paragraphs that describe config symbol fully.
Found using checkpatch.pl.
Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 11:34:43 +0000 (17:04 +0530)]
Staging: iio: Documentation: Added check for sscanf return value.
The following patch fixes the following checkpatch.pl warning by adding
a check for sscanf return value.
WARNING: unchecked sscanf return value.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 6 Oct 2014 11:34:10 +0000 (17:04 +0530)]
Staging: iio: Documentation: Simplify error handling.
This also has the nice effect of removing of a temporary variable from stack and
fixes the following checkpatch.pl warning:
WARNING: Missing blank line after declarations.
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / openwrt / staging / blogic.git / log