openwrt/staging/blogic.git
11 years agoiio: core: implement devm_iio_device_alloc/devm_iio_device_free
Grygorii Strashko [Thu, 18 Jul 2013 10:19:00 +0000 (11:19 +0100)]
iio: core: implement devm_iio_device_alloc/devm_iio_device_free

Add a resource managed devm_iio_device_alloc()/devm_iio_device_free()
to automatically clean up any allocations made by IIO drivers,
thus leading to simplified IIO drivers code.

In addition, this will allow IIO drivers to use other devm_*() API
(like devm_request_irq) and don't care about the race between
iio_device_free() and the release of resources by Device core
during driver removing.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Tested-by: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Remove IIO_DEV_ATTR_RESET macro
Lars-Peter Clausen [Tue, 16 Jul 2013 15:08:00 +0000 (16:08 +0100)]
iio: Remove IIO_DEV_ATTR_RESET macro

There are no users of this macro left and we have come to the conclusion that it
is not a good idea to expose the raw chip reset to userspace so the macro is
very unlikely to be used in new drivers.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ade7xxx: Don't expose the chip reset to userspace
Lars-Peter Clausen [Tue, 16 Jul 2013 15:08:00 +0000 (16:08 +0100)]
staging:iio:ade7xxx: Don't expose the chip reset to userspace

There is no reason why userspace should want to trigger a manual reset of the
device, so remove this functionality.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:adt7316: Don't expose the chip reset to userspace
Lars-Peter Clausen [Tue, 16 Jul 2013 15:08:00 +0000 (16:08 +0100)]
staging:iio:adt7316: Don't expose the chip reset to userspace

There is no reason why userspace should want to trigger a manual reset of the
device, so remove this functionality.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad2s1210: Don't expose the chip reset to userspace
Lars-Peter Clausen [Tue, 16 Jul 2013 15:08:00 +0000 (16:08 +0100)]
staging:iio:ad2s1210: Don't expose the chip reset to userspace

There is no reason why userspace should want to trigger a manual reset of the
device, so remove this functionality.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: add configuration option for debug support
Otavio Salvador [Tue, 16 Jul 2013 12:56:00 +0000 (13:56 +0100)]
iio: add configuration option for debug support

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Add a comment to about alphabetical order to Kconfigs and Makefiles
Lars-Peter Clausen [Mon, 15 Jul 2013 07:45:00 +0000 (08:45 +0100)]
iio: Add a comment to about alphabetical order to Kconfigs and Makefiles

Keeping Makefile and Kconfig entries in alphabetical order usually works better
than just appending new entries at the end, since it reduces the amount of
conflicts. This patch adds a comment to the IIO Kconfig and Makefile files to
document that the entries should be kept in alphabetical order.

Also reorder those  entries which weren't in alphabetical order yet.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio:dac:mcp4725 wrong return type of attribute _show function
Jonathan Cameron [Fri, 12 Jul 2013 19:54:00 +0000 (20:54 +0100)]
iio:dac:mcp4725 wrong return type of attribute _show function

Should be ssize_t and is int.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Reported-by: Fengguan Wu <fengguang.wu@intel.com>
Acked-by: Peter Meerwald <pmeerw@pmeerw.net>
11 years agoiio: hid-sensor-magn-3d: add module alias for autoload
Alexander Holler [Wed, 10 Jul 2013 08:32:00 +0000 (09:32 +0100)]
iio: hid-sensor-magn-3d: add module alias for autoload

Add a MODULE_DEVICE_TABLE in order to let hotplug mechanisms automatically
load the driver.

This makes it also possible to use the usual driver name instead of
HID-SENSOR-2000xx which isn't very descriptive in kernel messages.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Acked-by:Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: hid-sensor-als: add module alias for autoload
Alexander Holler [Wed, 10 Jul 2013 08:31:00 +0000 (09:31 +0100)]
iio: hid-sensor-als: add module alias for autoload

Add a MODULE_DEVICE_TABLE in order to let hotplug mechanisms automatically
load the driver.

This makes it also possible to use the usual driver name instead of
HID-SENSOR-2000xx which isn't very descriptive in kernel messages.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Acked-by:Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: hid-sensor-gyro-3d: add module alias for autoload
Alexander Holler [Wed, 10 Jul 2013 08:31:00 +0000 (09:31 +0100)]
iio: hid-sensor-gyro-3d: add module alias for autoload

Add a MODULE_DEVICE_TABLE in order to let hotplug mechanisms automatically
load the driver.

This makes it also possible to use the usual driver name instead of
HID-SENSOR-2000xx which isn't very descriptive in kernel messages.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Acked-by:Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: hid-sensor-accel-3d: add module alias for autoload
Alexander Holler [Wed, 10 Jul 2013 08:31:00 +0000 (09:31 +0100)]
iio: hid-sensor-accel-3d: add module alias for autoload

Add a MODULE_DEVICE_TABLE in order to let hotplug mechanisms automatically
load the driver.

This makes it also possible to use the usual driver name instead of
HID-SENSOR-2000xx which isn't very descriptive in kernel messages.

Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Acked-by:Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: mxs-lradc: Check the return value from stmp_reset_block()
Fabio Estevam [Wed, 10 Jul 2013 02:36:00 +0000 (03:36 +0100)]
iio: mxs-lradc: Check the return value from stmp_reset_block()

stmp_reset_block() may fail, so let's check its return value and propagate it in
the case of error.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: fix semicolon in io_core_trigger.h
Peter Meerwald [Sun, 7 Jul 2013 20:24:00 +0000 (21:24 +0100)]
iio: fix semicolon in io_core_trigger.h

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: staging: fix typo in ade758_ring.c
Peter Meerwald [Sun, 7 Jul 2013 20:24:00 +0000 (21:24 +0100)]
iio: staging: fix typo in ade758_ring.c

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: fix typo, Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350
Peter Meerwald [Sun, 7 Jul 2013 20:24:00 +0000 (21:24 +0100)]
iio: fix typo, Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: staging: fix device.txt documentation
Peter Meerwald [Sun, 7 Jul 2013 20:24:00 +0000 (21:24 +0100)]
iio: staging: fix device.txt documentation

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Add Nuvoton NAU7802 ADC driver
Alexandre Belloni [Mon, 24 Jun 2013 17:24:00 +0000 (18:24 +0100)]
iio: Add Nuvoton NAU7802 ADC driver

The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable
gain and sampling rates.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: move ABI specification for store_eeprom; is used by ad9523, mcp4725 and ds1077...
Peter Meerwald [Sun, 23 Jun 2013 21:30:00 +0000 (22:30 +0100)]
iio: move ABI specification for store_eeprom; is used by ad9523, mcp4725 and ds1077 devices

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: add DAC 500kohm_to_gnd to possible powerdown_modes
Peter Meerwald [Sun, 23 Jun 2013 21:30:00 +0000 (22:30 +0100)]
iio: add DAC 500kohm_to_gnd to possible powerdown_modes

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: add powerdown to mcp4725 dac drive
Peter Meerwald [Sun, 23 Jun 2013 21:30:00 +0000 (22:30 +0100)]
iio: add powerdown to mcp4725 dac drive

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: add store_eeprom to mcp4725 dac driver
Peter Meerwald [Sun, 23 Jun 2013 21:30:00 +0000 (22:30 +0100)]
iio: add store_eeprom to mcp4725 dac driver

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: reword help text of several IIO_ST drivers
Peter Meerwald [Sun, 23 Jun 2013 21:28:00 +0000 (22:28 +0100)]
iio: reword help text of several IIO_ST drivers

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: "Denis Ciocca" <denis.ciocca@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: remove mention of ring buffer from CONFIG_IIO_KFIFO_BUF, CONFIG_IIO_TRIGGER...
Peter Meerwald [Sun, 23 Jun 2013 21:28:00 +0000 (22:28 +0100)]
iio: remove mention of ring buffer from CONFIG_IIO_KFIFO_BUF, CONFIG_IIO_TRIGGER description

ring buffers are only in staging, don't mention them here

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: fix Kconfig typos
Peter Meerwald [Sun, 23 Jun 2013 21:28:00 +0000 (22:28 +0100)]
iio: fix Kconfig typos

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: use I2C_FUNC_SMBUS_I2C_BLOCK macro
Peter Meerwald [Sun, 23 Jun 2013 21:28:00 +0000 (22:28 +0100)]
iio: use I2C_FUNC_SMBUS_I2C_BLOCK macro

I do not see why the driver requires I2C_FUNC_SMBUS_I2C_BLOCK,
actually only single bytes or words are transferred

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Ge Gao <ggao@invensense.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: fix typos in dac Kconfig
Peter Meerwald [Sun, 23 Jun 2013 21:28:00 +0000 (22:28 +0100)]
iio: fix typos in dac Kconfig

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Added ST-sensors platform data to select the DRDY interrupt pin
Denis CIOCCA [Wed, 19 Jun 2013 08:28:00 +0000 (09:28 +0100)]
iio: Added ST-sensors platform data to select the DRDY interrupt pin

This patch add support to redirect the DRDY interrupt on INT1 or INT2
on accelerometer and pressure sensors.

Signed-off-by: Denis Ciocca <denis.ciocca@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging: lustre: remove ll_crypto_alloc_blkcipher
Greg Kroah-Hartman [Sat, 3 Aug 2013 06:44:31 +0000 (14:44 +0800)]
staging: lustre: remove ll_crypto_alloc_blkcipher

Turns out that the ll_crypto_alloc_blkcipher() wrapper didn't even do
anything, and is probably wrong, so it's not needed, just call the
crypto core directly.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove almost all crypto layer wrappers
Greg Kroah-Hartman [Sat, 3 Aug 2013 06:29:11 +0000 (14:29 +0800)]
staging: lustre: remove almost all crypto layer wrappers

Almost all of these are just a straight function name rename, so fix
them all up to call the crypto layer properly, no need for a #define to
hide things.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove cfs_register_sysctl_table macro
Greg Kroah-Hartman [Sat, 3 Aug 2013 06:00:50 +0000 (14:00 +0800)]
staging: lustre: remove cfs_register_sysctl_table macro

It was a wrapper around register_sysctl_table, so just remove it.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: Remove version.h header inclusion in dgnc_trace.c
Sachin Kamat [Fri, 2 Aug 2013 09:10:18 +0000 (14:40 +0530)]
staging: dgnc: Remove version.h header inclusion in dgnc_trace.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: Remove version.h header inclusion in dgnc_sysfs.c
Sachin Kamat [Fri, 2 Aug 2013 09:10:17 +0000 (14:40 +0530)]
staging: dgnc: Remove version.h header inclusion in dgnc_sysfs.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: Remove version.h header inclusion in dgnc_neo.c
Sachin Kamat [Fri, 2 Aug 2013 09:10:16 +0000 (14:40 +0530)]
staging: dgnc: Remove version.h header inclusion in dgnc_neo.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: Remove version.h header inclusion in dgnc_mgmt.c
Sachin Kamat [Fri, 2 Aug 2013 09:10:15 +0000 (14:40 +0530)]
staging: dgnc: Remove version.h header inclusion in dgnc_mgmt.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: Include version.h header in dgnc_kcompat.h
Sachin Kamat [Fri, 2 Aug 2013 09:10:14 +0000 (14:40 +0530)]
staging: dgnc: Include version.h header in dgnc_kcompat.h

version.h header inclusion is necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: Remove version.h header inclusion in dgnc_driver.h
Sachin Kamat [Fri, 2 Aug 2013 09:10:13 +0000 (14:40 +0530)]
staging: dgnc: Remove version.h header inclusion in dgnc_driver.h

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: Remove version.h header inclusion in dgnc_cls.c
Sachin Kamat [Fri, 2 Aug 2013 09:10:12 +0000 (14:40 +0530)]
staging: dgnc: Remove version.h header inclusion in dgnc_cls.c

version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: winbond: wb35reg: fixed some line over 80 characters
Iker Pedrosa [Fri, 2 Aug 2013 11:37:56 +0000 (13:37 +0200)]
Staging: winbond: wb35reg: fixed some line over 80 characters

Fixed some coding style issues

Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: Remove duplicate header file inclusion
Sachin Kamat [Fri, 2 Aug 2013 09:15:26 +0000 (14:45 +0530)]
staging: dgnc: Remove duplicate header file inclusion

sched.h was included twice.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove RETURN macro
Greg Kroah-Hartman [Sat, 3 Aug 2013 02:35:28 +0000 (10:35 +0800)]
staging: lustre: remove RETURN macro

We have a kernel-wide function tracing system, so use that instead of
rolling a custom one just for one filesystem.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove EXIT macro
Greg Kroah-Hartman [Fri, 2 Aug 2013 22:01:58 +0000 (06:01 +0800)]
staging: lustre: remove EXIT macro

We have a kernel-wide function tracing system, so use that instead of
rolling a custom one just for one filesystem.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove RETURN_EXIT macro
Greg Kroah-Hartman [Fri, 2 Aug 2013 10:20:34 +0000 (18:20 +0800)]
staging: lustre: remove RETURN_EXIT macro

We have a kernel-wide function tracing system, so use that instead of
rolling a custom one just for one filesystem.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ENTRY macro
Greg Kroah-Hartman [Fri, 2 Aug 2013 10:14:51 +0000 (18:14 +0800)]
staging: lustre: remove ENTRY macro

We have a kernel-wide function tracing system, so use that instead of
rolling a custom one just for one filesystem.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ENTRY/EXIT_NESTING stuff
Greg Kroah-Hartman [Fri, 2 Aug 2013 08:24:50 +0000 (16:24 +0800)]
staging: lustre: remove ENTRY/EXIT_NESTING stuff

These macros were empty, so remove them in anticipation of removing the
entire ENTRY/EXIT macros.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ll_invalidate_bdev()
Greg Kroah-Hartman [Fri, 2 Aug 2013 08:17:04 +0000 (16:17 +0800)]
staging: lustre: remove ll_invalidate_bdev()

It was a wrapper around invalidate_bdev(), totally useless.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ll_vfs_symlink()
Greg Kroah-Hartman [Fri, 2 Aug 2013 08:11:35 +0000 (16:11 +0800)]
staging: lustre: remove ll_vfs_symlink()

No one was ever even using it.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ll_generic_permission()
Greg Kroah-Hartman [Fri, 2 Aug 2013 08:08:01 +0000 (16:08 +0800)]
staging: lustre: remove ll_generic_permission()

It was a wrapper around generic_permission(), totally useless.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ll_permission()
Greg Kroah-Hartman [Fri, 2 Aug 2013 08:01:26 +0000 (16:01 +0800)]
staging: lustre: remove ll_permission()

It was a wrapper around inode_permission(), totally useless.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ll_generic_file_llseek_size()
Greg Kroah-Hartman [Fri, 2 Aug 2013 07:56:22 +0000 (15:56 +0800)]
staging: lustre: remove ll_generic_file_llseek_size()

It was a wrapper around generic_file_llseek_size(), totally useless.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ll_dentry_open()
Greg Kroah-Hartman [Fri, 2 Aug 2013 07:51:34 +0000 (15:51 +0800)]
staging: lustre: remove ll_dentry_open()

It was a wrapper around dentry_open(), totally useless.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: remove ll_blkdev_put()
Greg Kroah-Hartman [Fri, 2 Aug 2013 07:46:32 +0000 (15:46 +0800)]
staging: lustre: remove ll_blkdev_put()

It was a wrapper around blkdev_put(), totally useless.

Cc: Peng Tao <tao.peng@emc.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre: lloop depends on BLOCK
Xiong Zhou [Fri, 2 Aug 2013 05:50:48 +0000 (13:50 +0800)]
staging/lustre: lloop depends on BLOCK

Add a config option for llite/lloop in lustre driver, making it depends
on BLOCK to fix this better:
drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2:
error: implicit declaration of function â€˜unregister_blkdev'

Also, remove the wrapper ll_unregister_blkdev which depends on BLOCK in
the header and just call unregister_blkdev in lloop.c based on Peng Tao's
comment. Drop the redundant dependency on STAGING for LUSTRE_FS, remove
some unnecessary jdb header files which depends on BLOCK btw.

Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
Reviewed-by: Peng Tao <tao.peng@emc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Set farewell report length.
Rupesh Gujare [Thu, 1 Aug 2013 17:45:02 +0000 (18:45 +0100)]
staging: ozwpan: Set farewell report length.

Fixes a bug where we were not setting length field causing wrong
report size to be copied.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Increase farewell report size.
Rupesh Gujare [Thu, 1 Aug 2013 17:45:01 +0000 (18:45 +0100)]
staging: ozwpan: Increase farewell report size.

Farewell report size can be bigger than one byte, increase array
size to accomodate maximum 32 bytes of farewell report.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Drop oldest ISOC frame instead of dropping latest.
Rupesh Gujare [Thu, 1 Aug 2013 17:40:03 +0000 (18:40 +0100)]
staging: ozwpan: Drop oldest ISOC frame instead of dropping latest.

In case of ISOC transfer, if TX queue is full then we start
dropping latest frame, instead we should drop oldest frame &
add latest frame to TX queue.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Use kernel strncmp function.
Rupesh Gujare [Thu, 1 Aug 2013 17:40:02 +0000 (18:40 +0100)]
staging: ozwpan: Use kernel strncmp function.

Use kernel's strncmp() function instead of defining same within driver.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Mark string as const
Rupesh Gujare [Thu, 1 Aug 2013 17:40:01 +0000 (18:40 +0100)]
staging: ozwpan: Mark string as const

Make sure that we mark const string so that it does not get modified.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: Use kernel list function for managing interface list.
Rupesh Gujare [Thu, 1 Aug 2013 17:40:00 +0000 (18:40 +0100)]
staging: ozwpan: Use kernel list function for managing interface list.

Managing interface list, is easier if we use kernel list_* API
than managing it on our own.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: imx-drm: add missing MFD_SYSCON dependency for LDB
Jingoo Han [Thu, 1 Aug 2013 00:32:29 +0000 (09:32 +0900)]
staging: imx-drm: add missing MFD_SYSCON dependency for LDB

Added missing MFD_SYSCON dependency for LVDS display bridge
in order to fix the following link error.

drivers/staging/imx-drm/imx-ldb.c:484: undefined reference to `syscon_regmap_lookup_by_phandle'

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dgnc: add dgnc digi driver
Lidza Louina [Thu, 1 Aug 2013 21:00:20 +0000 (17:00 -0400)]
staging: dgnc: add dgnc digi driver

This patch adds the DGNC driver. This is a TTY Serial Port
Driver for the Digi International Neo and Classic PCI based product
line by Digi International <http://www.digi.com>.

This driver isn't hooked up to the build system because it doesn't
build, it merely adds the driver written by Digi to the kernel tree so
that it can be cleaned up and fixed up properly over time.

Cc: Mark Hounschell <markh@compro.net>
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: eliminate remaining typedef unions
Aaro Koskinen [Tue, 30 Jul 2013 20:43:12 +0000 (23:43 +0300)]
staging: octeon-usb: eliminate remaining typedef unions

Remaining typedef unions can be trivially eliminated with the pattern:

foo_t -> union foo

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_control_header_t -> union cvmx_usb_control_header
Aaro Koskinen [Tue, 30 Jul 2013 20:43:11 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_control_header_t -> union cvmx_usb_control_header

Replace cvmx_usb_control_header_t with union cvmx_usb_control_header.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_internal_state_t -> struct cvmx_usb_internal_state
Aaro Koskinen [Tue, 30 Jul 2013 20:43:10 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_internal_state_t -> struct cvmx_usb_internal_state

Replace cvmx_usb_internal_state_t with struct cvmx_usb_internal_state.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_tx_fifo_t -> struct cvmx_usb_tx_fifo
Aaro Koskinen [Tue, 30 Jul 2013 20:43:09 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_tx_fifo_t -> struct cvmx_usb_tx_fifo

Replace cvmx_usb_tx_fifo_t with struct cvmx_usb_tx_fifo_t.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_pipe_list_t -> struct cvmx_usb_pipe_list
Aaro Koskinen [Tue, 30 Jul 2013 20:43:08 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_pipe_list_t -> struct cvmx_usb_pipe_list

Replace cvmx_usb_pipe_list_t with struct cvmx_usb_pipe_list.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_pipe_t -> struct cvmx_usb_pipe
Aaro Koskinen [Tue, 30 Jul 2013 20:43:07 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_pipe_t -> struct cvmx_usb_pipe

Replace cvmx_usb_pipe_t with struct cvmx_usb_pipe.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_transaction_t -> struct cvmx_usb_transaction
Aaro Koskinen [Tue, 30 Jul 2013 20:43:06 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_transaction_t -> struct cvmx_usb_transaction

Replace cvmx_usb_transaction_t with struct cvmx_usb_transaction.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_state_t -> struct cvmx_usb_state
Aaro Koskinen [Tue, 30 Jul 2013 20:43:05 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_state_t -> struct cvmx_usb_state

Replace cvmx_usb_state_t with struct cvmx_usb_state.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_iso_packet_t -> struct cvmx_usb_iso_packet
Aaro Koskinen [Tue, 30 Jul 2013 20:43:04 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_iso_packet_t -> struct cvmx_usb_iso_packet

Replace cvmx_usb_iso_packet_t with struct cvmx_usb_iso_packet.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_port_status_t -> struct cvmx_usb_port_status
Aaro Koskinen [Tue, 30 Jul 2013 20:43:03 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_port_status_t -> struct cvmx_usb_port_status

Replace cvmx_usb_port_status_t with struct cvmx_usb_port_status.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_stage_t -> enum cvmx_usb_stage
Aaro Koskinen [Tue, 30 Jul 2013 20:43:02 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_stage_t -> enum cvmx_usb_stage

Replace cvmx_usb_stage_t with enum cvmx_usb_stage.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_transaction_flags_t -> enum cvmx_usb_transaction_flags
Aaro Koskinen [Tue, 30 Jul 2013 20:43:01 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_transaction_flags_t -> enum cvmx_usb_transaction_flags

Replace cvmx_usb_transaction_flags_t with enum cvmx_usb_transaction_flags.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_isochronous_flags_t -> enum cvmx_usb_isochronous_flags
Aaro Koskinen [Tue, 30 Jul 2013 20:43:00 +0000 (23:43 +0300)]
staging: octeon-usb: cvmx_usb_isochronous_flags_t -> enum cvmx_usb_isochronous_flags

Replace cvmx_usb_isochronous_flags_t with enum cvmx_usb_isochronous_flags.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_pipe_flags_t -> enum cvmx_usb_pipe_flags
Aaro Koskinen [Tue, 30 Jul 2013 20:42:59 +0000 (23:42 +0300)]
staging: octeon-usb: cvmx_usb_pipe_flags_t -> enum cvmx_usb_pipe_flags

Replace cvmx_usb_pipe_flags_t with enum cvmx_usb_pipe_flags.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_initialize_flags_t -> enum cvmx_usb_initialize_flags
Aaro Koskinen [Tue, 30 Jul 2013 20:42:58 +0000 (23:42 +0300)]
staging: octeon-usb: cvmx_usb_initialize_flags_t -> enum cvmx_usb_initialize_flags

Replace cvmx_usb_initialize_flags_t with enum cvmx_usb_initialize_flags.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_callback_t -> enum cvmx_usb_callback
Aaro Koskinen [Tue, 30 Jul 2013 20:42:57 +0000 (23:42 +0300)]
staging: octeon-usb: cvmx_usb_callback_t -> enum cvmx_usb_callback

Replace cvmx_usb_callback_t with enum cvmx_usb_callback.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_complete_t -> enum cvmx_usb_complete
Aaro Koskinen [Tue, 30 Jul 2013 20:42:56 +0000 (23:42 +0300)]
staging: octeon-usb: cvmx_usb_complete_t -> enum cvmx_usb_complete

Replace cvmx_usb_complete_t with enum cvmx_usb_complete.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_direction_t -> enum cvmx_usb_direction
Aaro Koskinen [Tue, 30 Jul 2013 20:42:55 +0000 (23:42 +0300)]
staging: octeon-usb: cvmx_usb_direction_t -> enum cvmx_usb_direction

Replace cvmx_usb_direction_t with enum cvmx_usb_direction.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_transfer_t -> enum cvmx_usb_transfer
Aaro Koskinen [Tue, 30 Jul 2013 20:42:54 +0000 (23:42 +0300)]
staging: octeon-usb: cvmx_usb_transfer_t -> enum cvmx_usb_transfer

Replace cvmx_usb_transfer_t with enum cvmx_usb_transfer.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: octeon-usb: cvmx_usb_speed_t -> enum cvmx_usb_speed
Aaro Koskinen [Tue, 30 Jul 2013 20:42:53 +0000 (23:42 +0300)]
staging: octeon-usb: cvmx_usb_speed_t -> enum cvmx_usb_speed

Replace cvmx_usb_speed_t with enum cvmx_usb_speed.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ozwpan: High resolution timers
Rupesh Gujare [Tue, 30 Jul 2013 12:31:50 +0000 (13:31 +0100)]
staging: ozwpan: High resolution timers

Current implementation assumes HZ = 1000 for calculating
all internal timer intervals, which creates problem on
platforms where HZ != 1000.

As well we need resolution of less than 10 mSec for heartbeat
calculation, this creates problem on some platforms where HZ is
configured as HZ = 100, or around, which restricts us to timer interval
of 10 mSec. This is particularly found on embedded devices.

This patch moves on to use high resolution timers to calculate
all timer intervals as it allows us to have very small resolution
of timer interval, removing dependency on HZ.

Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt9812: Resolve different base types warnings.
Shaun Laing [Tue, 30 Jul 2013 17:29:43 +0000 (11:29 -0600)]
staging: comedi: dt9812: Resolve different base types warnings.

Resolves warnings from the "sparse" checker of the form "warning: incorrect
type in assignment (different base types)".

Signed-off-by: Shaun Laing <shaun@xresource.ca>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: allow ISA and PC/104 drivers on non-ISA systems
H Hartley Sweeten [Tue, 30 Jul 2013 16:39:49 +0000 (09:39 -0700)]
staging: comedi: allow ISA and PC/104 drivers on non-ISA systems

Embedded systems with a PC/104 bus might have a configuration that
does not have ISA enabled. This creates a problem in Comedi where
the PC/104 drivers cannot be enabled.

Remove the 'depends on ISA' for the "Comedi ISA and PC/104 drivers"
menu to allow the user to select these drivers on non-ISA systems.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: absorb usbduxsigma_attach_common() into caller
H Hartley Sweeten [Tue, 30 Jul 2013 00:48:50 +0000 (17:48 -0700)]
staging: comedi: usbduxsigma: absorb usbduxsigma_attach_common() into caller

This function is only called by usbduxsigma_auto_attach(). Absorb it
and refactor the code a bit to match the usbdux driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: tidy up usbdux_free_usb_buffers()
H Hartley Sweeten [Tue, 30 Jul 2013 00:48:25 +0000 (17:48 -0700)]
staging: comedi: usbdux: tidy up usbdux_free_usb_buffers()

For aesthetics, pass the comedi_device pointer to this function
instead of the private data pointer.

The usb_kill_urb() calls are not needed. All the urbs were unlinked
before this function was called.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: tidy up usbdux_detach()
H Hartley Sweeten [Tue, 30 Jul 2013 00:48:04 +0000 (17:48 -0700)]
staging: comedi: usbdux: tidy up usbdux_detach()

Make sure the usb intfdata is always cleared when the device is
detached.

Refactor the code to remove an indent level.

Always unlink the urbs when the device is detached.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: always clear the usb intfdata in (*detach)
H Hartley Sweeten [Tue, 30 Jul 2013 00:47:44 +0000 (17:47 -0700)]
staging: comedi: usbduxsigma: always clear the usb intfdata in (*detach)

Make sure the usb intfdata is always cleared when the device is
detached.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: move urb unlink into usbduxsigma_detach()
H Hartley Sweeten [Tue, 30 Jul 2013 00:47:26 +0000 (17:47 -0700)]
staging: comedi: usbduxsigma: move urb unlink into usbduxsigma_detach()

For aesthetics, move the final force unlink of the urbs from
usbduxsigma_free_usb_buffers() to usbduxsigma_detach().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: init 'pwm_buf_sz' in usbduxsigma_auto_attach()
H Hartley Sweeten [Tue, 30 Jul 2013 00:47:06 +0000 (17:47 -0700)]
staging: comedi: usbduxsigma: init 'pwm_buf_sz' in usbduxsigma_auto_attach()

Initialize this variable with then_ai_urbs and n_ao_urbs in the
attach. Then usbduxsigma_alloc_usb_buffers() can just check the
variable to determine if the urb needs to be allocated.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: 'dac_commands' does not need to be kzalloc()'d
H Hartley Sweeten [Tue, 30 Jul 2013 00:46:46 +0000 (17:46 -0700)]
staging: comedi: usbduxsigma: 'dac_commands' does not need to be kzalloc()'d

The 'dac_commands' buffer is used to pass the ao channel list from
usbduxsigma_ao_cmd() to the urb callback, usbduxsigma_ao_urb_complete().
This buffer does not need to be allocated.

Change it into a simple array of the correct size. Rename the variable
to 'ao_chanlist' to clarify what it actually is.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: tidy up usbdux_alloc_usb_buffers()
H Hartley Sweeten [Tue, 30 Jul 2013 00:46:27 +0000 (17:46 -0700)]
staging: comedi: usbdux: tidy up usbdux_alloc_usb_buffers()

Tidy up the error path by doing all the basic allocations then checking
for failures.

We have the comedi device now so fill in the urb->context.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: return void from usbduxsigma_pwm_pattern()
H Hartley Sweeten [Tue, 30 Jul 2013 00:46:07 +0000 (17:46 -0700)]
staging: comedi: usbduxsigma: return void from usbduxsigma_pwm_pattern()

This function never fails and currently returns '1' so that the
usbduxsigma_pwm_write() function returns to proper value (insn->n).

It's also called by usbduxsigma_pwm_config() which also returns the
'1' value. The proper return code for this function should be '0' to
indicate success.

Change the return type of the function to void and just have the
callers return the proper values.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: return void from usbdux_pwm_pattern()
H Hartley Sweeten [Tue, 30 Jul 2013 00:45:47 +0000 (17:45 -0700)]
staging: comedi: usbdux: return void from usbdux_pwm_pattern()

This function never fails and currently returns '1' so that the
usbdux_pwm_write() function returns to proper value (insn->n).

It's also called by usbdux_pwm_config() which also returns the '1'
value. The proper return code for this function should be '0' to
indicate success.

Change the return type of the function to void and just have the
callers return the proper values.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: tidy up usbdux_pwm_config()
H Hartley Sweeten [Tue, 30 Jul 2013 00:45:28 +0000 (17:45 -0700)]
staging: comedi: usbdux: tidy up usbdux_pwm_config()

Rename the local variable used for the private data pointer to 'devpriv'.

Tidy up the function a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: remove usbdux_pwm_read()
H Hartley Sweeten [Tue, 30 Jul 2013 00:45:09 +0000 (17:45 -0700)]
staging: comedi: usbdux: remove usbdux_pwm_read()

The pwm subdevice is not readable so this callback function is not
needed. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: tidy up usbdux_pwm_write()
H Hartley Sweeten [Tue, 30 Jul 2013 00:44:50 +0000 (17:44 -0700)]
staging: comedi: usbdux: tidy up usbdux_pwm_write()

Remove the sanity check of the private data. This function can only be
called if the private data was successfully allocated in the attach.

Tidy up the function a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: tidy up usbdux_pwm_pattern()
H Hartley Sweeten [Tue, 30 Jul 2013 00:44:32 +0000 (17:44 -0700)]
staging: comedi: usbdux: tidy up usbdux_pwm_pattern()

Rename the local variable used for the private data pointer to 'devpriv'.

Remove the sanity check of the private data. This function can only be
called if the private data was successfully allocated in the attach.

Tidy up the function to make it more concise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: tidy up usbdux_pwm_period()
H Hartley Sweeten [Tue, 30 Jul 2013 00:44:14 +0000 (17:44 -0700)]
staging: comedi: usbdux: tidy up usbdux_pwm_period()

Rename the local variable used for the private data pointer to 'devpriv'.

Fix the fx2delay calculation so it does not use floating point values.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: remove the usb endpoint defines
H Hartley Sweeten [Tue, 30 Jul 2013 00:43:55 +0000 (17:43 -0700)]
staging: comedi: usbduxsigma: remove the usb endpoint defines

The endpoint defines are each only used in one place and don't help
clarify the code. Remove the defines and just open code the values.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>