openwrt/staging/blogic.git
11 years agocompat-drivers: add initial kconfig development
Luis R. Rodriguez [Wed, 27 Mar 2013 00:31:33 +0000 (17:31 -0700)]
compat-drivers: add initial kconfig development

This adds intial development kconfig support (make menuconfig).
Synching in kconfig from linux-next next-20130326.
Support is still under development so to enable it
if you want to work on it, just run manually:

  make -f scripts/kconfig/Makefile menuconfig

compat already provides its own set of scripts that
computes the kernels you need and spits it out to .config
through the call:

  ./compat/scripts/gen-compat-config.sh > $(COMPAT_CONFIG)

Perhaps something along these lines will do it:

--- a/Makefile
+++ b/Makefile
@@ -29,6 +29,7 @@ DESTDIR?=
 ifneq ($(KERNELRELEASE),)

 -include $(COMPAT_CONFIG)
+-include $(BACKPORT_CONFIG)
 include $(COMPAT_CONFIG_CW)

 NOSTDINC_FLAGS := \
@@ -86,7 +87,8 @@ export CFLAGS += \
 # These exported as they are used by the scripts
 # to check config and compat autoconf
 export COMPAT_CONFIG_CW=$(PWD)/config.mk
-export COMPAT_CONFIG=$(PWD)/.config
+export COMPAT_CONFIG=$(PWD)/compat/.config
+export BACKPORT_CONFIG=$(PWD)/.config

But I'm done for the day.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: ignore .o files and .o.d dirs
Luis R. Rodriguez [Wed, 27 Mar 2013 00:31:33 +0000 (17:31 -0700)]
compat-drivers: ignore .o files and .o.d dirs

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: backport mac80211 set_multicast_list() 488b366a
Luis R. Rodriguez [Wed, 27 Mar 2013 00:13:44 +0000 (17:13 -0700)]
compat-drivers: backport mac80211 set_multicast_list() 488b366a

Synchs with next-20130326

The addition of the new mac80211 driver callback
set_multicast_list() uses the struct netdev_hw_addr_list
added as of 2.6.35. We already dealt with backporting
this collateral evolution through the changes that
went in on for the prepare_multicast() callback, as
well as porting Ethernet driver usage of this. This
is all dealt with on the patch:

patches/collateral-evolutions/network/25-multicast-list_head.patch

Reviewing that gave a quick idea of how to backport this
new callback in a similar way.

commit 488b366a452934141959384c7a1b52b22d6154ef
Author: Alexander Bondar <alexander.bondar@intel.com>
Date:   Mon Feb 11 14:56:29 2013 +0200

    mac80211: add driver callback for per-interface multicast filter

    Some devices have multicast filter capability for each individual
    virtual interface rather than just a global one. Add an interface
    specific driver callback allowing such drivers to configure this.

Signed-off-by: Alexander Bondar <alexander.bondar@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
1   2.6.24              [  OK  ]
2   2.6.25              [  OK  ]
3   2.6.26              [  OK  ]
4   2.6.27              [  OK  ]
5   2.6.28              [  OK  ]
6   2.6.29              [  OK  ]
7   2.6.30              [  OK  ]
8   2.6.31              [  OK  ]
9   2.6.32              [  OK  ]
10  2.6.33              [  OK  ]
11  2.6.34              [  OK  ]
12  2.6.35              [  OK  ]
13  2.6.36              [  OK  ]
14  2.6.37              [  OK  ]
15  2.6.38              [  OK  ]
16  2.6.39              [  OK  ]
17  3.0.65              [  OK  ]
18  3.1.10              [  OK  ]
19  3.2.38              [  OK  ]
20  3.3.8               [  OK  ]
21  3.4.32              [  OK  ]
22  3.5.7               [  OK  ]
23  3.6.11              [  OK  ]
24  3.7.9               [  OK  ]
25  3.8.0               [  OK  ]
26  3.9-rc1             [  OK  ]

real    23m32.940s
user    650m11.334s
sys     79m7.021s

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix compilation on 2.6.30
Luis R. Rodriguez [Wed, 27 Mar 2013 00:44:01 +0000 (17:44 -0700)]
compat-drivers: fix compilation on 2.6.30

Commit cfe9f9 did indeed fix the new changes on the TI
driver for newer kernels but failed to address the removal
of the wl12xx_hardirq handle no longer required for older
kernels. Fix this.

commit cfe9f97862b7c6eceb25932a6fec32ed0887171b
Author: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Date:   Tue Mar 26 16:14:42 2013 -0700

    compat-drivers: fix collateral-evolutions/network/09-threaded-irq.patch

    Manual edits required due to some context changes. The change
    in question that caused this is

    commit 97236a0656034ef8512ded648cfaa3d7282534e8
    Author: Luciano Coelho <coelho@ti.com>
    Date:   Fri Mar 8 09:41:53 2013 +0200

        wlcore: move handling from hardirq to the irq thread function

        Spin locks and completions are expensive in hard IRQ context and cause
        problems with RT kernels.  In RT kernels, both spin locks and
        completions can schedule(), so we can't use them in hard irq context.

        Move handling code into the irq thread function to avoid that.

Reported-by: Gregoire Gentil <gregoire@alwaysinnovating.com>
Signed-off-by: Luciano Coelho <coelho@ti.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20130326
Luis R. Rodriguez [Tue, 26 Mar 2013 23:21:57 +0000 (16:21 -0700)]
compat-drivers: refresh patches for next-20130326

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix collateral-evolutions/network/09-threaded-irq.patch
Luis R. Rodriguez [Tue, 26 Mar 2013 23:14:42 +0000 (16:14 -0700)]
compat-drivers: fix collateral-evolutions/network/09-threaded-irq.patch

Manual edits required due to some context changes. The change
in question that caused this is

commit 97236a0656034ef8512ded648cfaa3d7282534e8
Author: Luciano Coelho <coelho@ti.com>
Date:   Fri Mar 8 09:41:53 2013 +0200

    wlcore: move handling from hardirq to the irq thread function

    Spin locks and completions are expensive in hard IRQ context and cause
    problems with RT kernels.  In RT kernels, both spin locks and
    completions can schedule(), so we can't use them in hard irq context.

    Move handling code into the irq thread function to avoid that.

Reported-by: Gregoire Gentil <gregoire@alwaysinnovating.com>
Signed-off-by: Luciano Coelho <coelho@ti.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20130320
Luis R. Rodriguez [Thu, 21 Mar 2013 02:02:44 +0000 (19:02 -0700)]
compat-drivers: refresh patches for next-20130320

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20130315
Luis R. Rodriguez [Fri, 15 Mar 2013 17:47:05 +0000 (10:47 -0700)]
compat-drivers: refresh patches for next-20130315

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix compilation on nl80211.c
Luis R. Rodriguez [Wed, 13 Mar 2013 09:06:32 +0000 (02:06 -0700)]
compat-drivers: fix compilation on nl80211.c

0005-netlink-portid.patch requies addition of one more hunk.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20130312
Luis R. Rodriguez [Wed, 13 Mar 2013 01:08:16 +0000 (18:08 -0700)]
compat-drivers: refresh patches for next-20130312

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix 0006-disable-dump-adjust-on-old-kernels.patch
Luis R. Rodriguez [Wed, 13 Mar 2013 01:06:55 +0000 (18:06 -0700)]
compat-drivers: fix 0006-disable-dump-adjust-on-old-kernels.patch

nl80211_dump_wiphy() got some huge updates throwing
off the hunks completley. This required some manual
updates.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix 0005-netlink-portid.patch
Luis R. Rodriguez [Wed, 13 Mar 2013 01:03:12 +0000 (18:03 -0700)]
compat-drivers: fix 0005-netlink-portid.patch

The nl80211_send_wiphy() routine expects a dev
argument first now, so the first two hunks
required manual adjustments.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix commend for genlog
Luis R. Rodriguez [Mon, 11 Mar 2013 23:34:33 +0000 (16:34 -0700)]
compat-drivers: fix commend for genlog

The genlog script was giving the incorrect command
we use to generate the log for the kernel, fix this.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: skip already appplied patches
Luis R. Rodriguez [Mon, 11 Mar 2013 21:52:49 +0000 (14:52 -0700)]
compat-drivers: skip already appplied patches

GNU Patch does not yet support giving a different
error return value for patches detected as reversed or
already applied. We can add that support but for now
we distinguish this by grep'ing the results. We nuke
already applied patches, this typically would come from
linux-next, on linux-stable branches given that there is
no linearity between the two.

To support this change however it means we now have
the double amount of time it takes to apply patches
given that we now need a dry run first. The algorithm
for checking if a patch is reversed only works by
analyzing the first hunk of a patch though so perhaps
what we need on GNU Patch is a check for asking if
a patch is reversed, that would not cause much
overhead here, it would just dry run on the first
hunk by reducing the search space considerably.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix copying of pending-stable patches
Luis R. Rodriguez [Sat, 9 Mar 2013 01:03:32 +0000 (17:03 -0800)]
compat-drivers: fix copying of pending-stable patches

This correctly copies the pending-stable patches for each
subsystem. When running ./scripts/admin-update.sh -s
we will now stats pending-stable for each subsystem:

compat-drivers code metrics

   1320032 - Total upstream lines of code being pulled

   network
   ----------------------------------------
      3105 - backport code changes
      2602 - backport code additions
       503 - backport code deletions
     15003 - backport from compat module
     18108 - total backport code
    1.3718 - % of code consists of backport work
       192 - Code changes brought in from pending-stable
       124 - Code additions brought in from pending-stable
        68 - Code deletions brought in from pending-stable
    0.0145 - % of code being cherry picked from pending-stable

   drm
   ----------------------------------------
       437 - backport code changes
       293 - backport code additions
       144 - backport code deletions
     15003 - backport from compat module
     15440 - total backport code
    1.1697 - % of code consists of backport work

Base tree: linux-stable.git
Base tree version: v3.9-rc1
compat.git: compat-v3.9-rc1-1
compat-drivers release: compat-drivers-v3.9-rc1-2-4-g9f5e67f-s
Code metrics archive: http://bit.ly/H6BTF7

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix removal of tmp pending-stable files
Luis R. Rodriguez [Sat, 9 Mar 2013 00:56:45 +0000 (16:56 -0800)]
compat-drivers: fix removal of tmp pending-stable files

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: add ar5523 to driver-select
Luis R. Rodriguez [Sat, 9 Mar 2013 00:20:34 +0000 (16:20 -0800)]
compat-drivers: add ar5523 to driver-select

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix processing pending-stable patches
Luis R. Rodriguez [Sat, 9 Mar 2013 00:08:53 +0000 (16:08 -0800)]
compat-drivers: fix processing pending-stable patches

After we got DRM subsystem support the patches for each
subsystem were separated. Stable patches then need to
be broken down as well. This fixes this and restores
the behaviour allowing us to make -s releases.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: add scripts/genlog-3.9
Luis R. Rodriguez [Fri, 8 Mar 2013 02:27:54 +0000 (18:27 -0800)]
compat-drivers: add scripts/genlog-3.9

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: documentation impact of dump adjust workaround patch
Luis R. Rodriguez [Thu, 7 Mar 2013 22:28:27 +0000 (14:28 -0800)]
compat-drivers: documentation impact of dump adjust workaround patch

Expand the patch documentation so users can know why
they may want to upgrade.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: rename disable-dump-adjust-on-old-kernels.patch
Luis R. Rodriguez [Thu, 7 Mar 2013 22:17:25 +0000 (14:17 -0800)]
compat-drivers: rename disable-dump-adjust-on-old-kernels.patch

Rename this from:

70-disable-dump-adjust-on-old-kernels.patch

to:

0006-disable-dump-adjust-on-old-kernels.patch

4 digit patches are patches which have undergone review for
breaking it down as much as possible to help with seeing if
some of these can later be expressed as SmPL grammer for usage
with Coccinelle.

At this point SmPL grammer is possible for 0001-netdev_ops.patch
but that is because we have all the other 2 digit patches yet to
break down further.

This patch submitted by Johannes is already well broken down
so rename it to annotate it has been reviewed and is as atomic
as can be.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: add mac80211_hwsim support to driver-select
Luis R. Rodriguez [Thu, 7 Mar 2013 20:46:59 +0000 (12:46 -0800)]
compat-drivers: add mac80211_hwsim support to driver-select

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20130307
Luis R. Rodriguez [Thu, 7 Mar 2013 20:42:16 +0000 (12:42 -0800)]
compat-drivers: refresh patches for next-20130307

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: netlink_callback min_dump_alloc only exists since 3.1
Johannes Berg [Thu, 7 Mar 2013 20:36:01 +0000 (12:36 -0800)]
compat-drivers: netlink_callback min_dump_alloc only exists since 3.1

The netlink callback min_dump_alloc only exists on kernel
3.1 so only enable using it for those kernels. If you're
on an older 64-bit kernel and want this functionality of
resizing the data sent to userspace for a wiphy dump then
you better upgrade.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: remove network/68-do-not-add-Werror.patch
Luis R. Rodriguez [Thu, 7 Mar 2013 20:32:20 +0000 (12:32 -0800)]
compat-drivers: remove network/68-do-not-add-Werror.patch

This was added by Hauke to try to avoid causing compile
errors where old kernels had warnings enabled by default
such as -Werror=unused-but-set-variable. This is a common
error and enabling -Werror would make compilation fail.

The following upstream patch however sould take care of this
by disabling -Werror if *any* -W* flag is found on EXTRA_FLAGS:

commit 6f56b06e74e2805577bf7940dc0fb17b3310d6b6
Author: Chen Gang <gang.chen@asianux.com>
Date:   Wed Feb 27 14:55:06 2013 +0800

    drivers/net/wireless/ath/wil6210: Makefile, only -Werror when no -W* in EXTRA_CFLAGS

      When make with EXTRA_CFLAGS=-W, it will report error.
      so give a check in Makefile.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
The change was as follows:

-subdir-ccflags-y += -Werror
+ifeq (, $(findstring -W,$(EXTRA_CFLAGS)))
+       subdir-ccflags-y += -Werror
+endif

Since this is now upstream, just nuke this work around!

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix netlink portid patch for nl80211
Johannes Berg [Thu, 7 Mar 2013 20:16:10 +0000 (12:16 -0800)]
compat-drivers: fix netlink portid patch for nl80211

This required a manual fix for one hunk on nl80211.c

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh unified-drivers patches
Luis R. Rodriguez [Tue, 5 Mar 2013 01:17:24 +0000 (17:17 -0800)]
compat-drivers: refresh unified-drivers patches

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20130304
Luis R. Rodriguez [Tue, 5 Mar 2013 01:16:11 +0000 (17:16 -0800)]
compat-drivers: refresh patches for next-20130304

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix network/99-change-makefiles.patch
Luis R. Rodriguez [Tue, 5 Mar 2013 01:13:40 +0000 (17:13 -0800)]
compat-drivers: fix network/99-change-makefiles.patch

CONFIG_USB_NET_AX88179_178A is part of the hunk now, this
required a manual update.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix network/18-rename-usb-net-symbols.patch
Luis R. Rodriguez [Tue, 5 Mar 2013 01:11:26 +0000 (17:11 -0800)]
compat-drivers: fix network/18-rename-usb-net-symbols.patch

CONFIG_USB_NET_AX88179_178A is now part of the first hunk,
this required a manual update.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agoscripts/driver-select: use $BACKUP_EXT everywhere
stefan.kuhn@foss-group.ch [Sat, 2 Mar 2013 19:31:38 +0000 (20:31 +0100)]
scripts/driver-select: use $BACKUP_EXT everywhere

Signed-off-by: Stefan Kuhn <stefan.kuhn@hispeed.ch>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh alx patch for INTX-MSI issue
xiong [Fri, 1 Mar 2013 22:10:39 +0000 (06:10 +0800)]
compat-drivers: refresh alx patch for INTX-MSI issue

chip revsion less than C0 has INTX/MSI issue.
this patch should be removed after the kernel drivers/pci/quirks.c
contains this workaround.

Signed-off-by: xiong <xiong@qca.qualcomm.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: reference adrian's alx tree instead
Luis R. Rodriguez [Wed, 27 Feb 2013 22:13:42 +0000 (14:13 -0800)]
compat-drivers: reference adrian's alx tree instead

Adrian is now maintaining the alx tree given that
the BSD OS port work is now on his court.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: remove network/0003-alx-remove-devinit-devexit.patch
Luis R. Rodriguez [Wed, 27 Feb 2013 22:12:43 +0000 (14:12 -0800)]
compat-drivers: remove network/0003-alx-remove-devinit-devexit.patch

All these changes are now merged on Adrian's alx.git tree.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: build driver/video/hdmi.ko
Hauke Mehrtens [Wed, 27 Feb 2013 23:53:39 +0000 (00:53 +0100)]
compat-drivers: build driver/video/hdmi.ko

This module is needed by the drm driver now.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches
Hauke Mehrtens [Wed, 27 Feb 2013 23:53:38 +0000 (00:53 +0100)]
compat-drivers: refresh patches

This refreshes the patches on next-20130227

Some of the drm patches needed manual editing.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches
Hauke Mehrtens [Tue, 19 Feb 2013 22:20:16 +0000 (23:20 +0100)]
compat-drivers: refresh patches

Refresh patches on next-20130220

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: do not use __sock_create()
Hauke Mehrtens [Tue, 19 Feb 2013 22:19:50 +0000 (23:19 +0100)]
compat-drivers: do not use __sock_create()

__sock_create() is not available on kernel version < 2.6.37.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: rename GPL file to COPYING
Johannes Berg [Mon, 18 Feb 2013 14:39:23 +0000 (15:39 +0100)]
compat-drivers: rename GPL file to COPYING

Code or other references in the kernel would point to
a file called "COPYING" (as in the upstream kernel),
so rename the GPL file to that name.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: refresh patches:
Hauke Mehrtens [Mon, 18 Feb 2013 22:08:32 +0000 (23:08 +0100)]
compat-drivers: refresh patches:

Refresh patches on next-20130218.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: move disable_drm
Hauke Mehrtens [Mon, 18 Feb 2013 21:55:06 +0000 (22:55 +0100)]
compat-drivers: move disable_drm

drm should be disabled when disable_bt_usb_ethernet is selected. This
disables drm also for e.g. b43.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: backport threaded IRQ for iwlwifi
Hauke Mehrtens [Wed, 13 Feb 2013 20:40:37 +0000 (21:40 +0100)]
compat-drivers: backport threaded IRQ for iwlwifi

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: refresh patches:
Hauke Mehrtens [Wed, 13 Feb 2013 18:22:05 +0000 (19:22 +0100)]
compat-drivers: refresh patches:

Refresh patches on next-20130213.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: do not include videomode headers when this feature is deactivated
Hauke Mehrtens [Wed, 13 Feb 2013 18:21:12 +0000 (19:21 +0100)]
compat-drivers: do not include videomode headers when this feature is deactivated

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: add missing include linux/export.h
Hauke Mehrtens [Wed, 13 Feb 2013 18:20:49 +0000 (19:20 +0100)]
compat-drivers: add missing include linux/export.h

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: make drm patches apply again
Hauke Mehrtens [Wed, 13 Feb 2013 18:19:59 +0000 (19:19 +0100)]
compat-drivers: make drm patches apply again

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: refresh patches
Hauke Mehrtens [Sun, 10 Feb 2013 19:54:55 +0000 (20:54 +0100)]
compat-drivers: refresh patches

Refresh patches on linux-next next-20130208

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: refresh patches on next-20130202
Hauke Mehrtens [Sun, 3 Feb 2013 14:05:04 +0000 (15:05 +0100)]
compat-drivers: refresh patches on next-20130202

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: add missing include for export
Hauke Mehrtens [Sun, 3 Feb 2013 17:35:38 +0000 (18:35 +0100)]
compat-drivers: add missing include for export

drivers/net/wireless/ti/wlcore/scan.c and drivers/net/wireless/ti/wlcore
/event.c need an #include <linux/export.h> to add EXPORT_SYMBOL_GPL on
kernel 3.2 and 3.3.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: add include for net/if_inet6.h to net/mac80211.h
Hauke Mehrtens [Sun, 3 Feb 2013 14:03:17 +0000 (15:03 +0100)]
compat-drivers: add include for net/if_inet6.h to net/mac80211.h

Some older kernels are missing the declaration of struct inet6_dev in
this file.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: add the iwlwifi MVM driver
Hauke Mehrtens [Sun, 3 Feb 2013 14:01:58 +0000 (15:01 +0100)]
compat-drivers: add the iwlwifi MVM driver

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: make patches apply again
Hauke Mehrtens [Sun, 3 Feb 2013 12:31:27 +0000 (13:31 +0100)]
compat-drivers: make patches apply again

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: update genlog-3.8 for rc5
Hauke Mehrtens [Sat, 26 Jan 2013 16:55:41 +0000 (17:55 +0100)]
compat-drivers: update genlog-3.8 for rc5

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: use backport for second workqueue
Hauke Mehrtens [Thu, 24 Jan 2013 23:22:51 +0000 (00:22 +0100)]
compat-drivers: use backport for second workqueue

bluetooth hci_core uses a second workqueue.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: deactivate mac80211_hwsim for kernel < 2.6.31
Hauke Mehrtens [Thu, 24 Jan 2013 23:21:01 +0000 (00:21 +0100)]
compat-drivers: deactivate mac80211_hwsim for kernel < 2.6.31

kernel version < 2.6.31 does not support tasklet_hrtimer, so deactivate
the driver there.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: refresh alx patches
Hauke Mehrtens [Thu, 24 Jan 2013 22:56:56 +0000 (23:56 +0100)]
compat-drivers: refresh alx patches

This was done against alx-20130124.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: deactivate loopback testing for older kernels
Hauke Mehrtens [Thu, 24 Jan 2013 22:55:24 +0000 (23:55 +0100)]
compat-drivers: deactivate loopback testing for older kernels

ETH_TEST_FL_EXTERNAL_LB and ETH_TEST_FL_EXTERNAL_LB_DONE are not
available in kernel version < 3.1.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: do not treat a warning as error
Hauke Mehrtens [Thu, 24 Jan 2013 22:35:37 +0000 (23:35 +0100)]
compat-drivers: do not treat a warning as error

Older kernel version show more warnings like -Werror=unused-but-set-variable
and with this option they are treated as an error.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: refresh patches
Hauke Mehrtens [Wed, 23 Jan 2013 23:01:45 +0000 (00:01 +0100)]
compat-drivers: refresh patches

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: remove devinit and devexit from alx driver
Hauke Mehrtens [Wed, 23 Jan 2013 22:59:55 +0000 (23:59 +0100)]
compat-drivers: remove devinit and devexit from alx driver

devinit and devexit were removed from kernel version 3.8 and using it
causes compile problems.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
11 years agocompat-drivers: refresh patches for next-20130121
Luis R. Rodriguez [Tue, 22 Jan 2013 03:40:25 +0000 (19:40 -0800)]
compat-drivers: refresh patches for next-20130121

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix driver-select for atheros drivers
Luis R. Rodriguez [Tue, 22 Jan 2013 00:19:40 +0000 (16:19 -0800)]
compat-drivers: fix driver-select for atheros drivers

The addition of the new wil6210 driver added a new ATH_CARDS
option to be used to describe Atheros cards and now uses ATH_COMMON
for the common module ath. This requires fixing the driver-select
script so that the drivers are enabled properly.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: do not call make clean for unified drivers
Luis R. Rodriguez [Mon, 21 Jan 2013 23:56:04 +0000 (15:56 -0800)]
compat-drivers: do not call make clean for unified drivers

We can skip the make clean process for unified drivers given
that the script that makes compat-drivers releases, gen-releases.sh,
already ensures that we call $(git clean -f -x -d) on each git
tree we are cherry picking code from.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: disable DRM drivers for 802.11 drivers
Luis R. Rodriguez [Mon, 21 Jan 2013 20:33:23 +0000 (12:33 -0800)]
compat-drivers: disable DRM drivers for 802.11 drivers

When using driver-select disable DRM driver sfor 802.11 drivers.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agoRevert "compat-drivers: remove wil6210 driver from scripts/driver-select"
Luis R. Rodriguez [Thu, 10 Jan 2013 21:53:43 +0000 (13:53 -0800)]
Revert "compat-drivers: remove wil6210 driver from scripts/driver-select"

This reverts commit efe0d228ae559546ffea85be9047899f10a13d30.

11 years agocompat-drivers: refresh patches for next-20130110
Luis R. Rodriguez [Thu, 10 Jan 2013 21:35:43 +0000 (13:35 -0800)]
compat-drivers: refresh patches for next-20130110

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: add new mac80211 debug options
Hauke Mehrtens [Wed, 9 Jan 2013 16:27:27 +0000 (17:27 +0100)]
compat-drivers: add new mac80211 debug options

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix section mismatch in ath5k
Hauke Mehrtens [Wed, 9 Jan 2013 16:27:26 +0000 (17:27 +0100)]
compat-drivers: fix section mismatch in ath5k

Fix section mismatch introduced by removing __devinitconst usage from
the kernel.

WARNING: /home/hauke/compat-wireless/compat-wireless/drivers/net/wireless/ath/ath5k/ath5k.o(.text+0x13898): Section mismatch in reference from the function ath5k_init_leds() to the variable .devinit.rodata:ath5k_led_devices
The function ath5k_init_leds() references
the variable __devinitconst ath5k_led_devices.
This is often because ath5k_init_leds lacks a __devinitconst
annotation or the annotation of ath5k_led_devices is wrong.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: add wil6210 driver
Hauke Mehrtens [Wed, 9 Jan 2013 16:27:25 +0000 (17:27 +0100)]
compat-drivers: add wil6210 driver

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: remove 'v' prefix from version on ChangeLog
Luis R. Rodriguez [Thu, 10 Jan 2013 20:59:24 +0000 (12:59 -0800)]
compat-drivers: remove 'v' prefix from version on ChangeLog

As with the previous commit this follows the kernel.org
model as well as the older releases we were making.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: trim 'v' prefix from ChangeLog file
Luis R. Rodriguez [Thu, 10 Jan 2013 20:53:59 +0000 (12:53 -0800)]
compat-drivers: trim 'v' prefix from ChangeLog file

This follows the kernel.org releases as well as our old
releases.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: update genlog-3.8
Luis R. Rodriguez [Wed, 9 Jan 2013 01:56:22 +0000 (17:56 -0800)]
compat-drivers: update genlog-3.8

This updates genlog-3.8 so it adds the extra version postfix
number. Even though the Linux kernel release may remain stable
we may at times make a new release of compat-drivers to update
fixes for backporting.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: add genlog-3.8
Luis R. Rodriguez [Wed, 9 Jan 2013 01:45:12 +0000 (17:45 -0800)]
compat-drivers: add genlog-3.8

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches
Luis R. Rodriguez [Tue, 8 Jan 2013 22:11:59 +0000 (14:11 -0800)]
compat-drivers: refresh patches

Refreshes patches for next-20130108

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix 61-netdev-addr_assign_type.patch
Luis R. Rodriguez [Tue, 8 Jan 2013 22:04:47 +0000 (16:04 -0600)]
compat-drivers: fix 61-netdev-addr_assign_type.patch

The following two patches adjusted uses of NET_ADDR_RANDOM
on some Ethernet drivers. This change adopts these changes
on the 61-netdev-addr_assign_type.patch patch.

commit 15c6ff3bc0ff3464a8c7efcdea09c86454571622
Author: Jiri Pirko <jiri@resnulli.us>
Date:   Tue Jan 1 03:30:17 2013 +0000

    net: remove unnecessary NET_ADDR_RANDOM "bitclean"

    NET_ADDR_SET is set in dev_set_mac_address() no need to alter
    dev->addr_assign_type value in drivers.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
commit e41b2d7fe7803e85e1202d0eb172717d7bf1bbaf
Author: Jiri Pirko <jiri@resnulli.us>
Date:   Tue Jan 1 03:30:15 2013 +0000

    net: set dev->addr_assign_type correctly

    Not a bitfield, but a plain value.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix collateral-evolutions/network/53-pr_fmt.patch
Luis R. Rodriguez [Tue, 8 Jan 2013 21:07:59 +0000 (15:07 -0600)]
compat-drivers: fix collateral-evolutions/network/53-pr_fmt.patch

The brcmfmac driver was updated recently to only define
pr_fmt() once and it also had the undef for us. Technically
Joe should not have had to add the undef as I previously
went on a crusade to verify that this was not needed at the
driver level so an upstream patch is welcomed to remove that
undef upstream and then to add it for backporting purposes.

commit 79d7c4e8da4ac3cfa98e8e622a17baaeb3c9d29d
Author: Arend van Spriel <arend@broadcom.com>
Date:   Wed Jan 2 21:20:10 2013 +0100

    brcmfmac: define pr_fmt in one place

    Several source files (but not all) define the pr_fmt() macro in exactly
    the same way. Instead this commit defines it in a header file so driver
    logging is consistent.

Cc: Joe Perches <joe@perches.com>
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches
Hauke Mehrtens [Thu, 27 Dec 2012 17:28:22 +0000 (18:28 +0100)]
compat-drivers: refresh patches

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: add old suspend/resume handlers only when function is available
Hauke Mehrtens [Thu, 27 Dec 2012 17:28:21 +0000 (18:28 +0100)]
compat-drivers: add old suspend/resume handlers only when function is available

All the suspend resume functions are only activated when
CONFIG_PM_SLEEP is set and not when CONFIG_PM is set.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: make patches apply again
Hauke Mehrtens [Thu, 27 Dec 2012 17:28:20 +0000 (18:28 +0100)]
compat-drivers: make patches apply again

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agoupdate-initramfs: Add support for Fedora
Ozan Çağlayan [Sat, 22 Dec 2012 11:04:13 +0000 (13:04 +0200)]
update-initramfs: Add support for Fedora

Fedora doesn't ship lsb_release anymore. So try to read /etc/os-release
to find whether distribution is Fedora.

If Fedora is found, generate a new initramfs suffixed with -compat-drivers
to not override the distribution kernel's default one. Also add a new
kernel entry to grub2 configuration without overriding the default boot
entry.

Signed-off-by: Ozan Çağlayan <ozancag@gmail.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agoupdate-initramfs: Silence lsb_release output
Ozan Çağlayan [Sat, 22 Dec 2012 11:04:12 +0000 (13:04 +0200)]
update-initramfs: Silence lsb_release output

Silence lsb_release output to avoid command not found errors
on distributions not having lsb_release like Fedora.

Signed-off-by: Ozan Çağlayan <ozancag@gmail.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agoupdate-initramfs: Update comments, fix some typos
Ozan Çağlayan [Sat, 22 Dec 2012 11:04:11 +0000 (13:04 +0200)]
update-initramfs: Update comments, fix some typos

update-initramfs is crucial for DRM drivers, let's clarify this.

Signed-off-by: Ozan Çağlayan <ozancag@gmail.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh 0001-backport-alx.patch
Luis R. Rodriguez [Thu, 20 Dec 2012 03:40:34 +0000 (19:40 -0800)]
compat-drivers: refresh 0001-backport-alx.patch

Refresh patches again.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patch 0001-backport-alx.patch
Luis R. Rodriguez [Thu, 20 Dec 2012 03:09:07 +0000 (19:09 -0800)]
compat-drivers: refresh patch 0001-backport-alx.patch

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: update 0001-backport-alx.patch context
Luis R. Rodriguez [Thu, 20 Dec 2012 03:07:11 +0000 (19:07 -0800)]
compat-drivers: update 0001-backport-alx.patch context

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix alx backport patch
Luis R. Rodriguez [Thu, 20 Dec 2012 01:06:05 +0000 (17:06 -0800)]
compat-drivers: fix alx backport patch

The hunks required some manual fixing due to some
new code changes on the alx driver.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20121218
Luis R. Rodriguez [Wed, 19 Dec 2012 05:31:02 +0000 (21:31 -0800)]
compat-drivers: refresh patches for next-20121218

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: allow git-paranoia to work on current directory
Luis R. Rodriguez [Fri, 14 Dec 2012 21:27:20 +0000 (13:27 -0800)]
compat-drivers: allow git-paranoia to work on current directory

This allows you to run git-paranoia on your current directory.
It will return 0 if everything is squeeky clean. This is useful
if for example you want to run a cronjob to update git trees but
never update them if you have any deltas in place of any kind.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh -u patches
Luis R. Rodriguez [Fri, 14 Dec 2012 19:02:17 +0000 (11:02 -0800)]
compat-drivers: refresh -u patches

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20121214
Luis R. Rodriguez [Fri, 14 Dec 2012 19:01:18 +0000 (11:01 -0800)]
compat-drivers: refresh patches for next-20121214

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: refresh patches for next-20121211
Luis R. Rodriguez [Thu, 13 Dec 2012 05:12:43 +0000 (21:12 -0800)]
compat-drivers: refresh patches for next-20121211

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: ship include/linux/bcm47xx_wdt.h
Luis R. Rodriguez [Wed, 12 Dec 2012 00:56:21 +0000 (16:56 -0800)]
compat-drivers: ship include/linux/bcm47xx_wdt.h

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: remove 67-use_spinlock_t.patch
Luis R. Rodriguez [Wed, 12 Dec 2012 00:46:09 +0000 (16:46 -0800)]
compat-drivers: remove 67-use_spinlock_t.patch

This work is now upstream.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix 62-usb_driver_lpm.patch
Luis R. Rodriguez [Wed, 12 Dec 2012 00:44:52 +0000 (16:44 -0800)]
compat-drivers: fix 62-usb_driver_lpm.patch

CONFIG_HOTPLUG is going away soon so a few helpers can
be removed now.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix 45-remove-platform-id-table.patch
Luis R. Rodriguez [Wed, 12 Dec 2012 00:43:01 +0000 (16:43 -0800)]
compat-drivers: fix 45-remove-platform-id-table.patch

CONFIG_HOTPLUG is going away soon so a few init/remove helpers
are being removed.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: remove __devexit_p() from 11-dev-pm-ops.patch
Luis R. Rodriguez [Wed, 12 Dec 2012 00:39:27 +0000 (16:39 -0800)]
compat-drivers: remove __devexit_p() from 11-dev-pm-ops.patch

The __devexit_p() was removed from a few drivers given that
CONFIG_HOTPLUG is going away.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: remove ksize() ifdef on scan.c
Luis R. Rodriguez [Wed, 12 Dec 2012 00:27:42 +0000 (16:27 -0800)]
compat-drivers: remove ksize() ifdef on scan.c

The patch bellow remove the usage of ksize() so just
remove that hunk.

commit 9caf03640279e64d0ba36539b42daa1b43a49486
Author: Johannes Berg <johannes.berg@intel.com>
Date:   Thu Nov 29 01:25:20 2012 +0100

    cfg80211: fix BSS struct IE access races

    When a BSS struct is updated, the IEs are currently
    overwritten or freed. This can lead to races if some
    other CPU is accessing the BSS struct and using the
    IEs concurrently.

    Fix this by always allocating the IEs in a new struct
    that holds the data and length and protecting access
    to this new struct with RCU.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: modify release script to support unified drivers
Luis R. Rodriguez [Wed, 5 Dec 2012 01:28:11 +0000 (17:28 -0800)]
compat-drivers: modify release script to support unified drivers

The -u argument was used to upload releases to kernel.org. Lets
rename this to -r for 'release to kernel.org' given that we have
no introduced -u for unified-drivers support into compat-drivers.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: fix alx suspend/resume calls for old kernels
Luis R. Rodriguez [Tue, 4 Dec 2012 23:19:17 +0000 (15:19 -0800)]
compat-drivers: fix alx suspend/resume calls for old kernels

The declarations compat_pci_suspend() and compat_pci_resume()
must be placed before SIMPLE_DEV_PM_OPS().

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
11 years agocompat-drivers: add the MDIO module
Luis R. Rodriguez [Tue, 4 Dec 2012 21:07:11 +0000 (21:07 +0000)]
compat-drivers: add the MDIO module

The alx Ethernet driver depends on the MDIO module.
This module has UAPI and kernel headers. The headers are
carried over intact to help *both* backport it for older
drivers and also provide the newer driver to other kernels
that may have it enabled after it was introduced in 2.6.31.

The way support for MDIO is enabled is by carrying over both
the UAPI and Linux kernel header files along with the module
with in compat-drivers. The exported symbols of the module
however are renamed with a compat_* prefix within compat
in include/linux/compat-2.6.31.h. This enables Linux
distributions shipping a driver that depends on older
versions of the MDIO to keep using it while allowing the
supplied drivers in compat-drivers to become users of
the newer module it likely will require a tighter
dependency on.

An alternative to using different exported symbol names
is for compat-drivers to work under a separate namespace
and while I hear some folks already implemented that support
we never got those patches sent to us.

C'est la vie.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>