Chaehyun Lim [Sun, 20 Sep 2015 06:51:11 +0000 (15:51 +0900)]
staging: wilc1000: remove blank line after an open brace '{'
This patch removes blank line after an open brace '{' found by checkpatch.pl.
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:10 +0000 (15:51 +0900)]
staging: wilc1000: fix NULL comparison style
This patch fixes NULL comparison style found by checkpatch.pl.
CHECK: Comparison to NULL could be written "!net"
CHECK: Comparison to NULL could be written "!net->ieee80211_ptr"
CHECK: Comparison to NULL could be written "!net->ieee80211_ptr->wiphy"
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:09 +0000 (15:51 +0900)]
staging: wilc1000: rename WILC_WFI_WiphyRegister
This patch replaces WILC_WFI_WiphyRegister with wilc_create_wiphy to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Sun, 20 Sep 2015 06:51:08 +0000 (15:51 +0900)]
staging: wilc1000: rename WILC_WFI_WiphyFree
This patch replaces WILC_WFI_WiphyFree with wilc_free_wiphy to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Erik Arfvidson [Tue, 25 Aug 2015 21:52:35 +0000 (17:52 -0400)]
staging: unisys: add visorhid driver
This driver provides mouse and keyboard input to Unisys s-Par
Partition Desktop application. This device is created by the
visorbus device.
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Fri, 18 Sep 2015 09:11:04 +0000 (18:11 +0900)]
staging: wilc1000: remove typedef from the struct
The Linux kernel coding style does not recommend to use typedef for the
structure. This patch removes typedef from the host_if_msg structure.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Fri, 18 Sep 2015 09:11:03 +0000 (18:11 +0900)]
staging: wilc1000: rename tstrHostIFmsg
This patch changes the name, tstrHostIFmsg to host_if_msg not to use
camelcase notation in the Linux.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Fri, 18 Sep 2015 14:46:23 +0000 (15:46 +0100)]
staging: comedi: comedi_fops.c: remove bogus kernel-doc for runflags
The comment before the `COMEDI_SRF_...` macros starts with a kernel-doc
mark but isn't valid kernel-doc. There isn't a kernel-doc template for
a group of macro constants. These macros are all private anyway, so
don't really need to be in kernel-doc. Just change it to a normal
comment.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 17 Sep 2015 16:44:35 +0000 (22:14 +0530)]
staging: slicoss: use status in isr
If we are not able to setup the LINK UP command then don't increment the
interrupt count.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 17 Sep 2015 16:44:34 +0000 (22:14 +0530)]
staging: slicoss: use status in slic_ioctl
In the ioctl function if we are not able to UP the link after setting
the new parameters then return an error code to the userspace.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 17 Sep 2015 16:44:33 +0000 (22:14 +0530)]
staging: slicoss: use status in slic_if_init
While initializing the interface if we are not able to setup the command
to UP the link then we release everything and return the error code.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 17 Sep 2015 16:44:32 +0000 (22:14 +0530)]
staging: slicoss: return status of slic_link_event_handler
slic_link_event_handler() issues command READ_LINK_STATUS to be executed
asynchronously, which is followed by UP configuration write command. But
it can fail while setting up the command and in that case the link will
not be up. Lets check the status and return it.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jakub Sitnicki [Fri, 18 Sep 2015 06:13:00 +0000 (08:13 +0200)]
staging: rtl8188eu: Introduce monitor interface for IEEE 802.11 frames
This adds support for monitoring IEEE 802.11 Data and Management frames
received or transmitted by a RTL8188EU-based device handled by this
driver.
The monitor interface is not enabled by default and will be registered
only if monitor_enable module parameter is set to 1. When enabled it
will show up as a monX network device, which can be used by the
userspace programs for monitoring network traffic.
It is intended as an exploratory/debugging tool for rtl8188eu driver.
Signed-off-by: Jakub Sitnicki <jsitnicki@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 17 Sep 2015 08:47:25 +0000 (17:47 +0900)]
staging: wilc1000: remove do-nothing ifdef statement
This patch removes do-nothing ifdef, else statement and add ifdef WILC_SDIO
for disable_sdio_interrupt().
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 17 Sep 2015 08:47:24 +0000 (17:47 +0900)]
staging: wilc1000: remove define RX_BH_TYPE
This patch removes the preprocessor definition, RX_BH_TYPE and uses the
request_threaded_irq instead of kernel thread to execute the interrupt
handler.
As a result, linux_wlan_enable_irq() and linux_wlan_disable_irq() are also
removed from the linux_wlan.c file.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:49 +0000 (16:48 +0900)]
staging: wilc1000: remove declaration of wilc_get_chipid
This patch removes the declaration of wilc_get_chipid function.
It is included wilc_wlan_if.h that has declaration of wilc_get_chipid.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:48 +0000 (16:48 +0900)]
staging: wilc1000: remove useless comment
This patch removes useless comment that is included "BugID_xxxx"
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:47 +0000 (16:48 +0900)]
staging: wilc1000: remove WILC_TIME typedef
This patch removes WILC_TIME typedef that is not used anymore.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:46 +0000 (16:48 +0900)]
staging: wilc1000: remove unused defines
This patch removes unused defines.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:45 +0000 (16:48 +0900)]
staging: wilc1000: linux_wlan_spi.c: fix kzalloc error check
This patch fixes error check of kzalloc.
If kzalloc is failed, return type is used as -ENOMEM.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:43 +0000 (16:48 +0900)]
staging: wilc1000: replace __inline with inline
This patch replaces __inline with inline. plain inline is more
preferred than __inline.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Thu, 17 Sep 2015 07:48:42 +0000 (16:48 +0900)]
staging: wilc1000: remove INLINE macro
This patch removes INLINE macro that is used anymore.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Raphaël Beamonte [Fri, 11 Sep 2015 07:29:09 +0000 (03:29 -0400)]
staging: rtl8192u: r8192U_core: fix comments lines over 80 characters
Move, replace and reorganize comments to stay under 80 characters
per line, as to follow the kernel code style. Some unuseful comments
have been removed.
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Marcos Canán [Wed, 16 Sep 2015 20:48:57 +0000 (17:48 -0300)]
staging: comedi: drivers: coding style: fixed block comment style
This is a patch to the drivers.c file that fixes
a block comment style.
Signed-off-by: Marcos Canán <mcanan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:49 +0000 (16:32 -0400)]
staging: rtl8723au: Clean up getPowerBase()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:48 +0000 (16:32 -0400)]
staging: rtl8723au: TurboScanOff is always true
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:47 +0000 (16:32 -0400)]
staging: rtl8723au: Tidy up SetTxPowerLevel8723A()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:46 +0000 (16:32 -0400)]
staging: rtl8723au: Fold getTxPowerIndex() into PHY_SetTxPowerLevel8723A()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:45 +0000 (16:32 -0400)]
staging: rtl8723au: Eliminate dummy ccxPowerIndexCheck()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Sep 2015 20:32:44 +0000 (16:32 -0400)]
staging: rtl8723au: Simplify eeprom content checking
This eliminates the ugly Hal_EEValueCheck() function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:26 +0000 (18:53 +0900)]
staging: wicl1000: remove function pointer wlan_handle_rx_que
The function pointer wlan_handle_rx_que is not called anywhere. Delete
wlan_handle_rx_que and it's assignment code.
But the function wilc_wlan_handle_rxq in assignment code is used. So leave it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Wed, 16 Sep 2015 11:11:27 +0000 (20:11 +0900)]
staging: wilc1000: replace INLINE with static inline
INLINE macro is defined as static __inline so that it is replaced by
static inline.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Wed, 16 Sep 2015 11:11:26 +0000 (20:11 +0900)]
staging: wilc1000: wilc_wlan.c: use BIT(x) macro
Remove bit shift macro that is custom defined, then replace BIT(x)
macro.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:27 +0000 (18:53 +0900)]
staging: wilc1000: remove unused variable rxq_thread
The rxq_thread never runs since it's kthread_run code was delete in a previous
patch. Remove kthread_run and it's related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:25 +0000 (18:53 +0900)]
staging: wilc1000: remove unused semaphore and it's related codes
Variable rxq_event, rxq_wait_event and rxq_wait have the same pointer.
nwi->os_context.rxq_wait_event = (void *)&g_linux_wlan->rxq_event;
g_wlan.rxq_wait = inp->os_context.rxq_wait_event;
They are never aquired(down) since down function was only called in
linux_wlan_rxq_task which was deleted in a previous patch.
So delete variable rxq_event, rxq_wait_event, rxq_wait and it's related codes.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:24 +0000 (18:53 +0900)]
staging: wilc1000: remove variable rxq_thread_started
rxq_thread_started is initiallized but never used in the driver. Remove
the variable and init code line.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:23 +0000 (18:53 +0900)]
staging: wilc1000: remove function linux_wlan_rxq_task
linux_wlan_rxq_task is not used in the driver. Just remove it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:22 +0000 (18:53 +0900)]
staging: wilc1000: remove define TCP_ENHANCEMENTS and it's related code
TCP_ENHANCEMENTS is always in use. Remove define TCP_ENHANCEMENTS, ifdef line,
ifndef line and codes inside ifndef.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:21 +0000 (18:53 +0900)]
staging: wilc1000: remove define WILC_P2P and ifdef line
WILC_P2P is always used in the driver. So delete define WILC_P2P and ifdef line.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 09:53:20 +0000 (18:53 +0900)]
staging: wilc1000: remove define WILC_AP_EXTERNAL_MLME and ifdef line
This driver use WILC_AP_EXTERNAL_MLME define always. Delete define
WILC_AP_EXTERNAL_MLME and ifdef line.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:04 +0000 (18:36 +0900)]
staging: wilc1000: remove wilc_errorsupport.h
This patch removes the wilc_errorsupport.h which is not used anymore and
also deletes #include "wilc_errorsupport.h" from the source code.
In addition, adds linux_wlan_common.h file in the wilc_msgqueue.c file
in order to use PRINT macros defined in the linux_wlan_common.h file.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:03 +0000 (18:36 +0900)]
staging: wilc1000: replace wilc error types with the generic error types
This patch replaces the error types defined by wilc driver with the
generic error types provided by the Linux kernel.
- WILC_SUCCESS 0
- WILC_FAIL -EFAULT
- WILC_BUSY -EBUSY
- WILC_INVALID_ARGUMENT -EINVAL
- WILC_INVALID_STATE -EINVAL
- WILC_BUFFER_OVERFLOW -EOVERFLOW
- WILC_NULL_PTR -EFAULT
- WILC_TIMEOUT -ETIMEDOUT
- WILC_NOT_FOUND -ENOENT
- WILC_NO_MEM -ENOMEM
After then removes all wilc definitions.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:02 +0000 (18:36 +0900)]
staging: wilc1000: remove definitions unused
Remove the definitions which are not used anywhere.
- WILC_ALREADY_EXSIT
- WILC_EMPTY
- WILC_FULL
- WILC_CANCELED
- WILC_INVALID_FILE
- WILC_UNSUPPORTED_VERSION
- WILC_FILE_EOF
Remove the definition which is not used anymore.
- WILC_CATCH
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:01 +0000 (18:36 +0900)]
staging: wilc1000: remove the macro WILC_ERRORREPORT
This patch removes the macro WILC_ERRORREPORT which is not used
anymore by replacing it with the plain statements.
The compiler complains the build warnings in some functions for WILC_CATCH and
ERRORHANDLER as unused definitions. So, this patch also removes WILC_CATCH and
ERRORHANDLER from some of functions.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:36:00 +0000 (18:36 +0900)]
staging: wilc1000: remove the macro WILC_ERRORCHECK
This patch removes the macro WILC_ERRORCHECK which is not used
anymore by replacing it with the plain statements.
This patch also removes the WILC_CATCH macros from some of functions not
to make the build warnings.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Wed, 16 Sep 2015 09:35:59 +0000 (18:35 +0900)]
staging: wilc1000: remove a macro WILC_NULLCHECK
This patch replaces WILC_NULLCHECK with the plain statements and then removes
the macro WILC_NULLCHECK in wilc_errorsupport.h which is not used anymore.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:55 +0000 (10:43 +0900)]
staging: wilc1000: remove unused variable g_flushing_in_progress
g_flushing_in_progress is never used so just delete it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:54 +0000 (10:43 +0900)]
staging: wilc1000: coreconfigurator.h: remove unused defines
The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver.
Delete two defines.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:53 +0000 (10:43 +0900)]
staging: wilc1000: delete function declaration SendRawPacket
SendRawpacket is declared but not implemented. It is not used also.
So just delete it.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:52 +0000 (10:43 +0900)]
staging: wilc1000: remove unused variables
Variable g_num_total_switches is never used so just remove it.
gastrWIDs is also not used because g_num_total_switches is deleted.
Remove gastrWIDs also.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:51 +0000 (10:43 +0900)]
staging: wilc1000: delete unused global variables.
gstrConfigPktInfo, SemHandleSendPkt and SemHandlePktResp are never used in
the drivers. So just delete the variables and it's related code.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:50 +0000 (10:43 +0900)]
staging: wilc1000: remove unnecessary extern function declaration
Function NetworkInfoReceived, GnrlAsyncInfoReceived and
host_int_ScanCompleteReceived are declared in the header file already.
Just removes the declaration and comments.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:49 +0000 (10:43 +0900)]
staging: wilc1000: remove unused defines
This patch removes follwing unused defines.
MAX_CFG_PKTLEN
MSG_HEADER_LEN
QUERY_MSG_TYPE
WRITE_MSG_TYPE
RESP_MSG_TYPE
WRITE_RESP_SUCCESS
INVALID
MAC_ADDR_LEN
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:48 +0000 (10:43 +0900)]
staging: wilc1000: remove unnecessary define FIVE_GHZ_BAND
wilc1000 driver does not support five Ghz band. Remove FIVE_GHZ_BAND and
it's related code.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Wed, 16 Sep 2015 01:43:47 +0000 (10:43 +0900)]
staging: wilc1000: remove useless define PHY_802_11n
The define PHY_802_11n is useless because wilc1000 support 802.11n as always.
Remove PHY_802_11n and it related code.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Wed, 16 Sep 2015 01:43:46 +0000 (10:43 +0900)]
staging: wilc1000: remove PANDA_BOARD
This patch removes one of the platform dependencies, PANDA_BOARD from the
driver codes. The device tree will provide the platform dependencies in
the future commits.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Tue, 15 Sep 2015 08:58:18 +0000 (14:28 +0530)]
Staging: most: aim-network: Replace pr_info with netdev_info
Use netdev_* family of macros when there is reference to a network
device. dev->name is removed as netdev_info will print the device
name
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Juston Li [Thu, 17 Sep 2015 02:51:56 +0000 (19:51 -0700)]
staging/lustre: use __noreturn for lbug_with_loc
fixes sparse error:
drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c:149:6: error:
symbol 'lbug_with_loc'redeclared with different type (originally declared at
drivers/staging/lustre/lustre/libcfs/linux/../../../include/linux/libcfs/libcfs_private.h:82)
- different modifiers
Use the __noreturn macro instead of __attribute__((noreturn))
The macro is exactly that but its usage seems more common and
it is bit more readable.
Signed-off-by: Juston Li <juston.h.li@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anjali Menon [Wed, 16 Sep 2015 11:42:21 +0000 (17:12 +0530)]
staging: lustre: lnet: lnet: Removed a space
Removed a space to fix the following coding style warning detected by
checkpatch:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:10 +0000 (12:27 -0400)]
staging/lustre: Remove server defines from lustre_disk.h
Take initial stab at removing server-disk related defines that
client does not need.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:09 +0000 (12:27 -0400)]
staging/lustre: remove IS_MDS|IS_OST|IS_MGS defines and users
These could only happen on the server, so they make no sense
on the client.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:08 +0000 (12:27 -0400)]
staging/lustre: Remove IS_SERVER and all users
Since the client can never be server, this is all dead code.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:07 +0000 (12:27 -0400)]
staging/lustre: remove obd_memory stats counter
Now that we no longer track allocated memory, remove
obd_memory statistics counter and all references to it everywhere
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:06 +0000 (12:27 -0400)]
staging/lustre: Remove lustre used memory tracking framework
Lustre memory allocation framework has a feature to track amount
of allocated memory, but since it's not being used consistently anymore
and is on the way out in general, just remove it.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:05 +0000 (12:27 -0400)]
staging/lustre: Remove memory allocation fault injection framework
Lustre memory allocation wrappers also included a fault injection
framework that's totally redundant, since in-kernel offering is
actually superior to what we had.
So let's remove it.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:04 +0000 (12:27 -0400)]
staging/lustre: Remove unused OBD_ALLOC* and OBD_FREE macros
This removes now unused OBD_ALLOC, OBD_ALLOC_GFP, OBD_ALLOC_PTR,
OBD_ALLOC_LARGE and supporting infrastructure.
Also OBD_FREE, OBD_FREE_PTR, OBD_FREE_LARGE and supporting infrastructure.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:03 +0000 (12:27 -0400)]
staging/lustre: Remove stray bit of userland utils code
The UTILS are userland and I see it's causing confusion
with things beging already converted to kmalloc,
so just remove it.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:02 +0000 (12:27 -0400)]
staging/lustre: Replace last users of OBD_ALLOC/FREE_LARGE
OBD_ALLOC_LARGE is now replaced with libcfs_kvzalloc and
OBD_FREE_LARGE is now replaced with kvfree.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:01 +0000 (12:27 -0400)]
staging/lustre/ptlrpc: Replace OBD_FREE_PTR with kfree
Part of effort of getting rid of custom Lustre alloc/free macros
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:27:00 +0000 (12:27 -0400)]
staging/lustre: Convert lustre_cfg_new/free to use kzalloc/kfree
Part of effort of getting rid of custom Lustre allocation macros
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:26:59 +0000 (12:26 -0400)]
staging/lustre/fld: Replace OBD_ALLOC_GFP with kzalloc
Part of effort to get rid of custom Lustre allocation macros.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:26:58 +0000 (12:26 -0400)]
staging/lustre: Remove references to OBD_ALLOC/FREE* in comments
Since everything is now supposed to use regular kernel alloc and
free functions.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:26:57 +0000 (12:26 -0400)]
staging/lustre/obdclass: replace OBD_ALLOC_GFP with kzalloc
Part of getting rid of custom Lustre allocation macros.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:26:56 +0000 (12:26 -0400)]
staging/lustre/llite: Get rid of OBD_ALLOC/FREE_PTR
The remaining users in ll_open_cleanup and obd_mod_alloc
are converted to regular kzalloc/kfree.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:26:55 +0000 (12:26 -0400)]
staging/lustre: Remove users of OBD_ALLOC/FREE_PTR lu_object.h
These are converted to regular kzalloc/kfree calls.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:26:54 +0000 (12:26 -0400)]
staging/lustre: Remove unused OBD_CPT_ALLOC* macros
OBD_CPT_ALLOC and friends are no longer used, so remove them.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:26:53 +0000 (12:26 -0400)]
staging/lustre: Remove unused OBD_VMALLOC
These macros are not used anymore, so let's remove them,
also __OBD_VMALLOC_VEROBSE and OBD_CPT_VMALLOC
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Wed, 16 Sep 2015 16:26:52 +0000 (12:26 -0400)]
staging/lustre: Remove OBD_CPT_ALLOC_LARGE
Remove OBD_CPT_ALLOC_LARGE define and convert the only user to
libcfs_kvzalloc_cpt.
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:28 +0000 (14:06 +0900)]
staging: wilc1000: wilc_wfi_cfgoperations.h: align defines
This patch fix alignment of some defines in wilc_wfi_cfgoperations.h
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:27 +0000 (14:06 +0900)]
staging: wilc1000: remove if defined codes of FORCE_P2P_CLIENT
This patch removes if defined codes of FORCE_P2P_CLIENT.
This macro is deleted because it it commented out.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:26 +0000 (14:06 +0900)]
staging: wilc1000: remove FORCE_P2P_CLIENT
This patch removes FORCE_P2P_CLIENT that is commented.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:25 +0000 (14:06 +0900)]
staging: wilc1000: remove if defined codes of USE_SUPPLICANT_GO_INTENT
This patch removes if defined codes of USE_SUPPLICANT_GO_INTENT.
This macro is deleted because it is commented out.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:24 +0000 (14:06 +0900)]
staging: wilc1000: remove USE_SUPPLICANT_GO_INTENT
This patch removes USE_SUPPLICANT_GO_INTENT macro that is commented.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:23 +0000 (14:06 +0900)]
staging: wilc1000: fix alignment of enum
This patch fix alignment of enum.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:22 +0000 (14:06 +0900)]
staging: wilc1000: fix alignment of defines
This patch fix alignment of defines.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:21 +0000 (14:06 +0900)]
staging: wilc1000: remove unused defines
The macros are not used anywhere in this driver, so just delete it.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:20 +0000 (14:06 +0900)]
staging: wilc1000: remove bit shift macro that is custom defined
This patch remove bit shift macro that is custom defined, then it is
replaced BIT(x) macro.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:19 +0000 (14:06 +0900)]
staging: wilc1000: use BIT macro
This patch replaces bit shift with BIT(x) macro.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:18 +0000 (14:06 +0900)]
staging: wilc1000: remove useless extern declarations
This patch removes useless extern declarations. This function is not
existed in the driver.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:17 +0000 (14:06 +0900)]
staging: wilc1000: remove commented codes
This patch removes commented codes.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:16 +0000 (14:06 +0900)]
staging: wilc1000: use u32 instead of uint32_t
This patch replaces uint32_t with u32 that is a preferred kernel type.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:15 +0000 (14:06 +0900)]
staging: wilc1000: use u16 instead of uint16_t
This patch replaces uint16_t with u16 that is preferred kernel type.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:14 +0000 (14:06 +0900)]
staging: wilc1000: use u8 instead of uint8_t
This patch replaces uint8_t with u8 that is a preferred kernel type.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:13 +0000 (14:06 +0900)]
staging: wilc1000: rename WILC_WFI_priv
This patch replaces WILC_WFI_priv with wilc_priv to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:12 +0000 (14:06 +0900)]
staging: wilc1000: rename WILC_WFI_cfg80211_ops
This patch replaces WILC_WFI_cfg80211_ops with wilc_cfg80211_ops to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 15 Sep 2015 05:06:11 +0000 (14:06 +0900)]
staging: wilc1000: remove duplicated include
wilc_wfi_cfgoperations.h and linux_wlan_common.h are included as
duplicated in linux_wlan.c.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Joseph [Tue, 15 Sep 2015 09:35:20 +0000 (11:35 +0200)]
staging/rtl8192u: remove unused function
Remove unused function N_DBPSOfRate. This function was only used by
function ComputeTxTime that was removed in the previous
commit
742728f97a99 ("staging: rtl8192u: remove unused function.")
Signed-off-by: Nicolas Joseph <nicolas.joseph@homecomputing.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Tue, 15 Sep 2015 11:52:28 +0000 (17:22 +0530)]
staging: rtl8192e: fix memory leak
If the size of the firmware is not as expected then we are jumping to the
error path but we missed releasing the firmware.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chandra S Gorentla [Tue, 15 Sep 2015 12:39:51 +0000 (18:09 +0530)]
drivers: staging: wilc1000: Add check for SPI availability
NULL pointer deference is observed in the wilc1000.ko module
with bus type SPI and when SPI is not ready.
Signed-off-by: Chandra S Gorentla <csgorentla@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 15 Sep 2015 02:53:35 +0000 (11:53 +0900)]
staging: wilc1000: remove definition WILC_IS_ERR
This patch removes the definition WILC_IS_ERR which is not used anymore.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>