Denis Pithon [Mon, 14 Apr 2014 16:25:30 +0000 (18:25 +0200)]
staging/lustre: fix sparse warning
Fix sparse complaint: "Using plain integer as NULL pointer"
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joshua Baldock [Wed, 2 Apr 2014 08:12:59 +0000 (19:12 +1100)]
Staging: lustre: Fixed syntax errors reported by checkpatch.pl script for file types.h
Added space after ',' and moved '{' to same line as struct as instructed by checkpatch.pl script.
Signed-off-by: Joshua Baldock <joshua.baldock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joshua Baldock [Wed, 2 Apr 2014 08:12:58 +0000 (19:12 +1100)]
Staging: lustre: Corrected styling errors reported by checkpatch.pl script on file ptllnd_wire.h
Moved '{' from new line to same line as struct as advised by checkpatch.pl script.
Signed-off-by: Joshua Baldock <joshua.baldock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joshua Baldock [Wed, 2 Apr 2014 08:12:57 +0000 (19:12 +1100)]
Staging: lustre: Fixed errors reported by checkpatch.pl script for file ptllnd.h
Added space after ',' as reported as error by checkpatch.pl script.
Signed-off-by: Joshua Baldock <joshua.baldock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christoph Jaeger [Thu, 27 Mar 2014 23:21:07 +0000 (00:21 +0100)]
staging: lustre: use __func__ instead of __FUNCTION__
__FUNCTION__ is gcc specific; use __func__ instead.
Signed-off-by: Christoph Jaeger <email@christophjaeger.info>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John de la Garza [Mon, 24 Mar 2014 20:58:02 +0000 (13:58 -0700)]
drivers:staging:lustre Fixed sparse warning: plain integer as NULL pointer
Fixes these sparse warnings:
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:202:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:203:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:204:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:205:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:206:51: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:207:11: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:213:47: warning: Using plain integer as NULL pointer
drivers/staging/lustre/lustre/lmv/lproc_lmv.c:214:11: warning: Using plain integer as NULL pointer
Signed-off-by: John de la Garza <john@jjdev.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Fri, 21 Mar 2014 14:42:52 +0000 (23:42 +0900)]
staging: lustre: Fix typo in lustre/include
Fix spelling typo in comments within lustre/include.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julian Gindi [Sun, 13 Apr 2014 22:38:31 +0000 (18:38 -0400)]
bcm: Fixing a few checkpatch issues in InterfaceMisc.h
Just cleaned up a few issues presented by checkpatch in InterfaceMisc.h.
I converted some spaces to tabs, and removed unnecessary whitespace. The
kernel version I am using linux-next-
20140411.
Signed-off-by: Julian Gindi <juliangindi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Maret [Tue, 15 Apr 2014 10:03:05 +0000 (12:03 +0200)]
staging: binder: add __user annotation in binder.c
Add __user to binder_version to correct sparse warning.
Reduce line size to fit to coding style.
Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Seunghun Lee [Wed, 16 Apr 2014 15:39:44 +0000 (00:39 +0900)]
staging: android: uapi: fix coding style
This patch fix checkpatch.pl warning and errors.
Signed-off-by: Seunghun Lee <waydi1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Garret Kelly [Mon, 7 Apr 2014 03:47:31 +0000 (23:47 -0400)]
staging: goldfish: Fix missing blank lines
Fix two instances of the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Garret Kelly <garret.kelly@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Mon, 24 Mar 2014 23:45:09 +0000 (01:45 +0200)]
staging: goldfish: switch from spinlock to mutex
Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by
the TODO list.
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:52 +0000 (19:44 +0200)]
staging: rtl8723au: Make _rtw_free_network23() static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:51 +0000 (19:44 +0200)]
staging: rtl8723au: Remove bogus inline from rtw_set_roaming() prototype
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:50 +0000 (19:44 +0200)]
staging: rtl8723au: Move rtw23a_roaming() so we can declare _rtw_roaming() static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:49 +0000 (19:44 +0200)]
staging: rtl8723au: collect_bss_info23a(): Use struct ieee80211_mgmt
Somplify code by using struct ieee80211_mgmt to calculate offsets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:48 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused function rtw_get_timestampe_from_ie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:47 +0000 (19:44 +0200)]
staging: rtl8723au: Fold _rtw_free_mlme_priv23a() into rtw_free_mlme_priv23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:46 +0000 (19:44 +0200)]
staging: rtl8723au: Fold rtw_to_roaming() into the code
Simple read variable from a struct function, having it as an external
function is just silly.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:45 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_mlme.c: Clean up mess
Clean up spaghetti formatting and avoid NULL initializing variables
where it isn't needed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:44 +0000 (19:44 +0200)]
staging: rtl8723au: Remove dummy function rtw_hostapd_mlme_rx23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:43 +0000 (19:44 +0200)]
staging: rtl8723au: Remove another unused prototype
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:42 +0000 (19:44 +0200)]
staging: rtl8723au: Fold some resource allocation abstraction into their callers
Fold rtw_os_recvbuf_resource_alloc23a() and
rtw_os_recvbuf_resource_free23a() into the functions calling them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:41 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unnecessary abstraction rtw_os_recv_resource_alloc23a()
No point calling a function to NULL a pointer that was just cleared in
the malloc call.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:40 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused function rtw_os_read_port23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:39 +0000 (19:44 +0200)]
staging: rtl8723au: Clean up namespace clashes with rtl8188eu driver
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:38 +0000 (19:44 +0200)]
staging: rtl8188eu: os_intfs.c: Mark a couple of variables static
Mark these variables local to avoid namespace clash with other RTL
drivers.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:37 +0000 (19:44 +0200)]
staging: rtl8188eu: usb_intf.c: No point processing an empty table
In addition, this would globally disable HT if one device in the
system would mark it unsupported. If any device ended up requiring
this, it should be handled on a per-instance basis.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:36 +0000 (19:44 +0200)]
staging: rtl8723au: os_intfs.c: Declare a couple of local variables static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:35 +0000 (19:44 +0200)]
staging: rtl8723au: init_channel_set(): Restructure variable names
Shorten variable names allowing for fewer broken lines due to the
large number of indents.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:34 +0000 (19:44 +0200)]
staging: rtl8723au: mgmt_dispatcher23a(): Use struct ieee80211_mgmt
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:33 +0000 (19:44 +0200)]
staging: rtl8723au: OnAuth23a(): ieee80211.h-ify
Switch to using struct ieee80211_mgmt to obtain offsets. Again a
bizarre +4 offset was applied for the IE scan which doesn't make
sense, since this offset wasn't applied for the auth struct elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:32 +0000 (19:44 +0200)]
staging: rtl8723au: OnAuth23aClient23a(): Clean up using struct ieee80211_mgmt
Use 80211_mgmt to determine offsets within the received frame. This
also removes a suspicious offset adjustment:
offset = ieee80211_has_protected(hdr->frame_control) ? 4: 0;
which didn't make any sense, since it was only applied to determining
the auth, sequence number, and status, but wasn't applied to the
location of the IEs.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:31 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocRsp23a() use ieee80211_mgmt to obtain DA
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:30 +0000 (19:44 +0200)]
staging: rtl8723au: OnAction23a_back23a(): Use struct ieee8011_mgmt to parse action frames
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:29 +0000 (19:44 +0200)]
staging: rtl8723au: OnAction23a(): Use struct ieee80211_mgmt instead of hardcoded offsets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:28 +0000 (19:44 +0200)]
staging: rtl8723au: update_TSF() remove unused argument and move to rtw_mlme_ext.c
This is only called from rtw_mlme_ext.c, so move it that and declare
it static.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:27 +0000 (19:44 +0200)]
staging: rtl8723au: clean up update_TSF()
Clean up and simplify update_TSF() using proper Linux functions and
move it to rtw_mlme_ext.c which is the only user of it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:26 +0000 (19:44 +0200)]
staging: rtl8723au: OnBeacon23a() tidy up code
Clean up the excessive if() levels at the end, and use struct
ieee80211_mgmt to calculate pointers passed on to check_assoc_AP23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:25 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_mlme.c: remove commented out debug code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:24 +0000 (19:44 +0200)]
staging: rtl8723au: Remove buggy function _rtw_report_sec_ie()
This function was extremely buggy calling kmalloc(GFP_KERNEL) while
holding a spin lock and then potentially overflowing the buffer it had
allocated.
Since the generated output wasn't used for anything, simply rip the
whole thing out.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:23 +0000 (19:44 +0200)]
staging: rtl8723au: OnProbeReq23a(): is_valid_p2p_probereq is always false
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:22 +0000 (19:44 +0200)]
staging: rtl8723au: OnProbeReq23a(): Use struct ieee80211_mgmt
Simplify parsing of probe request frame
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:21 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocReq23a(): use ieee80211_mgmt to calculate offset
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:20 +0000 (19:44 +0200)]
staging: rtl8723au: ioctl_cfg80211.c: Use eth_{zero,broadcast},addr()
Use kernel provided macros instead of own hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:19 +0000 (19:44 +0200)]
staging: rtl8723au: Remove some unused ieee80211 structs
These are duplicated from the kernel headers and not used anymore
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:18 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused ieee880211_is_empty_essid()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:17 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused dump_wpsie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:16 +0000 (19:44 +0200)]
staging: rtl8723au: Remove struct rtw_ieee802_11_elems and related code
This removes the double content tracking of data from IE elements. The
relevant code to validate IEs is moved to rtw_mlme_ext.c as this is
the only place where it is used.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:15 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocReq23a(): Use cfg80211_find_ie() to locate HT caps
Use cfg80211 interface to search for HT capabilities.
This was the last user of struct rtw_ieee802_11_elems, which can now
be removed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:14 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocReq23a(): Don't check for presence of BSSID twice
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:13 +0000 (19:44 +0200)]
staging: rtl8723au: OnAssocReq23a(): Simplify parsing crypto info from the IE
This reduces the dependency of rtw_ieee802_11_parse_elems23a() which
is only used in this function. Follow-on patches will remove the
remaining dependencies and get rid of the function.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:12 +0000 (19:44 +0200)]
staging: rtl8723au: update_bcn_vendor_spec_ie(): Go easy on those brackets
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:11 +0000 (19:44 +0200)]
staging: rtl8723au: Remove multiple duplicate defines of the WPA OUI
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:10 +0000 (19:44 +0200)]
staging: rtl8723au: Remove unused for_each_ie() and dump_ies23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:09 +0000 (19:44 +0200)]
staging: rtl8723au: Remove obsolete rtw_get_wpa{2,}_ie23a() functions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:08 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Remove unused variable 'pos'
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:07 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Use cfg80211_ API
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:06 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Use cfg80211 to find WPA info
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:05 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Remove excessive brackets
Remove excessive brackets and some general cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:04 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_get_cipher_info(): Convert to use cfg80211_* API
Use cfg80211_find_ie() and cfg80211_find_vendor_ie() rather than own
hacks.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:03 +0000 (19:44 +0200)]
staging: rtl8723au: Use const * for parsing wpa IEs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:02 +0000 (19:44 +0200)]
staging: rtl8723au: start_bss_network(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:01 +0000 (19:44 +0200)]
staging: rtl8723au: update_sta_support_rate23a(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:44:00 +0000 (19:44 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Clean up code obfuscation
There is no point doing a double check of the IE, either we found an
WLAN_EID_SSID or we didn't.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:59 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:58 +0000 (19:43 +0200)]
staging: rtl8723au: Make rtw_check_bcn_info23() take a ieee80211_mgmt pointer
Clean up the code by passing a struct ieee80211_mgmt pointer instead
of a raw frame pointer. In addition check we receive a beacon frame,
anything else here is an error.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:57 +0000 (19:43 +0200)]
staging: rtl8723au: OnBeacon23a(): Use ieee80211_mgmt to calculate ie location
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:56 +0000 (19:43 +0200)]
staging: rtl8723au: OnBeacon23a(): Use struct ieee80211_mgmt
We always receive a struct ieee80211_mgmt frame here, using just
ieee80211_hdr doesn't make sense.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:55 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_get_cur_max_rate23a(): use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:54 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_update_protection23a(): Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:53 +0000 (19:43 +0200)]
staging: rtl8723au: Make mlme_handlers and action_handlers return int
In addition, make them all static and move the prototypes to
rtw_mlme_ext.c.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:52 +0000 (19:43 +0200)]
staging: rtl8723au: OnAssocReq23a(): Clean up and use more ieee80211.h
This converts it to use struct ieee80211_mgmt and cfg80211_find_ie().
In addition fix a potential buffer overrun in the last loop searching
through list WLAN_EID_VENDOR_SPECIFIC elements.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:51 +0000 (19:43 +0200)]
staging: rtl8723au: issue_probersp23a(): various cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:50 +0000 (19:43 +0200)]
staging: rtl8723au: issue_asocrsp23a(): Use cfg80211_find_ie() and cleanups
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:49 +0000 (19:43 +0200)]
staging: rtl8723au: issue_assocreq23a(): General cleanups and use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:48 +0000 (19:43 +0200)]
staging: rtl8723au: issue_action_BSSCoexistPacket(): Clean + use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:47 +0000 (19:43 +0200)]
staging: rtl8723au: collect_bss_info23a(): Convert to use cfg80211_fine_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:46 +0000 (19:43 +0200)]
staging: rtl8723au: process_80211d() use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:45 +0000 (19:43 +0200)]
staging: rtl8723au: OnAction23_back23a() Use ieee80211_mgmt and bug fixes
This converts OnAction23a_back23a() to using struct ieee80211_mgmt to
parse the response packet. In addition this revealed a bug which has
been fixed:
case WLAN_ACTION_ADDBA_RESP: /* ADDBA response */
status = get_unaligned_le16(&frame_body[3]);
tid = ((frame_body[5] >> 2) & 0x7);
The above masks the tid to 3 bits, however per ieee80211.h, the tid is
in fact 4 bits wide, as defined by IEEE80211_ADDBA_PARAM_TID_MASK (0x3c)
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:44 +0000 (19:43 +0200)]
staging: rtl8723au: OnDisassoc23(): Use ieee80211_mgmt
Use proper kernel ieee80211.h defined headers to parse the response.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:43 +0000 (19:43 +0200)]
staging: rtl8723au: OnDeAuth23a() use ieee80211 header defines
Use the proper ieee80211.h structs to parse the response instead of
hard coded offsets.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:42 +0000 (19:43 +0200)]
staging: rtl8723au: OnAssocRsp23a() use ieee80211 header defines
Use the proper ieee80211.h structs to parse the response instead of
hard coded offsets.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:41 +0000 (19:43 +0200)]
staging: rtl8723au: OnAuth23aClient23a() Use cfg80211_find_ie()
Use cfg80211_find_ie() and tidy up the code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:40 +0000 (19:43 +0200)]
staging: rtl8723au: OnAuth23() Use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:39 +0000 (19:43 +0200)]
staging: rtl8723au: OnProbeReq23a() Use cfg80211_find_ie()
Switch to using cfg80211_find_ie() and tidy of the code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:38 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_update_ht_ie23a(): use cfg80211_find_ie()
Switch to using cfg80211_find_ie() and remove commented out code.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:37 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_restructure_ht_ie23a(): use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:36 +0000 (19:43 +0200)]
staging: rtl8723au: Remove another stack of unused P2P related #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:35 +0000 (19:43 +0200)]
staging: rtl8723au: Remove P2P/WiFiDirect/WiFiDisplay code
Discussing with Johannes Berg and Larry Finger, we have concluded that
this code really should be handled through wpa_supplicant, and not in
the kernel.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:34 +0000 (19:43 +0200)]
staging: rtl8723au: Remove obsolete local defines matching WLAN_EID_*
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:33 +0000 (19:43 +0200)]
staging: rtl8723au: Fixup last users to use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:32 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_recv.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:31 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_xmit.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:30 +0000 (19:43 +0200)]
staging: rtl8723au: rtl8723a_cmd.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:29 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_wlan_util.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:28 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_ieee80211.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:27 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_p2p.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:26 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_ap.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 15 Apr 2014 17:43:25 +0000 (19:43 +0200)]
staging: rtl8723au: rtw_mlme.c: Use the kernel's WLAN_EID_* definitions
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>