Amitoj Kaur Chawla [Sat, 20 Feb 2016 08:28:27 +0000 (13:58 +0530)]
staging: rdma: hfi1: Use DIV_ROUND_UP
The kernel.h macro DIV_ROUND_UP performs the computation
(((n) + (d) - 1) /(d)) but is perhaps more readable.
The Coccinelle script used is as follows:
// <smpl>
@@
expression n,d;
@@
(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)
@@
expression n,d;
@@
- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)
@@
expression n,d;
@@
- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Mon, 15 Feb 2016 19:25:25 +0000 (00:55 +0530)]
staging: rdma: hfi1: Replace kmalloc and memcpy with kmemdup
Replace kmalloc and memcpy with kmemdup. Found using Coccinelle.
The semantic patch used to make this change can be found here:
scripts/coccinelle/api/memdup.cocci
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fu Yong Quah [Sat, 20 Feb 2016 10:23:14 +0000 (10:23 +0000)]
staging: wlan-ng: fix NULL comparison
Fix NULL equality comparision by changing it with exclamation mark,
as suggested by Documentation/CodingStyle
Signed-off-by: Fu Yong Quah <fuyong@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Wed, 17 Feb 2016 17:36:14 +0000 (23:06 +0530)]
staging: wlan-ng: Remove flush_scheduled_work
flush_scheduled_work() is scheduled for deprecation. Use
cancel_work_sync() instead to ensure that there is no pending or
running work item.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Wed, 17 Feb 2016 16:50:09 +0000 (22:20 +0530)]
Staging: wlan-ng: Remove unused functions and prototypes
hfa384x_drvr_getconfig_async is not used anywhere in the kernel
so remove it. Also remove its prototype from the header file. Also
the function hfa384x_cb_rrid was only used by hfa384x_drvr_getconfig_async
so remove its definition and prototype as well.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Wed, 17 Feb 2016 16:50:08 +0000 (22:20 +0530)]
Staging: wlan-ng: Remove function hfa384x_drvr_commtallies
The function hfa384x_drvr_commtallies is not used anywhere in the kernel
so remove it. Also remove its prototype from the header file.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 10:59:39 +0000 (18:59 +0800)]
staging: iio: resolver: fix comparison to NULL
Remove comparison of spi->dev.platform_data to NULL by replacing it with
'!spi->dev.platform_data' as checkpatch suggested:
CHECK: Comparison to NULL could be written "!spi->dev.platform_data"
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 10:59:38 +0000 (18:59 +0800)]
staging: iio: resolver: remove unnecessary blank line
Delete the excess newline. Issue found by checkpatch.
CHECK: Please don't use multiple blank lines
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 10:59:37 +0000 (18:59 +0800)]
staging: iio: resolver: delete space after a cast
Delete unwanted whitespace after casting. Issue pointed out by
checkpatch.
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 10:59:36 +0000 (18:59 +0800)]
staging: iio: resolver: add missing braces on if-else statements
Add braces around the else clause to adhere to kernel coding style. This
clears the following checkpatch issue:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 10:59:35 +0000 (18:59 +0800)]
staging: iio: resolver: use blank line after array declaration
Add a blank line after array declaration. This clears the checkpatch
check:
CHECK: Please use a blank line after function/struct/union/enum
declarations
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 10:59:34 +0000 (18:59 +0800)]
staging: iio: resolver: add spaces around operators
Add spaces around operators to improve readability and to address the
checkpatch issue:
CHECK: spaces preferred around that '/' (ctx:VxV)
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 10:59:33 +0000 (18:59 +0800)]
staging: iio: resolver: align to match open parenthesis
Use a combination of tabs and spaces to align parameters to its
corresponding open parenthesis. Checkpatch found this issue.
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 07:35:40 +0000 (15:35 +0800)]
staging: iio: light: fix multiple assignments in a single line
Rewrite the multiple assignments to clear checkpatch check:
CHECK: multiple assignments should be avoided
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 07:35:39 +0000 (15:35 +0800)]
staging: iio: light: add space around '*"
Address checkpatch check pointing out the lack of space around the
operator '*'.
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 07:35:38 +0000 (15:35 +0800)]
staging: iio: light: fix block comments according to kernel coding style
Add the trailing */ accordingly to suit the preferred way of placing
block comments.
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 07:35:37 +0000 (15:35 +0800)]
staging: iio: light: omit space after a cast
Remove the unneeded space as pointed out by checkpatch:
CHECK: No space is necessary after a cast
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Thu, 18 Feb 2016 07:35:36 +0000 (15:35 +0800)]
staging: iio: light: indent to match open parenthesis
Indent the parameters to match open parenthesis as suggested by checkpatch.
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Janani Ravichandran [Thu, 18 Feb 2016 21:22:29 +0000 (16:22 -0500)]
staging: iio: accel: Remove unnecessary else after goto in if block
This patch removes the unnecessary else following an if block with a
goto statement.
Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Tue, 16 Feb 2016 18:14:31 +0000 (23:44 +0530)]
staging: iio: adc: Remove unnecessary test from if conditions
Remove unnecessary test condition on ret variable which has been
previously tested and returns its value if the value is non zero.
This fixes the following smatch warnings:
drivers/staging/iio/adc/ad7816.c:299 ad7816_set_oti() warn: we tested
'ret' before and it was 'false'
drivers/staging/iio/adc/ad7816.c:306 ad7816_set_oti() warn: we tested
'ret' before and it was 'false'
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Sat, 20 Feb 2016 21:42:11 +0000 (03:12 +0530)]
Staging: wilc1000: Remove and rename struct typedefs from .c files
Using typedef for a structure type is not suggested in Linux kernel coding
style guidelines. So remove typedefs from structures wilc_sdio_t,
wilc_spi_t and wilc_mac_cfg_t.
Also remove '_t' suffix from the struct names by hand.
The following semantic patch detects cases:
@tn1@
type td;
@@
typedef struct { ... } td;
@script:python tf@
td << tn1.td;
tdres;
@@
coccinelle.tdres = td;
@@ type tn1.td;
identifier tf.tdres;
@@
-typedef
struct
+ tdres
{ ... }
-td
;
@@ type tn1.td;
identifier tf.tdres;
@@
-td
+ struct tdres
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Sat, 20 Feb 2016 18:00:25 +0000 (23:30 +0530)]
Staging: wilc1000: Remove unused function WILC_WFI_update_stats
This patch removes the function WILC_WFI_update_stats as it is not used
anywhere in the kernel. Also remove its declaration from the header
file. Grepped to find the occurences.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Fri, 19 Feb 2016 13:43:52 +0000 (19:13 +0530)]
Staging: lustre: lnet: Remove and rename struct typedef lstcon_session_t
This patch gets rid of struct typedef lstcon_session_t as it is not
suggested to use typdefs for structure types. Also drop '_t' from the name.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Thu, 18 Feb 2016 18:06:12 +0000 (23:36 +0530)]
staging: lustre: Replace __attribute__((packed)) with __packed
This patch fixes the following checkpatch.pl warning:
"WARNING: __packed is preferred over __attribute__((packed))".
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Janani Ravichandran [Thu, 18 Feb 2016 22:15:48 +0000 (17:15 -0500)]
staging: lustre: lustre: Remove unneeded else after goto
Remove unnecessary else following an if block with a goto statement.
Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Janani Ravichandran [Thu, 18 Feb 2016 21:52:45 +0000 (16:52 -0500)]
staging: lustre: lustre: Remove unnecessary else after return
Else is unnecessary when there is a return statement in the
corresponding if block. Coccinelle patch used:
@rule1@
expression e1;
@@
if (e1) { ... return ...; }
- else{
...
- }
@rule2@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
- else
s1
Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Tue, 16 Feb 2016 19:31:58 +0000 (01:01 +0530)]
Staging: lustre: lov: Pull assignments out of function call
Assignments in function call arguments are undesirable. So pull such
assignments out before function call.
Made a coccinelle script to detect such cases:
@@
expression fn,b,d;
@@
* fn(...,d=b,...);
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Tue, 16 Feb 2016 13:44:12 +0000 (19:14 +0530)]
staging: lustre: osc: osc_request: Declare local function and structure as static
Declare osc_cleanup() function and osc_obd_ops structure as static
since they are defined and called only in this file.
Removed osc_cleanup() function prototype since it wasn't required.
This fixes the following sparse warnings:
drivers/staging/lustre/lustre/osc/osc_request.c:3210:5: warning:
symbol 'osc_cleanup' was not declared. Should it be static?
drivers/staging/lustre/lustre/osc/osc_request.c:3259:16: warning:
symbol 'osc_obd_ops' was not declared. Should it be static?
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Tue, 16 Feb 2016 11:49:35 +0000 (17:19 +0530)]
staging: lustre: obdclass: obd_mount: Declare function as static
Declare lustre_mount() function static since it is defined and called in this
file only.
This fixes the following sparse warning:
drivers/staging/lustre/lustre/obdclass/obd_mount.c:1169:15: warning:
symbol 'lustre_mount' was not declared. Should it be static?
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shalin Mehta [Mon, 15 Feb 2016 03:37:02 +0000 (19:37 -0800)]
staging: lustre: Fixed the parenthesis
The parentehsis are fixed in the macro for the ldlm lock to set and
clear the flags.
Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com>
Acked-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:17 +0000 (00:47 -0500)]
staging/lustre: Convert cfs_str2num_check to use kstrtoul
simple_strtoul is obsolete
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:16 +0000 (00:47 -0500)]
staging/lustre: Convert cfs_trace_daemon_command to use kstrtoul
simple_strtoul is obsolete
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:14 +0000 (00:47 -0500)]
staging/lustre: Remove space after cast in cfs_crypto_hash_final()
This is against kernel-code style.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:13 +0000 (00:47 -0500)]
staging/lustre/libcfs: Get rid of multiple assignments
They make checkpatch unhappy, and I guess overall might confuse
people too.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:12 +0000 (00:47 -0500)]
staging/lustre: Get rid of cfs_trace_buf_type_t typedef
Replace it with enum cfs_trace_buf_type
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:11 +0000 (00:47 -0500)]
staging/lustre: Update cfs_cpu_notify switch statement with a comment
We do really mean to fall through to that default case statement from
all previous ones, so add a comment to unconfuse verious tools
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:10 +0000 (00:47 -0500)]
staging/lustre/libcfs: Remove empty lines after/before braces
No need for an empty line after opening curvy brace and no need
for an empty line before the closing one too.
Remove them.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:09 +0000 (00:47 -0500)]
staging/lustre/libcfs: Remove useless returns in void functions
Return at the end of a void function does not serve any particular
purpose and makes checkpatch unhappy, so eliminate them.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:08 +0000 (00:47 -0500)]
staging/lustre/libcfs: Update comments style to match kernel
checkpatch complains that the trailing */ on the multiline comments
should be on it's own line.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:07 +0000 (00:47 -0500)]
staging/lustre/libcfs: Move private tracefile structs out of header
the struct page_collection, struct cfs_trace_page and
struct tracefiled_ctl are only used by tracefile.c, so move them
there.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:06 +0000 (00:47 -0500)]
staging/lustre/libcfs: Remove unused cfs_tcd_owns_tage() function
Does not appear to be used anywhere.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:05 +0000 (00:47 -0500)]
staging/lustre/libcfs: Shortened too long lines
Lines that were too long for not good reason were shortened in this patch.
Found with checkpatch.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:04 +0000 (00:47 -0500)]
staging/lustre/libcfs: Remove stray spaces after function name
Problem highlighted by checkpatch.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:03 +0000 (00:47 -0500)]
staging/lustre/libcfs: reformat cfs_tcd_for_each_type_lock define
Avoid using leading spaces that make checkpatch unhappy.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:02 +0000 (00:47 -0500)]
staging/lustre/libcfs: style change to add missing spaces for operations
This fixes checkpatch messages about
"spaces preferred around that '-' (ctx:VxV)"
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:01 +0000 (00:47 -0500)]
staging/lustre/libcfs: Move EXPORT_SYMBOLs under function/variable
Found with checkpatch
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:47:00 +0000 (00:47 -0500)]
staging/lustre/libcfs: Cleanup: parenthesis alignment adjustments
Adjust alignment of argments that were pushed to next lines
to conform to kernel code style.
Found with checkpatch.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:59 +0000 (00:46 -0500)]
staging/lustre: Remove the "write to FSF to get a copy of GPL" wording
Checkpatch highlighted that some of our Lustre files carry this
extra paragraph and indeed it does seem somewhat redundant, so remove it.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:58 +0000 (00:46 -0500)]
staging/lustre/ptlrpc: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:57 +0000 (00:46 -0500)]
staging/lustre/osc: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:56 +0000 (00:46 -0500)]
staging/lustre/obdecho: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:55 +0000 (00:46 -0500)]
staging/lustre/obdclass: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:54 +0000 (00:46 -0500)]
staging/lustre/mgc: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:53 +0000 (00:46 -0500)]
staging/lustre/mdc: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:52 +0000 (00:46 -0500)]
staging/lustre/include: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:51 +0000 (00:46 -0500)]
staging/lustre/lclient: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:50 +0000 (00:46 -0500)]
staging/lustre/fld: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:49 +0000 (00:46 -0500)]
staging/lustre/fid: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:48 +0000 (00:46 -0500)]
staging/lustre/lmv: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:47 +0000 (00:46 -0500)]
staging/lustre/ldlm: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:46 +0000 (00:46 -0500)]
staging/lustre/llite: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
The only exception is ll_update_inode where dropping != NULL
in the construction below would break the logic.
I guess we could change lsm != NULL to !!lsm, but that's uglier.
(lsm != NULL) == ((body->valid & OBD_MD_FLEASIZE) != 0)
Also removed some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:45 +0000 (00:46 -0500)]
staging/lustre/lov: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also removed some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:44 +0000 (00:46 -0500)]
staging/lustre/libcfs: Adjust NULL comparison codestyle
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also removed some redundant assertions.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:43 +0000 (00:46 -0500)]
staging/lustre/osc: Remove commented out osc_page_protected()
The complicated version of osc_page_protected and osc_page_is_dlocked
are unsafe and were commented out for ages, so probably no point in
carrying them on.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:42 +0000 (00:46 -0500)]
staging/lustre: Remove commented out lock_lock_multi_match
lock_lock_multi_match stayed commented out unused for ages now,
so let's just remove it.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:41 +0000 (00:46 -0500)]
staging/lustre: Remove server code from class_get_type()
class_get_type has some references to various server modules
that could not exist on the server, so get rid of them.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:40 +0000 (00:46 -0500)]
staging/lustre: Remove server code from client_obd_setup()
In client_obd_setup references to LUSTRE_OSP_NAME could only
happen on metadata servers, so remove them as never true
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:39 +0000 (00:46 -0500)]
staging/lustre: Remove unused osc_on_mdt function
This only makes sense on metadata server, so get rid of it.
Also remove now unused MDS_OSC_MAX_RIF_DEFAULT define
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:38 +0000 (00:46 -0500)]
staging/lustre: Remove unused function oti_init
All the users seems to have disappeared.
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:37 +0000 (00:46 -0500)]
staging/lustre/lov: Get rid of /proc references in comments
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:36 +0000 (00:46 -0500)]
staging/lustre/llite: Get rid of /proc references in comments
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:35 +0000 (00:46 -0500)]
staging/lustre/libcfs: Get rid of /proc references in comments
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:34 +0000 (00:46 -0500)]
staging/lustre/obdclass: Get rid of /proc references in comments.
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oleg Drokin [Tue, 16 Feb 2016 05:46:33 +0000 (00:46 -0500)]
staging/lustre/ptlrpc: Get rid of /proc references in comments
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amir Shehata [Mon, 15 Feb 2016 15:25:54 +0000 (10:25 -0500)]
staging: lustre: DLC Feature dynamic net config
This is the third patch of a set of patches that enables DLC.
This patch adds the following features to LNET. Currently these
features are not driven by user space.
- Adding/Deleting Networks dynamically
Two new functions were added:
- lnet_dyn_add_ni()
add an NI. if the NI is already added then fail with
appropriate error code
- lnet_dyn_del_ni()
delete an existing NI. If NI doesn't exist fail with
appropriate failure code.
These functions shall be called from IOCTL.
Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2456
Reviewed-on: http://review.whamcloud.com/9832
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amir Shehata [Mon, 15 Feb 2016 15:25:53 +0000 (10:25 -0500)]
staging: lustre: Dynamic LNet Configuration (DLC) dynamic routing
This is the second patch of a set of patches that enables DLC.
This patch adds the following features to LNET. Currently these
features are not driven by user space.
- Enabling Routing on Demand. The default number of router
buffers are allocated.
- Disable Routing on demand. Unused router buffers are freed and
used router buffers are freed when they are no longer in use.
The following time routing is enabled the default router buffer
values are used. It has been decided that remembering the
user set router buffer values should be remembered and re-set
by user space scripts.
- Increase the number of router buffers on demand, by allocating
new ones.
- Decrease the number of router buffers. Exccess buffers are freed
if they are not in use. Otherwise they are freed once they are
no longer in use.
Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2456
Change-Id: Id07d4ad424d8f5ba72475d4149380afe2ac54e77
Reviewed-on: http://review.whamcloud.com/9831
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amir Shehata [Mon, 15 Feb 2016 15:25:52 +0000 (10:25 -0500)]
staging: lustre: Dynamic LNet Configuration (DLC)
This is the first patch of a set of patches that enables DLC.
This patch adds some cleanup in the config.c as well as some
preparatory changes in peer.c to enable dynamic network
configuration
Signed-off-by: Amir Shehata <amir.shehata@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2456
Change-Id: I8c8bbf3b55acf4d76f22a8be587b553a70d31889
Reviewed-on: http://review.whamcloud.com/9830
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Frank Zago [Mon, 15 Feb 2016 15:25:51 +0000 (10:25 -0500)]
staging: lustre: do not memset after LIBCFS_ALLOC
LIBCFS_ALLOC already zero out the memory allocated, so there is no
need to zero out the memory again.
Signed-off-by: Frank Zago <fzago@cray.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5304
Reviewed-on: http://review.whamcloud.com/11012
Reviewed-by: Patrick Farrell <paf@cray.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Liang Zhen [Mon, 15 Feb 2016 15:25:50 +0000 (10:25 -0500)]
staging: lustre: return +ve for blocked lnet message
returned value of lnet_post_send_locked and
lnet_post_routed_recv_locked are changed to -ve by:
http://review.whamcloud.com/#/c/9369/
this is wrong because callers rely on +ve to identify blocked
message which is not a failure.
To respect linux kernel coding style and not use positive error
code, this patch adds two macros as non-error returned values of
these functions:
LNET_CREDIT_OK has credit for message
LNET_CREDIT_WAIT no credit and message is blocked
both these functions will return these two values instead of 0
and EAGAIN
Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Signed-off-by: James Simmons <uja.ornl@gmail.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5151
Reviewed-on: http://review.whamcloud.com/10625
Reviewed-by: Chris Horn <hornc@cray.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John L. Hammond [Mon, 15 Feb 2016 15:25:49 +0000 (10:25 -0500)]
staging: lustre: remove uses of IS_ERR_VALUE()
Remove most uses of IS_ERR_VALUE(). This macro was often given an int
argument coming from PTR_ERR(). This invokes implementation defined
behavior since the long value gotten by applying PTR_ERR() to a kernel
pointer will usually not be representable as an int. Moreover it may
be just plain wrong to do this since the expressions IS_ERR(p) and
IS_ERR_VALUE((int) PTR_ERR(p)) are not equivalent for a general
pointer p.
Signed-off-by: John L. Hammond <john.hammond@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3498
Reviewed-on: http://review.whamcloud.com/6759
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Mon, 15 Feb 2016 15:25:48 +0000 (10:25 -0500)]
staging: lustre: eliminate obsolete Cray SeaStar support
Remove the bulk of code for the no longer supported
SeaStar interconnect found on older Cray systems.
Signed-off-by: James Simmons <uja.ornl@gmail.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1422
Reviewed-on: http://review.whamcloud.com/7469
Reviewed-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: Chuck Fossen <chuckf@cray.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Liang Zhen [Mon, 15 Feb 2016 15:25:47 +0000 (10:25 -0500)]
staging: lustre: fix failure handle of create reply
error handler of lnet_create_reply_msg() didn't release lnet_res_lock
if lnet_msg_alloc() failed.
It can be fixed by moving validation check of msg out from lock.
Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2745
Reviewed-on: http://review.whamcloud.com/5542
Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chris Horn [Mon, 15 Feb 2016 15:25:46 +0000 (10:25 -0500)]
staging: lustre: reflect down routes in /proc/sys/lnet/routes
We consider routes "down" if the router is down or the router
NI for the target network is down. This should be reflected
in the output of /proc/sys/lnet/routes
Signed-off-by: Chris Horn <hornc@cray.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3679
Reviewed-on: http://review.whamcloud.com/7857
Reviewed-by: Cory Spitz <spitzcor@cray.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chris Horn [Mon, 15 Feb 2016 15:25:45 +0000 (10:25 -0500)]
staging: lustre: rename variables in lnet_find_route_locked
Rename several variables in lnet_find_route_locked to make
the code easier to understand. Broken out of patch 7857.
Signed-off-by: Chris Horn <hornc@cray.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3679
Reviewed-on: http://review.whamcloud.com/7857
Reviewed-by: Cory Spitz <spitzcor@cray.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Fri, 19 Feb 2016 13:29:20 +0000 (18:59 +0530)]
Staging: wilc1000: Remove and rename struct typedefs
This patch gets rid of struct typedefs wilc_cfg_byte_t, wilc_cfg_hword_t,
wilc_cfg_word_t and wilc_cfg_str_t as as linux kernel coding style
guidelines suggest not using typdefs for structure types.
Also drop '_t' from the names.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Wed, 17 Feb 2016 15:11:03 +0000 (20:41 +0530)]
staging: wilc1000: Return correct error codes
This change has been made with the goal that kernel functions should
return something more descriptive than -1 on failure.
The return value on an alloc_etherdev failure should be -ENOMEM,
and not -1.
This was found using Coccinelle. A simplified version of the semantic
patch used is:
//<smpl>
@@
expression *e;
identifier l1;
@@
e = alloc_etherdev(...);
if (e == NULL) {
...
return
- -1
+ -ENOMEM
;
}
//</smpl
Furthermore, introduced `ret` variable to store and return the
corresponding error code returned by register_netdev on failure.
The two call sites store the return value in a variable which only
checks that the value is non-zero, hence no change is required at
the call sites.
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Janani Ravichandran [Tue, 16 Feb 2016 22:27:03 +0000 (17:27 -0500)]
staging: wilc1000: Rearrange statement to respect 80 char limit
Split statement across multiple lines as the line modified is over 80
chars in length.
Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Janani Ravichandran [Tue, 16 Feb 2016 22:24:52 +0000 (17:24 -0500)]
staging: wilc1000: Use kmalloc_array instead of kmalloc
Use kmalloc_array instead of kmalloc for arrays to prevent integer
overflows.
Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Janani Ravichandran [Tue, 16 Feb 2016 19:07:00 +0000 (14:07 -0500)]
staging: wilc1000: Modify tcp_process to return void rather than int
tcp_process() returns int, which is not used anywhere. So, change
function header to return void intead of int and remove all uses of
the local variable ret, which is used as a return variable in the
function.
Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Tue, 16 Feb 2016 13:06:00 +0000 (18:36 +0530)]
staging: wilc1000: Remove unused function
Remove wilc_wlan_global_reset function since it is not used anywhere
in this driver.
This also silences the following sparse warning:
drivers/staging/wilc1000/wilc_wlan.c:1120:6: warning: symbol
'wilc_wlan_global_reset' was not declared. Should it be static?
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roger H. Newell [Tue, 16 Feb 2016 12:55:42 +0000 (09:25 -0330)]
staging: wilc1000: Removed braces from single block statements
This patch corrects warnings generated by checkpatch.pl by
removing braces from single block statements.
Signed-off-by: Roger H. Newell <newell.roger@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roger H. Newell [Tue, 16 Feb 2016 12:54:56 +0000 (09:24 -0330)]
staging: wilc1000: Whitespaces removed from function call
This patch corrects errors generated by checkpatch.pl by
removing whitespace between parameters passed to dev_err()
Signed-off-by: Roger H. Newell <newell.roger@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 16 Feb 2016 08:39:55 +0000 (17:39 +0900)]
staging: wilc1000: handle_set_mac_address: use netdev_err
This patch uses netdev_err instead of PRINT_ER that is a custom debug
print.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 16 Feb 2016 08:39:54 +0000 (17:39 +0900)]
staging: wilc1000: handle_set_mac_address: rename result
This patch renames result to ret that is used to get return value from
wilc_send_config_pkt. It will be changed until all handle_*() function
has same variable name as ret.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 16 Feb 2016 08:39:53 +0000 (17:39 +0900)]
staging: wilc1000: handle_set_mac_address: change data type of result
result variable gets value from wilc_send_config_pkt that has return
value of int. This patch changes data type of result variable to int.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 16 Feb 2016 08:39:52 +0000 (17:39 +0900)]
staging: wilc1000: handle_set_mac_address: change return type to void
When handle_set_mac_address is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes a brace of if statement due to
have a single statement.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 16 Feb 2016 08:39:51 +0000 (17:39 +0900)]
staging: wilc1000: handle_set_mac_address: use kmemdup
This patch replaces kmalloc followed by memcpy with kmemdup.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 16 Feb 2016 08:39:50 +0000 (17:39 +0900)]
staging: wilc1000: handle_set_mac_address: fix kmalloc return error code
This patch fix return error code of kmalloc as -ENOMEM instead of
-EFAULT.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 16 Feb 2016 08:39:49 +0000 (17:39 +0900)]
staging: wilc1000: handle_set_mac_address: remove debug message of kmalloc failure
There is no need to print debug message when kmalloc is failed. This
message is redundant. The code already show us that kmalloc is failed.
The brace of if statement is remove as well due to have a single
statement.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Tue, 16 Feb 2016 08:30:35 +0000 (00:30 -0800)]
staging: wilc1000: host_interface: remove unused semaphores
Remove unused semaphore declarations, initializations, and unlocks.
The functions that locked these semaphores were previously removed,
so this cleans up the remains.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / openwrt / staging / blogic.git / log