Malcolm Priestley [Mon, 19 May 2014 19:33:10 +0000 (20:33 +0100)]
staging: vt6656: BBvUpdatePreEDThreshold reorganize ControlvWriteByte.
Create variables cr_201 and cr 206 with values for registers 0xc9 and 0xce.
Set both to zero .
If cr201 and cr206 are zero drop out.
write both out with ControlvWriteByte.
pDevice->byBBPreEDIndex breaks will be dealt with in next patch
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:09 +0000 (20:33 +0100)]
staging: vt6656: BBvUpdatePreEDThreshold replace debug messages.
Replace DBG_PRT with single dev_dbg with calling function
and byBBPreEDRSSI value.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:08 +0000 (20:33 +0100)]
staging: vt6656: BBvExitDeepSleep remove camel case.
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:07 +0000 (20:33 +0100)]
staging: vt6656: BBvSetDeepSleep remove camel case
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:06 +0000 (20:33 +0100)]
staging: vt6656: BBvSetVGAGainOffset remove camel case
pDevice -> priv
byData -> data
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:05 +0000 (20:33 +0100)]
staging: vt6656: BBvSetShortSlotTime remove camel case.
pDevice -> priv
byBBVGA -> bb_vga
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:04 +0000 (20:33 +0100)]
staging: vt6656: BBvSetAntennaMode remove camel case.
changes
pDevice -> priv
byAntennaMode -> antenna_mode
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:03 +0000 (20:33 +0100)]
staging: vt6656: clean up BBvSetAntennaMode.
white space clean up.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:02 +0000 (20:33 +0100)]
staging: vt6656: BBvCalculateParameter remove camel case
Camel case changes
pDevice, cbFrameLength, wRate, byPacketType, cbBitCount, cbUsCount
cbTmp, bExtBit, byPreambleType
->
priv, frame_length, tx_rate, pkt_type, bit_count, count,
tmp, ext_bit, preamble_type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:01 +0000 (20:33 +0100)]
staging: vt6656: checkpatch cleanup BBvCalculateParameter.
White space clean up.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:33:00 +0000 (20:33 +0100)]
staging: vt6656: BBuGetFrameTime remove camel case.
Camel case changes.
byPreambleType, byPktType, cbFrameLength, uFrameTime, uPreamble, uTmp, uRate
->
preamble_type, pkt_type, frame_length, frame_time, preamble, tmp, rate
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:32:59 +0000 (20:32 +0100)]
staging: vt6656: BBuGetFrameTime remove uRateIdx
Remove uRateIdx and rename wRate tx_rate
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:32:58 +0000 (20:32 +0100)]
staging: vt6656: checkpatch cleanup BBuGetFrameTime.
clean up white space.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:32:57 +0000 (20:32 +0100)]
staging; vt6656: dead code aes_ccmp.
After dead code dpc hostapd remove aes.c/h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:32:56 +0000 (20:32 +0100)]
staging: vt6656: dead code bRelayPacketSend
After dead code hostapd remove bRelayPacketSend
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:32:55 +0000 (20:32 +0100)]
staging: vt6656: dpc.c remove hostapd
Remove dead functions
s_bAPModeRxCtl
s_bAPModeRxData
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:32:54 +0000 (20:32 +0100)]
staging: vt6656: Remove hostapd functions.
Remove throughout driver
bEnableHostapd
bEnable8021x
bEnableHostWEP
struct net_device *apdev
tx_80211
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Mon, 19 May 2014 19:32:53 +0000 (20:32 +0100)]
staging: vt6656: Remove dead code hostap.
It is based on viawget, proprietary version of wpa supplicant.
The code is not compatible with the current version of hostapd.
It may be possible to implement when the driver is fully converted
to mac80211.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anton Saraev [Mon, 19 May 2014 08:09:58 +0000 (12:09 +0400)]
staging: crypto: skein: rename macros
Mixing upper and lower case in names of macros like It_Is_Macro is
not accepted in the Linux Kernel. To prepare skein driver for mainline
inclusion, we rename all macros to uppercase or lowercase names.
Signed-off-by: Anton Saraev <antonysaraev@gmail.com>
Reviewed-by: Jake Edge <jake@lwn.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anton Saraev [Mon, 19 May 2014 08:09:57 +0000 (12:09 +0400)]
staging: crypto: skein: rename enums
Linux Kernel use capitalized names for enum. To prepare skein
driver to mainline inclusion, we rename all enums to capitalized
names.
Signed-off-by: Anton Saraev <antonysaraev@gmail.com>
Reviewed-by: Jake Edge <jake@lwn.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anton Saraev [Mon, 19 May 2014 08:09:56 +0000 (12:09 +0400)]
staging: crypto: skein: rename skein1024_ctx to skein_1024_ctx
Code have skein_512_ctx and skein_256_ctx but skein1024_ctx.
It would be logical to convert these names to a single form.
Signed-off-by: Anton Saraev <antonysaraev@gmail.com>
Reviewed-by: Jake Edge <jake@lwn.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anton Saraev [Mon, 19 May 2014 08:09:55 +0000 (12:09 +0400)]
staging: crypto: skein: rename camelcase vars
camelCase is not accepted in the Linux Kernel. To prepare skein
driver for mainline inclusion, we rename all vars to
non-camelCase equivalents.
Signed-off-by: Anton Saraev <antonysaraev@gmail.com>
Reviewed-by: Jake Edge <jake@lwn.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anton Saraev [Mon, 19 May 2014 08:09:54 +0000 (12:09 +0400)]
staging: crypto: skein: rename camelcase functions
camelCase is not accepted in the Linux Kernel. To prepare skein
driver for mainline inclusion, we rename all functions to
non-camelCase equivalents.
Signed-off-by: Anton Saraev <antonysaraev@gmail.com>
Reviewed-by: Jake Edge <jake@lwn.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jason Cooper [Fri, 25 Apr 2014 16:45:09 +0000 (16:45 +0000)]
staging: crypto: skein: depend upon CRYPTO
Fengguang's randconfig kernel build tester discovered the following
warnings:
warning: (CRYPTO_THREEFISH) selects CRYPTO_ALGAPI which has unmet direct dependencies (CRYPTO)
warning: (DM_VERITY && CRYPTO_SKEIN) selects CRYPTO_HASH which has unmet direct dependencies (CRYPTO)
Fix this in the Kconfig by depending on CRYPTO.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masaru Nomura [Sat, 17 May 2014 23:54:31 +0000 (00:54 +0100)]
staging: dgnc: Remove extra curly braces
Remove unnecessary curly braces of if statements in dgnc_neo.c and
dgnc_tty.c to meet kernel coding style.
Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masaru Nomura [Sat, 17 May 2014 23:54:30 +0000 (00:54 +0100)]
staging: dgnc: dgnc_neo: Clean up if statement
Fix line over 80 characters and indenting of condition part.
Also, remove unnecessary braces to meet coding style.
Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masaru Nomura [Sat, 17 May 2014 23:54:29 +0000 (00:54 +0100)]
staging: dgnc: Put else statements on the right line
Fix indenting of if-else statement in dgnc_neo.c and dgnc_tty.c
so that following else-if or else statement meets coding style.
Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lubomir Rintel [Sun, 18 May 2014 10:55:16 +0000 (12:55 +0200)]
staging: xgifb: Update TODO
There's no more printk abuse, it's been sorted out in
448810662ac3 ("Staging: xgifb: Remove printk usage.")
Extra ifdefs have been fixed too, mostly in
800d67cf9f77 ("staging: xgifb: eliminate #ifdef Tap4"),
c39aada6926c ("staging: xgifb: eliminate #ifdef XGIFB_PAN"),
fa4c212f2b81 ("staging: xgifb: delete unused definitions"),
5c167b30c1b4 ("staging: xgifb: eliminate #ifdef NewScratch"),
f059077388b0 ("Staging: xgifb: Remove #ifdef MODULE") and more.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lubomir Rintel [Sun, 18 May 2014 10:55:15 +0000 (12:55 +0200)]
staging: xgifb: Drop some more useless defines
SetLCDStdMode is not supported as of
34c13ee2b690 ("staging: xgifb: drop
code for legacy VGA modes").
DisableLCD24bpp defined to zero was never realy useful and went away with
aa56b2790a8b ("staging: xgifb: vb_table: delete XGI21_LCDCapList").
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lubomir Rintel [Sun, 18 May 2014 10:55:14 +0000 (12:55 +0200)]
staging: xgifb: Initialize Part0Port
It was left uninitialized, likely overseen, in this commit:
56810a92c689c6 ("staging: xgifb: use XGIRegInit()
Avoid copy-paste and use XGIRegInit() to initialize registers addresses.")
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lubomir Rintel [Sun, 18 May 2014 10:55:12 +0000 (12:55 +0200)]
staging: xgifb: Eliminate useless ifndefs
XGI_VB_CHIP_TYPE, PCI_DEVICE_ID_XGI_42 and PCI_DEVICE_ID_XGI_27
are never defined.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:39 +0000 (09:50 +0100)]
staging: vt6656: Remove always true bUpdateBBVGA
Remove true if statements.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:38 +0000 (09:50 +0100)]
staging: vt6656: vnt_private remove dead variables.
byBBCR4d
byBBCRc9
byBBCR88
byBBCR09
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:37 +0000 (09:50 +0100)]
staging: vt6656: vnt_private remove dead variables
byFOETuning
byAutoPwrTunning
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:36 +0000 (09:50 +0100)]
staging: vt6656: vnt_private remove dead variables.
dwAotoRateTxOkCnt
dwAotoRateTxFailCnt
dwErrorRateThreshold
dwTPTable
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:35 +0000 (09:50 +0100)]
staging: vt6656: Remove unused variable byACKRate.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:34 +0000 (09:50 +0100)]
staging: vt6656: Remove unused variable uScanTime.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:33 +0000 (09:50 +0100)]
staging: vt6656: Remove dead variable bCCK.
bCCK is always true remove all false conditions and
local variable.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:32 +0000 (09:50 +0100)]
staging: vt6656: Remove unused variable ulTxPower.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:31 +0000 (09:50 +0100)]
staging: vt6656: Remove unused variable byRevId.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:30 +0000 (09:50 +0100)]
staging: vt6656: rndis.h move all to device.h
Commands macros are common to all source files.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:29 +0000 (09:50 +0100)]
staging: vt6656: rndis.h remove dead code.
Remove dead structures and macros.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:28 +0000 (09:50 +0100)]
staging: vt6656: srom.h move all macros to device.h
Remove srom.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:27 +0000 (09:50 +0100)]
staging: vt6656: srom.h : Remove dead code.
Remove macros and unused strutures.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:26 +0000 (09:50 +0100)]
staging: vt6656: desc.h Remove unused macros
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:25 +0000 (09:50 +0100)]
staging: vt6656: device.h remove dead macros
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:24 +0000 (09:50 +0100)]
staging: vt6656: device_cfg.h Move macros to device.h
Remove device_cfg.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:23 +0000 (09:50 +0100)]
staging: vt6656: device_cfg.h remove dead code.
Also unneeded #ifndef
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:22 +0000 (09:50 +0100)]
staging: vt6656: PIPEnsControlIn remove camel case.
Camel case changes
pDevice, byRequest, wValue, wIndex, wLength, pbyBuffer, ntStatus
->
priv, request, value, index, length, buffer, status
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:21 +0000 (09:50 +0100)]
staging: vt6656: PIPEnsControlOut remove camel case.
Camel case changes
pDevice, byRequest, wValue, wIndex, wLength, pbyBuffer, ntStatus
->
priv, request, value, index, length, buffer, status
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:20 +0000 (09:50 +0100)]
staging: vt6656: usbpipe: replace debug messsages.
Replace all DBG_PRT wiht dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:19 +0000 (09:50 +0100)]
staging: vt6656: usbpipe: get rid of in/out debug messages.
Remove all in/out debug messages.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 17 May 2014 08:50:18 +0000 (09:50 +0100)]
staging: vt6656: rf.c additional power.
Provides extra power on weak RSSI.
The values orginate from the vendors driver.
It is applied later in RFbRawSetPower to simplify and check that it doesn't
exceed the max power.
Vendor driver VT6656_Linux_src_v1.21.03_x86_11.04.zip
http://www.viaembedded.com/servlet/downloadSvl?id=1890&download_file_id=14704
This is GPL-licensed code.
vendors code
...
if (pDevice->byRFType == RF_VT3226D0) {
if (lRSSI == 0){
lAdditionalPower = 7;
}
else if ((lRSSI < -60) && (lRSSI >= -65)){
lAdditionalPower = 5;
//lAdditionalPower = 9;
}
else if ((lRSSI < -65) && (lRSSI >= -70)){
lAdditionalPower = 7;
//lAdditionalPower = 9;
}
else if ((lRSSI < -70) && (lRSSI >= -80)){
lAdditionalPower = 9;
}
else if (lRSSI < -80) {
lAdditionalPower = 9;
}
}
else {
if (lRSSI == 0){
lAdditionalPower = 7;
}
else if ((lRSSI < -70) && (lRSSI >= -75)){
lAdditionalPower = 5;
}
else if ((lRSSI < -75) && (lRSSI >= -80)){
lAdditionalPower = 7;
}
else if (lRSSI < -80) {
lAdditionalPower = 9;
}
}
...
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masaru Nomura [Sat, 17 May 2014 20:32:53 +0000 (21:32 +0100)]
staging: unisys: visorutil: Add a blank line
Add a blank line after declarations to meet kernel coding style.
Signed-off-by: Masaru Nomura <massa.nomura@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:35 +0000 (12:38 -0400)]
staging: unisys: remove remaining proc directory entries
Finally, remove /proc/uislib and all remaining, redundant entries created
under /proc/uislib/vbus.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:34 +0000 (12:38 -0400)]
staging: unisys: move uislib/info proc entry to debugfs
Convert /proc/uislib/info to an equivalent entry under debugfs.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:33 +0000 (12:38 -0400)]
staging: unisys: remove functions made redundant in uislib.c
The patches to move proc files have made the functions
uislib_proc_read_writeonly() and stop_chipset() redundant. Remove them.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:32 +0000 (12:38 -0400)]
staging: unisys: move uislib/smart_wakeup proc entry to debugfs
Convert /proc/uislib/smart_wakeup to an equivalent entry in debugfs.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:31 +0000 (12:38 -0400)]
staging: unisys: move uislib/cycles_before_wait proc entry to debugfs
Convert /proc/uislib/cycles_before_wait to an equivalent entry in debugfs.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:30 +0000 (12:38 -0400)]
staging: unisys: move uislib/platform proc entry to debugfs
Convert /proc/uislib/platform to an equivalent entry in debugfs.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Mon, 12 May 2014 16:38:29 +0000 (12:38 -0400)]
staging: unisys: remove testing proc interfaces from uislib
Several proc interfaces in the uislib module were intended for debug and
testing during initial driver development. They are no longer needed, so
we should remove them from the module.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Tue, 6 May 2014 13:58:23 +0000 (09:58 -0400)]
staging: unisys: Replace GUID with uuid_le
This patch replaces the GUID type with uuid_le. It removes the header file
guidutils.h, updates all uses of the GUID type to uuid_le, and replaces all
function calls that used the GUID type with their uuid_le equivalents.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Mon, 28 Apr 2014 17:23:14 +0000 (12:23 -0500)]
Staging: unisys: visorutil: Add MODULE_LICENSE("GPL")
The visorutil module was lacking license info.
Signed-off-by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ken Cox [Mon, 28 Apr 2014 17:23:13 +0000 (12:23 -0500)]
Staging: unisys: detect s-Par firmware
This patch adds support for detection of s-Par firmware by checking for
the hypervisor bit in the CPU capabilities, and then querying the hypervisor
ID cpuid leaf.
This functionality will be used by the unisys drivers to determine if
they are being loaded on an s-Par platform and refuse to load if no
s-Par firmware is present.
This fixes a problem reported from upstream where a panic occurs if the
unisys drivers are loaded on a non s-Par system.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Ken Cox <jkc@redhat.com>
Tested by: Ken Cox <jkc@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fredrick John Berchmans [Sun, 4 May 2014 04:42:14 +0000 (21:42 -0700)]
staging: lustre: fix unused variable warnings
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Fredrick John Berchmans <fredrickprashanth@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vitaly Osipov [Sun, 4 May 2014 04:14:26 +0000 (14:14 +1000)]
staging: lustre: return -EFAULT instead of bytes remaining
return -EFAULT instead of the value returned by copy_from_user()
Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Sat, 3 May 2014 20:23:29 +0000 (23:23 +0300)]
staging: lustre: info leak in lnet_ping()
On 64 bit systems there is a 4 byte hole after the last member of the
struct. We should clear it to avoid disclosing stack information.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 20:49:29 +0000 (16:49 -0400)]
staging: dgap: Get rid of CamelCase
This patch gets rid of the obvious CamelCases
from both dgap.c and dgap.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 18:19:42 +0000 (14:19 -0400)]
staging: dgap: refactor ugly dgap_init_one function
This patch just cleans up the ugly dgap_init_one function
Signed-off-by: Mark Hounschell <markh@compro.net>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 20:59:18 +0000 (22:59 +0200)]
staging: rtl8723au: Do not reset wdev->iftype in netdev_close()
wdev->ifdev should be set by .change_virtual_intf(). This solves the
problem of WARN() messages on module unload.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 17:10:20 +0000 (13:10 -0400)]
staging: dgap: Add check for MAXBOARDS in .probe (dgap_init_one)
Insure we don't allow configuring more than MAXBOARDS (32).
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 17:10:19 +0000 (13:10 -0400)]
staging: dgap: remove two unnecessary conditionals
Remove 2 unnessessary conditionals. They are always
false in this code path.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 17:10:18 +0000 (13:10 -0400)]
staging: dgap: check unchecked return values
Check the return values of dgap_tty_register and
dgap_finalize_board_init. If they fail for a
particular board we should not be able to try
to use that board. IE. no device entries shall
be created for that board.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 25 Apr 2014 14:00:42 +0000 (10:00 -0400)]
staging: dgap: fix a few more sparse warnings
This patch fixes a few more sparse warnings related to __iomem
version 2 excludes a change that actually caused a new sparse
warning.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Thu, 24 Apr 2014 14:41:44 +0000 (10:41 -0400)]
staging: dgap: fix sparse warnings Using plain integer as NULL pointer
This patch fixes sparse warnings:
warning: Using plain integer as NULL pointer
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Thu, 24 Apr 2014 14:33:58 +0000 (10:33 -0400)]
staging: dgap: fix sparse warning about dgap_poll_lock
This patch fixes a sparse warning:
warning: symbol 'dgap_poll_lock' was not declared. Should it be static?
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Thu, 24 Apr 2014 13:22:12 +0000 (09:22 -0400)]
staging: dgap: fix a few misc sparse warnings
This patch fixes a few misc sparse warnings related to __iomem
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 20:43:21 +0000 (16:43 -0400)]
staging: dgap: fix sparse warnings for the entire cm_t structure
This patch fixes sparse warnings for the entire cm_t structure
This entire structure defines a hardware segment
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 20:25:27 +0000 (16:25 -0400)]
staging: dgap: fix sparse warnings for the entire bs_t structure
This patch fixes sparse warnings for the entire bs_t structure
This entire structure defines a hardware segment
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 19:43:07 +0000 (15:43 -0400)]
staging: dgap: fix sparse warnings for re_map_membase and re_map_port
This patch fixes sparse warnings for the
re_map_membase and re_map_port variables.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 14:33:45 +0000 (10:33 -0400)]
staging: dgap: Fix BUG in processing config file
This patch fixes an OOPS caused by a pointer being
changed between the malloc and free.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Reported-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 23 Apr 2014 14:33:44 +0000 (10:33 -0400)]
staging: dgap: Fix how we insure config data is a string
This patch changes the way we insure the config data
is a string. Clearly this was just wrong. After a
certain number of loads/unloads various OOPs were
generated indicating something other than this driver
had a problem. It was this driver.
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Reported-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Fri, 16 May 2014 12:08:53 +0000 (08:08 -0400)]
staging: dgap: Add Mark Hounschell to maintainers list for dgap
Add Mark Hounschell to the MAINTAINERs list for the dgap driver
Signed-off-by: Mark Hounschell <markh@compro.net>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:29 +0000 (18:08 +0800)]
staging: gdm72xx: Remove task from TODO list
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on
ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb:
fix deprecated function kernel_thread')
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:28 +0000 (18:08 +0800)]
staging: gdm72xx: Indentation and other whitespace fixes
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:27 +0000 (18:08 +0800)]
staging: gdm72xx: Whitespace fixes to conform to coding standards
Fixes the following checkpatch.pl issues:
WARNING: unnecessary whitespace before a quoted newline
CHECK: Alignment should match open parenthesis
CHECK: No space is necessary after a cast
Also some additional, whitespace related, readability issues.
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:26 +0000 (18:08 +0800)]
staging: gdm72xx: Removed commented-out code
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:25 +0000 (18:08 +0800)]
staging: gdm72xx: Fix braces to conform with coding style
Fixes the following checkpatch.pl issue:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:24 +0000 (18:08 +0800)]
staging: gdm72xx: Fix some camel-case variables
Fixes the following checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:23 +0000 (18:08 +0800)]
staging: gdm72xx: Move logical continuation to previous line to conform to coding style
Fixes the following checkpatch.pl issue:
CHECK: Logical continuations should be on the previous line
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:22 +0000 (18:08 +0800)]
staging: gdm72xx: Modify a struct allocation to match coding standards
Fixes the following checkpatch.pl issue:
CHECK: Prefer kmalloc(sizeof(*entry)...) over kmalloc(sizeof(struct qos_entry_s)...)
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:21 +0000 (18:08 +0800)]
staging: gdm72xx: Replace comparisons on jiffies values with wrap-safe functions
Fixes the following checkpatch.pl issue:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Fri, 9 May 2014 10:08:20 +0000 (18:08 +0800)]
staging: gdm72xx: Remove unnecessary extern declarations from header files
Fixes the following checkpatch.pl issue:
CHECK: extern prototypes should be avoided in .h files
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:13 +0000 (10:05 +0200)]
staging: rtl8723au: Remove some unused ODM dynamic TX power functionality
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:12 +0000 (10:05 +0200)]
staging: rtl8723au: The DBG_IO code is all gone
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:11 +0000 (10:05 +0200)]
staging: rtl8723au: Remove some leftover obsolete prototypes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:10 +0000 (10:05 +0200)]
staging: rtl8723au: Name port vs register access functions consistently
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:09 +0000 (10:05 +0200)]
staging: rtl8723au: Call usb_write*() functions directly
This allows us to finally remove the ugly HAL interface for accessing
registers, and remove rtw_io.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:08 +0000 (10:05 +0200)]
staging: rtl8723au: Call usb_read*() functions directly
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Fri, 16 May 2014 08:05:07 +0000 (10:05 +0200)]
staging: rtl8723au: Call usb_read_interrupt() directly instead of via HAL layer
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / openwrt / staging / blogic.git / log