Pavel Andrianov [Mon, 5 Sep 2016 13:17:47 +0000 (16:17 +0300)]
speakup: Add spinlock in synth_direct_store
All operations with synth buffer should be protected,
as there are global pointers, which should be modified atomically.
Found by Linux Driver Verification project (linuxtesting.org)
Signed-off-by: Pavel Andrianov <andrianov@ispras.ru>
Acked-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 6 Sep 2016 16:36:57 +0000 (18:36 +0200)]
staging: rtl8188eu: remove unused debugging functions
These functions were only mentioned in the rtw_proc_init_one()
function in drivers/staging/rtl8188eu/os_dep/os_intfs.c, which was
under #if 0 and has now been removed completely.
As they are not used anywhere, and also violate the coding style
rules, remove them.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kyle Kuffermann <kyle.kuffermann@gmail.com>
Cc: Chris Elliott <chris@uksysadmin.com>
Cc: Ivan Safonov <insafonov@gmail.com>
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 6 Sep 2016 16:36:56 +0000 (18:36 +0200)]
staging: rtl8188eu: remove useless include
Since the removal of rtw_proc_init_one() the proc filesystem is not
mentioned in this driver. So this include becomes useless.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Binoy Jayan <binoy.jayan@linaro.org>
Cc: Anish Bhatt <anish@gatech.edu>
Cc: "Rémy Oudompheng" <remyoudompheng@gmail.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Kyle Kuffermann <kyle.kuffermann@gmail.com>
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 6 Sep 2016 16:36:55 +0000 (18:36 +0200)]
staging: rtl8188eu: remove rtw_proc_{init,remove}_one
rtw_proc_init_one() and rtw_proc_remove_one() are two very long
functions that are supposed to create a bunch of proc entries to
access debugging features of the driver.
But both of them are under #if 0 since their first commit three years
ago (
5adef66acf73705ae95ea0b1e6b5fc7f17d82d30), replaced by two empty
functions.
Should they be moved out of #if 0 thay would not even compile, as they
used functions that have been removed years ago
(create_proc_read_entry()) and they use variables that are not defined
(e.g. rtw_proc_cnt).
rtw_proc_init_one() mentions several other functions that are not
mentioned anywhere else in the kernel tree. Thus, after the present
patch, all of those other functions can be cleanly removed as well, as
they will be not mentioned anymore, not even in disabled code.
Subsequent commits remove those other functions.
Should anybody want to implement (in a proper way) the mentioned
debugging features, they can still fetch this code from the git
history.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kyle Kuffermann <kyle.kuffermann@gmail.com>
Cc: Binoy Jayan <binoy.jayan@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "Rémy Oudompheng" <remyoudompheng@gmail.com>
Cc: Ivan Safonov <insafonov@gmail.com>
Cc: Jakub Sitnicki <jsitnicki@gmail.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Bhumika Goyal <bhumirks@gmail.com>
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 6 Sep 2016 16:36:54 +0000 (18:36 +0200)]
staging: rtl8188eu: declare internal function as static
This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Geliang Tang <geliangtang@163.com>
Cc: Jakub Sitnicki <jsitnicki@gmail.com>
Cc: Ivan Safonov <insafonov@gmail.com>
Cc: Kyle Kuffermann <kyle.kuffermann@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Luca Ceresoli [Tue, 6 Sep 2016 16:36:53 +0000 (18:36 +0200)]
staging: rtl8188eu: remove unimplemented functions declaration
These functions have been declared without any implementation since
the first commit (
58c434013a22fccfdb14abc2bb8408ca29073b76) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Kyle Kuffermann <kyle.kuffermann@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amit Ghadge [Sun, 4 Sep 2016 17:23:35 +0000 (22:53 +0530)]
Staging: rtl8188eu: ioctl_linux: Clean up if function returned NULL on failure.
Clean some all functions to return NULL on failure.
Used !x instead of x==NULL.
Signed-off-by: Amit Ghadge <amitg.b14@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Baoyou Xie [Sun, 4 Sep 2016 06:33:35 +0000 (14:33 +0800)]
Staging: rtl8192e: mark symbols static where possible
We get a few warnings when building kernel with W=1:
drivers/staging/rtl8192e/rtllib_softmac.c:279:13: warning: no previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations]
drivers/staging/rtl8192e/rtllib_softmac.c:773:24: warning: no previous declaration for 'rtllib_authentication_req' [-Wmissing-declarations]
....
In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
In addition, some of these functions are declared in different files,
it looks like that we need to clean the codes of this driver up,
but we can repress these warnings first, then clean it up.
so this patch marks these functions with 'static' now.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicolas Iooss [Sat, 3 Sep 2016 13:55:23 +0000 (15:55 +0200)]
staging: rtl8192u: do not use undefined $(TOPDIR) in Makefile
drivers/staging/rtl8192u/ieee80211/Makefile uses $(TOPDIR) to configure
an include directory, without defining this variable first. The path
which is configured is therefore "/drivers/net/wireless", which does not
seem to be the intended path.
Remove the offending line.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anchal Jain [Fri, 9 Sep 2016 15:02:16 +0000 (20:32 +0530)]
staging: lustre: lustre: obdclass: Modify return statement
Modify the return statement.
The Coccinelle semantic patch used to make this change is as follows:
@@
expression e, ret;
@@
-ret =
+return
e;
-return ret;
Delete the declaration of the return variable rc, as it is no longer used.
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Baoyou Xie [Thu, 8 Sep 2016 08:46:07 +0000 (16:46 +0800)]
staging/lustre/obdclass: add missing header dependencies
We get 1 warning when building kernel with W=1:
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning: no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes]
In fact, this function is declared in ../../include/obd_class.h,
so this patch add missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Acked-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rehas Sachdeva [Mon, 12 Sep 2016 10:07:37 +0000 (15:37 +0530)]
staging: emxx_udc: Remove unnecessary blank line
This patch fixes the checkpatch.pl warning:
Blank lines aren't necessary before a close brace '}'
Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Abbott [Wed, 31 Aug 2016 00:04:29 +0000 (17:04 -0700)]
staging: android: ion: Convert hi6220 to common platform
Now that we have common devicetree bindings, convert hisilicon
platform to use the binding and parsing methods.
Signed-off-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Abbott [Wed, 31 Aug 2016 00:04:28 +0000 (17:04 -0700)]
staging: ion: Add files for parsing the devicetree
Devicetree is the preferred mechanism for platform definition
these days. Add a set of files for supporting Ion with devicetree.
This includes a set of bindings for heaps common across all
devices and parsing methods. Clients may use the standard
bindings or they can call the parsing functions along with
their own parsing for platform specific heaps.
Signed-off-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Abbott [Wed, 31 Aug 2016 00:04:27 +0000 (17:04 -0700)]
devicetree: bindings for Ion
This adds a base set of devicetree bindings for the Ion memory
manager. This supports setting up the generic set of heaps and
their properties.
Signed-off-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Abbott [Wed, 7 Sep 2016 18:49:59 +0000 (11:49 -0700)]
staging: android: ion: Add ioctl to query available heaps
Ion clients currently lack a good method to determine what
heaps are available and what ids they map to. This leads
to tight coupling between user and kernel space and headaches.
Add a query ioctl to let userspace know the availability of
heaps.
Signed-off-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Raphaël Beamonte [Fri, 9 Sep 2016 15:31:45 +0000 (11:31 -0400)]
staging: rtl8712: checkpatch cleanup: block comments using a trailing */
Fix checkpatch.pl warning "Block comments use a trailing */ on
a separate line" on multiple files of the driver by editing the
affected comments.
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julia Lawall [Sun, 11 Sep 2016 13:05:45 +0000 (15:05 +0200)]
staging: rtl8192e: constify local structures
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored in a
variable.
Declare structures having all of these properties as const.
Done using Coccinelle.
Based on a suggestion by Joe Perches <joe@perches.com>.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Imre Deak [Sun, 11 Sep 2016 16:48:08 +0000 (19:48 +0300)]
staging: gdm724x: gdm_lte: Constify gdm_netdev_ops
Fix the following checkpatch.pl warning:
WARNING: struct net_device_ops should normally be const
+static struct net_device_ops gdm_netdev_ops = {
Signed-off-by: Imre Deak <imre.deak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:34:00 +0000 (22:34 +0700)]
staging: r8188eu: remove HalFunc member of adapter structure
hal_ops structure is empty.
Also remove hal_ops definition.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:56 +0000 (22:33 +0700)]
staging: r8188eu: remove hal_reset_security_engine member of hal_ops structure
hal_reset_security_engine always is NULL.
Also rtw_hal_reset_security_engine function removed.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:52 +0000 (22:33 +0700)]
staging: r8188eu: remove interrupt_handler member of hal_ops structure
interrupt_handler does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:49 +0000 (22:33 +0700)]
staging: r8188eu: remove hal_set_hal_ops macro
hal_set_hal_ops is a trivial wrapper for rtl8188eu_set_hal_ops.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:44 +0000 (22:33 +0700)]
staging: r8188eu: remove rtl8188e_set_hal_ops function
rtl8188e_set_hal_ops do nothing.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:40 +0000 (22:33 +0700)]
staging: r8188eu: rename rtl8188e_free_hal_data to rtw_hal_free_data
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:37 +0000 (22:33 +0700)]
staging: r8188eu: rename rtl8188e_init_dm_priv to rtw_hal_dm_init
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:34 +0000 (22:33 +0700)]
staging: r8188eu: rename ReadChipVersion8188E to rtw_hal_read_chip_version
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:30 +0000 (22:33 +0700)]
staging: r8188eu: rename phy_set_bw_mode to rtw_hal_set_bwmode
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:26 +0000 (22:33 +0700)]
staging: r8188eu: rename phy_sw_chnl to rtw_hal_set_chan
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:22 +0000 (22:33 +0700)]
staging: r8188eu: rename rtl8188e_HalDmWatchDog to rtw_hal_dm_watchdog
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:18 +0000 (22:33 +0700)]
staging: r8188eu: rename rtl8188e_Add_RateATid to rtw_hal_add_ra_tid
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:15 +0000 (22:33 +0700)]
staging: r8188eu: rename AntDivBeforeLink8188E to rtw_hal_antdiv_before_linked
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:11 +0000 (22:33 +0700)]
staging: r8188eu: rename AntDivCompare8188E to rtw_hal_antdiv_rssi_compared
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:05 +0000 (22:33 +0700)]
staging: r8188eu: rename phy_query_rf_reg to rtw_hal_read_rfreg
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:33:00 +0000 (22:33 +0700)]
staging: r8188eu: rename sreset_init_value to rtw_hal_sreset_init
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:57 +0000 (22:32 +0700)]
staging: r8188eu: remove sreset_get_wifi_status of hal_ops structure
Driver does not use it.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:53 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188e_SetHalODMVar to rtw_hal_set_odm_var
And remove many one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:50 +0000 (22:32 +0700)]
staging: r8188eu: rename hal_notch_filter_8188e to rtw_hal_notch_filter
And remove many one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:47 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_InitPowerOn to rtw_hal_power_on
And remove many one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:43 +0000 (22:32 +0700)]
staging: r8188eu: remove hal_init member of hal_ops structure
It is unnecessary wrapper for rtl8188eu_hal_init function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:40 +0000 (22:32 +0700)]
staging: r8188eu: remove hal_deinit member of hal_ops structure
It is unnecessary wrapper for rtl8188eu_hal_deinit function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:36 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_inirp_init to rtw_hal_inirp_init
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:33 +0000 (22:32 +0700)]
staging: r8188eu: rename usb_read_port_cancel to rtw_hal_inirp_deinit
And remove three one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:30 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_init_xmit_priv to rtw_hal_init_xmit_priv
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:26 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_init_recv_priv to rtw_hal_init_recv_priv
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:23 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_free_recv_priv to rtw_hal_free_recv_priv
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:20 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_InitSwLeds to rtw_hal_sw_led_init
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:16 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_DeInitSwLeds to rtw_hal_sw_led_deinit
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:11 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_init_default_value to rtw_hal_def_value_init
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:06 +0000 (22:32 +0700)]
staging: r8188eu: rename rtl8188eu_interface_configure to rtw_hal_chip_configure
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:32:01 +0000 (22:32 +0700)]
staging: r8188eu: rename _ReadAdapterInfo8188EU to rtw_hal_read_chip_info
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:58 +0000 (22:31 +0700)]
staging: r8188eu: rename SetHwReg8188EU to rtw_hal_set_hwreg
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:53 +0000 (22:31 +0700)]
staging: r8188eu: rename GetHwReg8188EU to rtw_hal_get_hwreg
And remove two one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:49 +0000 (22:31 +0700)]
staging: r8188eu: rename GetHalDefVar8188EUsb to rtw_hal_get_def_var
And remove many one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:45 +0000 (22:31 +0700)]
staging: r8188eu: remove UpdateRAMaskHandler member of hal_ops structure
It is unnecessary wrapper for UpdateHalRAMask8188EUsb function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:41 +0000 (22:31 +0700)]
staging: r8188eu: rename SetBeaconRelatedRegisters8188EUsb to rtw_hal_bcn_related_reg_setting
And remove many one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:36 +0000 (22:31 +0700)]
staging: r8188eu: rename pre_xmitframe to rtw_hal_xmit
And remove many one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:31 +0000 (22:31 +0700)]
staging: r8188eu: rename rtl8188eu_mgnt_xmit to rtw_hal_mgnt_xmit
And remove many one-line wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:25 +0000 (22:31 +0700)]
staging: r8188eu: remove pxmitbuf parameter of rtl8188eu_xmitframe_complete function
pxmitbuf always is NULL.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:20 +0000 (22:31 +0700)]
staging: r8188eu: remove do_queue_select function
do_queue_select is simplest one-line function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:10 +0000 (22:31 +0700)]
staging: r8188eu: remove sizeof_priv parameter of rtw_alloc_etherdev_with_old_priv function
sizeof_priv does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:06 +0000 (22:31 +0700)]
staging: r8188eu: remove sizeof_priv member of rtw_netdev_priv_indicator
sizeof_priv does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:31:00 +0000 (22:31 +0700)]
staging: r8188eu: remove not_indic_disco member of mlme_priv structure
This member does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:57 +0000 (22:30 +0700)]
staging: r8188eu: remove num_of_scanned member of mlme_priv structure and corresponding to it code
Value of this variabl does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:52 +0000 (22:30 +0700)]
staging: r8188eu: remove scan_start_time and assoc_by_rssi members from mlme_priv structure
Value of this members does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:48 +0000 (22:30 +0700)]
staging: r8188eu: remove p2p_* members from mlme_priv structure
This members does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:44 +0000 (22:30 +0700)]
staging: r8188eu: remove some members of registry_priv structure
some registry_priv members does not used after initialization.
Module parameters corresponding to this members deleted too.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:32 +0000 (22:30 +0700)]
staging: r8188eu: remove nr_endpoint member of dvobj_priv structure
nr_endpoint used as local variable.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:28 +0000 (22:30 +0700)]
staging: r8188eu: remove ep_num member of dvobj_priv structure
Value of the ep_num does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:19 +0000 (22:30 +0700)]
staging: r8188eu: remove usb_vendor_req_buf member of dvobj_priv
Memory allocation moved into usbctrl_vendorreq function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:15 +0000 (22:30 +0700)]
staging: r8188eu: remove phostapdpriv member of struct adapter
phostapdpriv does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:10 +0000 (22:30 +0700)]
staging: r8188eu: remove fw_ps_awake variable of rtl8188e_HalDmWatchDog function
Value of the fw_ps_awake does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:06 +0000 (22:30 +0700)]
staging: r8188eu: remove rwdinfo member of struct adapter
Only default value of wdinfo was used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:30:01 +0000 (22:30 +0700)]
staging: r8188eu: remove evtThread member of struct adapter
evtThread does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:29:56 +0000 (22:29 +0700)]
staging: r8188eu: remove rereg_nd_name_priv member of struct adapter
Only default value of rereg_nd_name_priv was used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:29:50 +0000 (22:29 +0700)]
staging: r8188eu: remove br_ext_lock and fix_rate members of struct adapter
br_ext_lock and fix_rate are not used after initialization.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:29:40 +0000 (22:29 +0700)]
staging: r8188eu: remove in_cta_test member of struct adapter
bNotifyChannelChange does not changed after initialization.
"if" branches with in_cta_test != 0 removed too.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:29:19 +0000 (22:29 +0700)]
staging: r8188eu: remove bNotifyChannelChange member of struct adapter
Default value of this variable used only to produce debug output.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:29:14 +0000 (22:29 +0700)]
staging: r8188eu: remove ieee80211_txb and tx_pending structures
ieee80211_txb and tx_pending structures are not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:28:56 +0000 (22:28 +0700)]
staging: r8188eu: replace rtw_ieee80211_hdr_3addr_qos with ieee80211_qos_hdr
rtw_ieee80211_hdr_3addr_qos is duplicate of ieee80211_qos_hdr.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:28:28 +0000 (22:28 +0700)]
staging: r8188eu: replace rtw_ieee80211_hdr_3addr with ieee80211_hdr_3addr
rtw_ieee80211_hdr_3addr is duplicate of ieee80211_hdr_3addr.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sat, 3 Sep 2016 15:27:57 +0000 (22:27 +0700)]
staging: r8188eu: replace rtw_ieee80211_hdr with ieee80211_hdr
rtw_ieee80211_hdr is duplicate of ieee80211_hdr.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Fri, 9 Sep 2016 15:56:38 +0000 (16:56 +0100)]
staging: ks7010: fix two memory leaks on error return path
On the error case where there is an invalid MAC address there is
memory leak on packet and pp on the error return. Free these first
before returning to fix the leak.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Colin Ian King [Wed, 7 Sep 2016 16:23:09 +0000 (17:23 +0100)]
staging: ks7010: avoid dereferencing packet if it is null
Updating tx_bytes from packet->len if packet is null will cause
a null pointer dereference, so only update tx_bytes if it packet
is not null.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hariharan R [Mon, 5 Sep 2016 22:22:46 +0000 (18:22 -0400)]
staging: ks7010: fix warning on return for void functions
This patch fixes the checkpatch warning in ks7010_sdio.c
'void function return statements are not generally useful'
Signed-off-by: Hariharan R <hariharanrangasamy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Sun, 4 Sep 2016 15:00:19 +0000 (20:30 +0530)]
staging: ks7010: fix memory leak
If the firmware request failed we were just returning but we missed
freeing the memory and releasing the MMC Host.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Sun, 4 Sep 2016 15:00:18 +0000 (20:30 +0530)]
staging: ks7010: return on failure
On failure we were jumping to error_out0 where we were trying
sdio_release_host() but at this point of execution we still have not
done sdio_claim_host() and as a result host->claimed can still be 0.
And if host->claimed is 0 then WARN_ON(!host->claimed) will give
a warning.
Moreover, if it is still not claimed then mmc_host->claim_cnt will be 0
and mmc_release_host() will do "if (--host->claim_cnt)" and thus the
condition will become true.
Lets just return the value on allocation failure instead of trying to
release the host before claiming it.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Fri, 9 Sep 2016 13:25:43 +0000 (15:25 +0200)]
staging: most: hdm-usb: remove repeated access to structure
This patch removes the repeated access to a struct member by assigning
its value to a local variable once.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Fri, 9 Sep 2016 13:25:42 +0000 (15:25 +0200)]
staging: most: hdm-usb: remove reference to read function in write only macro
This patch replaces the reference to the function show_value() with
NULL in the macro MOST_DCI_WO_ATTR used for the write only attributes.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Fri, 9 Sep 2016 13:25:41 +0000 (15:25 +0200)]
staging: most: hdm-usb: initialize variables by declaration
This patch moves initialization of the variables to the declaration
where possible.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Fri, 9 Sep 2016 13:25:40 +0000 (15:25 +0200)]
staging: most: hdm-usb: unify variable names
This patch is needed to have the same variable name for the same quantity
in the functions show_value() and store_value().
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Fri, 9 Sep 2016 13:25:39 +0000 (15:25 +0200)]
staging: most: hdm-usb: unify returned errors
This patch is needed to return the same error codes for the same error
cases in the functions show_value() and store_value().
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Fri, 9 Sep 2016 13:25:38 +0000 (15:25 +0200)]
staging: most: hdm-usb: replace if-else branches with lookup table
This patch removes a series of if-else-if conditions with a lookup table.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Fri, 9 Sep 2016 13:25:37 +0000 (15:25 +0200)]
staging: most: Documentation: update ABI description
This patch updates the ABI description file to reflect the latest changes
of the interface.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Fri, 9 Sep 2016 13:25:36 +0000 (15:25 +0200)]
staging: most: hdm-usb: use defined error codes
This patch replaces return values with defined error codes to indicate
an exception.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Fri, 9 Sep 2016 13:25:35 +0000 (15:25 +0200)]
staging: most: hdm-usb: extend DCI access
This patch extends the direct communication interface ABI of the USB
network interface controller. It is needed to provide applications
arbitrary access to DCI registers and the ability to synchronize the
internal endpoint logic of the controller.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Mon, 12 Sep 2016 07:18:04 +0000 (09:18 +0200)]
Merge 4.8-rc6 into staging-next
We need the IIO changes in here for future patches to build on.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linus Torvalds [Mon, 12 Sep 2016 03:02:25 +0000 (20:02 -0700)]
Linux 4.8-rc6
Linus Torvalds [Sun, 11 Sep 2016 21:41:49 +0000 (14:41 -0700)]
nvme: make NVME_RDMA depend on BLOCK
Commit
aa71987472a9 ("nvme: fabrics drivers don't need the nvme-pci
driver") removed the dependency on BLK_DEV_NVME, but the cdoe does
depend on the block layer (which used to be an implicit dependency
through BLK_DEV_NVME).
Otherwise you get various errors from the kbuild test robot random
config testing when that happens to hit a configuration with BLOCK
device support disabled.
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jay Freyensee <james_p_freyensee@linux.intel.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Linus Torvalds [Sun, 11 Sep 2016 21:23:48 +0000 (14:23 -0700)]
Merge tag 'staging-4.8-rc6' of git://git./linux/kernel/git/gregkh/staging
Pull IIO fixes from Greg KH:
"Here are a few small IIO fixes for 4.8-rc6.
Nothing major, full details are in the shortlog, all of these have
been in linux-next with no reported issues"
* tag 'staging-4.8-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging:
iio:core: fix IIO_VAL_FRACTIONAL sign handling
iio: ensure ret is initialized to zero before entering do loop
iio: accel: kxsd9: Fix scaling bug
iio: accel: bmc150: reset chip at init time
iio: fix pressure data output unit in hid-sensor-attributes
tools:iio:iio_generic_buffer: fix trigger-less mode