Greg Kroah-Hartman [Fri, 28 Aug 2009 23:23:49 +0000 (16:23 -0700)]
Staging: hv: move StorVscApi.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:23:17 +0000 (16:23 -0700)]
Staging: hv: move NetVscApi.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:59 +0000 (16:22 -0700)]
Staging: hv: move logging.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:45 +0000 (16:22 -0700)]
Staging: hv: move List.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:22:33 +0000 (16:22 -0700)]
Staging: hv: remove ChannelMessages.h
It's only ever used within the ChannelMgmt.h file, so pull it
into there.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:21:33 +0000 (16:21 -0700)]
Staging: hv: move nvspprotocol.h
Move it out of the include subdirectory.
No code changes here, just file movements.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:53 +0000 (16:20 -0700)]
Staging: hv: fix typedefs in nvspprotocol.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:34 +0000 (16:20 -0700)]
Staging: hv: fix coding style issues in nvspprotocol.h
No typedef changes yet though.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:20:07 +0000 (16:20 -0700)]
Staging: hv: fix typedefs in StorVscApi.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Fri, 28 Aug 2009 23:19:17 +0000 (16:19 -0700)]
Staging: hv: fix coding style issues in StorVscApi.h
No typedef changes yet though.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:02:36 +0000 (16:02 -0700)]
Staging: hv: remove typedefs from VmbusPacketFormat.h
All spiffied up now, shines like a brass button on the bump of a barge's
bilge.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:01:23 +0000 (16:01 -0700)]
Staging: hv: fix coding style issues in VmbusPacketFormat.h
Heh, volatiles, like that was a good idea... Turns out they were not
even used, wierd stuff.
All clean except for the typedefs.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 23:00:24 +0000 (16:00 -0700)]
Staging: hv: fix typedefs in vstorage.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:59:39 +0000 (15:59 -0700)]
Staging: hv: fix remaining style issue in ChannelInterface.h
It snuck in with the other typedef cleanups, sorry about that.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:58:52 +0000 (15:58 -0700)]
Staging: hv: move vstorage.h to hv dir
Move it out of the include subdir, it doesn't need to
be there.
No code was changed in the move.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:58:15 +0000 (15:58 -0700)]
Staging: hv: fix up typedefs in NetVscApi.h
It's now all clean from a coding style standpoint.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:57:15 +0000 (15:57 -0700)]
Staging: hv: fix up coding style issues in NetVscApi.h
Everything but the typedefs.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 27 Aug 2009 22:55:48 +0000 (15:55 -0700)]
Staging: hv: fix up some coding style issues in logging.h
It's now clean.
Well, from a coding style guide, not from a logic standpoint, the whole
file needs to be tossed overboard and cheered on as the sharks tear it
to individual bits.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 22:16:04 +0000 (15:16 -0700)]
Staging: hv: typedef removal for ChannelMessages.h
ChannelMessages.h is now coding style clean.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 26 Aug 2009 22:14:51 +0000 (15:14 -0700)]
Staging: hv: codingsyle cleanups for ChannelMessages.h
Everything but the typedefs are taken care of.
Also a number of unused defines were removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:17:36 +0000 (12:17 -0700)]
Staging: hv: typedef removal for VmbusApi.h
The function pointers still have ugly names, but the structures
are now cleaned up.
Note, a comment was added where the driver structure is pointing
at a problem that needs to be fixed up later in the code.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:16:33 +0000 (12:16 -0700)]
Staging: hv: coding style cleanups for VmbusApi.h
typedefs still need to be fixed up.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:54 +0000 (12:15 -0700)]
Staging: hv: typedef removal from VmbusChannelInterface.h
It's all clean now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:54 +0000 (12:15 -0700)]
Staging: hv: coding style cleanups for VmbusChannelInterface.h
typedefs still need to be fixed up.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:15:17 +0000 (12:15 -0700)]
Staging: hv: move HvStatus.h into hv_api.h
It doesn't need to be a standalone file anymore.
No code changed, only moving things around.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:14:11 +0000 (12:14 -0700)]
Staging: hv: coding style cleanups for HvStatus.h
Ugh, what a mess, it's all better now.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:13:27 +0000 (12:13 -0700)]
Staging: hv: create hv_api.h
Merge the different include/Hv*Api.h files together into
hv_api.h as they really don't justify separate files.
No code was changed here, only moving stuff around.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:12:31 +0000 (12:12 -0700)]
Staging: hv: remove volatile usage from HvSynicApi.h
It's pretty pointless as no one is using this structure, but even so
the use of volatile is so wrong here it's sad...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:11:26 +0000 (12:11 -0700)]
Staging: hv: typdef fixes for HvSynicApi.h
Still some volatile mis-usages left to fix.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:10:52 +0000 (12:10 -0700)]
Staging: hv: coding style cleanups for HvSynicApi.h
Don't fix the typedef issues, that will come next.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 20 Aug 2009 19:09:34 +0000 (12:09 -0700)]
Staging: hv: coding style cleanups for HvPtApi.h
Fix up the typedefs in there as well.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:26:24 +0000 (16:26 -0700)]
Staging: hv: rndis.h: typedef removal, part 2
This removes the rest of the typedefs in rndis.h
The file is now checkpatch.pl clean.
Note, there are a lot of structures in this file that are not used
anywhere. I don't know if we want to remove them, but I guess they
don't take up any space so it's a nice documentation trail.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:26:24 +0000 (16:26 -0700)]
Staging: hv: rndis.h: typedef removal, part 1
This removes about half of the typedefs in rndis.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:25:51 +0000 (16:25 -0700)]
Staging: hv: rndis.h: codingstyle fixes
This fixes all of the coding style issues in rndis.h with the
exception of the typedefs. That comes next.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:25:13 +0000 (16:25 -0700)]
Staging: hv: rndis.h: remove pointless typedefs
The typedefs for u32 are now removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:24:29 +0000 (16:24 -0700)]
Staging: hv: move rndis.h
This moves rndis.h from the include/ subdirectory. It doesn't
belong there.
No code changes happened here.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:23:45 +0000 (16:23 -0700)]
Staging: hv: vmbus.h coding style cleanups
Coding style fixes for vmbus.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:21:28 +0000 (16:21 -0700)]
Staging: hv: move vmbus.h
This moves vmbus.h from the include/ subdirectory. It doesn't
belong there.
No code changes happened here.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:21:28 +0000 (16:21 -0700)]
Staging: hv: coding style cleanup of include/HvVpApi.h
Coding style fixes for include/HvVpApi.h
All of the include/Hv*.h files should be merged eventually...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:21:28 +0000 (16:21 -0700)]
Staging: hv: coding style cleanup of include/HvHcApi.h
Coding style fixes for include/HvHcApi.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:20:41 +0000 (16:20 -0700)]
Staging: hv: remove include/HvHalApi.h
It isn't needed at all, was only being used for one typedef,
which is now removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:20:15 +0000 (16:20 -0700)]
Staging: hv: remove include/HvTypes.h
It isn't needed at all, was only being used for one typedef,
which is now removed.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:19:23 +0000 (16:19 -0700)]
Staging: hv: osd.c: coding style fixes
Codingstyle fixes for osd.c
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:18:56 +0000 (16:18 -0700)]
Staging: hv: osd.h: fix GUID reference problem
As GUID was a typedef, it hid the fact that we were passing it
a 2 variables in functions. This fixes this up by passing it
as a pointer, as it should be.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:17:03 +0000 (16:17 -0700)]
Staging: hv: osd.h: remove GUID typedef
GUID should not be a typedef. As proof of the problem of typedefs,
look, we are passing 2 of these as a value in functions! Bah...
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:16:21 +0000 (16:16 -0700)]
Staging: hv: osd.h: codingstyle cleanups
This fixes up the coding style issues in osd.h, with the exception of
the typedefs, they will be removed later.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 19 Aug 2009 23:14:47 +0000 (16:14 -0700)]
Staging: hv: move osd.h
This moves osd.h out of the include/ subdirectory.
No code changes are made here.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:21:19 +0000 (15:21 -0700)]
Staging: hv: clean up vstorage.h
Lots of coding style cleanups in vstorage.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:21:19 +0000 (15:21 -0700)]
Staging: hv: clean up typedefs in ChannelMgmt.h
This removes the typedefs from ChannelMgmt.h, it's now clean from a
codingstyle.pl standpoint.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:20:34 +0000 (15:20 -0700)]
Staging: hv: clean up typedefs in Hv.h
This removes the typedefs from Hv.h, it's now clean from a
codingstyle.pl standpoint.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:19:43 +0000 (15:19 -0700)]
Staging: hv: clean up RndisFilter.h
Cleans up coding style issues with RndisFilter.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 22:18:36 +0000 (15:18 -0700)]
Staging: hv: clean up NetVsc.h
Cleans up coding style issues with NetVsc.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:22:08 +0000 (17:22 -0700)]
Staging: hv: remove Sources.c
It's a .c file including other .c files, ick.
Remove that mess now that the header files are unwound.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:22:08 +0000 (17:22 -0700)]
Staging: hv: cleanup coding style issues in RingBuffer.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:23:00 +0000 (17:23 -0700)]
Staging: hv: cleanup coding style issues in VmbusPrivate.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:22:08 +0000 (17:22 -0700)]
Staging: hv: cleanup coding style issues in ChannelMgmt.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:22:08 +0000 (17:22 -0700)]
Staging: hv: cleanup coding style issues in ChannelInterface.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:21:51 +0000 (17:21 -0700)]
Staging: hv: cleanup coding style issues in VersionInfo.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:21:31 +0000 (17:21 -0700)]
Staging: hv: cleanup coding style issues in Channel.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:20:55 +0000 (17:20 -0700)]
Staging: hv: cleanup coding style issues in Hv.h
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 18 Aug 2009 00:20:02 +0000 (17:20 -0700)]
Staging: hv: remove ReadMsr and WriteMsr functions from Hv.h
They aren't needed as wrappers.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jan Beulich [Mon, 17 Aug 2009 11:54:31 +0000 (05:54 -0600)]
Staging: hv: adjust Hyper-V Kconfig
Hyper-V sub-components' options should all depend on the base option.
The default of these sub-component options is also more reasonably set
to that of the base option (since it makes little sense to enable the
base option without the sub-component ones).
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Randy Dunlap [Fri, 7 Aug 2009 18:17:04 +0000 (11:17 -0700)]
Staging: hv: blk dev depends on SCSI
hv block driver uses scsi_*() interfaces so it should depend on SCSI.
ERROR: "scsi_normalize_sense" [drivers/staging/hv/hv_blkvsc.ko] undefined!
ERROR: "scsi_print_sense_hdr" [drivers/staging/hv/hv_blkvsc.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nicolas Palix [Thu, 30 Jul 2009 15:37:23 +0000 (17:37 +0200)]
Staging: hv: Replace typedef SG_BUFFER_LIST by struct scatterlist
typedef SG_BUFFER_LIST is removed and its uses are replaced by the use of
struct scatterlist.
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:42:27 +0000 (15:42 -0700)]
Staging: hv: remove duplicated osd.o inclusions
Now that we have properly prefixed the osd.c functions, we don't need to
include it in each of the modules. So only build it into the hv_vmbus
module.
Export the symbols that the other hv_ modules need, so that they can
properly find them.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:40:57 +0000 (15:40 -0700)]
Staging: hv: remove timer wrapper functions
Use a real timer (there's only one in the code), no wrapper is needed,
it just increases the complexity for no reason.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:40:18 +0000 (15:40 -0700)]
Staging: hv: osd: add osd_ prefix to global functions
Put a "osd_" prefix on the osd.c functions in order for us to play nicer
in the kernel namespace.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:39:27 +0000 (15:39 -0700)]
Staging: hv: osd: remove physical address wrapper functions
Use the real functions the kernel provides, so that people can see what
is actually going on in the code easier.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:38:00 +0000 (15:38 -0700)]
Staging: hv: remove custom rdmsrl and wrmsrl functions
Use the ones that the kernel provides, they do it correctly.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 22:37:12 +0000 (15:37 -0700)]
Staging: hv: remove custom cpuid function
Use the one that the kernel provides, it does it correctly.
Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Wed, 29 Jul 2009 21:00:15 +0000 (17:00 -0400)]
Staging: hv: remove wrapper functions around kmap_
Remove PageMapVirtualAddress() and PageUnmapVirtualAddress() which
were wrappers around kmap_atomic() and kunmap_atomic()
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Wed, 29 Jul 2009 21:00:13 +0000 (17:00 -0400)]
Staging: hv: remove wrapper function VirtualFree
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Wed, 29 Jul 2009 21:00:12 +0000 (17:00 -0400)]
Staging: hv: remove wrapper functions for atomic operations
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Wed, 29 Jul 2009 21:00:11 +0000 (17:00 -0400)]
Staging: hv: remove wrapper functions for bit operations
There were several Bit* functions that did nothing but call the kernel
functions with the parameters reversed. Remove these and call the
functions directly.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Wed, 29 Jul 2009 21:00:10 +0000 (17:00 -0400)]
Staging: hv: remove WaitEventClose()
All WaitEventClose() close did was call kfree(), so get rid of it and
replace it with a call to kfree()
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Wed, 29 Jul 2009 21:00:09 +0000 (17:00 -0400)]
Staging: hv: rework use of workqueues in osd
Change the usage of workqueues to be consistant with other parts of
the kernel.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 16:06:51 +0000 (09:06 -0700)]
Staging: hv: fix sparse NULL pointer warnings
This fixes up all of the sparse warnings where NULL should be used
instead of 0.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 16:05:33 +0000 (09:05 -0700)]
Staging: hv: fix sparse function warnings
This fixes up all of the sparse warnings about functions not being
properly declared. Meaning, void functions need to say they are a void
function, otherwise the compiler assumes it is an integer here.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 29 Jul 2009 16:04:51 +0000 (09:04 -0700)]
Staging: hv: fix sparse static warnings
This fixes up all of the sparse warnings about static functions.
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nicolas Palix [Wed, 29 Jul 2009 12:10:19 +0000 (14:10 +0200)]
Staging: hv: Remove typedef STORVSC_REQUEST and PSTORVSC_REQUEST
typedef STORVSC_REQUEST and PSTORVSC_REQUEST are removed and their
usages are replace by the use of struct hv_storvsc_request and
struct hv_storvsc_request * respectively.
Here is the semantic patch generated to perform this transformation:
(http://coccinelle.lip6.fr/)
//<smpl>
@rm_STORVSC_REQUEST@
@@
-typedef struct _STORVSC_REQUEST
+struct hv_storvsc_request
{...}
-STORVSC_REQUEST
;
@rm_PSTORVSC_REQUEST@
@@
-typedef struct _STORVSC_REQUEST *PSTORVSC_REQUEST;
+struct hv_storvsc_request;
@fixtypedef_STORVSC_REQUEST@
typedef STORVSC_REQUEST;
@@
-STORVSC_REQUEST
+struct hv_storvsc_request
@fixstruct__STORVSC_REQUEST@
@@
struct
-_STORVSC_REQUEST
+hv_storvsc_request
@fixtypedef_PSTORVSC_REQUEST@
typedef PSTORVSC_REQUEST;
@@
-PSTORVSC_REQUEST
+struct hv_storvsc_request*
//</smpl>
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nicolas Palix [Wed, 29 Jul 2009 12:10:10 +0000 (14:10 +0200)]
Staging: hv: Remove typedef NETVSC_PACKET and PNETVSC_PACKET
typedef NETVSC_PACKET and PNETVSC_PACKET are removed and their usages
are replace by the use of struct hv_netvsc_packet and
struct hv_netvsc_packet * respectively.
Here is the semantic patch generated to perform this transformation:
(http://coccinelle.lip6.fr/)
//<smpl>
@rm_NETVSC_PACKET@
@@
-typedef struct _NETVSC_PACKET
+struct hv_netvsc_packet
{...}
-NETVSC_PACKET
;
@rm_PNETVSC_PACKET@
@@
-typedef struct _NETVSC_PACKET *PNETVSC_PACKET;
+struct hv_netvsc_packet;
@fixtypedef_NETVSC_PACKET@
typedef NETVSC_PACKET;
@@
-NETVSC_PACKET
+struct hv_netvsc_packet
@fixstruct__NETVSC_PACKET@
@@
struct
-_NETVSC_PACKET
+hv_netvsc_packet
@fixtypedef_PNETVSC_PACKET@
typedef PNETVSC_PACKET;
@@
-PNETVSC_PACKET
+struct hv_netvsc_packet*
//</smpl>
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nicolas Palix [Wed, 29 Jul 2009 12:09:45 +0000 (14:09 +0200)]
Staging: hv: Remove typedef DRIVER_OBJECT and PDRIVER_OBJECT
typedef DRIVER_OBJECT and PDRIVER_OBJECT are removed and their usages
are replace by the use of struct hv_driver and struct hv_driver *
respectively.
Here is the semantic patch generated to perform this transformation:
(http://coccinelle.lip6.fr/)
//<smpl>
@rm_DRIVER_OBJECT@
@@
-typedef struct _DRIVER_OBJECT
+struct hv_driver
{...}
-DRIVER_OBJECT
;
@rm_PDRIVER_OBJECT@
@@
-typedef struct _DRIVER_OBJECT *PDRIVER_OBJECT;
+struct hv_driver;
@fixtypedef_DRIVER_OBJECT@
typedef DRIVER_OBJECT;
@@
-DRIVER_OBJECT
+struct hv_driver
@fixstruct__DRIVER_OBJECT@
@@
struct
-_DRIVER_OBJECT
+hv_driver
@fixtypedef_PDRIVER_OBJECT@
typedef PDRIVER_OBJECT;
@@
-PDRIVER_OBJECT
+struct hv_driver*
//</smpl>
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 28 Jul 2009 23:18:05 +0000 (16:18 -0700)]
Staging: hv: properly fix the printk() warnings
This fixes the printk() warnings on all platforms now (x86-64 and i386).
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 28 Jul 2009 22:05:29 +0000 (15:05 -0700)]
Staging: hv: remove more printk() warnings
This should fix up the rest of the printk() warnings on an i386 build
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Tue, 28 Jul 2009 17:46:26 +0000 (13:46 -0400)]
Staging: hv: remove HANDLE typedef
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Tue, 28 Jul 2009 17:46:25 +0000 (13:46 -0400)]
Staging: hv remove TIMER typedef
Remove the TIMER typedef and also replace HANDLE types that use
the timer calls.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Tue, 28 Jul 2009 17:46:24 +0000 (13:46 -0400)]
Staging: hv: remove WAITEVENT typedef
Remove the WAITEVENT typedef and also replace HANDLE types that use
the WaitEvent calls with struct osd_waitevent.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Tue, 28 Jul 2009 17:46:23 +0000 (13:46 -0400)]
Staging: hv: comment out blkdev variable in blkvsc_ioctl
This variable generated an unused variable warning due to other code
in the fuction being commented out. This comments out the variable
defination so that the code compiles without warnings.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Tue, 28 Jul 2009 17:46:22 +0000 (13:46 -0400)]
Staging: hv: check return value of driver_for_each_device()
The return value of driver_for_each_device() is now checked. A
non-zero value simply generates a warning message, but it's better
than not checking at all.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Nicolas Palix [Tue, 28 Jul 2009 15:32:53 +0000 (17:32 +0200)]
Staging: hv: Transform PDEVICE_OBJECT and DEVICE_OBJECT typedefs into their corresponding structs
Remove typedef DEVICE_OBJECT and use a struct named hv_device instead.
Remove typedef PDEVICE_OBJECT which aliases a pointer and use
struct hv_device * instead.
Here is the semantic patch to perform this transformation:
(http://coccinelle.lip6.fr/)
//<smpl>
@rm_PDEVICE_OBJECT@
@@
-typedef struct _DEVICE_OBJECT *PDEVICE_OBJECT;
@rm_DEVICE_OBJECT@
@@
-typedef struct _DEVICE_OBJECT
+struct hv_device
{...}
-DEVICE_OBJECT
;
@fixtypedef_PDEVICE_OBJECT@
typedef PDEVICE_OBJECT;
@@
-PDEVICE_OBJECT
+struct hv_device*
@fixtypedef_DEVICE_OBJECT@
typedef DEVICE_OBJECT;
@@
-DEVICE_OBJECT
+struct hv_device
@fixstruct__DEVICE_OBJECT@
@@
struct
-_DEVICE_OBJECT
+hv_device
//</smpl>
Signed-off-by: Nicolas Palix <npalix@diku.dk>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:45 +0000 (16:47 -0400)]
Staging: hv: Remove WORKQUEUE typedef
WORKQUEUE was a wrapper around struct workqueue_struct so just use
that instead.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:44 +0000 (16:47 -0400)]
Staging: hv: remove NETVSC_DEVICE typedef
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:43 +0000 (16:47 -0400)]
Staging: hv: remove VMBUS_MSGINFO typedef
Note that this struct doesn't appear to be used anywhere and can
probably be removed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:42 +0000 (16:47 -0400)]
Staging: hv: remove VMBUS_CONNECTION typedef
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:41 +0000 (16:47 -0400)]
Staging: hv: remove VMBUS_CONNECT_STATE typedef
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:40 +0000 (16:47 -0400)]
Staging: hv: remove VMBUS_CHANNEL_PACKET_MULITPAGE_BUFFER typedef
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:39 +0000 (16:47 -0400)]
Staging: hv: remove VMBUS_CHANNEL_PACKET_PAGE_BUFFER typedef
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:38 +0000 (16:47 -0400)]
Staging: hv: Hv.c: remove unused physAddr
physAddr was declared but never used in HvInit()
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:37 +0000 (16:47 -0400)]
Staging: hv: vmbus_drv.c: remove unused structs
vmbus_ctl_table_hdr, vmbus_dev_ctl_table, vmbus_ctl_table, and
vmus_root_ctl_table were never used. This removes them.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Mon, 27 Jul 2009 20:47:36 +0000 (16:47 -0400)]
Staging: hv: check return value of device_register()
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>