openwrt/svn-archive/archive.git
18 years agoupdate ebtables to 2.0.8-rc2 (#558)
Felix Fietkau [Fri, 9 Jun 2006 01:55:14 +0000 (01:55 +0000)]
update ebtables to 2.0.8-rc2 (#558)

SVN-Revision: 3922

18 years agoppp: try to reconnect indefinitely (#551)
Felix Fietkau [Fri, 9 Jun 2006 01:34:58 +0000 (01:34 +0000)]
ppp: try to reconnect indefinitely (#551)

SVN-Revision: 3921

18 years agofix cflags, fix adjtimex patch (#587)
Felix Fietkau [Fri, 9 Jun 2006 01:30:19 +0000 (01:30 +0000)]
fix cflags, fix adjtimex patch (#587)

SVN-Revision: 3920

18 years agoupgrade maradns to the latest version (#511)
Felix Fietkau [Fri, 9 Jun 2006 00:46:54 +0000 (00:46 +0000)]
upgrade maradns to the latest version (#511)

SVN-Revision: 3919

18 years agoadd dropbear pubkey auth patch from #582
Felix Fietkau [Fri, 9 Jun 2006 00:29:26 +0000 (00:29 +0000)]
add dropbear pubkey auth patch from #582

SVN-Revision: 3916

18 years agodisable madwifi rfkill support by default (broken on some hardware)
Felix Fietkau [Thu, 8 Jun 2006 16:35:15 +0000 (16:35 +0000)]
disable madwifi rfkill support by default (broken on some hardware)

SVN-Revision: 3915

18 years agoadd rp-l2tp package (closes: #459).
Nicolas Thill [Sun, 4 Jun 2006 13:23:07 +0000 (13:23 +0000)]
add rp-l2tp package (closes: #459).

SVN-Revision: 3902

18 years agodon't compile libipkg in busybox if ipkg is disabled
Felix Fietkau [Sun, 4 Jun 2006 01:31:03 +0000 (01:31 +0000)]
don't compile libipkg in busybox if ipkg is disabled

SVN-Revision: 3901

18 years agoadd aircrack-ng package (thanks to Gerd, closes: #572, #581).
Nicolas Thill [Sat, 3 Jun 2006 16:23:17 +0000 (16:23 +0000)]
add aircrack-ng package (thanks to Gerd, closes: #572, #581).

SVN-Revision: 3900

18 years agofix wakelan addition.
Nicolas Thill [Sat, 3 Jun 2006 16:14:31 +0000 (16:14 +0000)]
fix wakelan addition.

SVN-Revision: 3899

18 years agoadd wakelan package (closes: #577).
Nicolas Thill [Fri, 2 Jun 2006 02:53:42 +0000 (02:53 +0000)]
add wakelan package (closes: #577).

SVN-Revision: 3893

18 years agoupdate avahi to v0.6.10.
Nicolas Thill [Fri, 2 Jun 2006 02:34:20 +0000 (02:34 +0000)]
update avahi to v0.6.10.

SVN-Revision: 3892

18 years agoadd libmcrypt package (thanks to Martin Matuska).
Nicolas Thill [Fri, 2 Jun 2006 01:32:15 +0000 (01:32 +0000)]
add libmcrypt package (thanks to Martin Matuska).

SVN-Revision: 3891

18 years agodisable check for openssl/engine.h in configure so that the package can be
Nicolas Thill [Thu, 1 Jun 2006 23:28:42 +0000 (23:28 +0000)]
disable check for openssl/engine.h in configure so that the package can be
backported to whiterussian.

SVN-Revision: 3889

18 years agoremove some debugging junk (#492)
Felix Fietkau [Wed, 31 May 2006 18:32:57 +0000 (18:32 +0000)]
remove some debugging junk (#492)

SVN-Revision: 3868

18 years agofix alsa compile error (backport from buildroot-ng)
Felix Fietkau [Wed, 31 May 2006 15:29:04 +0000 (15:29 +0000)]
fix alsa compile error (backport from buildroot-ng)

SVN-Revision: 3863

18 years agoupdate freeradius to v1.1.1.
Nicolas Thill [Sat, 27 May 2006 13:56:04 +0000 (13:56 +0000)]
update freeradius to v1.1.1.

SVN-Revision: 3830

18 years agoupgrade madwifi to r1590, fix the kernel cflags patch - thanks to Ge0rG
Imre Kaloz [Wed, 24 May 2006 09:39:23 +0000 (09:39 +0000)]
upgrade madwifi to r1590, fix the kernel cflags patch - thanks to Ge0rG

SVN-Revision: 3827

18 years agoFix default DebugLevel to 0, prevents from running in foreground when installing...
Florian Fainelli [Sun, 21 May 2006 20:06:04 +0000 (20:06 +0000)]
Fix default DebugLevel to 0, prevents from running in foreground when installing with ImageBuilder ...
Closes #491

SVN-Revision: 3816

18 years agotweak ebtables package:
Nicolas Thill [Sun, 21 May 2006 11:51:56 +0000 (11:51 +0000)]
tweak ebtables package:
 * add /etc/ethertypes (closes: #560),
 * strip, standardize,
 * bump release number.

SVN-Revision: 3811

18 years agowebif :
Florian Fainelli [Sat, 20 May 2006 19:06:26 +0000 (19:06 +0000)]
webif :
- add support for wl0_wdstimeout, wl0_antdiv (request by french Wireless User Groups), wl0_distance
- updated french translation, needs to update other translations
- Fixed cancel button not working, closes #543
- Preliminary OpenVPN webif support, partially closes #525

ntpclient: fix process running detection, closes #505
base-files:
- clean up per interface static_route code,restore old behaviour (with metric, gateway ...), closes #484
- add ifup_interfaces variable, can be used as order to bring interfaces, closes #309

SVN-Revision: 3809

18 years agoremove superfluous checks in /var/lock creation.
Nicolas Thill [Sat, 20 May 2006 18:58:04 +0000 (18:58 +0000)]
remove superfluous checks in /var/lock creation.

SVN-Revision: 3808

18 years agofix /var/log directory creation, needed for proper ppp operation.
Nicolas Thill [Sat, 20 May 2006 15:29:19 +0000 (15:29 +0000)]
fix /var/log directory creation, needed for proper ppp operation.

SVN-Revision: 3807

18 years agooops, fix wrong directories from my last commit.
Nicolas Thill [Sat, 20 May 2006 15:21:59 +0000 (15:21 +0000)]
oops, fix wrong directories from my last commit.

SVN-Revision: 3805

18 years agoadd support for multiple /etc/ppp/ip-{up,down} scripts.
Nicolas Thill [Sat, 20 May 2006 15:16:06 +0000 (15:16 +0000)]
add support for multiple /etc/ppp/ip-{up,down} scripts.

SVN-Revision: 3804

18 years agofix irq problem with the new brcm-2.4 system code
Felix Fietkau [Sat, 20 May 2006 02:35:12 +0000 (02:35 +0000)]
fix irq problem with the new brcm-2.4 system code

SVN-Revision: 3803

18 years agoBackport openvpn freatures from kamikaze to whiterussian
Florian Fainelli [Fri, 19 May 2006 13:14:02 +0000 (13:14 +0000)]
Backport openvpn freatures from kamikaze to whiterussian
Add easy-rsa package to openvpn, closes #541
Fix kmod-ipip module (wrong kernel extension)

SVN-Revision: 3800

18 years agoAdd kmod-ipip, closes #539
Florian Fainelli [Fri, 19 May 2006 09:52:54 +0000 (09:52 +0000)]
Add kmod-ipip, closes #539

SVN-Revision: 3799

18 years agoupdate siproxd to v0.5.12, standardize.
Nicolas Thill [Thu, 18 May 2006 23:53:14 +0000 (23:53 +0000)]
update siproxd to v0.5.12, standardize.

SVN-Revision: 3798

18 years agoupdate sipsak to v0.9.6, add mirror url.
Nicolas Thill [Thu, 18 May 2006 23:51:53 +0000 (23:51 +0000)]
update sipsak to v0.9.6, add mirror url.

SVN-Revision: 3797

18 years agoadd axtls embedded ssl/tls library.
Nicolas Thill [Thu, 18 May 2006 22:15:21 +0000 (22:15 +0000)]
add axtls embedded ssl/tls library.

SVN-Revision: 3795

18 years agoupdate busybox to v1.1.3, remove passwd_salt patch (fixed upstream).
Nicolas Thill [Thu, 18 May 2006 08:32:07 +0000 (08:32 +0000)]
update busybox to v1.1.3, remove passwd_salt patch (fixed upstream).

SVN-Revision: 3794

18 years agoload kernel modules in kmod- packages from postinst scripts at install.
Nicolas Thill [Thu, 18 May 2006 00:35:02 +0000 (00:35 +0000)]
load kernel modules in kmod- packages from postinst scripts at install.

SVN-Revision: 3793

18 years agoadd gcom to trunk too (closes: #333).
Nicolas Thill [Wed, 17 May 2006 01:37:51 +0000 (01:37 +0000)]
add gcom to trunk too (closes: #333).

SVN-Revision: 3792

18 years agofix rebuild of pwlib and openh323 after root_clean.
Nicolas Thill [Wed, 17 May 2006 01:07:20 +0000 (01:07 +0000)]
fix rebuild of pwlib and openh323 after root_clean.

SVN-Revision: 3791

18 years agoadd md5sum (commit some forgotten changes).
Nicolas Thill [Tue, 16 May 2006 23:33:00 +0000 (23:33 +0000)]
add md5sum (commit some forgotten changes).

SVN-Revision: 3787

18 years agoadd matrixtunnel package (thanks to Lorenz Schori).
Nicolas Thill [Mon, 15 May 2006 07:14:09 +0000 (07:14 +0000)]
add matrixtunnel package (thanks to Lorenz Schori).

SVN-Revision: 3779

18 years agoremove obsolete and unmaintained packages, as soon as 2.6.17 is out, dscape and bcm43...
Waldemar Brodkorb [Sun, 14 May 2006 08:33:24 +0000 (08:33 +0000)]
remove obsolete and unmaintained packages, as soon as 2.6.17 is out, dscape and bcm43xx driver is integrated into mainstream

SVN-Revision: 3773

18 years agoadd common functions for the new config file format
Felix Fietkau [Wed, 10 May 2006 18:17:12 +0000 (18:17 +0000)]
add common functions for the new config file format

SVN-Revision: 3751

18 years agoresync config-ramdisk to config
Mike Baker [Tue, 9 May 2006 17:16:37 +0000 (17:16 +0000)]
resync config-ramdisk to config

SVN-Revision: 3743

18 years agoupdate busybox+ipkg to latest ipkg (v0.99.162),
Nicolas Thill [Tue, 9 May 2006 03:42:19 +0000 (03:42 +0000)]
update busybox+ipkg to latest ipkg (v0.99.162),
fix a bug in ipkg that would prevent it from installing local packages if
at least a remote package with the same name is available.

SVN-Revision: 3742

18 years agoupdate ulogd to v1.24, add a -mod-sqlite output plugin.
Nicolas Thill [Mon, 8 May 2006 16:52:37 +0000 (16:52 +0000)]
update ulogd to v1.24, add a -mod-sqlite output plugin.

SVN-Revision: 3741

18 years agoupdate wpa_supplicant to v0.4.9,
Nicolas Thill [Mon, 8 May 2006 16:07:06 +0000 (16:07 +0000)]
update wpa_supplicant to v0.4.9,
add dependency on madwifi-ng (needed to build).

SVN-Revision: 3740

18 years agoadd sablevm dependency on libpthread.
Nicolas Thill [Mon, 8 May 2006 14:38:05 +0000 (14:38 +0000)]
add sablevm dependency on libpthread.

SVN-Revision: 3739

18 years agoupdate sablevm to 1.13 (closes: #524),
Nicolas Thill [Mon, 8 May 2006 14:23:17 +0000 (14:23 +0000)]
update sablevm to 1.13 (closes: #524),
add the patch from whiterussian to use a reasonable heap size.

SVN-Revision: 3738

18 years agomake asterisk chan_bluetooth and chan_h323 modules optional,
Nicolas Thill [Sun, 7 May 2006 19:05:51 +0000 (19:05 +0000)]
make asterisk chan_bluetooth and chan_h323 modules optional,
link openh323 and pwlib statically.

SVN-Revision: 3737

18 years agofix ulogd-mod-pcap packaging
Nicolas Thill [Sun, 7 May 2006 15:33:43 +0000 (15:33 +0000)]
fix ulogd-mod-pcap packaging

SVN-Revision: 3736

18 years agoexport get_system_type()
Felix Fietkau [Sun, 7 May 2006 00:59:39 +0000 (00:59 +0000)]
export get_system_type()

SVN-Revision: 3735

18 years agoupdate madwifi to r1543
Felix Fietkau [Sat, 6 May 2006 23:40:19 +0000 (23:40 +0000)]
update madwifi to r1543

SVN-Revision: 3734

18 years agoappend a table with offsets for the no-ack and slot timing code to wl.o
Felix Fietkau [Sat, 6 May 2006 06:30:32 +0000 (06:30 +0000)]
append a table with offsets for the no-ack and slot timing code to wl.o

SVN-Revision: 3733

18 years agorename wl.o wireless interface from ethX to wl0
Felix Fietkau [Sat, 6 May 2006 02:34:35 +0000 (02:34 +0000)]
rename wl.o wireless interface from ethX to wl0

SVN-Revision: 3732

18 years agofix duplicate packaging of the ipv6 imq module
Felix Fietkau [Fri, 5 May 2006 20:39:34 +0000 (20:39 +0000)]
fix duplicate packaging of the ipv6 imq module

SVN-Revision: 3731

18 years agoMore au1000 fixes.
Florian Fainelli [Fri, 5 May 2006 09:58:23 +0000 (09:58 +0000)]
More au1000 fixes.
Clean up patch
Add mount_root specific (different partition naming)
Add an init script to kernel command line to set up OpenWrt at boot time

SVN-Revision: 3730

18 years agoFix zImage target, now really build valid images
Florian Fainelli [Thu, 4 May 2006 22:45:27 +0000 (22:45 +0000)]
Fix zImage target, now really build valid images

SVN-Revision: 3729

18 years agoadd missing libpng dependency
Felix Fietkau [Thu, 4 May 2006 21:15:59 +0000 (21:15 +0000)]
add missing libpng dependency

SVN-Revision: 3728

18 years agobrcm-2.4 system code and driver update
Felix Fietkau [Thu, 4 May 2006 00:22:23 +0000 (00:22 +0000)]
brcm-2.4 system code and driver update

SVN-Revision: 3727

18 years agofix /etc/config/firewall
Felix Fietkau [Wed, 3 May 2006 23:44:45 +0000 (23:44 +0000)]
fix /etc/config/firewall

SVN-Revision: 3726

18 years agofix stupid typo in firewall init script
Felix Fietkau [Tue, 2 May 2006 20:16:26 +0000 (20:16 +0000)]
fix stupid typo in firewall init script

SVN-Revision: 3724

18 years agoAdd mips kernel entry patch
Florian Fainelli [Tue, 2 May 2006 10:28:13 +0000 (10:28 +0000)]
Add mips kernel entry patch
Fix image creation

SVN-Revision: 3723

18 years agoremove Maintainer and Source fiels from ipk/control files
Nicolas Thill [Mon, 1 May 2006 12:06:01 +0000 (12:06 +0000)]
remove Maintainer and Source fiels from ipk/control files

SVN-Revision: 3722

18 years agoadd squid ipkg/conffiles, missing from [3718].
Nicolas Thill [Mon, 1 May 2006 11:48:52 +0000 (11:48 +0000)]
add squid ipkg/conffiles, missing from [3718].

SVN-Revision: 3721

18 years agoremove intrusive patch and find-a-better-way-to-do-it (tm)
Nicolas Thill [Mon, 1 May 2006 11:29:52 +0000 (11:29 +0000)]
remove intrusive patch and find-a-better-way-to-do-it (tm)

SVN-Revision: 3720

18 years agoremove /usr/{include,lib} ref from libxml2 pkgconfig
Nicolas Thill [Mon, 1 May 2006 11:24:15 +0000 (11:24 +0000)]
remove /usr/{include,lib} ref from libxml2 pkgconfig

SVN-Revision: 3719

18 years agofix squid build, standardize, add ipkg/conffiles.
Nicolas Thill [Sun, 30 Apr 2006 23:31:37 +0000 (23:31 +0000)]
fix squid build, standardize, add ipkg/conffiles.

SVN-Revision: 3718

18 years agoNow build rootfs+kernel images
Florian Fainelli [Sun, 30 Apr 2006 23:09:45 +0000 (23:09 +0000)]
Now build rootfs+kernel images

SVN-Revision: 3717

18 years agofix build on x86 (--disable-asm), standardize.
Nicolas Thill [Sun, 30 Apr 2006 18:38:02 +0000 (18:38 +0000)]
fix build on x86 (--disable-asm), standardize.

SVN-Revision: 3716

18 years agoUpdate pptpd to 1.3.0, closes #496 for kamikaze
Florian Fainelli [Sun, 30 Apr 2006 13:04:31 +0000 (13:04 +0000)]
Update pptpd to 1.3.0, closes #496 for kamikaze

SVN-Revision: 3715

18 years agoinstall more iptables development stuff into the staging dir
Felix Fietkau [Sat, 29 Apr 2006 21:43:26 +0000 (21:43 +0000)]
install more iptables development stuff into the staging dir

SVN-Revision: 3713

18 years agoupdate sibyte kernel, fix a few remaining bugs
Mike Baker [Fri, 28 Apr 2006 22:35:21 +0000 (22:35 +0000)]
update sibyte kernel, fix a few remaining bugs

SVN-Revision: 3712

18 years agoclean up code so it compiles
Mike Baker [Fri, 28 Apr 2006 22:34:33 +0000 (22:34 +0000)]
clean up code so it compiles

SVN-Revision: 3711

18 years agodon't drop all incoming connections if wan_ifname is not set
Felix Fietkau [Thu, 27 Apr 2006 14:55:04 +0000 (14:55 +0000)]
don't drop all incoming connections if wan_ifname is not set

SVN-Revision: 3709

18 years agofix kmod-sched build on 2.4
Nicolas Thill [Wed, 26 Apr 2006 05:52:15 +0000 (05:52 +0000)]
fix kmod-sched build on 2.4

SVN-Revision: 3708

18 years agofix typo and wrong func call in rint()
Nicolas Thill [Wed, 26 Apr 2006 05:50:16 +0000 (05:50 +0000)]
fix typo and wrong func call in rint()

SVN-Revision: 3707

18 years agofix busybox applet lookup (thanks, Stefan Weil)
Felix Fietkau [Tue, 25 Apr 2006 23:58:48 +0000 (23:58 +0000)]
fix busybox applet lookup (thanks, Stefan Weil)

SVN-Revision: 3706

18 years agofix export of __ashldi3, __ashrdi3 and __lshrdi3 symbols
Felix Fietkau [Tue, 25 Apr 2006 23:35:14 +0000 (23:35 +0000)]
fix export of __ashldi3, __ashrdi3 and __lshrdi3 symbols

SVN-Revision: 3705

18 years agoMerge 2.4 patches to 2.6 kernel.
Florian Fainelli [Mon, 24 Apr 2006 12:09:31 +0000 (12:09 +0000)]
Merge 2.4 patches to 2.6 kernel.
Update kernel config

SVN-Revision: 3704

18 years agoAdd watchdog driver, prevents device from rebooting. Kernel now fully usable
Florian Fainelli [Sat, 22 Apr 2006 15:30:07 +0000 (15:30 +0000)]
Add watchdog driver, prevents device from rebooting. Kernel now fully usable
Add patches for various image formats
Add map for MTX-1 board (same as pb1500)

SVN-Revision: 3702

18 years agopreliminary sibyte support
Mike Baker [Fri, 21 Apr 2006 23:25:46 +0000 (23:25 +0000)]
preliminary sibyte support

SVN-Revision: 3701

18 years agoadd support for the wrt54g3g pcmcia
Felix Fietkau [Fri, 21 Apr 2006 16:35:21 +0000 (16:35 +0000)]
add support for the wrt54g3g pcmcia

SVN-Revision: 3700

18 years agooops... committed the wrong patch
Felix Fietkau [Fri, 21 Apr 2006 14:26:38 +0000 (14:26 +0000)]
oops... committed the wrong patch

SVN-Revision: 3699

18 years agofix jpeg build for x86_64 hosts
Felix Fietkau [Fri, 21 Apr 2006 14:21:30 +0000 (14:21 +0000)]
fix jpeg build for x86_64 hosts

SVN-Revision: 3698

18 years agoFix wrong compile dependency, closes #501
Florian Fainelli [Fri, 21 Apr 2006 10:26:05 +0000 (10:26 +0000)]
Fix wrong compile dependency, closes #501

SVN-Revision: 3696

18 years agoupdate OpenVPN to 2.0.7 (security update), closes #497
Oliver Ertl [Wed, 19 Apr 2006 19:28:09 +0000 (19:28 +0000)]
update OpenVPN to 2.0.7 (security update), closes #497

SVN-Revision: 3673

18 years agoEnable mod-ulogd-pcap build
Florian Fainelli [Wed, 19 Apr 2006 10:07:20 +0000 (10:07 +0000)]
Enable mod-ulogd-pcap build

SVN-Revision: 3671

18 years agoLinux 2.6.16.7
Imre Kaloz [Tue, 18 Apr 2006 17:43:57 +0000 (17:43 +0000)]
Linux 2.6.16.7

SVN-Revision: 3670

18 years agoFix patch, closes #494
Florian Fainelli [Mon, 17 Apr 2006 21:04:55 +0000 (21:04 +0000)]
Fix patch, closes #494

SVN-Revision: 3668

18 years agocleanup watchdog
Mike Baker [Mon, 17 Apr 2006 18:39:32 +0000 (18:39 +0000)]
cleanup watchdog

SVN-Revision: 3666

18 years agoXScale support (Gateway 7001), take two
Imre Kaloz [Mon, 17 Apr 2006 18:03:53 +0000 (18:03 +0000)]
XScale support (Gateway 7001), take two

SVN-Revision: 3665

18 years agoupdate kismet to 2006-04-R1 (from #485)
Mike Baker [Mon, 17 Apr 2006 17:15:43 +0000 (17:15 +0000)]
update kismet to 2006-04-R1 (from #485)

SVN-Revision: 3664

18 years agoCreate iptraf directories
Florian Fainelli [Sun, 16 Apr 2006 22:26:21 +0000 (22:26 +0000)]
Create iptraf directories
Build mod_webdav for lighttpd
Fix libtool patch

SVN-Revision: 3661

18 years agoUpdate iptraf to 3.0.0
Florian Fainelli [Sun, 16 Apr 2006 14:35:32 +0000 (14:35 +0000)]
Update iptraf to 3.0.0

SVN-Revision: 3660

18 years agoFixed typos in menuconfig
Florian Fainelli [Sat, 15 Apr 2006 08:40:42 +0000 (08:40 +0000)]
Fixed typos in menuconfig
Cleanup patch, fix building when using 'pkg-config --openssl' on host system, closes #482

SVN-Revision: 3657

18 years agocleanup makefiles
Mike Baker [Fri, 14 Apr 2006 22:13:32 +0000 (22:13 +0000)]
cleanup makefiles

SVN-Revision: 3656

18 years agohardware watchdog
Mike Baker [Fri, 14 Apr 2006 22:11:32 +0000 (22:11 +0000)]
hardware watchdog

SVN-Revision: 3655

18 years agofinally fix/tweaks for vncrepeater (thanks to Russell Harmon)
Oliver Ertl [Fri, 14 Apr 2006 21:57:31 +0000 (21:57 +0000)]
finally fix/tweaks for vncrepeater (thanks to Russell Harmon)

SVN-Revision: 3654

18 years agofix vncrepeater download url
Oliver Ertl [Fri, 14 Apr 2006 21:19:46 +0000 (21:19 +0000)]
fix vncrepeater download url

SVN-Revision: 3653

18 years agoelinks cosmetic fix
Oliver Ertl [Fri, 14 Apr 2006 21:19:06 +0000 (21:19 +0000)]
elinks cosmetic fix

SVN-Revision: 3652

18 years agoAdd squid, with its modules.
Florian Fainelli [Fri, 14 Apr 2006 14:20:13 +0000 (14:20 +0000)]
Add squid, with its modules.
Fix fakeidentd compilation (wrong source downloading),closes #478
Fix GNUTLS dependency for weechat

SVN-Revision: 3650

18 years agoadd preliminary support for the XScale port, generic endianness indication
Imre Kaloz [Fri, 14 Apr 2006 10:23:54 +0000 (10:23 +0000)]
add preliminary support for the XScale port, generic endianness indication

SVN-Revision: 3648

18 years agofix openswan patch
Felix Fietkau [Thu, 13 Apr 2006 18:33:50 +0000 (18:33 +0000)]
fix openswan patch

SVN-Revision: 3639