Gabor Juhos [Tue, 29 Jan 2013 18:29:45 +0000 (18:29 +0000)]
kernel: update linux 3.7 to 3.7.5
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
SVN-Revision: 35390
Felix Fietkau [Tue, 29 Jan 2013 18:16:55 +0000 (18:16 +0000)]
build: fix the strip default for musl
SVN-Revision: 35389
Felix Fietkau [Tue, 29 Jan 2013 16:12:00 +0000 (16:12 +0000)]
add libusb-compat
SVN-Revision: 35387
Felix Fietkau [Tue, 29 Jan 2013 14:40:04 +0000 (14:40 +0000)]
netifd: update to latest version
fixes DNS servers on reload (#12910)
fixes ubus object race on reload or down/up (#12612)
SVN-Revision: 35383
Felix Fietkau [Tue, 29 Jan 2013 13:18:56 +0000 (13:18 +0000)]
samba36: update to 3.6.11 and refresh patches (based on patch from #12914)
SVN-Revision: 35382
Felix Fietkau [Tue, 29 Jan 2013 12:27:17 +0000 (12:27 +0000)]
usb-modeswitch: split out usb-modeswitch-data again
SVN-Revision: 35381
Felix Fietkau [Tue, 29 Jan 2013 12:02:10 +0000 (12:02 +0000)]
usb-modeswitch: add from /packages, merge usb-modeswitch-data, use libusb-compat, add myself as maintainer
SVN-Revision: 35379
John Crispin [Tue, 29 Jan 2013 11:06:57 +0000 (11:06 +0000)]
fix mtd_mp25p80_add_gd25q32_gd25q64.patch
SVN-Revision: 35378
Steven Barth [Tue, 29 Jan 2013 11:05:22 +0000 (11:05 +0000)]
netifd: implement IPv6 prefix deprecation according to RFC 6204
SVN-Revision: 35377
Felix Fietkau [Tue, 29 Jan 2013 10:48:46 +0000 (10:48 +0000)]
move a few packages to system/utils
SVN-Revision: 35375
Felix Fietkau [Tue, 29 Jan 2013 10:48:41 +0000 (10:48 +0000)]
usbutils: add from /packages, clean up, add myself as maintainer
SVN-Revision: 35374
Felix Fietkau [Tue, 29 Jan 2013 10:48:37 +0000 (10:48 +0000)]
libusb: add from /packages, add myself as maintainer
SVN-Revision: 35373
Steven Barth [Tue, 29 Jan 2013 10:13:49 +0000 (10:13 +0000)]
6relayd: remove IPv6 forwarding-sysctl workaround
SVN-Revision: 35371
Steven Barth [Tue, 29 Jan 2013 10:13:44 +0000 (10:13 +0000)]
odhcp6c: remove IPv6 forwarding-sysctl workaround
SVN-Revision: 35370
Steven Barth [Tue, 29 Jan 2013 10:13:39 +0000 (10:13 +0000)]
netifd: remove IPv6 forwarding-sysctl workaround
SVN-Revision: 35369
Steven Barth [Tue, 29 Jan 2013 10:13:33 +0000 (10:13 +0000)]
base-files: Fix race-conditions with IPv6 sysctls
SVN-Revision: 35368
Florian Fainelli [Tue, 29 Jan 2013 09:46:11 +0000 (09:46 +0000)]
Fix GigaDevice GD25Q32/GD25Q64 SPI Flash bad commit
Fix GigaDevice GD25Q32/GD25Q64 SPI Flash bad commit.
The patch was added to "linux/generic/patches-3.6" instead of
"target/linux/generic/patches-3.6".
I also fixed a missing patch space and refreshed generic patches.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Florian Fainelli <florian@openwrt.org>
SVN-Revision: 35367
Gabor Juhos [Tue, 29 Jan 2013 09:44:58 +0000 (09:44 +0000)]
generic: fix build failure in MIPS kexec code if SMP is enabled
Fix it for older kernels as well.
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
SVN-Revision: 35366
Gabor Juhos [Tue, 29 Jan 2013 09:40:29 +0000 (09:40 +0000)]
ar71xx: add TP-LINK WA-801ND to run-time model detection
A small cosmetic fix to show the HW model name correctly in LuCI.
Patch-by: Amir Sagie <openwrt-devel@taproot.org.il>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
SVN-Revision: 35365
Gabor Juhos [Tue, 29 Jan 2013 09:40:23 +0000 (09:40 +0000)]
generic: fix build failure in MIPS kexec code if SMP is enabled
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
SVN-Revision: 35364
Felix Fietkau [Mon, 28 Jan 2013 20:35:55 +0000 (20:35 +0000)]
netifd: update to latest version, fixes setting addresses/routes on alias interfaces
SVN-Revision: 35362
John Crispin [Mon, 28 Jan 2013 19:10:21 +0000 (19:10 +0000)]
Add support for GigaDevice GD25Q32/GD25Q64 SPI Flash in m25p80.c
Add support for GigaDevice GD25Q32 32 Mbit (4 MB) SPI Flash (see datasheet: http://www.gigadevice.com/UserFiles/GD25Q32_Rev0.2(1).pdf) used in Hame MPR-A1 and clones and for GigaDevice GD25Q64 64 Mbit (8 MB) SPI Flash used in Hame MPR-A2 devices (datasheet: http://www.gigadevice.com/UserFiles/GD25Q64.pdf).
Signed-off-by: Michel Stempin <michel.stempin@wanadoo.fr>
Patchwork: http://patchwork.openwrt.org/patch/3120/
SVN-Revision: 35361
John Crispin [Mon, 28 Jan 2013 18:20:10 +0000 (18:20 +0000)]
package ncm & qmi wwan
Signed-off-by: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>
Patchwork: http://patchwork.openwrt.org/patch/3134/
SVN-Revision: 35360
John Crispin [Mon, 28 Jan 2013 18:06:31 +0000 (18:06 +0000)]
fix for non-blinking LAN LEDs
https://dev.openwrt.org/ticket/12830
SVN-Revision: 35359
Jo-Philipp Wich [Mon, 28 Jan 2013 18:05:33 +0000 (18:05 +0000)]
hostapd: don't configure wpa_supplicant with empty password="" if no password is specified (#12912)
SVN-Revision: 35358
John Crispin [Mon, 28 Jan 2013 17:46:07 +0000 (17:46 +0000)]
dont load gptu on ase
fixes #12792
SVN-Revision: 35357
John Crispin [Mon, 28 Jan 2013 17:44:41 +0000 (17:44 +0000)]
ramips: reset switch on single-port devices
Signed-off-by: Daniel Gole <dgolle@allnet.de>
SVN-Revision: 35356
John Crispin [Mon, 28 Jan 2013 17:44:20 +0000 (17:44 +0000)]
refresh patches
SVN-Revision: 35355
John Crispin [Mon, 28 Jan 2013 17:43:35 +0000 (17:43 +0000)]
Fix ARV7518 USB
This patch correctly fixes USB on Lantiq ARV7518.
There was a failed attempt on fixing this on r35077 (https://dev.openwrt.org/changeset/35077/).
Signed-off-by: José Vázquez Fernández <ppvazquezfer@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
SVN-Revision: 35354
John Crispin [Mon, 28 Jan 2013 17:43:25 +0000 (17:43 +0000)]
Add ath9k eeprom and pci fixup support
Add ath9k eeprom and pci fixup support (again) for linux 3.7.
On linux 3.3, the fixup forced the regdomain to 0x67, causing low TX power.
This patch only corrects checksum, the rest of the EEPROM isn't changed.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
SVN-Revision: 35353
John Crispin [Mon, 28 Jan 2013 17:42:59 +0000 (17:42 +0000)]
Add support for ARV4518PW R01 and rename R01A.
There are two different versions of SMC7908A-ISP: R01 and R01A.
R01 has an internal clock for PCI, meanwhile R01A has an external clock.
This fixes: https://dev.openwrt.org/ticket/12884
Signed-off-by: John Crispin <blogic@openwrt.org>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
SVN-Revision: 35352
Jo-Philipp Wich [Mon, 28 Jan 2013 15:54:27 +0000 (15:54 +0000)]
scripts: bundle-libraries.sh: support mixing 32bit and 64bit binaries
SVN-Revision: 35349
Jo-Philipp Wich [Mon, 28 Jan 2013 15:53:44 +0000 (15:53 +0000)]
firewall: flush conntrack table after changing interface rules
SVN-Revision: 35348
Steven Barth [Mon, 28 Jan 2013 14:07:27 +0000 (14:07 +0000)]
netifd: IPv6 sysctl, restart IPv6 in static mode to send RS
SVN-Revision: 35347
Steven Barth [Mon, 28 Jan 2013 13:53:48 +0000 (13:53 +0000)]
netifd: add SLAAC ipv6 value for static-proto
SVN-Revision: 35346
Steven Barth [Mon, 28 Jan 2013 13:53:43 +0000 (13:53 +0000)]
odhcp6c: work-around for proto-script to avoid loosing the default route
SVN-Revision: 35345
Steven Barth [Mon, 28 Jan 2013 13:53:38 +0000 (13:53 +0000)]
base-files: remove IPv6-forwarding setting for all interfaces
SVN-Revision: 35344
Felix Fietkau [Sun, 27 Jan 2013 23:23:39 +0000 (23:23 +0000)]
kernel: disable CONFIG_CRYPTO_MANAGER2, it is not needed
SVN-Revision: 35342
Hauke Mehrtens [Sun, 27 Jan 2013 21:48:28 +0000 (21:48 +0000)]
brcm47xx: load pps_core and ptp before tg3 to make the interface available for failsafe.
SVN-Revision: 35341
Hauke Mehrtens [Sun, 27 Jan 2013 21:39:53 +0000 (21:39 +0000)]
kernel: b53: the b53 spi driver depends on spi
SVN-Revision: 35340
Hauke Mehrtens [Sun, 27 Jan 2013 21:28:26 +0000 (21:28 +0000)]
kernel: make usb2-pci depend on usb2 and not the other way around
SVN-Revision: 35339
Hauke Mehrtens [Sun, 27 Jan 2013 21:23:33 +0000 (21:23 +0000)]
kernel: activate input-matrixkmap for kernel 3.8
SVN-Revision: 35338
Hauke Mehrtens [Sun, 27 Jan 2013 21:19:48 +0000 (21:19 +0000)]
kernel: add ehci-platform.ko and ehci-pci.ko when build with kernel 3.8
SVN-Revision: 35337
Hauke Mehrtens [Sun, 27 Jan 2013 21:18:52 +0000 (21:18 +0000)]
kernel: add packages for pps and ptp, they are needed by tg3 in kernel 3.8
SVN-Revision: 35336
Hauke Mehrtens [Sun, 27 Jan 2013 21:17:38 +0000 (21:17 +0000)]
kernel: remove __devinit, __devexit and __devexit_p for kernel 3.8
These attributes where removed with kernel 3.8 and are now causing compile errors.
SVN-Revision: 35335
Hauke Mehrtens [Sun, 27 Jan 2013 21:16:35 +0000 (21:16 +0000)]
acx-mac80211: make it compile with kernel 3.8
SVN-Revision: 35334
Hauke Mehrtens [Sun, 27 Jan 2013 21:15:48 +0000 (21:15 +0000)]
acx-mac80211: refresh patches
SVN-Revision: 35333
Hauke Mehrtens [Sun, 27 Jan 2013 21:15:13 +0000 (21:15 +0000)]
acx-mac80211: use same config options as mac80211 package
Problem was missing CONFIG_MAC80211_DEBUGFS
in the acx-mac80211 build, which broke subsequently the ABI in struct
ieee80211_ops. Defect manifested in failing ieee80211_alloc_hw() and maybe
also in other strange behaviour before.
I added CONFIG_CFG80211_DEBUGFS, CONFIG_MAC80211_DEBUGFS and the same also
for CONFIG_MAC80211_MESH, just to be inline on how it's done currently in
package/mac80211/Makefile.
Thank you Oliver Winker
SVN-Revision: 35332
Felix Fietkau [Sun, 27 Jan 2013 19:02:38 +0000 (19:02 +0000)]
netfilter: add support for flushing conntrack via /proc
SVN-Revision: 35330
Felix Fietkau [Sun, 27 Jan 2013 17:49:09 +0000 (17:49 +0000)]
kernel: clean up crypto kconfig options on 3.8
SVN-Revision: 35329
Hauke Mehrtens [Sun, 27 Jan 2013 17:48:48 +0000 (17:48 +0000)]
kernel: remove __devinit, __devexit and __devexit_p for kernel 3.8
These attributes where removed with kernel 3.8 and are now causing compile errors.
SVN-Revision: 35328
Felix Fietkau [Sun, 27 Jan 2013 17:23:12 +0000 (17:23 +0000)]
kernel: clean up crypto related kconfig options
SVN-Revision: 35327
Felix Fietkau [Sun, 27 Jan 2013 16:38:27 +0000 (16:38 +0000)]
ar71xx: disable support for unsupported mtd configuration, saves about 5K kernel size after lzma
SVN-Revision: 35326
Felix Fietkau [Sun, 27 Jan 2013 16:21:08 +0000 (16:21 +0000)]
kernel: prevent cryptomgr from pulling in useless extra dependencies for tests that are not run
Reduces kernel size after LZMA by about 5k on MIPS
SVN-Revision: 35325
Hauke Mehrtens [Sat, 26 Jan 2013 20:34:38 +0000 (20:34 +0000)]
brcm47xx: create image for Netgear WNDR3400 V1
SVN-Revision: 35323
Hauke Mehrtens [Sat, 26 Jan 2013 20:34:00 +0000 (20:34 +0000)]
brcm47xx: add initial board detection code
SVN-Revision: 35322
Hauke Mehrtens [Sat, 26 Jan 2013 20:33:23 +0000 (20:33 +0000)]
brcm47xx: add gpio to irq function again
SVN-Revision: 35321
Felix Fietkau [Sat, 26 Jan 2013 16:26:13 +0000 (16:26 +0000)]
kernel: use -ffunction-sections, -fdata-sections and --gc-sections on mips
in combination with kernel symbol export stripping this significantly reduces
the kernel image size
SVN-Revision: 35320
Felix Fietkau [Sat, 26 Jan 2013 16:26:04 +0000 (16:26 +0000)]
kernel: fix module export stripping
SVN-Revision: 35319
Gabor Juhos [Thu, 24 Jan 2013 17:08:37 +0000 (17:08 +0000)]
kernel: update linux 3.7 to 3.7.4
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
SVN-Revision: 35318
Florian Fainelli [Thu, 24 Jan 2013 17:04:52 +0000 (17:04 +0000)]
kernel: refresh 3.8 patches
Signed-off-by: Florian Fainelli <florian@openwrt.org>
SVN-Revision: 35317
Florian Fainelli [Thu, 24 Jan 2013 17:04:46 +0000 (17:04 +0000)]
mvebu: update to 3.8-rc4
Signed-off-by: Florian Fainelli <florian@openwrt.org>
SVN-Revision: 35316
Hauke Mehrtens [Thu, 24 Jan 2013 14:48:15 +0000 (14:48 +0000)]
kernel: add missing config options for 3.8
SVN-Revision: 35315
Hauke Mehrtens [Thu, 24 Jan 2013 14:38:10 +0000 (14:38 +0000)]
brcm47xx: change generic profiles
The default profile now contains Ethernet drivers for all the types
found on supported boards. There are other profiles for each Ethernet
driver.
SVN-Revision: 35314
Felix Fietkau [Wed, 23 Jan 2013 16:31:38 +0000 (16:31 +0000)]
kernel: remove the cisco sip phone patch for 3.7 and 3.8 as well
SVN-Revision: 35310
Felix Fietkau [Wed, 23 Jan 2013 16:29:25 +0000 (16:29 +0000)]
ar71xx: sync kernel sizes where possible to fix images for some devices (#12874)
SVN-Revision: 35309
Jonas Gorski [Wed, 23 Jan 2013 10:12:40 +0000 (10:12 +0000)]
bcm63xx: switch to b53 and swconfig
Switch to using the B53 switch driver where appropriate.
Use a non-tagged default config where it isn't confirmed to be
working.
Remove the switch configuration in preinit as the switch will now
be configured by the driver to use port isolation to prevent leakage
between lan and wan.
While at it, also provide a switch config for Neufbox 6.
Signed-off-by: Jonas Gorski <jogo@openwrt.org>
SVN-Revision: 35307
Jonas Gorski [Wed, 23 Jan 2013 10:12:37 +0000 (10:12 +0000)]
bcm63xx: expose the internal switch to b53
Allow b53 access to the internal switch of BCM6328, BCM6362 and BCM6368.
Signed-off-by: Jonas Gorski <jogo@openwrt.org>
SVN-Revision: 35306
Jonas Gorski [Wed, 23 Jan 2013 10:12:33 +0000 (10:12 +0000)]
generic: add b53 swconfig switch driver
Add swconfig switch driver for Broadcom BCM53XX switch chips. Supports
switches connected through MDIO, SPI or memory mapped registers, and
supports BCM5325, BCM539x, BCM531x5 and the BCM63XX internal switch
chips.
Tested are BCM5325 trough MDIO, BCM53115 through SPI, and BCM6328.
Signed-off-by: Jonas Gorski <jogo@openwrt.org>
SVN-Revision: 35305
Jonas Gorski [Wed, 23 Jan 2013 10:12:13 +0000 (10:12 +0000)]
bcm63xx: move bcm63xx-spi into the kernel
The SPI driver is needed for supporting to boot from SPI flash on BCM6358
and BCM6368, and for SPI connected switches.
Signed-off-by: Jonas Gorski <jogo@openwrt.org>
SVN-Revision: 35304
Steven Barth [Wed, 23 Jan 2013 08:15:09 +0000 (08:15 +0000)]
ipv6-support: don't overwrite existing setting across reflashs
SVN-Revision: 35302
Steven Barth [Tue, 22 Jan 2013 16:47:16 +0000 (16:47 +0000)]
base-files: fix network_get_prefix6
SVN-Revision: 35300
Steven Barth [Tue, 22 Jan 2013 16:47:09 +0000 (16:47 +0000)]
base-files: Set default value for IPv6 forwarding
SVN-Revision: 35299
Felix Fietkau [Tue, 22 Jan 2013 16:05:59 +0000 (16:05 +0000)]
netifd: update to latest version, adds another fix for interface aliases
SVN-Revision: 35297
Steven Barth [Tue, 22 Jan 2013 15:49:42 +0000 (15:49 +0000)]
netifd: Fix a segfault when globals.ula_prefix is empty
SVN-Revision: 35296
Felix Fietkau [Tue, 22 Jan 2013 15:05:04 +0000 (15:05 +0000)]
uhttpd: always turn on TLS support, include ustream-ssl as a build dependency
SVN-Revision: 35295
Felix Fietkau [Tue, 22 Jan 2013 14:52:52 +0000 (14:52 +0000)]
ustream-ssl: remove dependency conditional part to avoid build breakage when no variant is selected
SVN-Revision: 35294
Felix Fietkau [Tue, 22 Jan 2013 14:29:01 +0000 (14:29 +0000)]
ustream-ssl: update to latest version, fixes handling large chunks of data (fixes #12866)
SVN-Revision: 35293
Luka Perkov [Tue, 22 Jan 2013 12:55:01 +0000 (12:55 +0000)]
uboot-lantiq: upgrade to 2013.01
SVN-Revision: 35292
Felix Fietkau [Tue, 22 Jan 2013 09:38:00 +0000 (09:38 +0000)]
uhttpd: fix another small hang issue with the same symptoms
SVN-Revision: 35291
Felix Fietkau [Tue, 22 Jan 2013 09:28:55 +0000 (09:28 +0000)]
uhttpd: fix connection hangs
SVN-Revision: 35290
Felix Fietkau [Tue, 22 Jan 2013 07:51:15 +0000 (07:51 +0000)]
tcpdump: add SLL parsing support to tcpdump-mini, use -ffunction-sections, -fdata-sections and --gc-sections to reduce size
SVN-Revision: 35288
Jo-Philipp Wich [Mon, 21 Jan 2013 19:02:38 +0000 (19:02 +0000)]
base-files: network.sh: fix typo in previous commit
SVN-Revision: 35287
Jo-Philipp Wich [Mon, 21 Jan 2013 18:54:58 +0000 (18:54 +0000)]
base-files: network.sh: simplify network_get_prefix6()
SVN-Revision: 35286
Felix Fietkau [Mon, 21 Jan 2013 16:13:43 +0000 (16:13 +0000)]
kernel: turn on kallsyms and debug info by default
SVN-Revision: 35285
Felix Fietkau [Mon, 21 Jan 2013 12:46:41 +0000 (12:46 +0000)]
uhttpd: fix unencrypted passwords in httpd.conf
SVN-Revision: 35265
Felix Fietkau [Mon, 21 Jan 2013 12:46:37 +0000 (12:46 +0000)]
ath9k: add support for more antenna mask combinations on AR93xx
SVN-Revision: 35264
Steven Barth [Mon, 21 Jan 2013 11:27:03 +0000 (11:27 +0000)]
6relayd: fix shell library includes in init-script
Thanks to Daniel Golle
SVN-Revision: 35262
Steven Barth [Mon, 21 Jan 2013 10:42:31 +0000 (10:42 +0000)]
6relayd: avoid a race-condition with looping RAs
SVN-Revision: 35260
Steven Barth [Mon, 21 Jan 2013 09:21:30 +0000 (09:21 +0000)]
netifd: Fix segfaults in IPv6 prefix handling
SVN-Revision: 35259
Steven Barth [Mon, 21 Jan 2013 07:58:58 +0000 (07:58 +0000)]
odhcp6c: Fix address assignment with infinite validity
SVN-Revision: 35258
Felix Fietkau [Sun, 20 Jan 2013 21:15:43 +0000 (21:15 +0000)]
uhttpd: fix selecting the right ustream implementation when openssl is to be used (#12857)
SVN-Revision: 35257
Felix Fietkau [Sun, 20 Jan 2013 18:33:21 +0000 (18:33 +0000)]
ath9k: merge another round of cleanups and stability fixes, refresh patches
SVN-Revision: 35255
Felix Fietkau [Sun, 20 Jan 2013 15:47:09 +0000 (15:47 +0000)]
netifd: update to latest version, fixes alias support
SVN-Revision: 35251
Felix Fietkau [Sun, 20 Jan 2013 11:25:18 +0000 (11:25 +0000)]
network/iproute2: Bump version to 3.7.0
Updated to latest stable version and added an upstream patch to handle
a link failure
Signed-off-by: Oliver Smith <olipro@8.c.9.b.0.7.4.0.1.0.0.2.ip6.arpa>
[dgolle@allnet.de: refreshed patches]
Signed-off-by: Daniel Golle <dgolle@allnet.de>
SVN-Revision: 35250
Felix Fietkau [Sat, 19 Jan 2013 22:55:46 +0000 (22:55 +0000)]
uhttpd: update to a newer version, fixes chunked transfer on some POST requests
SVN-Revision: 35249
Felix Fietkau [Sat, 19 Jan 2013 19:14:37 +0000 (19:14 +0000)]
kernel: remove 340-module_alloc_size_check.patch from linux 3.8, it is not necessary anymore
SVN-Revision: 35248
Felix Fietkau [Sat, 19 Jan 2013 18:47:09 +0000 (18:47 +0000)]
uhttpd: switch to uhttpd2, it is now feature complete
SVN-Revision: 35247
Gabor Juhos [Sat, 19 Jan 2013 17:05:07 +0000 (17:05 +0000)]
ramips: add profile and build image for the Tenda 3G300M
Factory image should be used to flash from
original firmware.
[juhosg: use the GENERIC_4M template]
Signed-off-by: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
SVN-Revision: 35246
Gabor Juhos [Sat, 19 Jan 2013 17:05:06 +0000 (17:05 +0000)]
ramips: add user-space support for the Tenda 3G300M
Signed-off-by: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
SVN-Revision: 35245