Julia Lawall [Wed, 24 Dec 2008 15:23:37 +0000 (16:23 +0100)]
Staging: meilhaus: Correct use of ! and &
ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING and ME_IO_STREAM_CONFIG_WRAPAROUND both
hanve 0 as the rightmost bit, and thus eg
!flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING is always 0.
I assume that !(flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING) and
!(flags & ME_IO_STREAM_CONFIG_WRAPAROUND) were intended.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@ expression E; constant C; @@
(
!E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 17 Mar 2009 23:01:58 +0000 (16:01 -0700)]
Staging: go7007: fix build error
VID_TYPE_CAPTURE is a v4l1 thing only.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Thu, 25 Dec 2008 20:09:57 +0000 (21:09 +0100)]
Staging: go7007: introduce missing kfree
Error handling code following a kmalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@
(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
when != if (...) { <+...x...+> }
x->f = E
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Fri, 19 Dec 2008 17:11:25 +0000 (18:11 +0100)]
Staging: go7007: Move a dereference below a NULL test
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/). The result has been modified to
move the initialization of usb down closer to where it is used.
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:36 +0000 (22:39 +0100)]
Staging: agnx: Fixup xmit.c checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:35 +0000 (22:39 +0100)]
Staging: agnx: Fixup table.c checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:34 +0000 (22:39 +0100)]
Staging: agnx: Fixup sta.h checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:33 +0000 (22:39 +0100)]
Staging: agnx: Fixup sta.c checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:32 +0000 (22:39 +0100)]
Staging: agnx: Fixup rf.c checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:31 +0000 (22:39 +0100)]
Staging: agnx: Fixup phy.c checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:30 +0000 (22:39 +0100)]
Staging: agnx: Fixup pci.c checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:29 +0000 (22:39 +0100)]
Staging: agnx: Fixup debug.h checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Erik Andrén [Sat, 14 Mar 2009 21:39:28 +0000 (22:39 +0100)]
Staging: agnx: Fixup agnx.h checkpatch warnings
Signed-off-by: Erik Andrén <erik.andren@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Herton Ronaldo Krzesinski [Fri, 13 Feb 2009 13:35:12 +0000 (08:35 -0500)]
Staging: agnx: mac80211 hw config change flags
Adapt agnx after commit "mac80211: introduce hw config change flags",
detected by following build warning:
drivers/staging/agnx/pci.c:426: warning: initialization from incompatible pointer type
Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Kluin [Sat, 31 Jan 2009 10:44:02 +0000 (11:44 +0100)]
Staging: agnx: i reaches -1, tested 0
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Fri, 19 Dec 2008 17:11:01 +0000 (18:11 +0100)]
Staging: agnx: Move a dereference below a NULL test
If the NULL test is necessary, then the dereference should be moved below
the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: YanBo <dreamfly281@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Huang Weiyi [Sun, 11 Jan 2009 09:22:36 +0000 (17:22 +0800)]
Staging: remove duplicated #include's
Removed duplicated #include's in
drivers/staging/altpciechdma/altpciechdma.c
drivers/staging/comedi/comedidev.h
drivers/staging/rt2860/rt_linux.h
drivers/staging/rt2870/rt_linux.h
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:25 +0000 (16:12 +0100)]
Staging: me4000: make file_operations const
This eliminates checkpatch.pl warnings, that struct file_operations is
usually const. The structs me4000_ai_fops_array and
me4000_ao_fops_array are not modified and thus also made const.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:24 +0000 (16:12 +0100)]
Staging: me4000: use tabs for code indentation
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:23 +0000 (16:12 +0100)]
Staging: me4000: do not use C99 style comments.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:22 +0000 (16:12 +0100)]
Staging: me4000: fix various checkpatch.pl warnings about bracing
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:21 +0000 (16:12 +0100)]
Staging: me4000: kfree(NULL) is safe, so no extra checks needed.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:20 +0000 (16:12 +0100)]
Staging: me4000: replace some C99 comments
checkpatch.pl triggered those as false positives for trailing
statements, but those lines also triggered some other warnings.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:19 +0000 (16:12 +0100)]
Staging: me4000: inline keyword should sit between storage class and type
fixes some checkpatch.pl errors complaining about wrong position of the
inline keyword
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:18 +0000 (16:12 +0100)]
Staging: me4000: return is not a function, no parentheses required
fixes some checkpatch.pl errors about unneccessary parentheses.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Haupt [Mon, 26 Jan 2009 15:12:17 +0000 (16:12 +0100)]
Staging: me4000: use linux/uaccess.h and linux/io.h
This fixes the following checkpatch.pl warnings:
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Richard Kennedy [Fri, 20 Feb 2009 12:09:12 +0000 (12:09 +0000)]
Staging: wlan-ng: block ioctls until card fully initialised
Add a mutex to block ioctls before the card is fully initialised and
only allow one ioctl at a time.
This stops udev trying to load the firmware before to card is fully up.
patch ported from wlan-ng-devel
Karl Relton <karllinuxtest.relton@ntlworld.com> spotted that this was
missing from the staging version,
http://lists.linux-wlan.com/pipermail/linux-wlan-devel/2009-February/003890.html
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Karl Relton <karllinuxtest.relton@ntlworld.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Wed, 18 Feb 2009 18:50:07 +0000 (19:50 +0100)]
Staging: wlan-ng: Replace local byteorder macros
Replace hfa384x2host_16(), hfa384x2host_32(), host2hfa384x_16()
and host2hfa384x_32() with standard byteorder macros.
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Mon, 9 Feb 2009 18:33:44 +0000 (19:33 +0100)]
Staging: wlan-ng: Remove the now empty wlan_compat.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Mon, 9 Feb 2009 18:33:43 +0000 (19:33 +0100)]
Staging: wlan-ng: Remove dead code from p80211netdev.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Mon, 9 Feb 2009 18:33:42 +0000 (19:33 +0100)]
Staging: wlan-ng: Remove unnecessary checks for NULL before calling kfree()
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Mon, 9 Feb 2009 18:33:41 +0000 (19:33 +0100)]
Staging: wlan-ng: Remove more dead code from hfa384x_usb.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Mon, 9 Feb 2009 18:33:40 +0000 (19:33 +0100)]
Staging: wlan-ng: Remove dead code from prism2mib.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:48 +0000 (02:20 +0100)]
Staging: wlan-ng: prism2mgmt.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:21:00 +0000 (02:21 +0100)]
Staging: wlan-ng: hfa384x_usb.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:21:01 +0000 (02:21 +0100)]
Staging: wlan-ng: p80211netdev.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:21:04 +0000 (02:21 +0100)]
Staging: wlan-ng: prism2sta.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:21:05 +0000 (02:21 +0100)]
Staging: wlan-ng: prism2usb.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:21:03 +0000 (02:21 +0100)]
Staging: wlan-ng: prism2mib.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:21:02 +0000 (02:21 +0100)]
Staging: wlan-ng: p80211mgmt.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:59 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211netdev.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:58 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211msg.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:57 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211types.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:56 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211conv.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:55 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211conv.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:54 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211hdr.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:53 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211metastruct.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:52 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211ioctl.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:51 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211meta.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:50 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211wext.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:49 +0000 (02:20 +0100)]
Staging: wlan-ng: hfa384x.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:47 +0000 (02:20 +0100)]
Staging: wlan-ng: prism2mgmt.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:46 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211req.c: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:20:45 +0000 (02:20 +0100)]
Staging: wlan-ng: p80211req.h: Coding style cleanups
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 8 Feb 2009 01:01:00 +0000 (02:01 +0100)]
Staging: wlan-ng: Replace WLAN_LOG_DEBUG() with printk(KERN_DEBUG
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:39:16 +0000 (13:39 +0100)]
Staging: wlan-ng: Move wlan_mkprintstr() and wlan_hexchar() macros into prism2sta.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Thu, 5 Feb 2009 22:55:56 +0000 (23:55 +0100)]
Staging: wlan-ng: Move netdevice_t typedef into p80211netdev.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Thu, 5 Feb 2009 22:55:54 +0000 (23:55 +0100)]
Staging: wlan-ng: Remove WLAN_INCLUDE_DEBUG and some related, mostly unused
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:08 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove more dead/unused code from hfa384x.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:07 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove dead/unused code from hfa384x.h and p80211metamsg.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:06 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211ioctl.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:05 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211metadef.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:04 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove unused header file p80211metamib.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:03 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove dead code from hfa384x_usb.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:02 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove dead code from prism2mgmt.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:01 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove dead/unused code from prism2sta.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:29:00 +0000 (13:29 +0100)]
Staging: wlan-ng: Remove more dead/unused code from p80211types.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:28:59 +0000 (13:28 +0100)]
Staging: wlan-ng: Replace SSWAP() with the generic swap(). Also remove a
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 1 Feb 2009 12:28:58 +0000 (13:28 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211req.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:10 +0000 (21:55 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211conv.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:09 +0000 (21:55 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211conv.c
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:08 +0000 (21:55 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211netdev.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:07 +0000 (21:55 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211msg.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:06 +0000 (21:55 +0100)]
Staging: wlan-ng: Remove dead/unused code from hfa384x.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:05 +0000 (21:55 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211meta.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:04 +0000 (21:55 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211hdr.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:03 +0000 (21:55 +0100)]
Staging: wlan-ng: Remove dead/unused code from p80211types.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:02 +0000 (21:55 +0100)]
Staging: wlan-ng: Replace wlan_isprint() with generic isprint()
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:01 +0000 (21:55 +0100)]
Staging: wlan-ng: Replace WLAN_LOG_WARNING() with printk()
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:55:00 +0000 (21:55 +0100)]
Staging: wlan-ng: Replace WLAN_LOG_ERROR() with printk()
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:54:59 +0000 (21:54 +0100)]
Staging: wlan-ng: Replace WLAN_LOG_NOTICE with printk()
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:54:58 +0000 (21:54 +0100)]
Staging: wlan-ng: Remove wlan_max()/wlan_min()
Replace wlan_min() with the generic min_t(), remove unused wlan_max().
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:54:57 +0000 (21:54 +0100)]
Staging: wlan-ng: Remove WLAN_LOG_INFO
Replace WLAN_LOG_INFO with printk() and remove it.
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:54:56 +0000 (21:54 +0100)]
Staging: wlan-ng: Move URB_ASYNC_UNLINK and USB_QUEUE_BULK out of wlan_compat.h
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Sun, 25 Jan 2009 20:54:55 +0000 (21:54 +0100)]
Staging: wlan-ng: Replace BITx with the generic BIT(x)
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Wed, 21 Jan 2009 21:00:45 +0000 (22:00 +0100)]
Staging: wlan-ng: Use generic byteorder macros
This patch removes the ieee2host16(), ieee2host32(), host2ieee16()
and host2ieee32() macros and replaces them with the generic ones.
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Wed, 21 Jan 2009 21:00:44 +0000 (22:00 +0100)]
Staging: wlan-ng: Remove DBFENTER/DBFEXIT macros
Remove the ugly DBFENTER/DBFEXIT macros, which are only inserted to add "<---" and
"--->" at the function start/end at higher debug levels and which make the code
a lot less readable.
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Wed, 21 Jan 2009 21:00:43 +0000 (22:00 +0100)]
Staging: wlan-ng: Cleanup wlan_compat.h more
Move version identifier into p80211netdev.h and rename it to 0.3.0-staging
to differentiate from the out-of-tree version.
Also remove the unused wlan_ethconv declaration.
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Wed, 21 Jan 2009 21:00:42 +0000 (22:00 +0100)]
Staging: wlan-ng: Remove stray comments in header files
The header files contain a few comments, which describe the
function of the header element. Remove them where not needed.
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Wed, 21 Jan 2009 21:00:41 +0000 (22:00 +0100)]
Staging: wlan-ng: Remove use of WLAN_ADDR_LEN
Replace the driver local WLAN_ADDR_LEN constant through the kernel-wide ETH_ALEN definiton.
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Moritz Muehlenhoff [Wed, 21 Jan 2009 21:00:40 +0000 (22:00 +0100)]
Staging: wlan-ng: Remove use of __WLAN_ATTRIB_PACK__
Replace all ocurrances of the __WLAN_ATTRIB_PACK__ from wlan_compat.h
by __attribute__((packed)) and remove it afterwards.
Signed-off-by: Moritz Muehlenhoff <jmm@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Mon, 2 Mar 2009 10:30:16 +0000 (12:30 +0200)]
Staging: w35und: remove gl_80211.h header
The gl_80211.h header file contains only two definitions that are actually
used. Move them to mds_s.h and remove the otherwise unused file.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Mon, 2 Mar 2009 10:19:57 +0000 (12:19 +0200)]
Staging: w35und: remove ds_tkip.h header
The ds_tkip.h header file contains declarations of a function that is not
actually defined anywhere.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Pekka Enberg [Mon, 2 Mar 2009 10:19:56 +0000 (12:19 +0200)]
Staging: w35und: remove unused bssdscpt.h header
The bssdscpt.h header file contains definitions that are not actually used for
anything.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Mon, 12 Jan 2009 16:03:39 +0000 (18:03 +0200)]
Staging: w35und: Remove MTO_FUNC_INPUT macro obfuscation
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Mon, 12 Jan 2009 16:02:47 +0000 (18:02 +0200)]
Staging: w35und: remove hw_data_t typedef
As this typedef is used everywhere in the driver, remove it in a separate
patch.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Thu, 8 Jan 2009 16:32:14 +0000 (18:32 +0200)]
Staging: w35und: typedef removal
This patch removes some typedefs from the driver code. I also removed some
unused structs I spotted while removing the typedefs.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Thu, 8 Jan 2009 09:31:59 +0000 (11:31 +0200)]
Staging: w35und: kill WBDEBUG and remove common.h header file
The only remaining thing in common.h header file is the WBDEBUG() macro which
is unconditionally defined as printk(). Kill the macro and remove the header
file.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Thu, 8 Jan 2009 09:31:28 +0000 (11:31 +0200)]
Staging: w35und: remove useless macro from common.h
The DebugUsbdStatusInformation macro doesn't do anything useful so remove the
definition and the two users of it from driver code.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pekka Enberg [Thu, 8 Jan 2009 09:56:53 +0000 (11:56 +0200)]
Staging: w35und: convert code to use ETH_ALEN
As suggested by Harvey Harrison, convert driver to use ETH_ALEN and kill a
private macro from common.h that is used for the same thing.
Acked-by: Harvey Harrison <harvey.harrison@gmail.com>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
projects / openwrt / staging / blogic.git / log