openwrt/staging/blogic.git
14 years agoStaging: rt28x0: run *.h files through Lindent
Bartlomiej Zolnierkiewicz [Fri, 11 Dec 2009 20:23:14 +0000 (12:23 -0800)]
Staging: rt28x0: run *.h files through Lindent

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: run sta/*.c files through Lindent
Bartlomiej Zolnierkiewicz [Fri, 11 Dec 2009 20:23:14 +0000 (12:23 -0800)]
Staging: rt28x0: run sta/*.c files through Lindent

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: run common/*.c files through Lindent
Bartlomiej Zolnierkiewicz [Fri, 11 Dec 2009 20:23:13 +0000 (12:23 -0800)]
Staging: rt28x0: run common/*.c files through Lindent

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: run *.c files through Lindent
Bartlomiej Zolnierkiewicz [Fri, 11 Dec 2009 20:23:13 +0000 (12:23 -0800)]
Staging: rt28x0: run *.c files through Lindent

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove __LINE__ instances
Bartlomiej Zolnierkiewicz [Fri, 11 Dec 2009 20:23:13 +0000 (12:23 -0800)]
Staging: rt28x0: remove __LINE__ instances

Remove instances of __LINE__ preprocessor directive to make
validation of resulting binary output files easier.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove dead code
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:45:09 +0000 (22:45 +0200)]
Staging: rt28x0: remove dead code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove unused SHA256 code
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:45:02 +0000 (22:45 +0200)]
Staging: rt28x0: remove unused SHA256 code

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove dead code from rtmp_phy.h
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:44:55 +0000 (22:44 +0200)]
Staging: rt28x0: remove dead code from rtmp_phy.h

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove optional cmm profile parameters
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:44:48 +0000 (22:44 +0200)]
Staging: rt28x0: remove optional cmm profile parameters

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: fix some build warnings
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:44:42 +0000 (22:44 +0200)]
Staging: rt28x0: fix some build warnings

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove optional loading of EEPROM from file in eFuse mode
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:44:35 +0000 (22:44 +0200)]
Staging: rt28x0: remove optional loading of EEPROM from file in eFuse mode

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove support for private driver parameters
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:44:27 +0000 (22:44 +0200)]
Staging: rt28x0: remove support for private driver parameters

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove private WEXT handlers
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:44:19 +0000 (22:44 +0200)]
Staging: rt28x0: remove private WEXT handlers

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove private RTPRIV_IOCTL_GSITESURVEY ioctl
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:44:12 +0000 (22:44 +0200)]
Staging: rt28x0: remove private RTPRIV_IOCTL_GSITESURVEY ioctl

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove private RTPRIV_IOCTL_SET ioctl
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:44:05 +0000 (22:44 +0200)]
Staging: rt28x0: remove private RTPRIV_IOCTL_SET ioctl

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove unused code from common/ee_efuse-c
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:43:57 +0000 (22:43 +0200)]
Staging: rt28x0: remove unused code from common/ee_efuse-c

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt28x0: remove unused ->eewrite methods
Bartlomiej Zolnierkiewicz [Wed, 21 Oct 2009 20:43:51 +0000 (22:43 +0200)]
Staging: rt28x0: remove unused ->eewrite methods

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: otus : checkpatch.pl cleanup for some more .c files
Mithlesh Thukral [Tue, 27 Oct 2009 04:22:55 +0000 (21:22 -0700)]
Staging: otus : checkpatch.pl cleanup for some more .c files

Second lot of checkpatch.pl error and warning fixes for .c files of
otus driver in staging tree.
(Externs would be removed in a seperate patch)

Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: otus : checkpatch.pl cleanup for .c files
Mithlesh Thukral [Tue, 27 Oct 2009 04:22:20 +0000 (21:22 -0700)]
Staging: otus : checkpatch.pl cleanup for .c files

First patch for checkpatch.pl error and warning fixes for .c files of otus
driver in staging tree.

Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: otus : checkpatch.pl cleanup for header files
Mithlesh Thukral [Tue, 27 Oct 2009 04:21:39 +0000 (21:21 -0700)]
Staging: otus : checkpatch.pl cleanup for header files

Fix for checkpatch.pl errors and warnings in header files of otus driver.
(There is a typedef which still remains. Plan to clean it up in next set
of patches)

Signed-off-by: Mithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dream: remove wakelock support from smd_rpcrouter.h
Pavel Machek [Sat, 24 Oct 2009 20:01:08 +0000 (22:01 +0200)]
Staging: dream: remove wakelock support from smd_rpcrouter.h

wakelocks are power optimalization, not supported in mainline. Remove
them so that code compiles on mainline.

Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dream: remove wakelock support
Pavel Machek [Thu, 22 Oct 2009 09:03:54 +0000 (11:03 +0200)]
Staging: dream: remove wakelock support

Includes changed so that <linux/sched.h> is now needed for
TASK_INTERRUPTIBLE and friends, so include it.

Remove hooks for features not in mainline, such as earlysuspend and
wakelocks.

Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dream: Synaptics touchscreen for HTC Dream: check that smbus is available
Pavel Machek [Fri, 18 Sep 2009 19:59:22 +0000 (12:59 -0700)]
Staging: dream: Synaptics touchscreen for HTC Dream: check that smbus is available

Check that SMBUS APIs are available in touchscreen driver.

Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: Trilok Soni <soni.trilok@gmail.com>
Cc: <arve@android.com>
Cc: Brian Swetland <swetland@google.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dream: mark as BROKEN
Greg Kroah-Hartman [Mon, 26 Oct 2009 23:43:54 +0000 (16:43 -0700)]
Staging: dream: mark as BROKEN

It doesn't build, and hasn't for a long time (if ever).  So mark
it BROKEN for now.

Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dream: make it independant from CONFIG_ANDROID
Pavel Machek [Sun, 11 Oct 2009 09:05:08 +0000 (11:05 +0200)]
Staging: dream: make it independant from CONFIG_ANDROID

Make Dream support independent of CONFIG_ANDROID.

Signed-off-by: Pavel Machek <pavel@ucw.cz>
14 years agoStaging: wlags49: fix kconfigs dependancy
Randy Dunlap [Fri, 30 Oct 2009 18:01:43 +0000 (11:01 -0700)]
Staging: wlags49: fix kconfigs dependancy

Fix depends/selects in wlags49 drivers.

ERROR: "wireless_spy_update" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "iw_handler_get_spy" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "iw_handler_set_spy" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!

ERROR: "pcmcia_dev_present" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_request_irq" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_register_driver" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_request_configuration" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_request_io" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_error_ret" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_error_func" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_unregister_driver" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_disable_device" [drivers/staging/wlags49_h25/wlags49_h25_cs.ko] undefined!
ERROR: "pcmcia_dev_present" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "pcmcia_request_irq" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "pcmcia_register_driver" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "pcmcia_request_configuration" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "pcmcia_request_io" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "pcmcia_error_ret" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "pcmcia_error_func" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "pcmcia_unregister_driver" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!
ERROR: "pcmcia_disable_device" [drivers/staging/wlags49_h2/wlags49_h2_cs.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: wlags49_h2: add TODO files
Henk de Groot [Wed, 28 Oct 2009 22:43:55 +0000 (23:43 +0100)]
Staging: wlags49_h2: add TODO files

Adds TODO to the wlags_h2 and wlags_h5 staging drivers.

Signed-off-by: Henk de Groot <pe1dnn@amsat.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: wlags49_h2: add Agere driver for HERMES II and HERMES II.5 chipsets
Henk de Groot [Sun, 27 Sep 2009 09:12:52 +0000 (11:12 +0200)]
Staging: wlags49_h2: add Agere driver for HERMES II and HERMES II.5 chipsets

WLAN driver for cards using the HERMES II and HERMES II.5 chipset

Based on Agere Systems Linux LKM Wireless Driver Source Code,
Version 7.22; complies with Open Source BSD License.

The software is a modified version of wl_lkm_722_abg.tar.gz from the
Agere Systems website, addapted for Ubuntu 9.04 and modified to
fit in the current Linux kernel (2.6.31).

Modified for kernel 2.6 by Henk de Groot <pe1dnn@amsat.org>
Based on 7.18 version by Andrey Borzenkov <arvidjaar@mail.ru> $Revision: 39 $

Signed-off-by: Henk de Groot <pe1dnn@amsat.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8187su: remove unused #include <linux/version.h>
Huang Weiyi [Thu, 17 Sep 2009 13:25:37 +0000 (21:25 +0800)]
Staging: rtl8187su: remove unused #include <linux/version.h>

Remove unused #include <linux/version.h>('s) in
  drivers/staging/rtl8192su/ieee80211/ieee80211_rx.c
  drivers/staging/rtl8192su/ieee80211/ieee80211_tx.c
  drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c

Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rtl8187se: remove unused #include <linux/version.h>
Huang Weiyi [Thu, 17 Sep 2009 13:25:21 +0000 (21:25 +0800)]
Staging: rtl8187se: remove unused #include <linux/version.h>

Remove unused #include <linux/version.h>('s) in
  drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c
  drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
  drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c

Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: poch: Add sample Rx code
Vijay Kumar B [Mon, 21 Sep 2009 05:54:00 +0000 (11:24 +0530)]
Staging: poch: Add sample Rx code

Add sample code Rx to README.

Signed-off-by: Vijay Kumar B <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: poch: Include linux/types.h
Vijay Kumar B [Mon, 21 Sep 2009 05:53:59 +0000 (11:23 +0530)]
Staging: poch: Include linux/types.h

Include linux/types.h in poch.h, so that poch.h can be included in
user application header files.

Signed-off-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: poch: Remove circular buffer header
Vijay Kumar B [Mon, 21 Sep 2009 05:53:58 +0000 (11:23 +0530)]
Staging: poch: Remove circular buffer header

Remove the circular buffer header. Which has been superseded by the
ioctl consume interface.

Signed-off-by: Vijay Kumar B <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: poch: Parameter to enable loopback
Vijay Kumar [Mon, 21 Sep 2009 05:53:57 +0000 (11:23 +0530)]
Staging: poch: Parameter to enable loopback

Enable setting of loopback through module parameter.

Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: poch: Increase groups per interrupt
Vijay Kumar B [Mon, 21 Sep 2009 05:53:56 +0000 (11:23 +0530)]
Staging: poch: Increase groups per interrupt

Increase groups per interrupt to reduce hogging of the CPU.

Signed-off-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: poch: Fetch Flush IOCTL interface
Vijay Kumar B [Mon, 21 Sep 2009 05:53:55 +0000 (11:23 +0530)]
Staging: poch: Fetch Flush IOCTL interface

Change user space interface to an IOCTL based interface instead of a
memory mapped circular buffer. The circular buffer had some serious
cache(?) issues and never worked.

Signed-off-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: poch: Parameter to enable synthetic counter
Vijay Kumar B [Mon, 21 Sep 2009 05:53:54 +0000 (11:23 +0530)]
Staging: poch: Parameter to enable synthetic counter

Adds a parameter that causes the hardware to synthesize Rx values
using a counter.

Signed-off-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean up the phy code, especially dup stuff
Alan Cox [Tue, 6 Oct 2009 14:51:17 +0000 (15:51 +0100)]
Staging: et131x: Clean up the phy code, especially dup stuff

Fold in the TPAL stuff and remove the duplication
Clean up other stuff where we do un-needed work or have verbose implementations
Comment some of the functions as we go

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: phy clean up
Alan Cox [Tue, 6 Oct 2009 14:51:10 +0000 (15:51 +0100)]
Staging: et131x: phy clean up

Clean up the phy code a bit so we can see what needs doing. This involves
moving blocks around and making stuff static

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean up MII control
Alan Cox [Tue, 6 Oct 2009 14:51:04 +0000 (15:51 +0100)]
Staging: et131x: Clean up MII control

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: kill off MAC_TEST_t
Alan Cox [Tue, 6 Oct 2009 14:50:58 +0000 (15:50 +0100)]
Staging: et131x: kill off MAC_TEST_t

It isn't used anyway

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: clean up MAX_FM type
Alan Cox [Tue, 6 Oct 2009 14:50:51 +0000 (15:50 +0100)]
Staging: et131x: clean up MAX_FM type

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean up MAC_CFG types
Alan Cox [Tue, 6 Oct 2009 14:50:45 +0000 (15:50 +0100)]
Staging: et131x: Clean up MAC_CFG types

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean up the MII_MGMT type
Alan Cox [Tue, 6 Oct 2009 14:50:39 +0000 (15:50 +0100)]
Staging: et131x: Clean up the MII_MGMT type

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean up the half duplex control reg types
Alan Cox [Tue, 6 Oct 2009 14:50:32 +0000 (15:50 +0100)]
Staging: et131x: Clean up the half duplex control reg types

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean the IPG types up
Alan Cox [Tue, 6 Oct 2009 14:50:26 +0000 (15:50 +0100)]
Staging: et131x: Clean the IPG types up

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Kill the RX skb list element - it isn't used
Alan Cox [Tue, 6 Oct 2009 14:50:20 +0000 (15:50 +0100)]
Staging: et131x: Kill the RX skb list element - it isn't used

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Kill the RX pending list
Alan Cox [Tue, 6 Oct 2009 14:50:12 +0000 (15:50 +0100)]
Staging: et131x: Kill the RX pending list

As with tx there was a pending list Linux doesn't use

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: tx ring mac error is only used as a local
Alan Cox [Tue, 6 Oct 2009 14:50:05 +0000 (15:50 +0100)]
Staging: et131x: tx ring mac error is only used as a local

So make it a local

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Bring tx into coding style
Alan Cox [Tue, 6 Oct 2009 14:49:58 +0000 (15:49 +0100)]
Staging: et131x: Bring tx into coding style

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: kill unused tcb fields
Alan Cox [Tue, 6 Oct 2009 14:49:52 +0000 (15:49 +0100)]
Staging: et131x: kill unused tcb fields

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean up tx naming
Alan Cox [Tue, 6 Oct 2009 14:49:45 +0000 (15:49 +0100)]
Staging: et131x: Clean up tx naming

Clean up the names to be Linux like
Remove the unused pad buffer

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean up the tx ring init
Alan Cox [Tue, 6 Oct 2009 14:49:36 +0000 (15:49 +0100)]
Staging: et131x: Clean up the tx ring init

Keep this small change separate for bisectability

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: tidy up a bit further
Alan Cox [Tue, 6 Oct 2009 14:49:29 +0000 (15:49 +0100)]
Staging: et131x: tidy up a bit further

Clean up the minor uglies left from the previous work

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Remove old SendWaitQueue code
Alan Cox [Tue, 6 Oct 2009 14:49:21 +0000 (15:49 +0100)]
Staging: et131x: Remove old SendWaitQueue code

The Linux driver doesn't keep a pending queue as the old one did. so we can
remove all the code related to it.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: fold up simple wrapper functions
Alan Cox [Tue, 6 Oct 2009 14:49:13 +0000 (15:49 +0100)]
Staging: et131x: fold up simple wrapper functions

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Clean up the receive arrays
Alan Cox [Tue, 6 Oct 2009 14:49:04 +0000 (15:49 +0100)]
Staging: et131x: Clean up the receive arrays

We don't use them for anything having stripped out the debug gunge in
the original driver.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: first pass RX cleanup
Alan Cox [Tue, 6 Oct 2009 14:48:57 +0000 (15:48 +0100)]
Staging: et131x: first pass RX cleanup

Sort out the variable naming and clean up types and obvious trivia

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: pci_alloc_consistent DMA alignment is guaranteed
Alan Cox [Tue, 6 Oct 2009 14:48:49 +0000 (15:48 +0100)]
Staging: et131x: pci_alloc_consistent DMA alignment is guaranteed

So we can remove this alignment work.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: the stuck descriptor copy is never used
Alan Cox [Tue, 6 Oct 2009 14:48:42 +0000 (15:48 +0100)]
Staging: et131x: the stuck descriptor copy is never used

Say goodbye to it

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: tidy up names for the TX structures
Alan Cox [Tue, 6 Oct 2009 14:48:33 +0000 (15:48 +0100)]
Staging: et131x: tidy up names for the TX structures

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: clean up WORD2 usage
Alan Cox [Tue, 6 Oct 2009 14:48:25 +0000 (15:48 +0100)]
Staging: et131x: clean up WORD2 usage

A little more complex but again move the structure and typedef into into the
documentation

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: clean up word 3 definition
Alan Cox [Tue, 6 Oct 2009 14:48:16 +0000 (15:48 +0100)]
Staging: et131x: clean up word 3 definition

This is basically not really used so turn it into a u32 and comment the
format for reference

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: rxstat is not used
Alan Cox [Tue, 6 Oct 2009 14:48:02 +0000 (15:48 +0100)]
Staging: et131x: rxstat is not used

Turn it into a u32 and document the fields in a comment instead

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: PHY loopback cannot be set (and isn't useful for us anyway)
Alan Cox [Tue, 6 Oct 2009 14:47:55 +0000 (15:47 +0100)]
Staging: et131x: PHY loopback cannot be set (and isn't useful for us anyway)

Remove the stuff that falls out from this always being zero.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: kill NMI hacks
Alan Cox [Tue, 6 Oct 2009 14:47:48 +0000 (15:47 +0100)]
Staging: et131x: kill NMI hacks

The NMI code is in the shipped driver for "validation". We won't be doing
chip validation and we have proper core nmi handling so this can go.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: tidy up initpci code
Alan Cox [Tue, 6 Oct 2009 14:47:41 +0000 (15:47 +0100)]
Staging: et131x: tidy up initpci code

Perform some easy tidying so we can see what needs to be done next

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: Kill the NoPhyAccess variable
Alan Cox [Tue, 6 Oct 2009 14:47:29 +0000 (15:47 +0100)]
Staging: et131x: Kill the NoPhyAccess variable

Another write once "variable"

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: extract the eeprom setup logic from initpci
Alan Cox [Tue, 6 Oct 2009 14:47:22 +0000 (15:47 +0100)]
Staging: et131x: extract the eeprom setup logic from initpci

This puts all the eeprom handling in one place and cleans up the interfaces

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: tidy eeprom code up
Alan Cox [Tue, 6 Oct 2009 14:46:59 +0000 (15:46 +0100)]
Staging: et131x: tidy eeprom code up

Turn this one into something resembling a clean Linux driver

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: kill SUCCESS and FAILURE defines
Alan Cox [Tue, 6 Oct 2009 14:46:24 +0000 (15:46 +0100)]
Staging: et131x: kill SUCCESS and FAILURE defines

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: slicoss: remove duplicate structure field initialization
Julia Lawall [Sat, 19 Sep 2009 19:49:03 +0000 (21:49 +0200)]
Staging: slicoss: remove duplicate structure field initialization

The definition of slic_netdev_ops has initializations of a local function
and eth_mac_addr for its ndo_set_mac_address field.  This change uses only
the local function.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
  cocci.print_main(fld,p0)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: Fix up the module build.
Paul Mundt [Thu, 5 Nov 2009 06:09:00 +0000 (15:09 +0900)]
Staging: iio: Fix up the module build.

Both the max1363 and lis3l02dq modules rely on IIO trigger support in
their ring buffer implementations, which is presently a separate config
option. In the case of IIO_RING_BUFFER=y and IIO_TRIGGER=n, we end up
with the following:

ERROR: "iio_trigger_attach_poll_func" [drivers/staging/iio/adc/max1363.ko] undefined!
ERROR: "iio_trigger_dettach_poll_func" [drivers/staging/iio/adc/max1363.ko] undefined!
ERROR: "iio_trigger_unregister" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
ERROR: "iio_trigger_notify_done" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
ERROR: "iio_trigger_read_name" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
ERROR: "iio_trigger_poll" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
ERROR: "iio_trigger_attach_poll_func" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
ERROR: "iio_trigger_register" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
ERROR: "iio_free_trigger" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
ERROR: "iio_trigger_dettach_poll_func" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
ERROR: "iio_allocate_trigger" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

This adds an IIO_TRIGGER select for these two drivers conditional on
IIO ring buffer support. Caught with an SH randconfig in -next.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: lots of doc fixes
Randy Dunlap [Mon, 5 Oct 2009 02:34:02 +0000 (19:34 -0700)]
Staging: iio: lots of doc fixes

Fix iio header files kernel-doc notation errors, spelling, typos,
indentation, grammar, etc.

It would also be good if these function names were spelled
correctly, but I didn't change them:
  iio_push_or_escallate_ring_event()
  iio_trigger_dettach_poll_func()

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: iio: kconfig and make edits
Randy Dunlap [Mon, 5 Oct 2009 02:32:27 +0000 (19:32 -0700)]
Staging: iio: kconfig and make edits

Fix spelling, typos, indentation in iio Kconfig files.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: phison: adding __init/__exit macros
Peter Huewe [Mon, 28 Sep 2009 23:53:16 +0000 (01:53 +0200)]
Staging: phison: adding __init/__exit macros

Trivial patch which adds the __init/__exit macros to the module_init/
module_exit functions of drivers/staging/phison/phison.c

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: p9auth: adding __init/__exit macros
Peter Huewe [Mon, 28 Sep 2009 23:49:00 +0000 (01:49 +0200)]
Staging: p9auth: adding __init/__exit macros

Trivial patch which adds the __init/__exit macros to the module_init/
module_exit functions of drivers/staging/p9auth/p9auth.c

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: cx25821: adding __init/__exit macros
Peter Huewe [Mon, 28 Sep 2009 23:40:59 +0000 (01:40 +0200)]
Staging: cx25821: adding __init/__exit macros

Trivial patch which adds the __init/__exit macros to the module_init/
module_exit functions of ./staging/cx25821/cx25821-core.c

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: et131x: adding __init/__exit macros
Peter Huewe [Mon, 28 Sep 2009 23:34:14 +0000 (01:34 +0200)]
Staging: et131x: adding __init/__exit macros

Trivial patch which adds the __init/__exit macros to the module_init/
module_exit functions of ./staging/et131x/et131x_initpci.c

Greg, please have a look at the small patch and either pull it through
your staging tree, or please ack' it so Jiri can pull it through the trivial tree.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ramzswap: add TODO file
Nitin Gupta [Tue, 22 Sep 2009 10:02:33 +0000 (15:32 +0530)]
Staging: ramzswap: add TODO file

TODO file for ramzswap.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: ramzswap: documentation
Nitin Gupta [Tue, 22 Sep 2009 04:56:54 +0000 (10:26 +0530)]
Staging: ramzswap: documentation

Short guide on how to setup and use ramzswap.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: virtual block device driver (ramzswap)
Nitin Gupta [Tue, 22 Sep 2009 04:56:53 +0000 (10:26 +0530)]
Staging: virtual block device driver (ramzswap)

Creates RAM based block devices (/dev/ramzswapX) which can be
used (only) as swap disks. Pages swapped to these are compressed
and stored in memory itself.

The module is called ramzswap.ko. It depends on:
 - xvmalloc memory allocator (compiled with this driver)
 - lzo_compress.ko
 - lzo_decompress.ko

See ramzswap.txt for usage details.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: xvmalloc memory allocator
Nitin Gupta [Tue, 22 Sep 2009 04:56:52 +0000 (10:26 +0530)]
Staging: xvmalloc memory allocator

* Features:
 - Low metadata overhead (just 4 bytes per object)
 - O(1) Alloc/Free - except when we have to call system page allocator to
   get additional memory.
 - Very low fragmentation: In all tests, xvmalloc memory usage is within 12%
   of "Ideal".
 - Pool based allocator: Each pool can grow and shrink.
 - It maps pages only when required. So, it does not hog vmalloc area which
   is very small on 32-bit systems.

SLUB allocator could not be used due to fragmentation issues:
http://code.google.com/p/compcache/wiki/AllocatorsComparison
Data here shows kmalloc using ~43% more memory than TLSF and xvMalloc
is showed ~2% more space efficiency than TLSF (due to smaller metadata).
Creating various kmem_caches can reduce space efficiency gap but still
problem of being limited to low memory exists. Also, it depends on
allocating higher order pages to reduce fragmentation - this is not
acceptable for ramzswap as it is used under memory crunch (its a swap
device!).

SLOB allocator could not be used do to reasons mentioned here:
http://lkml.org/lkml/2009/3/18/210

* Implementation:
It uses two-level bitmap search to find free list containing block of
correct size. This idea is taken from TLSF (Two-Level Segregate Fit)
allocator and is well explained in its paper (see [Links] below).

* Limitations:
 - Poor scalability: No per-cpu data structures (work in progress).

[Links]
1. Details and Performance data:
http://code.google.com/p/compcache/wiki/xvMalloc
http://code.google.com/p/compcache/wiki/xvMallocPerformance

2. TLSF memory allocator:
home: http://rtportal.upv.es/rtmalloc/
paper: http://rtportal.upv.es/rtmalloc/files/MRBC_2008.pdf

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: pcl816: update convert_src mask for AI cmdtest
Ian Abbott [Fri, 20 Nov 2009 11:32:38 +0000 (11:32 +0000)]
Staging: comedi: pcl816: update convert_src mask for AI cmdtest

The COMEDI_CMDTEST ioctl needs to clear unsupported bits in the
struct comedi_cmd's convert_src and other *_src members.  This
needs fixing in the pcl816 driver's AI cmdtest.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: initialize divisor variables
Ian Abbott [Fri, 20 Nov 2009 11:32:37 +0000 (11:32 +0000)]
Staging: comedi: initialize divisor variables

The i8253_cascade_ns_to_timer_2div() function (and
i8253_cascade_ns_to_timer macro) checks the old values *d1 and *d2
for correctness as a heuristic before calculating new values.  Don't
call the function with uninitialized values in *d1 and *d2.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: serial2002: decrease stack usage
Ian Abbott [Fri, 20 Nov 2009 11:32:36 +0000 (11:32 +0000)]
Staging: comedi: serial2002: decrease stack usage

512 bytes of stack can be saved in serial_2002_open() by modifying
'struct config_t'.  A short int suffices for the 'kind' and 'bits'
members.  (Actually, a char would suffice, but wouldn't save any more
stack than a short int.)

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: fix usbdux timeout bug
Bernd Porr [Mon, 16 Nov 2009 01:12:02 +0000 (01:12 +0000)]
Staging: comedi: fix usbdux timeout bug

I've fixed a bug in the USBDUX driver which caused timeouts while
sending commands to the boards. This was mainly because of one bulk
transfer which had a timeout of 1ms (!). I've now set all timeouts to
1000ms.

From: Bernd Porr <BerndPorr@f2s.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: ke_counter: fix style issues
Dirk Hohndel [Wed, 21 Oct 2009 08:05:50 +0000 (01:05 -0700)]
Staging: comedi: ke_counter: fix style issues

80 char limit (where useful)
braces around single line block
KERN_ facility for printk

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: ii_pci_20kc: fix style printk
Dirk Hohndel [Wed, 21 Oct 2009 08:05:49 +0000 (01:05 -0700)]
Staging: comedi: ii_pci_20kc: fix style printk

add KERN_ facility to printk (mostly KERN_INFO, some KERN_WARNING)
I think I found a bug - commented on it but didn't change as it's just
in a printk (off by 1 error in output)

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: ii_pci20kc: white space fixes
Dirk Hohndel [Wed, 21 Oct 2009 08:05:48 +0000 (01:05 -0700)]
Staging: comedi: ii_pci20kc: white space fixes

No code changes - left some 80 char violations alone as
folding those lines would have made code less readable

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: icp_multi: don't init static
Dirk Hohndel [Wed, 21 Oct 2009 08:05:47 +0000 (01:05 -0700)]
Staging: comedi: icp_multi: don't init static

don't initialize static variable to 0

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: icp_multi: fix style issue printk
Dirk Hohndel [Wed, 21 Oct 2009 08:05:46 +0000 (01:05 -0700)]
Staging: comedi: icp_multi: fix style issue printk

add KERN_ facility to printk (mostly KERN_DEBUG, some KERN_WARNING)

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: icp_multi: white space style fixes
Dirk Hohndel [Wed, 21 Oct 2009 08:05:45 +0000 (01:05 -0700)]
Staging: comedi: icp_multi: white space style fixes

no code changes, just fixing white space, line length, etc

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: gsc_hdpi: style fixes static function
Dirk Hohndel [Wed, 21 Oct 2009 08:05:44 +0000 (01:05 -0700)]
Staging: comedi: gsc_hdpi: style fixes static function

Convert external function to static

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: gsc_hpdi: Fix style issues
Dirk Hohndel [Wed, 21 Oct 2009 08:05:43 +0000 (01:05 -0700)]
Staging: comedi: gsc_hpdi: Fix style issues

Style cleanup in staging based on Greg's tutorial / checkpatch
Fix 80 char line length (where useful) - includes two changes to code
to make it more logical / readable
Remove {} around single line blocks

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: gsc_hpdi: style fixes printk
Dirk Hohndel [Wed, 21 Oct 2009 08:05:42 +0000 (01:05 -0700)]
Staging: comedi: gsc_hpdi: style fixes printk

Style cleanup in staging based on Greg's tutorial / checkpatch
Add printk KERN_ facility level (KERN_WARNING seemed appropriate for all)

Signed-off-by: Dirk Hohndel <hohndel@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: drivers: ni_6527: fixup checkpatch.pl warnings
Klaas van Gend [Wed, 28 Oct 2009 01:01:08 +0000 (02:01 +0100)]
Staging: comedi: drivers: ni_6527: fixup checkpatch.pl warnings

This patch fixes all warnings as issued by checkpatch.pl.
Note that I had to modify some of the logging messages to make that possible.

Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: comedi_fc: checkpatch.pl fixes
Klaas van Gend [Wed, 28 Oct 2009 01:01:07 +0000 (02:01 +0100)]
Staging: comedi: comedi_fc: checkpatch.pl fixes

This patch fixes all warnings as issued by checkpatch.pl.

Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: pcl726: fix coding style issues
Kevyn-Alexandre Paré [Fri, 23 Oct 2009 21:34:17 +0000 (17:34 -0400)]
Staging: comedi: pcl726: fix coding style issues

Signed-off-by: Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: addi-data: Cleanup redundant tests on unsigned
Roel Kluin [Fri, 23 Oct 2009 10:26:25 +0000 (12:26 +0200)]
Staging: comedi: addi-data: Cleanup redundant tests on unsigned

The variables are unsigned so the test `>= 0' is always true,
In these cases the other part of the test catch wrapped values.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>