openwrt/staging/blogic.git
9 years agoStaging: lustre: ptlrpc: pinger: Declare as static
Shraddha Barke [Sun, 4 Oct 2015 07:30:11 +0000 (13:00 +0530)]
Staging: lustre: ptlrpc: pinger: Declare as static

Declare ptlrpc_pinger_remove_timeouts as static since it is used
only in this particular file.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: ptlrpc: events: Declare as static
Shraddha Barke [Sun, 4 Oct 2015 07:30:10 +0000 (13:00 +0530)]
Staging: lustre: ptlrpc: events: Declare as static

Declare ptl_get_pid as static since it is used only in this particular
file. Also remove declaration from corresponding header file

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: ptlrpc: nrs: Declare as static
Shraddha Barke [Sun, 4 Oct 2015 07:30:09 +0000 (13:00 +0530)]
Staging: lustre: ptlrpc: nrs: Declare as static

Declare ptlrpc_nrs_policy_register as static since it is used
only in this particular file. Also remove corresponding declaration
from header files.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: remove references to dev_root
Itai Katz [Sun, 4 Oct 2015 07:09:54 +0000 (10:09 +0300)]
staging: fsl-mc: remove references to dev_root

The dev_root field in the bus type struct has been replaced by a
new mechanism to identify the root dprc.  Remove all references
to dev_root.

Signed-off-by: Itai Katz <itai.katz@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: add counter to track number of root DPRCs
Itai Katz [Sun, 4 Oct 2015 07:09:53 +0000 (10:09 +0300)]
staging: fsl-mc: add counter to track number of root DPRCs

Add a counter to track the number of root DPRCs.
When this counter is greater then 0 it means that at least
one root DPRC device exists.

Signed-off-by: Itai Katz <itai.katz@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: add function to return pointer to root dprc
Itai Katz [Sun, 4 Oct 2015 07:09:52 +0000 (10:09 +0300)]
staging: fsl-mc: add function to return pointer to root dprc

To support multiple root dprcs, instead of relying on the
dev_root field of the bus type struct, instead create a
function to traverse to the root dprc and return a pointer
to the device struct

Signed-off-by: Itai Katz <itai.katz@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: abstract test for whether a dprc is a root dprc
Itai Katz [Sun, 4 Oct 2015 07:09:51 +0000 (10:09 +0300)]
staging: fsl-mc: abstract test for whether a dprc is a root dprc

Instead of relying on assumptions about fields in data
structures, abstract the test for whether a dprc is a root
dprc into a function.

Signed-off-by: Itai Katz <itai.katz@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: fsl-mc: abstract test for existence of fsl-mc bus
Itai Katz [Sun, 4 Oct 2015 07:09:50 +0000 (10:09 +0300)]
staging: fsl-mc: abstract test for existence of fsl-mc bus

Add function to test for existence of an fsl-mc bus instance
instead of doing this by looking directly at a field in the
bus type struct.

Signed-off-by: Itai Katz <itai.katz@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device_tx_srv rename pTD
Malcolm Priestley [Sat, 3 Oct 2015 19:30:27 +0000 (20:30 +0100)]
staging: vt6655: device_tx_srv rename pTD

Following the convention elsewhere for vnt_tx_desc rename
desc.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device_main replace pTDInfo with td_info.
Malcolm Priestley [Sat, 3 Oct 2015 19:30:26 +0000 (20:30 +0100)]
staging: vt6655: device_main replace pTDInfo with td_info.

Removing camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device_main replace pRD with rd.
Malcolm Priestley [Sat, 3 Oct 2015 19:30:25 +0000 (20:30 +0100)]
staging: vt6655: device_main replace pRD with rd.

Removing camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device_alloc_rx_buf replace pRDInfo with rd_info.
Malcolm Priestley [Sat, 3 Oct 2015 19:30:24 +0000 (20:30 +0100)]
staging: vt6655: device_alloc_rx_buf replace pRDInfo with rd_info.

Removing camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device_main.c replace pDesc with desc.
Malcolm Priestley [Sat, 3 Oct 2015 19:30:23 +0000 (20:30 +0100)]
staging: vt6655: device_main.c replace pDesc with desc.

Removing camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: vt6655: device_main replace pDevice with priv.
Malcolm Priestley [Sat, 3 Oct 2015 19:30:22 +0000 (20:30 +0100)]
staging: vt6655: device_main replace pDevice with priv.

Removing camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: remove extraneous do_key function
Tim Sell [Fri, 2 Oct 2015 17:19:25 +0000 (13:19 -0400)]
staging: unisys: visorinput: remove extraneous do_key function

do_key() is no longer needed.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: remove extraneous mouse logic
Tim Sell [Fri, 2 Oct 2015 17:19:24 +0000 (13:19 -0400)]
staging: unisys: visorinput: remove extraneous mouse logic

Removes a cursor positioning hack that no longer seems to be required.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: register & use input_dev open() and close()
Tim Sell [Fri, 2 Oct 2015 17:19:23 +0000 (13:19 -0400)]
staging: unisys: visorinput: register & use input_dev open() and close()

Registration of visorinput_open() and visorinput_close() for each device
allow us to eliminate unnecessary activity when nobody in user-land
cares.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: change input bus type to BUS_VIRTUAL (6)
Tim Sell [Fri, 2 Oct 2015 17:19:22 +0000 (13:19 -0400)]
staging: unisys: visorinput: change input bus type to BUS_VIRTUAL (6)

BUS_HOST wasn't really appropriate, so I changed to BUS_VIRTUAL, which is
what virtio uses.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: comment tweaks - s/gizmo/input node/g
Tim Sell [Fri, 2 Oct 2015 17:19:21 +0000 (13:19 -0400)]
staging: unisys: visorinput: comment tweaks - s/gizmo/input node/g

Just a simple search and replace in the comments.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: correct code comments per kernel conventions
Tim Sell [Fri, 2 Oct 2015 17:19:20 +0000 (13:19 -0400)]
staging: unisys: visorinput: correct code comments per kernel conventions

Multi-line comments were modified to conform to kernel conventions:

    /*
     * multi-line
     * comments
     */

doc-test /** */ for some comments was removed.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: make structs & arrays const where possible
Tim Sell [Fri, 2 Oct 2015 17:19:19 +0000 (13:19 -0400)]
staging: unisys: visorinput: make structs & arrays const where possible

This also gave me a warning with the assignment:

    visorinput_dev->keycode = visorkbd_keycode;

because input_dev->keycode is NOT static but visorkbd_keycode now is, so
I went ahead and also added logic to stash away non-static copies of
visorkbd_keycode[] and visorkbd_ext_keycode[] within visorinput_devdata,
and use the copy to assign to visorinput_dev->keycode.  This change is
also technically required, because user-space can remap keys, and we
don't want this to be shared with the other keyboard devices running on
the same system.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: re-order declarations for consistency
Tim Sell [Fri, 2 Oct 2015 17:19:17 +0000 (13:19 -0400)]
staging: unisys: visorinput: re-order declarations for consistency

In order to be more consistent with kernel conventions used elsewhere,
I have re-ordered declarations in visorinput.c to follow this general
order (where possible):
* #defines
* struct/enum/union declarations
* static declarations (const if possible for all of them)
* forward function declarations where absolutely necessary

Exceptions were made for the static declarations like the driver
declaration, given that it depends on previously-defined callbacks.
So such declarations are at the end of visorinput.c.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorinput: subsume .h files directly into visorinput.c
Tim Sell [Fri, 2 Oct 2015 17:19:16 +0000 (13:19 -0400)]
staging: unisys: visorinput: subsume .h files directly into visorinput.c

keyboardchannel.h and mousechannel.h are now included within
visorinput.c directly.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: unisys: visorhid: rename to visorinput
Tim Sell [Fri, 2 Oct 2015 17:19:15 +0000 (13:19 -0400)]
staging: unisys: visorhid: rename to visorinput

This visorhid driver provides a Human Interface Device, but is not at all
using HID, the protocol.  It's a plain input driver, so for clarity, it is
being renamed to visorinput.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: rdma: Fix braces around if/else
Martin Kletzander [Sat, 3 Oct 2015 20:55:49 +0000 (22:55 +0200)]
staging: rdma: Fix braces around if/else

Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove blank lines before close brace
Chaehyun Lim [Fri, 2 Oct 2015 12:44:56 +0000 (21:44 +0900)]
staging: wilc1000: remove blank lines before close brace

This patch removes blank lines before close brace '}'

CHECK: Blank lines aren't necessary before a close brace '}'
drivers/staging/wilc1000/host_interface.c:5366:

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename s32Error in host_int_wait_msg_queue_idle
Chaehyun Lim [Fri, 2 Oct 2015 12:44:54 +0000 (21:44 +0900)]
staging: wilc1000: rename s32Error in host_int_wait_msg_queue_idle

This patch replaces s32Error with result to avoid camelcase.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fix return type of host_int_wait_msg_queue_idle
Chaehyun Lim [Fri, 2 Oct 2015 12:44:53 +0000 (21:44 +0900)]
staging: wilc1000: fix return type of host_int_wait_msg_queue_idle

This patch changes return type of host_int_wait_msg_queue_idle from s32
to int. s32Error gets return value from wilc_mq_send that has return
type of int. It should be changed return type of
host_int_wait_msg_queue_idle by int as well as data type of s32Error.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename hWFIDrv of host_int_set_mac_chnl_num
Chaehyun Lim [Fri, 2 Oct 2015 12:44:52 +0000 (21:44 +0900)]
staging: wilc1000: rename hWFIDrv of host_int_set_mac_chnl_num

This patch replaces hWFIDrv with wfi_drv that is first argument of
host_int_set_mac_chnl_num to avoid camelcase.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename u8ChNum of host_int_set_mac_chnl_num
Chaehyun Lim [Fri, 2 Oct 2015 12:44:51 +0000 (21:44 +0900)]
staging: wilc1000: rename u8ChNum of host_int_set_mac_chnl_num

This patch replaces u8ChNum with channel that is second argument of
host_int_set_mac_chnl_num to avoid camelcase.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename s32Error in host_int_set_mac_chnl_num
Chaehyun Lim [Fri, 2 Oct 2015 12:44:49 +0000 (21:44 +0900)]
staging: wilc1000: rename s32Error in host_int_set_mac_chnl_num

This patch replaces s32Error with result to avoid camelcase.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fix NULL comparison style
Chaehyun Lim [Fri, 2 Oct 2015 12:44:48 +0000 (21:44 +0900)]
staging: wilc1000: fix NULL comparison style

This patch changes NULL comparison style to use ! operator found by
checkpatch.pl

CHECK: Comparison to NULL could be written "!pstrWFIDrv"
drivers/staging/wilc1000/host_interface.c:5324:

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fix return type of host_int_set_mac_chnl_num
Chaehyun Lim [Fri, 2 Oct 2015 12:44:47 +0000 (21:44 +0900)]
staging: wilc1000: fix return type of host_int_set_mac_chnl_num

This patch changes return type of host_int_set_mac_chnl_num from s32 to
int. s32Error gets return value from wilc_mq_send function that
has return type of int. It should be changed return type of
host_int_set_mac_chnl_num function by int as well as data type of
s32Error.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: most: Use module_platform_driver
Shraddha Barke [Sat, 3 Oct 2015 12:01:30 +0000 (17:31 +0530)]
Staging: most: Use module_platform_driver

Use module_platform_driver for drivers whose init and exit functions
only register and unregister, respectively. Thus remove some
boilerplate code.

A simplified version of Coccinelle patch -

@a@
identifier f, x;
@@
-static f(...) { return platform_driver_register(&x); }
@b depends on a@
identifier e, a.x;
@@
-static e(...) { platform_driver_unregister(&x); }
@c depends on a && b@
identifier a.f;
declarer name module_init;
@@
-module_init(f);

@d depends on a && b && c@
identifier b.e, a.x;
declarer name module_exit;
declarer name module_platform_driver;
@@
-module_exit(e);
+module_platform_driver(x);

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: panel: Replace NULL comparison.
Aybuke Ozdemir [Sat, 3 Oct 2015 11:52:09 +0000 (14:52 +0300)]
Staging: panel: Replace NULL comparison.

Use ! operating instead of NULL checks.
Addresses "CHECK: Comparison to NULL" from checkpatch.pl.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: comedi: Use mutex instead of semaphore in ni_usb6501.c
Ksenija Stanojevic [Fri, 2 Oct 2015 20:09:43 +0000 (22:09 +0200)]
Staging: comedi: Use mutex instead of semaphore in ni_usb6501.c

Replace binary semaphore with mutex because mutex gives better
performance.
This change is safe because the thread that decrements the value of semaphore
is also the one that increments it, and acts like a mutex where owner of the
lock is the only one that can release the lock.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: comedi: Use mutex instead of semaphore in usbduxfast.c
Ksenija Stanojevic [Fri, 2 Oct 2015 20:07:54 +0000 (22:07 +0200)]
Staging: comedi: Use mutex instead of semaphore in usbduxfast.c

Replace binary semaphore with mutex because mutex gives better
performance.
This change is safe because the thread that decrements the value of semaphore
is also the one that increments it, and acts like a mutex where owner of the
lock is the only one that can release the lock.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: comedi: Use mutex instead of semaphore in usbdux.c
Ksenija Stanojevic [Fri, 2 Oct 2015 20:05:57 +0000 (22:05 +0200)]
Staging: comedi: Use mutex instead of semaphore in usbdux.c

Replace binary semaphore with mutex because mutex gives better
performance.
This change is safe because the thread that decrements the value of semaphore
is also the one that increments it, and acts like a mutex where owner of the
lock is the only one that can release the lock.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: comedi: Use mutex instead of semaphore in usbduxsigma.c
Ksenija Stanojevic [Fri, 2 Oct 2015 20:04:22 +0000 (22:04 +0200)]
Staging: comedi: Use mutex instead of semaphore in usbduxsigma.c

Replace binary semaphore with mutex because mutex gives better
performance.
This change is safe because the thread that decrements the value of semaphore
is also the one that increments it, and acts like a mutex where owner of the
lock is the only one that can release the lock.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: olpc_dcon: Replace timespec with ktime_t
Ksenija Stanojevic [Fri, 2 Oct 2015 17:24:05 +0000 (19:24 +0200)]
Staging: olpc_dcon: Replace timespec with ktime_t

Struct timespec will overflow in year 2038, here it will not cause an
overflow because it is used with timespec_sub, but still has to be
removed as part of y2038 changes. Replace it with ktime_t. Also use
monotonic instead of real-time by replacing functions getnstimeofday
with ktime_get.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: dgnc: take a lock when storing value in dgnc_poll_tick
Salah Triki [Sun, 4 Oct 2015 01:49:48 +0000 (02:49 +0100)]
staging: dgnc: take a lock when storing value in dgnc_poll_tick

Reads of dgnc_poll_tick are protected by dgnc_poll_lock spinlock, but the write
to dgnc_poll_tick is not. It could theoretically race.

Signed-off-by: Salah Triki <salah.triki@acm.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: dgnc: remove dgnc_init_globals function
Sudip Mukherjee [Sat, 3 Oct 2015 15:22:49 +0000 (20:52 +0530)]
staging: dgnc: remove dgnc_init_globals function

The dgnc_init_globals() function is only initializing the timer so
initialize it directly and remove dgnc_init_globals() and change the
comment appropriately.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: dgnc: remove initialization of global
Sudip Mukherjee [Sat, 3 Oct 2015 15:22:48 +0000 (20:52 +0530)]
staging: dgnc: remove initialization of global

globals variable will be initialied to 0 and the global pointers will be
to NULL. No need to initialize them separately.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: dgnc: remove NULL test
Sudip Mukherjee [Sat, 3 Oct 2015 15:22:46 +0000 (20:52 +0530)]
staging: dgnc: remove NULL test

This NULL test is not required as iounmap will validate the argument.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: dgnc: change style of NULL comparison
Sudip Mukherjee [Sat, 3 Oct 2015 15:22:44 +0000 (20:52 +0530)]
staging: dgnc: change style of NULL comparison

Change the NULL comparison style as warned by checkpatch.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: dgnc: remove unused variables
Sudip Mukherjee [Sat, 3 Oct 2015 15:22:39 +0000 (20:52 +0530)]
staging: dgnc: remove unused variables

These variables were only assigned some values but were never used.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: dgnc: Fix line over 80 characters warning
Cristina Moraru [Fri, 2 Oct 2015 17:15:55 +0000 (20:15 +0300)]
staging: dgnc: Fix line over 80 characters warning

Fix 'line over 80 characters' checkpatch warning

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: octeon: Add kernel-doc params description
Cristina Moraru [Sat, 3 Oct 2015 13:33:34 +0000 (16:33 +0300)]
staging: octeon: Add kernel-doc params description

Fix 'No description found for parameter' kernel-doc warnings

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: obdclass: Remove unused functions
Shraddha Barke [Fri, 2 Oct 2015 12:37:04 +0000 (18:07 +0530)]
Staging: lustre: obdclass: Remove unused functions

Remove dump_exports and print_export_data as they are defined
but not used anywhere.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging/lustre: Make nrs_policy_get_info_locked() static
Rocco Folino [Fri, 2 Oct 2015 21:54:26 +0000 (23:54 +0200)]
staging/lustre: Make nrs_policy_get_info_locked() static

This patch fixes the warning generated by sparse: "symbol 'nrs_policy_get_info_locked' was not
declared. Should it be static?" by declaring the function static.

Signed-off-by: Rocco Folino <rocco@devzen.net>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: obdclass: class_obd: Declare as static
Shraddha Barke [Fri, 2 Oct 2015 17:49:14 +0000 (23:19 +0530)]
Staging: lustre: obdclass: class_obd: Declare as static

Declare class_resolve_dev_name as static it is not used anywhere
apart from this particular file.Also remove the declaration
from header file

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: obdclass: genops: Declare as static
Shraddha Barke [Fri, 2 Oct 2015 17:49:13 +0000 (23:19 +0530)]
Staging: lustre: obdclass: genops: Declare as static

Declare class_get_type and class_search_type as static since they
are used only in this particular file. Also remove the declaration
from header files.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: obdclass: obd_config: Declare as static
Shraddha Barke [Fri, 2 Oct 2015 17:49:12 +0000 (23:19 +0530)]
Staging: lustre: obdclass: obd_config: Declare as static

Declare class_add_conn, class_add_profile, class_cleanup,
class_config_parse_rec, class_del_conn, class_detach, class_match_param,
class_attach, class_setup as static since they are used only in this
particular file. Also remove the corresponding declarations from
header files.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: obdclass: cl_lock: Declare as static
Shraddha Barke [Fri, 2 Oct 2015 17:49:11 +0000 (23:19 +0530)]
Staging: lustre: obdclass: cl_lock: Declare as static

Declare cl_lock_intransit and cl_lock_extransit as static since they
are used only in this particular file.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: obdclass: cl_io: Declare as static
Shraddha Barke [Fri, 2 Oct 2015 17:49:10 +0000 (23:19 +0530)]
Staging: lustre: obdclass: cl_io: Declare as static

Declare cl_page_list_assume, cl_io_cancel, cl_io_rw_advance,
cl_page_list_del, cl_page_list_discard, cl_page_list_fini as
static since they are used only in this particular file.
Also remove them from corresponding header files

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: ptlrpc: Declare sptlrpc_parse_rule as static
Shraddha Barke [Fri, 2 Oct 2015 10:49:31 +0000 (16:19 +0530)]
Staging: lustre: ptlrpc: Declare sptlrpc_parse_rule as static

Declare sptlrpc_parse_rule as static since it is accessed from this
particular file only. Also remove its declaration from
header file

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: ptlrpc: Declare sptlrpc_req_replace_dead_ctx as static
Shraddha Barke [Fri, 2 Oct 2015 10:49:30 +0000 (16:19 +0530)]
Staging: lustre: ptlrpc: Declare sptlrpc_req_replace_dead_ctx as static

Declare sptlrpc_req_replace_dead_ctx as static since it is accessed from
this particular file only. Also remove its declaration from
header file

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: ptlrpc: Declare sptlrpc_rule_set_choose as static
Shraddha Barke [Fri, 2 Oct 2015 10:49:29 +0000 (16:19 +0530)]
Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_choose as static

Declare sptlrpc_rule_set_choose as static since it is accessed from this
particular file only. Also remove its declaration from
header file

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: ptlrpc: Declare sptlrpc_rule_set_expand as static
Shraddha Barke [Fri, 2 Oct 2015 10:49:28 +0000 (16:19 +0530)]
Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_expand as static

Declare sptlrpc_rule_set_expand as static since it is accessed from this
particular file only. Also remove its declaration from
header file

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: ptlrpc: Declare sptlrpc_rule_set_free as static
Shraddha Barke [Fri, 2 Oct 2015 10:49:27 +0000 (16:19 +0530)]
Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_free as static

Declare sptlrpc_rule_set_free as static since it is accessed from this
particular file only. Also remove its declaration from
header file

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agoStaging: lustre: ptlrpc: Declare sptlrpc_rule_set_merge as static
Shraddha Barke [Fri, 2 Oct 2015 10:49:26 +0000 (16:19 +0530)]
Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_merge as static

Declare sptlrpc_rule_set_merge as static since it is accessed from this
particular file only. Also remove its declaration from
header file

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: android: Remove /** from regular comments
Cristina Moraru [Sat, 3 Oct 2015 15:45:01 +0000 (18:45 +0300)]
staging: android: Remove /** from regular comments

Fix 'cannot understand function prototype' and 'No description found for
parameter' kernel-doc warnings by replacing /** with /* in regular
comments

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: android: Remove kernel-doc typo
Cristina Moraru [Sat, 3 Oct 2015 15:20:47 +0000 (18:20 +0300)]
staging: android: Remove kernel-doc typo

Fix 'No description found for parameter 'prot_mask'' and 'Excess
struct/union/enum/typedef member 'prot_masks' description in
'ashmem_area'' warnings by removing typo

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: iio: adc: fix comment block coding style issue
Hugo Camboulive [Sat, 3 Oct 2015 18:32:48 +0000 (18:32 +0000)]
staging: iio: adc: fix comment block coding style issue

This patch to ad7746.c makes the comment block end with a */
on a separate line.

Signed-off-by: Hugo Camboulive <hugo.camboulive@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: iio: resolver: replace iio_device_register by devm_iio_device_register
Ioana Ciornei [Fri, 2 Oct 2015 10:37:50 +0000 (13:37 +0300)]
staging: iio: resolver: replace iio_device_register by devm_iio_device_register

Use devm_iio_device_register instead of iio_device_register when the remove
function is only used to call iio_device_unregister in order to ease the error path.
Since resource managed functions implicitly call unregister at driver detach also remove
iio_device_unregister

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: iio: light: use devm_iio_device_register instead iio_device_register
Ioana Ciornei [Fri, 2 Oct 2015 10:37:49 +0000 (13:37 +0300)]
staging: iio: light: use devm_iio_device_register instead iio_device_register

Replace iio_device_register with resource managed devm_iio_device_register in order
to ease the error path. Also delete the remove function since there is no need after
this change.

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: iio: cdc: use devm_iio_device_register instead iio_device_register
Ioana Ciornei [Fri, 2 Oct 2015 10:37:48 +0000 (13:37 +0300)]
staging: iio: cdc: use devm_iio_device_register instead iio_device_register

Replace iio_device_register with resource managed devm_iio_device_register in order
to ease the error path. Also delete de remove function since there is no need after
this change.

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wlan-ng: prism2sta: replace memcmp with ether_addr_equal
Maciek Borzecki [Sat, 3 Oct 2015 14:01:36 +0000 (16:01 +0200)]
staging: wlan-ng: prism2sta: replace memcmp with ether_addr_equal

Replace memcmp() with ether_addr_equal(). In every location where the
replacement was done, the addresses accessed are
__aligned(2). Structures accessed either stack or heap allocated, no
direct memory casts to possibly unaligned structs are used.

Involved structures:

typedef struct hfa384x_authenticateStation_data {
u8 address[ETH_ALEN];   /* 0 offset */
...
} __packed hfa384x_authenticateStation_data_t;

struct prism2sta_authlist {
unsigned int cnt;
u8 addr[WLAN_AUTH_MAX][ETH_ALEN]; /* 4 bytes offset,
     addresses start
     at u16 boundary */
u8 assoc[WLAN_AUTH_MAX];
};

struct prism2sta_accesslist {
unsigned int modify;
unsigned int cnt;
u8 addr[WLAN_ACCESS_MAX][ETH_ALEN]; /* 8 bytes offset,
       multiple of u16 */
...
u8 addr1[WLAN_ACCESS_MAX][ETH_ALEN]; /* starts at u32 boundary,
struct not packed */
};

typedef struct hfa384x_AssocStatus {
u16 assocstatus;
u8 sta_addr[ETH_ALEN];    /* 2 bytes offset,
     struct is packed */
u8 old_ap_addr[ETH_ALEN]; /* 8 bytes offset */
...
} __packed hfa384x_AssocStatus_t;

The patch resolves the following checkpatch warnings:

  WARNING: Prefer ether_addr_equal() or ether_addr_equal_unaligned()
           over memcmp()

Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: rename u8CurrChannel
Chaehyun Lim [Fri, 2 Oct 2015 07:41:21 +0000 (16:41 +0900)]
staging: wilc1000: rename u8CurrChannel

This patch replaces u8CurrChannel with curr_channel to avoid camelcase.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: set_channel: rename s32Error
Chaehyun Lim [Fri, 2 Oct 2015 07:41:20 +0000 (16:41 +0900)]
staging: wilc1000: set_channel: rename s32Error

This patch replaces s32Error with result to avoid camelcase.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: set_channel: fix data type of s32Error
Chaehyun Lim [Fri, 2 Oct 2015 07:41:19 +0000 (16:41 +0900)]
staging: wilc1000: set_channel: fix data type of s32Error

This patch changes data type of s32Error variable from s32 to int
because return type of this function is int.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: set_channel: remove blank line after open brace
Chaehyun Lim [Fri, 2 Oct 2015 07:41:18 +0000 (16:41 +0900)]
staging: wilc1000: set_channel: remove blank line after open brace

This patch removes blank line after open brace '{' found by
checkpatch.pl

CHECK: Blank lines aren't necessary after an open brace '{'
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:664:

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: use int instead of int8_t
Chaehyun Lim [Fri, 2 Oct 2015 07:41:17 +0000 (16:41 +0900)]
staging: wilc1000: use int instead of int8_t

This patch replaces int8_t with int.
The int8_t should be int. It's used as an index into an array
or -1 for not found.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: use ARRAY_SIZE macro
Chaehyun Lim [Fri, 2 Oct 2015 07:41:16 +0000 (16:41 +0900)]
staging: wilc1000: use ARRAY_SIZE macro

This patch uses ARRAY_SIZE macro found by checkpatch.pl

WARNING: Prefer ARRAY_SIZE(wb)
drivers/staging/wilc1000/wilc_spi.c:400
drivers/staging/wilc1000/wilc_spi.c:402

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove unnecessary comment
Chaehyun Lim [Fri, 2 Oct 2015 07:41:15 +0000 (16:41 +0900)]
staging: wilc1000: remove unnecessary comment

This patch removes unnecessary comment.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove #if 1 and #endif
Chaehyun Lim [Fri, 2 Oct 2015 07:41:14 +0000 (16:41 +0900)]
staging: wilc1000: remove #if 1 and #endif

This patch removes #if 1 and #endif, which is encapsulated
some codes.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: fix indentation level
Chaehyun Lim [Fri, 2 Oct 2015 07:41:13 +0000 (16:41 +0900)]
staging: wilc1000: fix indentation level

This patch removes unnecessary block braces and fix indentation.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove if defined codes of USE_OLD_SPI_SW
Chaehyun Lim [Fri, 2 Oct 2015 07:41:12 +0000 (16:41 +0900)]
staging: wilc1000: remove if defined codes of USE_OLD_SPI_SW

This patch removes if defined codes of USE_OLD_SPI_SW.
This macro is deleted because it is commented out.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove commented codes
Chaehyun Lim [Fri, 2 Oct 2015 07:41:11 +0000 (16:41 +0900)]
staging: wilc1000: remove commented codes

This patch removes commented codes that is not used in this driver.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove wilc_platform.h
Chaehyun Lim [Fri, 2 Oct 2015 07:41:10 +0000 (16:41 +0900)]
staging: wilc1000: remove wilc_platform.h

This patch removes wilc_platform.h file that is not used anywhere.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove unused variable real_ndev
Glen Lee [Fri, 2 Oct 2015 05:22:12 +0000 (14:22 +0900)]
staging: wilc1000: remove unused variable real_ndev

This patch removes unused variable real_ndev.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer cfg_init
Glen Lee [Fri, 2 Oct 2015 05:22:11 +0000 (14:22 +0900)]
staging: wilc1000: remove function pointer cfg_init

This patch removes function pointer cfg_init and call the function
wilc_wlan_cfg_init instead. Remove static from function declaration.
After removing cfg_init, the struct wilc_cfg_func_t is useless so just delete
it and it's related codes.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer rx_indicate
Glen Lee [Fri, 2 Oct 2015 05:22:10 +0000 (14:22 +0900)]
staging: wilc1000: remove function pointer rx_indicate

This patch removes function pointer rx_indicate and just call the function
wilc_wlan_cfg_indicate_rx instead. Remove static from the function
declration.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer cfg_wid_get_val
Glen Lee [Fri, 2 Oct 2015 05:22:09 +0000 (14:22 +0900)]
staging: wilc1000: remove function pointer cfg_wid_get_val

This patch removes cfg_wid_get_val and call the function
wilc_wlan_cfg_get_wid_value. Remove static from the function declaration.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer cfg_wid_get
Glen Lee [Fri, 2 Oct 2015 05:22:08 +0000 (14:22 +0900)]
staging: wilc1000: remove function pointer cfg_wid_get

Remove function pointer cfg_wid_get and call the function
wilc_wlan_cfg_get_wid instead. Remove static from the function declaration.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer cfg_wid_set
Glen Lee [Fri, 2 Oct 2015 05:22:07 +0000 (14:22 +0900)]
staging: wilc1000: remove function pointer cfg_wid_set

This patch removes function pointer cfg_wid_set and call the function
wilc_wlan_cfg_set_wid instead. Remove static from the function declaration.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: Delete undefined DEBUG_MODE and it's related codes
Glen Lee [Fri, 2 Oct 2015 05:22:06 +0000 (14:22 +0900)]
staging: wilc1000: Delete undefined DEBUG_MODE and it's related codes

This patch removes undefined DEBUG_MODE and it's related codes.
We won't use this at the moment.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: wilc_wfi_netdevice.h: remove unused variables
Glen Lee [Fri, 2 Oct 2015 05:22:05 +0000 (14:22 +0900)]
staging: wilc1000: wilc_wfi_netdevice.h: remove unused variables

This patch removes unused variable already_claim and hWILCWFIDrv_2.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: coreconfigurator.c: remove unused struct
Tony Cho [Fri, 2 Oct 2015 05:22:04 +0000 (14:22 +0900)]
staging: wilc1000: coreconfigurator.c: remove unused struct

This patch removes unused structure, tstrconfigPktInfo from the
coreconfigurator.c file.

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove typedef from enum
Tony Cho [Fri, 2 Oct 2015 05:22:03 +0000 (14:22 +0900)]
staging: wilc1000: remove typedef from enum

This patch removes typedef from enumerated types defined in
coreconfigurator.c file and also changes their names to avoid CamelCase
naming convention as shown:

- tenuBasicFrmType to basic_frame_type
- tenuFrmSubtype to sub_frame_type
- tenuInfoElemID to info_element_id

Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_add_mgmt_to_tx_que
Glen Lee [Thu, 1 Oct 2015 07:03:43 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_add_mgmt_to_tx_que

This patch removes function pointer wlan_add_mgmt_to_tx_que and just call
the function wilc_wlan_txq_add_mgmt_pkt.
Remove structure wilc_wlan_oup_t also because no members in it. Since
wilc_wlan_oup_t is deleted, it's variable, function parameters and related
codes are also deleted.
- deleted variables
gpstrWlanOps
oup
- modified functions
wilc1000_prepare_11b_core
wilc_wlan_init

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_cfg_get_value
Glen Lee [Thu, 1 Oct 2015 07:03:42 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_cfg_get_value

This patch removes function pointer wlan_cfg_get_value and just call
the function wilc_wlan_cfg_get_val. Remove static from the function also.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_cfg_get
Glen Lee [Thu, 1 Oct 2015 07:03:41 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_cfg_get

This patch removes function pointer wlan_cfg_get and just call
the function wilc_wlan_cfg_get. Remove static from the function also.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_cfg_set
Glen Lee [Thu, 1 Oct 2015 07:03:40 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_cfg_set

This patch removes function pointer wlan_cfg_set and just call
the function wilc_wlan_cfg_set. Remove static from the function also.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: delete define ACTION and PROBE_REQ
Glen Lee [Thu, 1 Oct 2015 07:03:39 +0000 (16:03 +0900)]
staging: wilc1000: delete define ACTION and PROBE_REQ

The define ACTION and PROBE_REQ are duplicate. They are aleady defined in
host_interface.h. Just delete it.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_cleanup
Glen Lee [Thu, 1 Oct 2015 07:03:38 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_cleanup

This patch removes function pointer wlan_cleanup and just call the function
wilc_wlan_cleanup. Remove static from the function also.
After changing function pointer wlan_cleanup with wilc_wlan_cleanup,
the define wilc_wlan_deinit will be like folowing.

-define wilc_wlan_deinit(nic)  { wilc_wlan_cleanup(); }

The define is unnecessary so just call wilc_wlan_cleanup instead of
wilc_wlan_deinit() and remove the define also.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_handle_rx_isr
Glen Lee [Thu, 1 Oct 2015 07:03:37 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_handle_rx_isr

This patch removes function pointer wlan_handle_rx_isr and just call
the function wilc_handle_isr.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_handle_tx_que
Glen Lee [Thu, 1 Oct 2015 07:03:36 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_handle_tx_que

This patch removes function pointer wlan_handle_tx_que and just call
the function wilc_wlan_handle_txq. Remove static from the function also.
There is one function call wlan_handle_tx_que which does not have an argument
and return value. So put txq_count as argument and ret for return value.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_add_to_tx_que
Glen Lee [Thu, 1 Oct 2015 07:03:35 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_add_to_tx_que

This patch removes function pointer wlan_add_to_tx_que and just call
the function wilc_wlan_txq_add_net_pkt. Remove static from the function also.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
9 years agostaging: wilc1000: remove function pointer wlan_stop
Glen Lee [Thu, 1 Oct 2015 07:03:34 +0000 (16:03 +0900)]
staging: wilc1000: remove function pointer wlan_stop

This patch removes function pointer wlan_stop and just call
the function wilc_wlan_stop. Remove static from the function also.

Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>