openwrt/staging/blogic.git
13 years agostaging: brcm80211: rename active_queue identifier
Arend van Spriel [Tue, 3 May 2011 09:35:29 +0000 (11:35 +0200)]
staging: brcm80211: rename active_queue identifier

The queue for pending transmit packets is called active_queue, but
the driver is only using one single queue. Therefor a more appro-
priate name has been given, ie. pkt_queue.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: implement flush driver callback for mac80211
Arend van Spriel [Tue, 3 May 2011 09:35:28 +0000 (11:35 +0200)]
staging: brcm80211: implement flush driver callback for mac80211

The mac80211 interface has a flush callback which is used by mac80211
to assure all pending transmit packets have been transmitted. This
is used before scanning off-channel.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed remaining ASSERTs from phy
Roland Vossen [Tue, 3 May 2011 09:35:27 +0000 (11:35 +0200)]
staging: brcm80211: removed remaining ASSERTs from phy

Partially deleted, partially replaced by WARN_ON to indicate hardware
failure to the user.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed all ASSERTs from wlc_ampdu.c
Roland Vossen [Tue, 3 May 2011 09:35:26 +0000 (11:35 +0200)]
staging: brcm80211: removed all ASSERTs from wlc_ampdu.c

Either removed ASSERTs or replaced with WARN_ON in case of HW failure.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed all ASSERTs from wl_mac80211.c
Roland Vossen [Tue, 3 May 2011 09:35:25 +0000 (11:35 +0200)]
staging: brcm80211: removed all ASSERTs from wl_mac80211.c

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: delete ASSERTs in 4 files in brcmsmac dir
Roland Vossen [Tue, 3 May 2011 09:35:24 +0000 (11:35 +0200)]
staging: brcm80211: delete ASSERTs in 4 files in brcmsmac dir

wlc_antsel.c, wlc_channel.c, wlc_rate.c and wlc_stf.c are now
ASSERT free.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed ASSERTs from util dir, part 2
Roland Vossen [Tue, 3 May 2011 09:35:23 +0000 (11:35 +0200)]
staging: brcm80211: removed ASSERTs from util dir, part 2

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed ASSERTs from util dir, part 1
Roland Vossen [Tue, 3 May 2011 09:35:22 +0000 (11:35 +0200)]
staging: brcm80211: removed ASSERTs from util dir, part 1

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: made fullmac error codes more consistent
Roland Vossen [Tue, 3 May 2011 09:35:21 +0000 (11:35 +0200)]
staging: brcm80211: made fullmac error codes more consistent

Code cleanup. The code contains several checks on the condition
SDIOH_API_SUCCESS(status). On failure, the error returned depended on the
check, instead of being consistent. This has been corrected.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: replace error codes part 2
Roland Vossen [Tue, 3 May 2011 09:35:20 +0000 (11:35 +0200)]
staging: brcm80211: replace error codes part 2

Replacing part of the proprietary error code values with native error
code values.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: replace error codes part 1
Roland Vossen [Tue, 3 May 2011 09:35:19 +0000 (11:35 +0200)]
staging: brcm80211: replace error codes part 1

Replacing part of the proprietary error code values with native error
code values.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed error string function
Roland Vossen [Tue, 3 May 2011 09:35:18 +0000 (11:35 +0200)]
staging: brcm80211: removed error string function

Only fullmac used this functionality, in which a broadcom specific error
code was converted to a human readable string. Since this  functionality
is not needed, a function and accompanying data structures have been
removed.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed ASSERTs from wlc_bmac.c
Roland Vossen [Tue, 3 May 2011 09:35:17 +0000 (11:35 +0200)]
staging: brcm80211: removed ASSERTs from wlc_bmac.c

Driver contains far too many ASSERTs. Extraneous asserts removed.
Only asserts that signal a hardware problem have been converted
into WARN_ON.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed ASSERTs from wlc_ampdu.c
Roland Vossen [Tue, 3 May 2011 09:35:16 +0000 (11:35 +0200)]
staging: brcm80211: removed ASSERTs from wlc_ampdu.c

Driver contains far too many ASSERTs.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed ASSERTs from wlc_main.c
Roland Vossen [Tue, 3 May 2011 09:35:15 +0000 (11:35 +0200)]
staging: brcm80211: removed ASSERTs from wlc_main.c

Driver contains far too many ASSERTs. Functions that were only used
from within removed ASSERTs have also been deleted, such as
wlc_bmac_taclear() in wlc_bmac.c.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: honour basic rate configuration from mac80211
Arend van Spriel [Tue, 3 May 2011 09:35:14 +0000 (11:35 +0200)]
staging: brcm80211: honour basic rate configuration from mac80211

The basic rates to be used are provided by the wireless access point
within the beacon information. The station should conform to those
rates and this information is passed by mac80211 to the driver. The
patch processes the information and applies the basic rates accor-
dingly. This is required functionality for mac80211 drivers.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: rename rate related definitions
Arend van Spriel [Tue, 3 May 2011 09:35:13 +0000 (11:35 +0200)]
staging: brcm80211: rename rate related definitions

Added prefix WLC_ to the rate related definition.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove wl_ops_set_rts_threshold
Arend van Spriel [Tue, 3 May 2011 09:35:12 +0000 (11:35 +0200)]
staging: brcm80211: remove wl_ops_set_rts_threshold

The function is not required as the driver does honour the USE_RTS_CTS
flag. The mac80211 API notes state that either one or the other is required
(see http://wireless.kernel.org/en/developers/Documentation/mac80211/API).

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove unnecessary if statements from bss_info_changed
Arend van Spriel [Tue, 3 May 2011 09:35:11 +0000 (11:35 +0200)]
staging: brcm80211: remove unnecessary if statements from bss_info_changed

The mac80211 api callback bss_info_changed contained two placeholders
that were expected to need to be implemented. However, reading the mac80211
notes (http://wireless.kernel.org/en/developers/Documentation/mac80211/API)
shows that it is not needed as the driver honours the flags provided with
the transmit sk_buff.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: replaced WL_ERROR in rest of softmac.
Roland Vossen [Tue, 3 May 2011 09:35:10 +0000 (11:35 +0200)]
staging: brcm80211: replaced WL_ERROR in rest of softmac.

Code cleanup. Replaced proprietary function by wiphy_err(). Removed
WL_ERROR() on spots where struct wlc was not available and message
was redundant.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: replaced WL_ERROR in wlc_main.c
Roland Vossen [Tue, 3 May 2011 09:35:09 +0000 (11:35 +0200)]
staging: brcm80211: replaced WL_ERROR in wlc_main.c

Code cleanup. Replaced proprietary function by wiphy_err().

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: replaced WL_ERROR in wlc_bmac.c
Roland Vossen [Tue, 3 May 2011 09:35:08 +0000 (11:35 +0200)]
staging: brcm80211: replaced WL_ERROR in wlc_bmac.c

Code cleanup. Replaced proprietary function by wiphy_err().

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: replaced WL_ERROR in wlc_ampdu.c
Roland Vossen [Tue, 3 May 2011 09:35:07 +0000 (11:35 +0200)]
staging: brcm80211: replaced WL_ERROR in wlc_ampdu.c

Code cleanup. Replaced proprietary function by wiphy_err().

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: replaced WL_ERROR in two files.
Roland Vossen [Tue, 3 May 2011 09:35:06 +0000 (11:35 +0200)]
staging: brcm80211: replaced WL_ERROR in two files.

Code cleanup. Use Linux functions instead of Broadcom specific
one. On spots where the wiphy object is not yet available,
pr_err() is used instead.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: making wiphy object accessible from wlc and phy
Roland Vossen [Tue, 3 May 2011 09:35:05 +0000 (11:35 +0200)]
staging: brcm80211: making wiphy object accessible from wlc and phy

Next commits will replace WL_ERROR and friends with BCMMSG. Because
this new message log function require a wiphy object, device object pointers
have been added to three data structures.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed WL_NONE
Roland Vossen [Tue, 3 May 2011 09:35:04 +0000 (11:35 +0200)]
staging: brcm80211: removed WL_NONE

Code cleanup.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: bugfix for fullmac return codes
Roland Vossen [Tue, 3 May 2011 09:35:03 +0000 (11:35 +0200)]
staging: brcm80211: bugfix for fullmac return codes

Some code paths in the fullmac driver did not return a negative value
on error. This has been corrected.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: made error codes in bcmutils.h positive
Roland Vossen [Tue, 3 May 2011 09:35:02 +0000 (11:35 +0200)]
staging: brcm80211: made error codes in bcmutils.h positive

Code cleanup. Bringing driver more inline with Linux code style.
Does not introduce behavioral changes.

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: fixed error in non-DHD_DEBUG fullmac build
Roland Vossen [Tue, 3 May 2011 09:35:01 +0000 (11:35 +0200)]
staging: brcm80211: fixed error in non-DHD_DEBUG fullmac build

A build error was introduced with recent fullmac changes when building without
debug option configured:

drivers/staging/brcm80211/brcmfmac/dhd_sdio.c: In function
  ‘dhdsdio_sdiod_drive_strength_init’:
drivers/staging/brcm80211/brcmfmac/dhd_sdio.c:6366:3: error: ‘chn’ undeclared

Cc: devel@linuxdriverproject.org
Cc: linux-wireless@vger.kernel.org
Cc: Brett Rudley <brudley@broadcom.com>
Cc: Henry Ptasinski <henryp@broadcom.com>
Cc: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove few more unused header files
Vasanthakumar Thiagarajan [Mon, 2 May 2011 12:20:59 +0000 (17:50 +0530)]
ath6kl: Remove few more unused header files

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Replace data type macros with kernel defined ones
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:49 +0000 (11:22 +0530)]
ath6kl: Replace data type macros with kernel defined ones

Now athtypes_linux.h and a_types.h are unused, remove them.

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove unused macros from gpio_reg.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:48 +0000 (11:22 +0530)]
ath6kl: Remove unused macros from gpio_reg.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove unused regdump.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:47 +0000 (11:22 +0530)]
ath6kl: Remove unused regdump.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove somemore unused header files from hw4.0/hw/
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:46 +0000 (11:22 +0530)]
ath6kl: Remove somemore unused header files from hw4.0/hw/

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove unused hw4.0/hw/vmc_reg.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:45 +0000 (11:22 +0530)]
ath6kl: Remove unused hw4.0/hw/vmc_reg.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove unused bb_lc_reg.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:44 +0000 (11:22 +0530)]
ath6kl: Remove unused bb_lc_reg.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove unused hw2.0/hw/uart_reg.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:43 +0000 (11:22 +0530)]
ath6kl: Remove unused hw2.0/hw/uart_reg.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove duplicate si_reg.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:42 +0000 (11:22 +0530)]
ath6kl: Remove duplicate si_reg.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove duplicate rtc_reg.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:41 +0000 (11:22 +0530)]
ath6kl: Remove duplicate rtc_reg.h

Also remove unused rtc register definition from rtc_reg.h.

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove duplicate mbox_wlan_reg.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:40 +0000 (11:22 +0530)]
ath6kl: Remove duplicate mbox_wlan_reg.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove duplicate mbox_host_reg.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:39 +0000 (11:22 +0530)]
ath6kl: Remove duplicate mbox_host_reg.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove duplicate abp_map.h
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:38 +0000 (11:22 +0530)]
ath6kl: Remove duplicate abp_map.h

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoath6kl: Remove unused analog_register header files
Vasanthakumar Thiagarajan [Mon, 2 May 2011 05:52:37 +0000 (11:22 +0530)]
ath6kl: Remove unused analog_register header files

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: lirc: fixed coding style
Greg Dietsche [Sat, 30 Apr 2011 20:03:20 +0000 (15:03 -0500)]
staging: lirc: fixed coding style

fixed a few minor coding style issues reported by checkpatch.pl

Signed-off-by: Greg Dietsche <gregory.dietsche@cuw.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: sm7xx: minor cleanup
Javier M. Mellid [Sat, 30 Apr 2011 15:44:26 +0000 (17:44 +0200)]
staging: sm7xx: minor cleanup

Sync code comments with TODO, fix some style and format issues

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: sm7xx: smtcfb.c: Use the new PCI PM
Javier M. Mellid [Sat, 30 Apr 2011 15:44:25 +0000 (17:44 +0200)]
staging: sm7xx: smtcfb.c: Use the new PCI PM

The sm7xx driver uses the legacy PCI power management (suspend and
resume) callbacks.

This patch adds the new PCI PM and let the PCI core code handles the
PCI-specific details of power transitions.

Tested in 2.6.38, including standby and hibernation support.

Tested-by: Wu Zhangjin <wuzhangjin@gmail.com>
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: ath6kl: open/shared auth implementation
Naveen Singh [Fri, 29 Apr 2011 17:02:31 +0000 (20:02 +0300)]
staging: ath6kl: open/shared auth implementation

If the wpa_supplicant conf file supplies both open and shared
algorithm, and AP is configured as shared then connection never
happens. Since it is a FMAC driver additional logic is added in
driver which first detects this, then tries open algorithm for the
first time and when it fails tries the shared algo.

kvalo: fix style issues

Signed-off-by: Naveen Singh <nsingh@atheros.com>
Signed-off-by: Kalle Valo <kalle.valo@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: ath6kl: cfg80211_roam issue; driver wedge
Naveen Singh [Fri, 29 Apr 2011 17:02:20 +0000 (20:02 +0300)]
staging: ath6kl: cfg80211_roam issue; driver wedge

If a heavy traffic is undergoing and a link is lost (bcn miss),
wlan driver does a reconnection on its own and after connection
is re-established, reports it as ROAM_EVENT to cfg. Now this event
is handled as work queue. It could very well happen that by the
time this event gets handled, cfg would have aged out the bss and
we get the following WARN_ON in __cfg80211_roamed function in file
net/wireless/sme.c.

        /* internal error -- how did we get to CONNECTED w/o BSS? */
        if (WARN_ON(!wdev->current_bss)) {
                return;
        }
To resolve the issue we report the BSS whenever we send a connect or
roam event to the cfg.

kvalo: fix style issues

Signed-off-by: Naveen Singh <nsingh@atheros.com>
Signed-off-by: Kalle Valo <kalle.valo@atheros.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: ft1000: Removed unused variable InterruptsEnabled.
Marek Belisko [Fri, 29 Apr 2011 05:41:10 +0000 (07:41 +0200)]
staging: ft1000: Removed unused variable InterruptsEnabled.

Removed beacuse was only assigned and never used.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: ft1000: Remove unused variable CurrentInterruptEnableMask.
Marek Belisko [Fri, 29 Apr 2011 05:41:09 +0000 (07:41 +0200)]
staging: ft1000: Remove unused variable CurrentInterruptEnableMask.

Removed because was only assigned and never used.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: ft1000: Remove unused variable DSPResetNum.
Marek Belisko [Fri, 29 Apr 2011 05:41:08 +0000 (07:41 +0200)]
staging: ft1000: Remove unused variable DSPResetNum.

Removed because was only assigned and never used.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: ft1000: Remove unused variable ASICResetNum.
Marek Belisko [Fri, 29 Apr 2011 05:41:07 +0000 (07:41 +0200)]
staging: ft1000: Remove unused variable ASICResetNum.

Removed because was only assigned and not used on other places.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: ft1000: Remove unused variables in ft1000_info.
Marek Belisko [Fri, 29 Apr 2011 05:41:06 +0000 (07:41 +0200)]
staging: ft1000: Remove unused variables in ft1000_info.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: ft1000: Remove unused declaration in ft1000_usb.h.
Marek Belisko [Fri, 29 Apr 2011 05:41:05 +0000 (07:41 +0200)]
staging: ft1000: Remove unused declaration in ft1000_usb.h.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoIIO: GYRO: ADXRS450: Don't exit probe, in case the power on default is not met.
Michael Hennerich [Fri, 29 Apr 2011 12:17:04 +0000 (14:17 +0200)]
IIO: GYRO: ADXRS450: Don't exit probe, in case the power on default is not met.

If the part get's probed twice without hard reset in between, the power on default
register read-back can't be met. This shouldn't cause the second probe to fail.
So warn but don't exit.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoIIO: GYRO: ADXRS450: Fix sign issues, properly shift results and limit values
Michael Hennerich [Fri, 29 Apr 2011 12:17:03 +0000 (14:17 +0200)]
IIO: GYRO: ADXRS450: Fix sign issues, properly shift results and limit values

RATE and QUADRATURE_CORRECTION data is formatted as a twos complement number,
and therefore must be handled as type signed short.

TEMP result should be properly shifted.

Dynamic Null Correction is a 10-bit signed number.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoIIO: GYRO: ADXRS450: enforce sequential transfer delay of at least 0.1ms
Michael Hennerich [Fri, 29 Apr 2011 12:17:02 +0000 (14:17 +0200)]
IIO: GYRO: ADXRS450: enforce sequential transfer delay of at least 0.1ms

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoIIO: GYRO: ADXRS450: Add missing parity bit generation
Michael Hennerich [Fri, 29 Apr 2011 12:17:01 +0000 (14:17 +0200)]
IIO: GYRO: ADXRS450: Add missing parity bit generation

Add missing parity bit generation. Failure to add the parity bit
caused half of the register accesses to fail.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoIIO: GYRO: ADXRS450: Cleanup result extraction and update license notice
Michael Hennerich [Fri, 29 Apr 2011 12:17:00 +0000 (14:17 +0200)]
IIO: GYRO: ADXRS450: Cleanup result extraction and update license notice

Cleanup result extraction and update license notice, no functional changes.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoIIO: GYRO: ADXRS450: Don't issue two messages, use two transfers
Michael Hennerich [Fri, 29 Apr 2011 12:16:59 +0000 (14:16 +0200)]
IIO: GYRO: ADXRS450: Don't issue two messages, use two transfers

Don't issue the same message twice, use two transfers and group them together

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoIIO: DDS: AD9834: Add support for AD9837 and AD9838 DDS devices
Michael Hennerich [Wed, 27 Apr 2011 15:22:36 +0000 (17:22 +0200)]
IIO: DDS: AD9834: Add support for AD9837 and AD9838 DDS devices

Add support for AD9837 and AD9838 DDS devices
Update copyright and license notice
Fix typo

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoIIO: DAC: AD5791: Add support for the AD5760/AD5780 High Resolution DACs
Michael Hennerich [Wed, 27 Apr 2011 15:13:58 +0000 (17:13 +0200)]
IIO: DAC: AD5791: Add support for the AD5760/AD5780 High Resolution DACs

Add support for the AD5760/AD5780 High Resolution Voltage Output DACs

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: r8712u: Fix driver to support ad-hoc mode
Jeff Chua [Wed, 27 Apr 2011 16:25:14 +0000 (11:25 -0500)]
staging: r8712u: Fix driver to support ad-hoc mode

Driver r8712u is unable to handle ad-hoc mode. The issue is that when
the driver first starts, there will not be an SSID for association.
The fix is to always call the "select and join from scan" routine when
in ad-hoc mode.

Note: Ad-hoc mode worked intermittently before. If the driver had
previously been associated, then things were OK.

Signed-off-by: Jeff Chua <jeff.chua.linux@gmail.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Get rid of the priv pointer in struct hv_driver
K. Y. Srinivasan [Tue, 26 Apr 2011 16:20:27 +0000 (09:20 -0700)]
Staging: hv: Get rid of the priv pointer in struct hv_driver

Now that we have gotten rid of all uses of the priv element in
struct hv_driver, get rid of the priv pointer.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Cleanup vmbus_match()
K. Y. Srinivasan [Tue, 26 Apr 2011 16:20:24 +0000 (09:20 -0700)]
Staging: hv: Cleanup vmbus_match()

In preparation for getting rid of the priv element from struct hv_driver,
cleanup vmbus_match - the setting of the drv field in struct hv_device
is not needed.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Get rid of the references to the priv element of struct hv_driver in...
K. Y. Srinivasan [Tue, 26 Apr 2011 16:20:23 +0000 (09:20 -0700)]
Staging: hv: Get rid of the references to the priv element of struct hv_driver in storvsc_drv.c

In preparation for getting rid of the priv element from struct hv_driver,
get rid of the references to the priv element of struct
hv_driver in storvsc_drv.c.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Get rid of the references to the priv element of struct hv_driver in...
K. Y. Srinivasan [Tue, 26 Apr 2011 16:20:22 +0000 (09:20 -0700)]
Staging: hv: Get rid of the references to the priv element of struct hv_driver in net driver

In preparation for getting rid of the priv element from struct hv_driver,
get rid of the references to the priv element of struct
hv_driver in network driver.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Introduce a function to map a generic driver pointer to a pointer to...
K. Y. Srinivasan [Tue, 26 Apr 2011 16:20:21 +0000 (09:20 -0700)]
Staging: hv: Introduce a function to map a generic driver pointer to a pointer to struct netvsc_driver

In preparation for getting rid of the priv element from struct hv_driver,
introduce a function to map a generic driver pointer to a pointer to
struct netvsc_driver.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Get rid of the references to the priv element of struct hv_driver in...
K. Y. Srinivasan [Tue, 26 Apr 2011 16:20:20 +0000 (09:20 -0700)]
Staging: hv: Get rid of the references to the priv element of struct hv_driver in hv_mouse.c

In preparation for getting rid of the priv element from struct hv_driver,
get rid of the references to the priv element of struct hv_driver
in hv_mouse.c

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Get rid of the references to the priv element of struct hv_driver in...
K. Y. Srinivasan [Tue, 26 Apr 2011 16:20:19 +0000 (09:20 -0700)]
Staging: hv: Get rid of the references to the priv element of struct hv_driver in block driver

In preparation for getting rid of the priv element from struct hv_driver,
get rid of the references to the priv element of struct hv_driver
in blkvsc_drv.c and storvsc.c

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Introduce a function to map a generic driver pointer to a pointer to...
K. Y. Srinivasan [Tue, 26 Apr 2011 16:20:18 +0000 (09:20 -0700)]
Staging: hv: Introduce a function to map a generic driver pointer to a pointer to storvsc_driver_object

In preparation for getting rid of the priv element from struct hv_driver,
introduce a function that maps a generic struct driver pointer to struct
storvsc_driver_object.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed style issues.
Kenji Toyama [Tue, 26 Apr 2011 04:13:43 +0000 (12:13 +0800)]
Staging: xgifb: Fixed style issues.

Not all warnings/errors were silenced, some of them are related to
simple printk() messages that imho should not be split across multiple
lines (it makes it harder to grep for example), and some of them are
related to long lines that are pretty much impossible to split without
proper code refactoring.

Resubmitting this patch because of conflicts.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed style issues.
Kenji Toyama [Tue, 26 Apr 2011 04:12:39 +0000 (12:12 +0800)]
Staging: xgifb: Fixed style issues.

Now there's only 10 errors and 1 warning given by checkpatch.pl, and
these are related initialization of statics. The only warning left can
be safely ignored I believe.

I'm resending this patch as the previous one was conflicting with the
newer version updated by Aaro Koskinen.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: Remove si sb utils from brcmfmac
Franky Lin [Tue, 26 Apr 2011 02:34:08 +0000 (19:34 -0700)]
staging: brcm80211: Remove si sb utils from brcmfmac

si/sb utility is removed from Broadcom fullmac driver.
All unused files are removed.

Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: Remove siutils dependence from dhd_sdio.c
Franky Lin [Tue, 26 Apr 2011 02:34:07 +0000 (19:34 -0700)]
staging: brcm80211: Remove siutils dependence from dhd_sdio.c

Remove siutils related functions and resources from dhd_sdio.c

Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: Add dhdsdio_chip_detach in dhd_sdio.c
Franky Lin [Tue, 26 Apr 2011 02:34:06 +0000 (19:34 -0700)]
staging: brcm80211: Add dhdsdio_chip_detach in dhd_sdio.c

Add dhdsdio_chip_detach to replace si_detach for si/sb utils removal

Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: Move sdiod strength init to dhd_sdio.c
Franky Lin [Tue, 26 Apr 2011 02:34:05 +0000 (19:34 -0700)]
staging: brcm80211: Move sdiod strength init to dhd_sdio.c

Move si_sdiod_drive_strength_init to dhd_sdio and rename to
dhdsdio_sdiod_drive_strength_init for dhd_pmu.c removal

Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: Remove siutils dependency of dhdsdio_download_state
Franky Lin [Tue, 26 Apr 2011 02:34:04 +0000 (19:34 -0700)]
staging: brcm80211: Remove siutils dependency of dhdsdio_download_state

Use dhdsdio_chip_disablecore and dhd_sdio_chip_resetcore to replace
siutils functions used in dhdsdio_download_state

Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed styles issues.
Kenji Toyama [Sun, 24 Apr 2011 05:55:49 +0000 (13:55 +0800)]
Staging: xgifb: Fixed styles issues.

All the warnings about styles have been removed.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed style issues.
Kenji Toyama [Sun, 24 Apr 2011 05:46:25 +0000 (13:46 +0800)]
Staging: xgifb: Fixed style issues.

Now checkpatch.pl doesn't complain about vgatypes.h.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed header file.
Kenji Toyama [Sun, 24 Apr 2011 05:35:35 +0000 (13:35 +0800)]
Staging: xgifb: Fixed header file.

As suggested by checkpatch.pl, <linux/io.h> should be used instead of
<asm/io.h>.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Removed thousands of warnings.
Kenji Toyama [Sun, 24 Apr 2011 03:37:17 +0000 (11:37 +0800)]
Staging: xgifb: Removed thousands of warnings.

This is a big patch to remove all the warnings given by checkpatch.pl.
There were 13348 errors and  3112 warnings, but now there's nothing.
I've compiled the files dependent on this header and they seem alright.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed almost all style warnings.
Kenji Toyama [Sat, 23 Apr 2011 13:54:07 +0000 (21:54 +0800)]
Staging: xgifb: Fixed almost all style warnings.

I've removed all the warnings except one that I believe is a false
positive. The original author has used a macro to #define EXTERN to be
'extern', so in this case 'extern' is not used to define the storage
class of anything, but just the value of the macro. We can safely ignore
this warning.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed lots of coding style issues.
Kenji Toyama [Sat, 23 Apr 2011 11:36:49 +0000 (19:36 +0800)]
Staging: xgifb: Fixed lots of coding style issues.

There were hundreds of warnings and errors given by checkpatch.pl but
now it's down to 20. These ones that were left in the code need some
more attention, cause I reckon the functions are overly nested leading
to a mess of code in a traditional 80 character screen. I'm sure this code
can be refactored into something more visually pleasing (things like
compressing two nested if's into a single if with an AND would help a
lot already).

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed coding style issues in vb_setmode.h
Kenji Toyama [Sat, 23 Apr 2011 08:14:34 +0000 (16:14 +0800)]
Staging: xgifb: Fixed coding style issues in vb_setmode.h

All the warnings in vb_setmode.h given by checkpatch.pl were removed.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed lots of coding style issues.
Kenji Toyama [Sat, 23 Apr 2011 04:11:16 +0000 (12:11 +0800)]
Staging: xgifb: Fixed lots of coding style issues.

There were hundreds of warnings, but now there's only four. These are
related to the 'volatile' keyword and printk(), which I think should be
left to the maintainers to modify if deemed necessary.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed coding style issues.
Kenji Toyama [Sat, 23 Apr 2011 00:27:48 +0000 (08:27 +0800)]
Staging: xgifb: Fixed coding style issues.

Not all warnings were silenced. One of them is a typedef in vb_ext.h
which I think seems alright.
The other warnings in vb_ext.c I left there because that would involve
changing a bit of the logic in the code. IMHO though I think the
functions are too complicated (i.e. the if/else are too deep within a
big function.) and can probably be split.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: xgifb: Fixed coding style issues in vb_def.h
Kenji Toyama [Fri, 22 Apr 2011 23:02:49 +0000 (07:02 +0800)]
Staging: xgifb: Fixed coding style issues in vb_def.h

I've removed all the warnings given by checkpatch.pl in vb_def.h and
also changed the indentation of pretty much the entire file so that it
is more consistent.

Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: main: make internal functions static
Aaro Koskinen [Mon, 18 Apr 2011 19:14:08 +0000 (22:14 +0300)]
staging: xgifb: main: make internal functions static

Make remaining non-static internal functions static.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: main: delete unused functions
Aaro Koskinen [Mon, 18 Apr 2011 19:14:07 +0000 (22:14 +0300)]
staging: xgifb: main: delete unused functions

Delete unused/dead code.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: main: delete redudant extern declarations
Aaro Koskinen [Mon, 18 Apr 2011 19:14:06 +0000 (22:14 +0300)]
staging: xgifb: main: delete redudant extern declarations

Delete redudant declarations and include proper .h files.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: main: move functions to avoid forward declarations
Aaro Koskinen [Mon, 18 Apr 2011 19:14:05 +0000 (22:14 +0300)]
staging: xgifb: main: move functions to avoid forward declarations

Move functions so that all forward declarations of internal functions
can be deleted.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: delete unused register I/O functions
Aaro Koskinen [Mon, 18 Apr 2011 19:14:04 +0000 (22:14 +0300)]
staging: xgifb: delete unused register I/O functions

Delete unused register I/O functions.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: delete unused register I/O macros
Aaro Koskinen [Mon, 18 Apr 2011 19:14:03 +0000 (22:14 +0300)]
staging: xgifb: delete unused register I/O macros

Delete unused register I/O macros.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: replace setXGIIDXREG() with xgifb_reg_and_or()
Aaro Koskinen [Mon, 18 Apr 2011 19:14:02 +0000 (22:14 +0300)]
staging: xgifb: replace setXGIIDXREG() with xgifb_reg_and_or()

Replace setXGIIDXREG() with xgifb_reg_and_or().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: replace andXGIIDXREG() with xgifb_reg_and()
Aaro Koskinen [Mon, 18 Apr 2011 19:14:01 +0000 (22:14 +0300)]
staging: xgifb: replace andXGIIDXREG() with xgifb_reg_and()

Replace andXGIIDXREG() with xgifb_reg_and().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: replace orXGIIDXREG() with xgifb_reg_or()
Aaro Koskinen [Mon, 18 Apr 2011 19:14:00 +0000 (22:14 +0300)]
staging: xgifb: replace orXGIIDXREG() with xgifb_reg_or()

Replace orXGIIDXREG() with xgifb_reg_or().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: replace outXGIIDXREG() with xgifb_reg_set()
Aaro Koskinen [Mon, 18 Apr 2011 19:13:59 +0000 (22:13 +0300)]
staging: xgifb: replace outXGIIDXREG() with xgifb_reg_set()

Replace outXGIIDXREG() with xgifb_reg_set().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: replace inXGIIDXREG() with xgifb_reg_get()
Aaro Koskinen [Mon, 18 Apr 2011 19:13:58 +0000 (22:13 +0300)]
staging: xgifb: replace inXGIIDXREG() with xgifb_reg_get()

Replace inXGIIDXREG() with xgifb_reg_get().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: xgifb: replace outXGIREG() with outb()
Aaro Koskinen [Mon, 18 Apr 2011 19:13:57 +0000 (22:13 +0300)]
staging: xgifb: replace outXGIREG() with outb()

Replace outXGIREG() with outb().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>