luci-base: dispatcher.lua: pass permission state to legacy CBI templates

Ref: https://github.com/openwrt/luci/issues/3937
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit c48a8d58132b4f175ec0a4b4ec4e15eb199edeb8)

luci-base: dispatcher.lua: honour acl_depends annotations in Lua controllers

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 760763a7b5da42860c6c2d63478859bb02fa9104)

luci-base: dispatcher.lua: add support for handling menu ACL annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 125916f2f4603acf980acd074aca55d0b528f34b)

luci-base: Add missed config parameter for cbi when converting to JSON

The cbi() function has a second argument 'config' in which various
configuration parameters can be passed. When converting the lua menu
to JSON, we must also convert this parameter.

Signed-off-by: Anton Kikin <a.kikin@tano-systems.com>
(cherry picked from commit 2d8299338e6c77fb15c457f5cf7f34dc0278db60)

luci-base: dispatcher.lua: remove redundant check_fs_depends() call

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 08eea3f93e9f2e9a2940df2e3a7afbe04c40f4b6)

luci-base: dispatcher.lua: fix filesystem dependency checks

A variable clash led to declarative `fs` dependencies being ineffective.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 7cfce565530cbf6103275002ad20af57a509ad7b)

luci-base: dispatcher: remove empty firstchild nodes from menu

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit fd7961337f44ebe8aa71e6ae0925cb70a8c53b21)

luci-base: dispatcher: fix rpc controller regression

When testing the luci-rpc authnetication, avoid clobbering the HTTP
post request body.

Fixes: #3470
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 38c9c9e0a2564b9644a56f1143f6acf0c9e272c8)

luci-base: dispatcher.lua: add support for loading JSON menu files

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit cf1219bd0790506279b14007595e8389e5eb99ff)

luci-base: dispatcher.lua: refactor dispatch logic

Refactor the dispatch logic to operate on the internal JSON representation
of the menu tree.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 184ea6230076bf4dd3abf6669bde17f87a051146)

luci-base: dispatcher.lua: factor out template class init into own function

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 1ec6e72106218e11871dd8ee563f7673c2d1f7dc)

luci-base: dispatcher.lua: factor out language check into own function

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit a6b214f87332471b8210d05b02ae59ea6b0c16b7)

luci-base: dispatcher.lua: introduce dispatch tree JSON conversion

Introduce a new method menu_json() which converts the current dispatch
tree into JSON structure.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 852d24061d236048a8c2c886787eede2586b10b4)

luci-mod-status: use LuCI.ui.instantiateView() to load index view

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit f9d61213fbfde66ffc6f8ca0e112d6445c6c4695)

luci-base: ui.js: add instantiateView() helper

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit d9e9cf92d15c81284000c7c97c6f7bf2b5953c2d)

treewide: import utility classes explicitly

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit 3c4bc228a1f7b5731cf464f3f407c9ed9ace3cd2)

luci-base: harmonize JS class naming and requesting

 - Make builtin classes available via `require` to allow view code to
   request external and internal classes in a consistent manner without
   having to know which classes are builtin and which not

 - Make base classes request any used class explicitely instead of
   relying on implicitly set up L.{dom,view,Poll,Request,Class} aliases

 - Consistently convert class names to lower case in JSdoc to match
   the names used in `require` statements

 - Deprecate L.{dom,view,Poll,Request,Class} aliases

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit 711f75927849fade74f79e4b198b3a839d9d4fbc)

luci-base: Improve change application message

As a native English speaker the luci message displayed when clicking
'Save & Apply' has a somewhat uncomfortable English phrasing of "Waiting
for configuration to get applied".  It could be improved by replacing
'get' with 'be' but once you've got that far you might as well replace
this with the shorter & simpler "Applying configuration changes".  This
is also technically more correct since luci/openwrt should only be
updating/restarting processes that are related to the changed areas, not
changing the entire configuration.

As a result of that, change both the 'success' and 'rolled back'
messages to "Configuration changes have been applied" & "Configuration
changes have been rolled back"

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
(cherry picked from commit 9b266d11c6b5082c733f101326160cef797f6edf)

luci-base: ui.js: dispatch "cbi-tab-active" event when a tab is selected

This is useful to lazy-load tab contents.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit bf774e4c2a6a03aa01d4bcd9f5ce4f960cd91874)

luci-base: ui.js: allow custom validation in Dropdown and DynamicList

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 90a161018c9c7650a27a66f8e0a4f060d1ccebd6)

luci-base: ui.js: add documentation

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 1bb27177296cbfc4ad4a07dc59edf31fb8f92c7a)

luci-app-statistics: remove quotemark from comment

Having quote " in a comment may cause error with non-minified code.
(explanation: caused by 'require' function's parsing behaviour)

Remove also ";" just in case.

Reference to issue 4020

(backported from 4f80f9542)

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

Merge pull request #4009 from stangri/19.07-luci-app-vpn-policy-routing

[19.07] luci-app-vpn-policy-routing: support phys-dev policies

luci-app-vpn-policy-routing: support phys-dev policies

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-base: i18n - cleanup after backport

The backport script apparently imported some stale strings.
Remove them.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

treewide: i18n - backport translations from master

Backport updates to translations from master by using
build/i18n-merge-master.pl

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

treewide: sync translations

Sync translations.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>

Merge pull request #4002 from stangri/19.07-luci-app-vpnbypass

[19.07] luci-app-vpnbypass: better localizeable resources

luci-app-vpnbypass: better localizeable resources

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #3998 from stangri/19.07-luci-app-simple-adblock

[19.07] luci-app-simple-adblock: bugfix: remove escaped double-quotes from translateable resources

Merge pull request #3996 from stangri/19.07-luci-app-vpn-policy-routing

[19.07] luci-app-vpn-policy-routing: bugfix: remove escaped double-quotes from translateable resources

luci-app-simple-adblock: bugfix: remove escaped double-quotes from translateable resources

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #3992 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: bugfix: remove escaped double-quotes from translateable resources

luci-app-vpn-policy-routing: bugfix: remove escaped double-quotes from translateable resources

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-https-dns-proxy: bugfix: remove escaped double-quotes from translateable resources

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #3960 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: add CIRA Canadian Shiled

luci-app-https-dns-proxy: add CIRA Canadian Shiled

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-travelmate: refine logical interface selection

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit c2d8275fdae8caf76cb54af553bcf880d2c6f157)

luci-app-travelmate: sync with travelmate 1.5.4

* change wifi scanning to logical interface name,
  no longer use the radio device

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit 9d02ef1bd936e79d30370a243b42428675dce247)

luci-proto-openconnect: fix certificate file paths

This addresses the issue of openconnect.sh from openconnect package expecting
a vpn- suffix for the files, while the frontend didn't.

Signed-off-by: Friendly fellow <DasTestament@users.noreply.github.com>
[reword commit message]
Ref: https://github.com/openwrt/packages/issues/11584
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit adf0fb1879ffb6bd04984d257484fad0fba1d6a3)
Fixes: #3951

Merge pull request #3944 from stangri/19.07-luci-app-simple-adblock

[19.07] luci-app-simple-adblock: bugfix: get package version from opkg

luci-app-simple-adblock: bugfix: get package version from opkg

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-adblock: accept capital letters in DNS filter

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit e7cb6efb5a2c147fb00b5dd97651099a60da9bd3)

luci-app-adblock: more DNS Report tweaks

* revert last page loading change,
  this breaks the filter functionality on that page
* Add a short paragraph to explain the page functionality
* Fix search to accept ":" character as well
  (e.g. for IPv6 address search)

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit 94799995aa3fc7961c6d6aea6d3105a29d550b3f)

luci-app-advanced-reboot: fix syntax

Add the missing ")" to lines 45 and 54.
Fixes 75a4a80c1dd
Fixes #3903

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
(cherry picked from commit 2c812fbd58fd7399969185cc501bdba561d98d95)

luci-app-adblock: refresh report data on page load

* refresh report data on page load (without hitting
  the refresh button explicity)

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit bfcd962ffd211521e91a875e60ef897335de1fc0)

Merge pull request #3897 from stangri/19.07-luci-app-vpn-policy-routing

[19.07] luci-app-vpn-policy-routing: improve i18n

Merge pull request #3899 from stangri/19.07-luci-app-simple-adblock

[19.07] luci-app-simple-adblock: improve i18n

luci-app-vpn-policy-routing: improve i18n

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-simple-adblock: improve i18n

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #3878 from stangri/19.07-luci-app-advanced-reboot

[19.07] luci-app-advanced-reboot: improve localization by moving from translate to translatef

Merge pull request #3890 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: improve i18n

luci-app-https-dns-proxy: improve i18n

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-advanced-reboot: improve localization by moving from translate to translatef

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #3856 from dibdot/adblock

[19.07] luci-app-adblock: release 4.0.3

[19.07] luci-app-adblock: release 4.0.3

* sync with adblock 4.0.3 in 19.07 package branch

Signed-off-by: Dirk Brenken <dev@brenken.org>

Merge pull request #3853 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: Move help links to providers files, Add LibreDNS

luci-app-https-dns-proxy: Move help links to providers files, Add LibreDNS.

Signed-off-by: Stan Grishin <stangri@melmac.net>

Merge pull request #3846 from joweisberg/openwrt-19.07

luci-app-samba: Fix path url link to mounts

luci-app-samba: Fix path url link to mounts

Signed-off-by: joweisberg <jo.weisberg@gmail.com>

Merge pull request #3829 from stangri/19.07-luci-app-https-dns-proxy

[19.07] luci-app-https-dns-proxy: better service control & buttons styling

Merge pull request #3826 from stangri/19.07-luci-app-vpnbypass

[19.07] luci-app-vpnbypass: better service control & buttons styling

Merge pull request #3824 from stangri/19.07-luci-app-vpn-policy-routing

[19.07] luci-app-vpn-policy-routing: better service control & buttons styling

Merge pull request #3821 from stangri/19.07-luci-app-simple-adblock

[19.07] luci-app-simple-adblock: better service control & buttons styling

luci-app-https-dns-proxy: better service control & buttons styling

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-vpnbypass: better service control & buttons styling

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-vpn-policy-routing: better service control & buttons styling

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-simple-adblock: better service control & buttons styling

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-mod-network: rework signal badge disabled state

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit eb1422defe529f93b073abc72a3601b0b22b6c7e)

luci-mod-wireless: avoid signal badge wrapping in scan list

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 515069f9ecf7eb3d5b83bb79ae1dfa799bf9630d)

luci-mod-network, luci-mod-status: allow assoclist wrapping

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit a600ebb5fe14b13cb53669eb73b86f66cc699e94)
(cherry picked from commit 04c73f1613734b3f2a7204c24d7c9267d1b45955)

luci-mod-network: adjust assoclist markup for easier styling

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 1b7e923cf6ca3da515104cd732de64c5312942dc)

luci-mod-network: properly handle "no signal" and "disabled" in signal badges

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit cf09705ee394ea9cad90581df09a81ec48b48906)

luci-base: ui.js: properly handle null choices in dropdown constructor

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit f1aa3f8f6e378a2fd212590cb3c7b426c014e8ba)

luci-mod-status: luci-bwc: skip "." and ".." when finding netdevs

Skip the "." and ".." directory entries of "/sys/class/net/" instead of
passing them on to libiwinfo's probe function. This avoids a situation
where the kernel requests a modprobe of "netdev-." and "netdev-.." over
and over again, resulting in high load on lower end systems.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 16f0997bdbf85df0c7bae7f0773a118714d15cdf)

Merge pull request #3793 from stangri/19.07-luci-app-simple-adblock

[19.07] luci-app-simple-adblock: better status/error display, better service control

luci-app-simple-adblock: better status/error display

Signed-off-by: Stan Grishin <stangri@melmac.net>

luci-app-openvpn: fix upload input validator

* accept/replace common '.' seperator in instance names as well,
  see comment in #2235

Signed-off-by: Dirk Brenken <dev@brenken.org>
(cherry picked from commit 51579cd49e67890a427bb56a76dc49719d39a9f6)

luci-mod-network: add WPA3-EAP and mixed WPA2/WPA3-EAP settings

Fixes: #3363
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit cae804536785cac5d5a2b3b8e3b9d38c1e623148)

luci-app-firewall: use Firewall.removeZone() helper

Fixes: FS#2932
Ref: https://bugs.openwrt.org/index.php?do=details&task_id=2932
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 0ff4dc822b62bdc4abc925a2d1a6b8641defa98a)

luci-base: firewall.js: fix Firewall.removeZone()

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 4c55e8226d7d6808ad7aa7d9a420dfda628a89f0)

Merge pull request #3777 from aparcar/noci-19

[19.07]CI: remove circleci

CI: remove circleci

LuCI packages are mostly architecture independent and therefore require
no compile checks.

Signed-off-by: Paul Spooren <mail@aparcar.org>

Merge pull request #3763 from oofnikj/openwrt-19.07

add ipv6 firewall view

luci-app-statistics: add ipv6 firewall view

Signed-off-by: Jordan Sokolic <oofnik@gmail.com>

luci-theme-rosy: mark as broken

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit fff15e4e712a4ac5bda9cdb4280445eec502ddbb)

themes: ensure that data-page attribute is escaped

Fixes: #3757
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 5d7dc391d4af4ad5dd6d7e1f6ef9891aa21fd220)

Revert "luci-base: require minimum versions of rpcd and cgi-io"

This reverts commit fb679333a5c0dbba66809559dac2badbc7dcba04.

Version constraints are not correctly handled by luci-app-opkg.

Ref: https://forum.openwrt.org/t/something-changed-luci-compat/56959/5
Signed-off-by: Jo-Philipp Wich <jo@mein.io>

Revert "luci-base: move unused tools.webadmin class to luci-compat"

This reverts commit a22e8bc2e5ce44e0bc20368c6b5cb303a95e8999.

Moving the class file causes too much churn in stable due to the
need to upgrade luci-base for legacy apps.

Ref: #3726
Ref: https://forum.openwrt.org/t/package-install-issues/57010
Signed-off-by: Jo-Philipp Wich <jo@mein.io>

luci-app-firewall: tools.firewall: properly handle protocol 0

The existing code failed to anticipate that '' == 0 in JS.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 2c036b36ce76c3c7430bf936e131f0d9d4ab83c4)

luci-base: require minimum versions of rpcd and cgi-io

Signed-off-by: Jo-Philipp Wich <jo@mein.io>

luci-base: move unused tools.webadmin class to luci-compat

Signed-off-by: Jo-Philipp Wich <jo@mein.io>

luci-theme-bootstrap: fix overview wireless display quirks

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit aa2445cdd85109987b893fb950adbe7d3ef2dddb)

luci-mod-status: don't drop lines with negated addresses

Fixes: #3642
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit c3b07fb3586500afb6395bef6fe05ac8ae008df7)

luci-mod-status: routes.js: remove debug code

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit acef56726c09e9eed15165be17aa955bf93d2e93)

luci-mod-status: reimplement route status page as client side view

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit 16d049f7cd76f0e309814a2b09cde32ff680d962)

luci-mod-status: reimplement log pages as client side views

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit 939b371bc72f4c020c499c815f636dafc296829a)

luci-mod-status: reimplement iptables status page as client side view

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit b9bb34612e28a239153dd2e041921a50e4d7578f)

luci-mod-status: replace iptables controller actions with cgi-io calls

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit 43a4481e103d764d6f656f2ed1f5c57f8580858e)

luci-mod-network: replace controller address check action with cgi-io script

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(backported from commit 3a657b8ab585f6e0fef5c9128dc84c5a008a6969)