Erik Arfvidson [Mon, 21 Nov 2016 17:15:40 +0000 (12:15 -0500)]
staging: unisys: include: fixed iochannel.h comments
The purpose of this patch is to add style consistency and beautify the
entire file.
Grammar:
Uppercased beginning of new sentences/paragraphs
Missing ' and .
Fixed several comments using prefix phrase "as is in" to "as in"
Standard Grammar
Comments:
Fixed comments to follow the multiline styling
All comments are now either same line or above variable/definitions
Removed nested slash-star comments
Removed a random comment left by accident
Aligned star comments
Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Mon, 21 Nov 2016 16:48:24 +0000 (17:48 +0100)]
staging: slicoss: change some macros into inline functions
This patch changes macros into inline functions to avoid this checkpatch
check:
Macro argument 'x' may be better as '(x)' to avoid precedence issues
It also removes two macros because they aren't being used.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shiva Kerdel [Mon, 21 Nov 2016 09:12:41 +0000 (10:12 +0100)]
Staging: rtl8712: rtl871x_*: Removed unnecessary else statements after a break or return
The indent code blocks of the else statements were unnecessary
and are better written without them.
Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vijai Kumar K [Mon, 21 Nov 2016 01:01:52 +0000 (17:01 -0800)]
staging: rtl8712: Fix coding style warnings on Block comments
Fixed checkpatch.pl warnings related to Block comments in
staging/rtl8712/*.c files.
Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jian Yu [Mon, 21 Nov 2016 05:46:48 +0000 (00:46 -0500)]
staging/lustre: Use proper number of bytes in copy_from_user
This patch removes the usage of MAX_STRING_SIZE from
copy_from_user() and just copies enough bytes to cover
count passed in.
Signed-off-by: Jian Yu <jian.yu@intel.com>
Reviewed-on: http://review.whamcloud.com/23462
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8774
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vijai Kumar K [Sun, 20 Nov 2016 20:51:40 +0000 (12:51 -0800)]
staging: vt6656: Fix coding style warnings on Block comments
Fix checkpatch.pl warnings related to Block comments in
staging/vt6656/rf.c file.
Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vijai Kumar K [Sun, 20 Nov 2016 18:57:09 +0000 (10:57 -0800)]
staging: vt6655: Fixed coding style warnings on Block comments
Fixed checkpatch.pl warnings related to Block comments in
staging/vt6655/*.c files.
Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vijai Kumar K [Sun, 20 Nov 2016 18:39:23 +0000 (10:39 -0800)]
staging: dgnc: dgnc_tty: Remove blank lines
Fixes checkpatch warning: waitqueue_active without comment
Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sun, 20 Nov 2016 21:10:47 +0000 (16:10 -0500)]
staging: skein: threefish_block.c Remove blank lines
Make suggested checkpatch modification for
CHECK: Please don't use multiple blank lines
Acked-by: Jason Cooper <jason@lakedaemon.net
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:47:41 +0000 (11:47 -0500)]
staging: dgnc: digi.h Spelling correction
Make spelling correction for 'regular'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:47:40 +0000 (11:47 -0500)]
staging: dgnc: digi.h Comment style modifications
Make modifications to comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:45:42 +0000 (11:45 -0500)]
staging: dgnc: dgnc_tty.c Spelling corrections
Make spelling corrections for 'transitions' and 'satisfy'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:45:41 +0000 (11:45 -0500)]
staging: dgnc: dgnc_tty.c comment style modifications
Make modifications to comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:45:40 +0000 (11:45 -0500)]
staging: dgnc: dgnc_tty.c Align on parenthesis
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:45:39 +0000 (11:45 -0500)]
staging: dgnc: dgnc_tty.c Space preferred around
Make suggested checkpatch modification for
CHECK: spaces preferred around that '|'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Fri, 18 Nov 2016 17:57:18 +0000 (18:57 +0100)]
staging: slicoss: fix different address space warnings
Remove incorrect __iomem annotation.
This patch fix the following sparse warnings in slicoss driver:
warning: incorrect type in assignment (different address spaces)
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 17:35:47 +0000 (12:35 -0500)]
staging: speakup: synth.c Align parenthesis
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 17:35:46 +0000 (12:35 -0500)]
staging: speakup: synth.c Comment modifications
Make modifications to comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 17:35:45 +0000 (12:35 -0500)]
staging: speakup: synth.c Logical continuation
Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 17:35:44 +0000 (12:35 -0500)]
staging: speakup: synth.c Blank line before }
Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 19:34:35 +0000 (14:34 -0500)]
staging: speakup: synth.c Spaces around operators
Make suggested checkpatch modification for
CHECK: spaces preferred around that '|,+,-,/'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 17:12:12 +0000 (12:12 -0500)]
staging: speakup: thread.c align on parenthesis
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 17:12:11 +0000 (12:12 -0500)]
staging: speakup: thread.c Comment modifications
Make comment style modifications
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:50:54 +0000 (11:50 -0500)]
staging: speakup: TODO Correct email
Make email correction for kirk@reisers.ca
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Acked-by: Chris Brannon <chris@the-brannons.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:50:53 +0000 (11:50 -0500)]
staging: speakup: varhandlers.c Align parenthesis
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Sat, 19 Nov 2016 16:50:52 +0000 (11:50 -0500)]
staging: speakup: varhandlers.c Comment style modifications
Make modifications to comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 23:34:06 +0000 (18:34 -0500)]
staging: dgnc: dgnc_sysfs.c Delete blank line
Make modification to remove extra blank line
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 23:34:05 +0000 (18:34 -0500)]
staging: dgnc: dgnc_sysfs.c Comment style modifications
Make modifications to comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 23:21:09 +0000 (18:21 -0500)]
staging: dgnc: dgnc_neo.h Spelling correction
Make spelling correction for 'control'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 23:21:08 +0000 (18:21 -0500)]
staging: dgnc: dgnc_neo.h Comment style modifications
Make modifications for comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 23:08:03 +0000 (18:08 -0500)]
staging: dgnc: dgnc_neo.c Comment style modifications
Make modifications for comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 22:49:24 +0000 (17:49 -0500)]
staging: dgnc: dgnc_mgmt.c Comment style modifications
Make modifications for comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Fri, 18 Nov 2016 17:58:10 +0000 (18:58 +0100)]
staging: slicoss: avoid CamelCases slicoss.c
Replace CamelCases to comply with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Fri, 18 Nov 2016 17:58:09 +0000 (18:58 +0100)]
staging: slicoss: avoid CamelCases in slichw.h
Replace CamelCases to comply with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Fri, 18 Nov 2016 17:58:08 +0000 (18:58 +0100)]
staging: slicoss: braces should be used on all arms of this statement
Add braces in if statement to comply with the standard
kernel coding style.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Fri, 18 Nov 2016 17:58:07 +0000 (18:58 +0100)]
staging: slicoss: logical continuations should be on the previous line
Move logical or operator to previous line to comply with
the standard kernel coding style.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Fri, 18 Nov 2016 17:58:06 +0000 (18:58 +0100)]
staging: slicoss: fix parenthesis alignment in slicoss.c
This patch fix open parenthesis alignment matching in slicoss.c
file to comply with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Fri, 18 Nov 2016 17:58:05 +0000 (18:58 +0100)]
staging: slicoss: avoid CamelCases in slic.h
Replace CamelCases to comply with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rahul Krishnan [Fri, 18 Nov 2016 15:15:25 +0000 (20:45 +0530)]
staging: Greybus: Remove unnecessary braces for single statement block
This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 22:39:13 +0000 (17:39 -0500)]
staging: dgnc: dgnc_driver.h Spelling correction
Make spelling correction for 'statements'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 22:39:12 +0000 (17:39 -0500)]
staging: dgnc: dgnc_driver.h Align columns
Make modifications to align columns
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 22:39:11 +0000 (17:39 -0500)]
staging: dgnc: dgnc_driver.h Comment style modifications
Make modifications to comment style
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 20:18:10 +0000 (15:18 -0500)]
staging: dgnc: dgnc_driver.c Blank line before }
Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary before
a close brace '}'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 20:18:09 +0000 (15:18 -0500)]
staging: dgnc: dgnc_driver.c Remove blank lines
Make suggested checkpatch modification for
CHECK: Please don't use multiple blank lines
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 20:18:08 +0000 (15:18 -0500)]
staging: dgnc: dgnc_driver.c Comment style modifications
Make modifications to comment styles
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 17:45:19 +0000 (12:45 -0500)]
staging: dgnc: dgnc_cls.c Comment style modifications
Make modifications to comment style format
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 17:36:50 +0000 (12:36 -0500)]
staging: dgnc: dgnc_cls.h Spelling correction
Make spelling correction for 'control'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 17:14:07 +0000 (12:14 -0500)]
staging: vme: vme_user.c Spelling corrections
Make spelling corrections for 'correctly' and
'unregister'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Acked-by: Martyn Welch <martyn at welchs.e.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shiva Kerdel [Fri, 18 Nov 2016 13:12:42 +0000 (14:12 +0100)]
Staging: wlan-ng: prism2mgmt: Fixed operators spacing style issues
Fixed spaces around operators to fix their coding style issues.
Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 01:56:01 +0000 (20:56 -0500)]
staging: xgifb: XGI_main.h Align data columns
Make modifications to data column alignment
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 01:29:08 +0000 (20:29 -0500)]
staging: xgifb: vb_util.h Space after cast
Make suggested checkpatch modification for
CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 00:12:54 +0000 (19:12 -0500)]
staging: xgifb: vb_setmode.c Align match parenthesis
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 00:12:53 +0000 (19:12 -0500)]
staging: xgifb: vb_setmode.c Logical continuation
Make suggested checkpatch modification for
CHECK: Logical continuations should be on the
previous line
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 00:12:52 +0000 (19:12 -0500)]
staging: xgifb: vb_setmode.c Space after cast
Make suggested checkpatch modification for
CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 00:12:51 +0000 (19:12 -0500)]
staging: xgifb: vb_setmode.c Braces single statement blocks
Make suggested checkpatch modificationfor
WARNING: braces {} are not necessary for single
statement blocks
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 00:12:50 +0000 (19:12 -0500)]
staging: xgifb: vb_setmode.c Space around operator
Make suggested checkpatch modificationfor
CHECK: spaces preferred around that '+'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 00:12:49 +0000 (19:12 -0500)]
staging: xgifb: vb_setmode.c Comment style modifications
Make comment style modifications.
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Fri, 18 Nov 2016 00:12:48 +0000 (19:12 -0500)]
staging: xgifb: vb_setmode.c Comment Spelling correction
Make spelling correction for 'vertical'.
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:44 +0000 (11:48 -0500)]
staging: lustre: libcfs: use uXX instead of __uXX types in headers
The types __[u|s]XX is only used for UAPI headers and userspace.
Only keep these types for the libcfs headers that are UAPI
headers. The rest convert to the standard uXX types.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:43 +0000 (11:48 -0500)]
staging: lustre: libcfs: remove zero comparisons in headers
Remove the zero comparisions in the libcfs headers.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:42 +0000 (11:48 -0500)]
staging: lustre: libcfs: remove NULL comparisons in headers
Remove the NULL comparisions in the libcfs headers.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:41 +0000 (11:48 -0500)]
staging: lustre: libcfs: remove whitespace in libcfs_fail.h
One last white space is still left in libcfs_fail.h. Lets
remove it.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:40 +0000 (11:48 -0500)]
staging: lustre: libcfs: use bit macro in libcfs headers
Use the BIT macros instead of (1 << ***) in libcfs
headers.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:39 +0000 (11:48 -0500)]
staging: lustre: libcfs: correct spelling in libcfs_cpu.h
Spell the word destroy correctly.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:38 +0000 (11:48 -0500)]
staging: lustre: libcfs: remove blank line in header
The header libcfs_fail.h has a extra blank line that
is not needed.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:37 +0000 (11:48 -0500)]
staging: lustre: libcfs: name parameters for function prototypes
Give the parameters names for the function
prototypes in the libcfs headers.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:36 +0000 (11:48 -0500)]
staging: lustre: libcfs: remove header's bare unsigned use
Fixup the libcfs headers to use the proper unsigned int
instead of raw unsigned.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Fri, 18 Nov 2016 16:48:35 +0000 (11:48 -0500)]
staging: lustre: libcfs: fixup all header block comments
Properly format the incorrect comments sections
that were reported by checkpatch.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mikhail Pershin [Fri, 18 Nov 2016 16:49:52 +0000 (11:49 -0500)]
staging: lustre: llog: fix wrong offset in llog_process_thread()
- llh_cat_idx may become bigger than llog bitmap size in
llog_cat_set_first_idx() function
- it is wrong to use previous cur_offset as new buffer offset,
new offset should be calculated from value returned by
llog_next_block().
- optimize llog_skip_over() to find llog entry offset by index
for llog with fixed-size records.
Signed-off-by: Mikhail Pershin <mike.pershin@intel.com>
Signed-off-by: Bob Glossman <bob.glossman@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6714
Reviewed-on: http://review.whamcloud.com/15316
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6163
Reviewed-on: http://review.whamcloud.com/18819
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:57 +0000 (14:35 -0500)]
staging: lustre: lnet: cleanup some of the > 80 line issues
Cleanup some of the checkpatch over 80 character lines
reported.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:56 +0000 (14:35 -0500)]
staging: lustre: lnet: use BIT macro in LNet selftest
Some of the defines for lnet selftest can use the BIT
macros.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:55 +0000 (14:35 -0500)]
staging: lustre: libcfs: remove use of __u* types
The __[u|s]* types are for UAPI headers or user
space. They shouldn't be used in core kernel code.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:54 +0000 (14:35 -0500)]
staging: lustre: libcfs: use pr_* instead of printk
Checkpatch recommended that we use pr_*() instead
of printk directly.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:53 +0000 (14:35 -0500)]
staging: lustre: libcfs: Make char * array envp static constant
The envp char array can be made static constant.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:52 +0000 (14:35 -0500)]
staging: lustre: libcfs: fix misspelling of descriptor
Fix typo for correct spelling.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:51 +0000 (14:35 -0500)]
staging: lustre: libcfs: white space cleanup
Remove white space present for variable declarations
or initialization. Cleanup structs was strange
alignments due to white spacing.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:50 +0000 (14:35 -0500)]
staging: lustre: libcfs: remove == 0 testing
Testing == 0 is not kernel style so remove this
type of testing from libcfs.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:49 +0000 (14:35 -0500)]
staging: lustre: libcfs: remove != 0 testing
Testing != 0 is not kernel style so remove this
type of testing from libcfs.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:48 +0000 (14:35 -0500)]
staging: lustre: lnet: replace uninitialized_var
Checkpatch for some reason doesn't like the way
libcfs_str2net_internal. Lets just replace it with
nf being set to NULL instead
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:47 +0000 (14:35 -0500)]
staging: lustre: lnet: fill in real lnet_md_t
While checkpatch reported an alignment issue
its just ugly to fill in a data structure being
passed to a function. Instead fill in a lnet_md_t
on the stack and pass that to LNetMDBind.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:46 +0000 (14:35 -0500)]
staging: lustre: lnet: missing blank line after declaration
Add in missing blank line in lnet_copy_iov2iter() after
variable declarations.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:45 +0000 (14:35 -0500)]
staging: lustre: lnet: remove unused lib_me_dump
Remove unused lib_me_dump.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:44 +0000 (14:35 -0500)]
staging: lustre: lnet: fix misspelled word destroy
Fix misspelling of destroy in LNet core.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:43 +0000 (14:35 -0500)]
staging: lustre: libcfs: fix aligment issue
Make alignment match open parenthesis for
parameters to wait_event_interruptible_exclusive()
call.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:42 +0000 (14:35 -0500)]
staging: lustre: libcfs: remove explicit test of NULL variable
Remove != NULL which is not needed to test key existence.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:41 +0000 (14:35 -0500)]
staging: lustre: libcfs: use static const char const * for a suffixes array
Change the static const array libcfs_debug_subsystems
to use static const char const * as pointed out by
checkpatch.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:40 +0000 (14:35 -0500)]
staging: lustre: lnet: resolve trailing */ errors
This patch resolves the checkpatch error:
Block comments use a trailing */ on a separate line
for the LNet/libcfs layer
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Thu, 17 Nov 2016 19:35:39 +0000 (14:35 -0500)]
staging: lustre: lnet: don't use bare unsigned
Turn all bare unsigned to unsigned int that were
detected by checkpatch in the LNet/libcfs layer.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 05:39:14 +0000 (00:39 -0500)]
staging: xgifb: XGI_main_26.c Align match parenthesis
Make suggested checkpatch modification for
CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 05:39:13 +0000 (00:39 -0500)]
staging: xgifb: XGI_main_26.c Blank line before }
Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 05:39:12 +0000 (00:39 -0500)]
staging: xgifb: XGI_main_26.c Blank line after {
Make suggested checkpatch modification for
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 05:39:11 +0000 (00:39 -0500)]
staging: xgifb: XGI_main_26.c Space around operator
Make suggested checkpatch modification for
CHECK: spaces preferred around that '-,&'
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 05:39:10 +0000 (00:39 -0500)]
staging: xgifb: XGI_main_26.c Logical continuation
Make suggested checkpatch modification for
CHECK: Logical continuations should be on the previous line
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 05:39:09 +0000 (00:39 -0500)]
staging: xgifb: XGI_main_26.c No space after cast
Make suggested checkpatch modification for
CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 05:39:08 +0000 (00:39 -0500)]
staging: xgifb: XGI_main_26.c Comment style modifications
Make comment style modifications.
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Yamanappagouda Patil [Thu, 17 Nov 2016 09:16:42 +0000 (14:46 +0530)]
Staging: rtl8712: Fixed 'tabstop' coding style warnings.
Fixed checkpatch warning "Statements should start on a tabstop" in
rtl8712 module.
Signed-off-by: Yamanappagouda Patil <goudapatilk@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 03:04:14 +0000 (22:04 -0500)]
staging: xgifb: vb_init.c Comment style
Make various comment style modifications.
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 03:04:13 +0000 (22:04 -0500)]
staging: xgifb: vb_init.c Align on parenthesis
Make suggested checkpatch modification for:
CHECK: Alignment should match open parenthesis.
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Walt Feasel [Thu, 17 Nov 2016 03:04:12 +0000 (22:04 -0500)]
staging: xgifb: vb_init.c Logical continuation
Make suggested checkpatch modification for:
CHECK: Logical continuations should be on the previous line.
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Niu Yawei [Thu, 17 Nov 2016 01:05:30 +0000 (20:05 -0500)]
staging/lustre/ptlrpc: update imp_known_replied_xid on resend-replay
The imp_known_replied_xid should be updated when try to resend
an already replied replay request, because the xid of this replay
request could be less than current imp_known_replied_xid.
Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-on: http://review.whamcloud.com/22776
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8645
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>