openwrt/staging/blogic.git
10 years agostaging: vt6656: struct vnt_private replace byBBPreEDRSSI with bb_pre_ed_rssi
Malcolm Priestley [Sun, 20 Jul 2014 14:33:27 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byBBPreEDRSSI with bb_pre_ed_rssi

Remove type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove dead code ldBmThreshold
Malcolm Priestley [Sun, 20 Jul 2014 14:33:26 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private remove dead code ldBmThreshold

ldBmThreshold was used in old function s_vCheckSensitivity which
had been disabled in orginal vendors code.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace abyBBVGA with bb_vga
Malcolm Priestley [Sun, 20 Jul 2014 14:33:25 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace abyBBVGA with bb_vga

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace byAutoFBCtrl with auto_fb_ctrl
Malcolm Priestley [Sun, 20 Jul 2014 14:33:24 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byAutoFBCtrl with auto_fb_ctrl

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace wSeqCounter with seq_counter
Malcolm Priestley [Sun, 20 Jul 2014 14:33:23 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace wSeqCounter with seq_counter

Removing type prefix and camel case

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove dead variable bBarkerPreambleMd
Malcolm Priestley [Sun, 20 Jul 2014 14:33:22 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private remove dead variable bBarkerPreambleMd

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace bShortSlotTime with short_slot_time
Malcolm Priestley [Sun, 20 Jul 2014 14:33:21 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace bShortSlotTime with short_slot_time

Removing type prefix and camel case

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove camel case retry limit
Malcolm Priestley [Sun, 20 Jul 2014 14:33:20 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private remove camel case retry limit

camel case changes
byShortRetryLimit -> short_retry_limit
byLongRetryLimit -> long_retry_limit

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace wCurrentRate with current_rate
Malcolm Priestley [Sun, 20 Jul 2014 14:33:19 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace wCurrentRate with current_rate

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rf power table remove camel case
Malcolm Priestley [Sun, 20 Jul 2014 14:33:18 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private rf power table remove camel case

Camel case changes
byCCKPwr -> cck_pwr
byOFDMPwrG -> ofdm_pwr_g
byOFDMPwrA -> ofdm_pwr_a
byCurPwr -> power
abyCCKPwrTbl -> cck_pwr_tbl
abyOFDMPwrTbl -> ofdm_pwr_tbl
abyOFDMAPwrTbl -> ofdm_a_pwr_tbl

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace byPreambleType with preamble_type
Malcolm Priestley [Sun, 20 Jul 2014 14:33:17 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byPreambleType with preamble_type

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace abyEEPROM with eeprom
Malcolm Priestley [Sun, 20 Jul 2014 14:33:16 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace abyEEPROM with eeprom

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace byTopCCKBasicRate with top_cck_basic_rate
Malcolm Priestley [Sun, 20 Jul 2014 14:33:15 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byTopCCKBasicRate with top_cck_basic_rate

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace byTopOFDMBasicRate with top_ofdm_basic_rate
Malcolm Priestley [Sun, 20 Jul 2014 14:33:14 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byTopOFDMBasicRate with top_ofdm_basic_rate

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace wBasicRate with basic_rates
Malcolm Priestley [Sun, 20 Jul 2014 14:33:13 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace wBasicRate with basic_rates

The same name as in struct ieee80211_bss_conf

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace byPacketType with packet_type
Malcolm Priestley [Sun, 20 Jul 2014 14:33:12 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byPacketType with packet_type

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace byBBType with bb_type
Malcolm Priestley [Sun, 20 Jul 2014 14:33:11 +0000 (15:33 +0100)]
staging: vt6656: struct vnt_private replace byBBType with bb_type

Removing type prefix and camel case.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove camel case IFS names
Malcolm Priestley [Sat, 19 Jul 2014 11:30:18 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private remove camel case IFS names

Camel case changes
uSIFS -> sifs
uDIFS -> difs
uEIFS -> eifs
uSlot -> slot

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove uCwMin/uCwMax
Malcolm Priestley [Sat, 19 Jul 2014 11:30:17 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private remove uCwMin/uCwMax

Although set these variables are not used.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove camel case antenna variables
Malcolm Priestley [Sat, 19 Jul 2014 11:30:16 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private remove camel case antenna variables

Camel case changes
bTxRxAntInv -> tx_rx_ant_inv
dwRxAntennaSel -> rx_antenna_sel
byRxAntennaMode -> rx_antenna_mode
byTxAntennaMode -> tx_antenna_mode
byRadioCtl -> radio_ctl

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: antenna modes remove unused variables
Malcolm Priestley [Sat, 19 Jul 2014 11:30:15 +0000 (12:30 +0100)]
staging: vt6656: antenna modes remove unused variables

dwTxAntennaSel is always the same as dwRxAntennaSel

byAntennaCount is never used.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename uCurrRSSI to current_rssi
Malcolm Priestley [Sat, 19 Jul 2014 11:30:14 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename uCurrRSSI to current_rssi

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename qwCurrTSF to current_tsf
Malcolm Priestley [Sat, 19 Jul 2014 11:30:13 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename qwCurrTSF to current_tsf

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: replace bExistSWNetAddr with exist_sw_net_addr
Malcolm Priestley [Sat, 19 Jul 2014 11:30:12 +0000 (12:30 +0100)]
staging: vt6656: replace bExistSWNetAddr with exist_sw_net_addr

Always needed as u8 type.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: rename abyPermanentNetAddr to permanent_net_addr
Malcolm Priestley [Sat, 19 Jul 2014 11:30:11 +0000 (12:30 +0100)]
staging: vt6656: rename abyPermanentNetAddr to permanent_net_addr

Removing prefix and camel case

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: remame abyCurrentNetAddr to current_net_addr
Malcolm Priestley [Sat, 19 Jul 2014 11:30:10 +0000 (12:30 +0100)]
staging: vt6656: remame abyCurrentNetAddr to current_net_addr

Removing prefix and camel case

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: remove variable byZoneType
Malcolm Priestley [Sat, 19 Jul 2014 11:30:09 +0000 (12:30 +0100)]
staging: vt6656: remove variable byZoneType

Zone types are nolonger handled by driver.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename byBBRxConf to bb_rx_conf
Malcolm Priestley [Sat, 19 Jul 2014 11:30:08 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename byBBRxConf to bb_rx_conf

Remove camel case

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private replace byRFType with rf_type
Malcolm Priestley [Sat, 19 Jul 2014 11:30:07 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private replace byRFType with rf_type

Remove camel case

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename byLocalID to local_id
Malcolm Priestley [Sat, 19 Jul 2014 11:30:06 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename byLocalID to local_id

Removing camel case

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename wFirmwareVersion to firmware_version
Malcolm Priestley [Sat, 19 Jul 2014 11:30:05 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename wFirmwareVersion to firmware_version

Removing camel case

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename cdTD to num_tx_context
Malcolm Priestley [Sat, 19 Jul 2014 11:30:04 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename cdTD to num_tx_context

number of tx_context

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename cbRD to num_rcb
Malcolm Priestley [Sat, 19 Jul 2014 11:30:03 +0000 (12:30 +0100)]
staging: vt6656: struct vnt_private rename cbRD to num_rcb

Number of rcb

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: rtw_resume(): release semaphore before exit on error
Jes Sorensen [Mon, 21 Jul 2014 09:25:09 +0000 (11:25 +0200)]
staging: rtl8723au: rtw_resume(): release semaphore before exit on error

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Fold rtw_resume_process23a() into rtw_resume()
Jes Sorensen [Mon, 21 Jul 2014 09:25:08 +0000 (11:25 +0200)]
staging: rtl8723au: Fold rtw_resume_process23a() into rtw_resume()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Reduce wrapper layers around hal_{de, }init() calls
Jes Sorensen [Mon, 21 Jul 2014 09:25:07 +0000 (11:25 +0200)]
staging: rtl8723au: Reduce wrapper layers around hal_{de, }init() calls

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Fold rtl8723a_set_nav_upper() into rtl8723au_hal_init()
Jes Sorensen [Mon, 21 Jul 2014 09:25:06 +0000 (11:25 +0200)]
staging: rtl8723au: Fold rtl8723a_set_nav_upper() into rtl8723au_hal_init()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove a pile of fluff for calling into a bunch of no-op functions
Jes Sorensen [Mon, 21 Jul 2014 09:25:05 +0000 (11:25 +0200)]
staging: rtl8723au: Remove a pile of fluff for calling into a bunch of no-op functions

The whole antenna diversity selection was completely pointless as all
the end functions called were no-ops.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: odm_CommonInfoSelfInit23a(): Use proper register defines
Jes Sorensen [Mon, 21 Jul 2014 09:25:04 +0000 (11:25 +0200)]
staging: rtl8723au: odm_CommonInfoSelfInit23a(): Use proper register defines

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Merge Init_ODM_ComInfo_8723a() into rtl8723a_init_dm_priv()
Jes Sorensen [Mon, 21 Jul 2014 09:25:03 +0000 (11:25 +0200)]
staging: rtl8723au: Merge Init_ODM_ComInfo_8723a() into rtl8723a_init_dm_priv()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove obsolete ODM23a_CmnInfoHook()
Jes Sorensen [Mon, 21 Jul 2014 09:25:02 +0000 (11:25 +0200)]
staging: rtl8723au: Remove obsolete ODM23a_CmnInfoHook()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Eliminate obsolete odm_CmnInfoHook_Debug23a()
Jes Sorensen [Mon, 21 Jul 2014 09:25:01 +0000 (11:25 +0200)]
staging: rtl8723au: Eliminate obsolete odm_CmnInfoHook_Debug23a()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Eliminate ODM_CMNINFO_POWER_SAVING usage
Jes Sorensen [Mon, 21 Jul 2014 09:25:00 +0000 (11:25 +0200)]
staging: rtl8723au: Eliminate ODM_CMNINFO_POWER_SAVING usage

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Eliminate ODM_CMNINFO_SCAN related code
Jes Sorensen [Mon, 21 Jul 2014 09:24:59 +0000 (11:24 +0200)]
staging: rtl8723au: Eliminate ODM_CMNINFO_SCAN related code

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Eliminate ODM_CMNINFO_CHNL usage
Jes Sorensen [Mon, 21 Jul 2014 09:24:58 +0000 (11:24 +0200)]
staging: rtl8723au: Eliminate ODM_CMNINFO_CHNL usage

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Eliminate ODM_CMNINFO_BW usage
Jes Sorensen [Mon, 21 Jul 2014 09:24:57 +0000 (11:24 +0200)]
staging: rtl8723au: Eliminate ODM_CMNINFO_BW usage

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Eliminate ugly ODM_CMNINFO_SEC_CHNL_OFFSET usage
Jes Sorensen [Mon, 21 Jul 2014 09:24:56 +0000 (11:24 +0200)]
staging: rtl8723au: Eliminate ugly ODM_CMNINFO_SEC_CHNL_OFFSET usage

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: ODM_DMWatchdog23a(): Take a struct hal_data_8723a *
Jes Sorensen [Mon, 21 Jul 2014 09:24:55 +0000 (11:24 +0200)]
staging: rtl8723au: ODM_DMWatchdog23a(): Take a struct hal_data_8723a *

This will allow us to access variables in the hal_data struct
directly, and get rid of the horrendous ODM_CMNINFO spaghetti API.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: We don't need two APIs to set pHalData->odmpriv.SupportAbility
Jes Sorensen [Mon, 21 Jul 2014 09:24:54 +0000 (11:24 +0200)]
staging: rtl8723au: We don't need two APIs to set pHalData->odmpriv.SupportAbility

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove another pile of awful unused ODM variables
Jes Sorensen [Mon, 21 Jul 2014 09:24:53 +0000 (11:24 +0200)]
staging: rtl8723au: Remove another pile of awful unused ODM variables

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove another pile of useless ODM variables
Jes Sorensen [Mon, 21 Jul 2014 09:24:52 +0000 (11:24 +0200)]
staging: rtl8723au: Remove another pile of useless ODM variables

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove useless ODM_CMNINFO_{WM_MODE, BAND} related code
Jes Sorensen [Mon, 21 Jul 2014 09:24:51 +0000 (11:24 +0200)]
staging: rtl8723au: Remove useless ODM_CMNINFO_{WM_MODE, BAND} related code

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code
Jes Sorensen [Mon, 21 Jul 2014 09:24:50 +0000 (11:24 +0200)]
staging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove write-only variables struct dm_priv->{Init,}DMFlag
Jes Sorensen [Mon, 21 Jul 2014 09:24:49 +0000 (11:24 +0200)]
staging: rtl8723au: Remove write-only variables struct dm_priv->{Init,}DMFlag

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove write-only struct dm_priv->DM_Type variable
Jes Sorensen [Mon, 21 Jul 2014 09:24:48 +0000 (11:24 +0200)]
staging: rtl8723au: Remove write-only struct dm_priv->DM_Type variable

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove no-op function dm_CheckStatistics()
Jes Sorensen [Mon, 21 Jul 2014 09:24:47 +0000 (11:24 +0200)]
staging: rtl8723au: Remove no-op function dm_CheckStatistics()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove no-op rtl8723a_deinit_dm_priv()
Jes Sorensen [Mon, 21 Jul 2014 09:24:46 +0000 (11:24 +0200)]
staging: rtl8723au: Remove no-op rtl8723a_deinit_dm_priv()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove some redundant check for hw_init_completed
Jes Sorensen [Mon, 21 Jul 2014 09:24:45 +0000 (11:24 +0200)]
staging: rtl8723au: Remove some redundant check for hw_init_completed

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Remove unused DefaultInitialGain array
Jes Sorensen [Mon, 21 Jul 2014 09:24:44 +0000 (11:24 +0200)]
staging: rtl8723au: Remove unused DefaultInitialGain array

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: bDMInitialGainEnable is always true
Jes Sorensen [Mon, 21 Jul 2014 09:24:43 +0000 (11:24 +0200)]
staging: rtl8723au: bDMInitialGainEnable is always true

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Declare odm_EdcaTurbo*() functions static
Jes Sorensen [Mon, 21 Jul 2014 09:24:42 +0000 (11:24 +0200)]
staging: rtl8723au: Declare odm_EdcaTurbo*() functions static

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: rtl8723au: Fold odm_EdcaTurboCheck23aCE23a() into odm_EdcaTurboCheck23a()
Jes Sorensen [Mon, 21 Jul 2014 09:24:41 +0000 (11:24 +0200)]
staging: rtl8723au: Fold odm_EdcaTurboCheck23aCE23a() into odm_EdcaTurboCheck23a()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoUpdate speakup mailing list address
Samuel Thibault [Thu, 17 Jul 2014 21:34:58 +0000 (23:34 +0200)]
Update speakup mailing list address

The speakup mailing list only works on the linux-speakup.org domain now.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging/lustre: fix misuse of current->parent.
NeilBrown [Fri, 18 Jul 2014 05:39:19 +0000 (15:39 +1000)]
staging/lustre: fix misuse of current->parent.

current->parent is used by ptrace to redirect some signal delivery
to the ptracer.  It should only be used by 'ptrace' or 'signal' code.
All other users should  use current->real_parent, which is the real
parent.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agoStaging: comedi: adl_pci9118: line over 80 fixed
Sam Asadi [Fri, 18 Jul 2014 20:13:08 +0000 (23:13 +0300)]
Staging: comedi: adl_pci9118: line over 80 fixed

A 'line over 80 characters' issue fixed.

Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vme: Add missing CR in printk messages in vme_pio2_core.c
Masanari Iida [Fri, 18 Jul 2014 15:33:58 +0000 (00:33 +0900)]
staging: vme: Add missing CR in printk messages in vme_pio2_core.c

This patch add missing CR in messages within vme_pio2_core.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vme: Add missing CR in error message
Masanari Iida [Fri, 18 Jul 2014 15:33:57 +0000 (00:33 +0900)]
staging: vme: Add missing CR in error message

This patch adds missing CR in dev_err message.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vme: Fix typo in vme_pio2_gpio.c
Masanari Iida [Fri, 18 Jul 2014 15:33:56 +0000 (00:33 +0900)]
staging: vme: Fix typo in vme_pio2_gpio.c

This patch fix spelling typo in printk message.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: remove unused macros
Malcolm Priestley [Fri, 18 Jul 2014 22:00:56 +0000 (23:00 +0100)]
staging: vt6656: remove unused macros

Remove macros start are unlikely to be reused

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: mac.h clean up macros
Malcolm Priestley [Fri, 18 Jul 2014 22:00:55 +0000 (23:00 +0100)]
staging: vt6656: mac.h clean up macros

White space and comment clean up

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: put radio power off and on into correct state every time.
Malcolm Priestley [Fri, 18 Jul 2014 22:00:54 +0000 (23:00 +0100)]
staging: vt6656: put radio power off and on into correct state every time.

When radio is off bit GPIO3_INTMD should be on and off when radio is on.

Add these to the tail of vnt_radio_power_off and vnt_radio_power_on
and remove variable bHWRadioOff.

In device_init_registers just check GPIO3_DATA are in correct state and
always power on.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove unused variable bRadioOff
Malcolm Priestley [Fri, 18 Jul 2014 22:00:53 +0000 (23:00 +0100)]
staging: vt6656: struct vnt_private remove unused variable bRadioOff

The variable flips from true to false but does nothing

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove unused variable bRadioControlOff
Malcolm Priestley [Fri, 18 Jul 2014 22:00:52 +0000 (23:00 +0100)]
staging: vt6656: struct vnt_private remove unused variable bRadioControlOff

This variable is never set.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: comedi_compat32.h: checkpatch.pl --strict cleanup
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:16 +0000 (14:28 -0700)]
staging: comedi: comedi_compat32.h: checkpatch.pl --strict cleanup

Fix the checkpatch.pl --strict issues:

CHECK: extern prototypes should be avoided in .h files

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: comedidev.h: checkpatch.pl --strict cleanup
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:15 +0000 (14:28 -0700)]
staging: comedi: comedidev.h: checkpatch.pl --strict cleanup

Fix the checkpatch.pl --strict issues:

CHECK: Please use a blank line after function/struct/union/enum declarations
CHECK: Alignment should match open parenthesis

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: comedi_fops: checkpatch.pl --strict cleanup
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:14 +0000 (14:28 -0700)]
staging: comedi: comedi_fops: checkpatch.pl --strict cleanup

Fix the checkpatch.pl --strict issues:

CHECK: braces {} should be used on all arms of this statement
CHECK: Alignment should match open parenthesis
CHECK: Prefer kzalloc(sizeof(*dev)...) over kzalloc(sizeof(struct comedi_device)...)

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: comedi.h: checkpatch.pl --strict cleanup
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:13 +0000 (14:28 -0700)]
staging: comedi: comedi.h: checkpatch.pl --strict cleanup

Fix the checkpatch.pl --strict issues:

CHECK: Please use a blank line after function/struct/union/enum declarations

For aesthetics, convert the inline functions into simple macros.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: comedi_internal.h: checkpatch.pl --strict cleanup
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:12 +0000 (14:28 -0700)]
staging: comedi: comedi_internal.h: checkpatch.pl --strict cleanup

Fix the checkpatch.pl --strict issues:

CHECK: Please use a blank line after function/struct/union/enum declarations

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: drivers.c: checkpatch.pl --strict cleanup
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:11 +0000 (14:28 -0700)]
staging: comedi: drivers.c: checkpatch.pl --strict cleanup

Fix the checkpatch.pl --strict issues:

CHECK: DEFINE_MUTEX definition without comment
CHECK: braces {} should be used on all arms of this statement

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: comedi_compat32: checkpatch.pl --strict cleanup
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:10 +0000 (14:28 -0700)]
staging: comedi: comedi_compat32: checkpatch.pl --strict cleanup

Fix the checkpatch.pl --strict issues:

CHECK: Logical continuations should be on the previous line

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: hwdrv_apci3120: cleanup printk messages
H Hartley Sweeten [Fri, 18 Jul 2014 20:30:02 +0000 (13:30 -0700)]
staging: comedi: hwdrv_apci3120: cleanup printk messages

Remove the printk messages that are just driver development debug noise
and convert the rest to dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: hwdrv_apci3200: remove commented out printk messages
H Hartley Sweeten [Fri, 18 Jul 2014 20:30:01 +0000 (13:30 -0700)]
staging: comedi: hwdrv_apci3200: remove commented out printk messages

The commented out printk() messages all apear to be development noise.
Just remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_atmio: remove printk noise in ni_isapnp_find_board()
H Hartley Sweeten [Fri, 18 Jul 2014 20:30:00 +0000 (13:30 -0700)]
staging: comedi: ni_atmio: remove printk noise in ni_isapnp_find_board()

The printk() messages in this function a just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: hwdrv_apci3200: remove disabled PRINT_INFO debug
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:59 +0000 (13:29 -0700)]
staging: comedi: hwdrv_apci3200: remove disabled PRINT_INFO debug

Remove all the PRINT_INFO debug.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: comedi_fops: remove commented out debug messages
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:58 +0000 (13:29 -0700)]
staging: comedi: comedi_fops: remove commented out debug messages

Remove the commented out printk() debug.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: das1800: tidy up das1800_probe()
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:57 +0000 (13:29 -0700)]
staging: comedi: das1800: tidy up das1800_probe()

The (*attach) of driver calls this function to probe the 'id' of the
hardware to verify that a valid boardinfo has been selected by the
user.

The dev_dbg() messages when the boardinfo is valid is just added
noise. The printk messages when the id does not match the boardinfo
does have some value.

Refactor the function to remove the noise and use a common message
for the "(probed, not recommended)" message.

Convert the printk() messages to dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_at_a2150: convert printk to dev_err
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:56 +0000 (13:29 -0700)]
staging: comedi: ni_at_a2150: convert printk to dev_err

Convert the printk() message to dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_atmio: convert printk to dev_err in ni_getboardtype()
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:55 +0000 (13:29 -0700)]
staging: comedi: ni_atmio: convert printk to dev_err in ni_getboardtype()

Convert these printk() messages to dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_atmio: remove board attach noise
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:54 +0000 (13:29 -0700)]
staging: comedi: ni_atmio: remove board attach noise

Remove the printk messages in the (*attach) of this driver. These are
just added noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_mio_common: consolidate call to ni_mseries_get_pll_parameters()
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:53 +0000 (13:29 -0700)]
staging: comedi: ni_mio_common: consolidate call to ni_mseries_get_pll_parameters()

All cases of the switch call ni_mseries_get_pll_parameters() with the same
parameters. Move the call out of the switch.

Also, move the printk from ni_mseries_get_pll_parameters() so that it can
be converted into a dev_err().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: comedi: ni_mio_common: convert printk messages to dev_err
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:52 +0000 (13:29 -0700)]
staging: comedi: ni_mio_common: convert printk messages to dev_err

Where possible, convert the printk() messages in this file to dev_err().

Remove a couple commented out printk() messages.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename apTD to tx_context
Malcolm Priestley [Fri, 18 Jul 2014 05:36:16 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_private rename apTD to tx_context

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private rename apRCB to rcb
Malcolm Priestley [Fri, 18 Jul 2014 05:36:15 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_private rename apRCB to rcb

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private pInterruptURB rename to interrupt_urb
Malcolm Priestley [Fri, 18 Jul 2014 05:36:14 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_private pInterruptURB rename to interrupt_urb

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_private remove dead variables
Malcolm Priestley [Fri, 18 Jul 2014 05:36:13 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_private remove dead variables

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: remove dead structure struct vnt_tx_pkt_info
Malcolm Priestley [Fri, 18 Jul 2014 05:36:12 +0000 (06:36 +0100)]
staging: vt6656: remove dead structure struct vnt_tx_pkt_info

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_rcb remove camel case
Malcolm Priestley [Fri, 18 Jul 2014 05:36:11 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_rcb remove camel case

Camel case changes
pDevice -> priv
pUrb -> urb
bBoolInUse -> in_use

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: struct vnt_rcb remove unused members
Malcolm Priestley [Fri, 18 Jul 2014 05:36:10 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_rcb remove unused members

Remove Next and Ref

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: fix module_param_named tx_buffers variable
Malcolm Priestley [Fri, 18 Jul 2014 05:36:09 +0000 (06:36 +0100)]
staging: vt6656: fix module_param_named tx_buffers variable

Should point to vnt_tx_buffers

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
10 years agostaging: vt6656: usb_device_reset remove camel case
Malcolm Priestley [Fri, 18 Jul 2014 05:36:08 +0000 (06:36 +0100)]
staging: vt6656: usb_device_reset remove camel case

Camel case change
pDevice -> priv

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>