From: Felix Fietkau <nbd@openwrt.org>
Date: Mon, 30 Jun 2014 08:19:52 +0000 (+0000)
Subject: build: Introduce PKG_CHECK_FORMAT_SECURITY
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=ff9595dbcf642336e1b1129f25365563f53b7752;p=openwrt%2Fstaging%2Fnbd.git

build: Introduce PKG_CHECK_FORMAT_SECURITY

The idea is to get rid of
http://en.wikipedia.org/wiki/Uncontrolled_format_string
by using "-Wformat -Werror=format-security" by default

Signed-off-by: Etienne CHAMPETIER <etienne.champetier@free.fr>

SVN-Revision: 41412
---

diff --git a/include/package.mk b/include/package.mk
index f7da9e3499..7d75f08444 100644
--- a/include/package.mk
+++ b/include/package.mk
@@ -14,6 +14,7 @@ PKG_INSTALL_DIR ?= $(PKG_BUILD_DIR)/ipkg-install
 PKG_MD5SUM ?= unknown
 PKG_BUILD_PARALLEL ?=
 PKG_USE_MIPS16 ?= 1
+PKG_CHECK_FORMAT_SECURITY ?= 1
 
 ifneq ($(CONFIG_PKG_BUILD_USE_JOBSERVER),)
   MAKE_J:=$(if $(MAKE_JOBSERVER),$(MAKE_JOBSERVER) -j)
@@ -33,6 +34,9 @@ ifdef CONFIG_USE_MIPS16
     TARGET_CFLAGS += -mips16 -minterlink-mips16
   endif
 endif
+ifeq ($(strip $(PKG_CHECK_FORMAT_SECURITY)),1)
+  TARGET_CFLAGS += -Wformat -Werror=format-security
+endif
 
 include $(INCLUDE_DIR)/prereq.mk
 include $(INCLUDE_DIR)/host.mk