From: Ian Abbott Date: Thu, 31 Jul 2014 13:47:55 +0000 (+0100) Subject: staging: comedi: amplc_pci224: no need to comedi_set_hw_dev() here X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=fe10bdbda634597b4853cd45bc655e1bc8f3d89e;p=openwrt%2Fstaging%2Fblogic.git staging: comedi: amplc_pci224: no need to comedi_set_hw_dev() here The comedi core module calls `comedi_set_hw_dev()` to associate the hardware `struct device` with the `struct comedi_device` before it calls the comedi driver's "auto_attach" hook `pci224_auto_attach()`. There is no need for `pci224_auto_attach()` to call `comedi_set_hw_dev()` itself, so remove the call. Signed-off-by: Ian Abbott Reviewed-by: H Hartley Sweeten Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/drivers/amplc_pci224.c index a01504ac0443..0b056cfd0136 100644 --- a/drivers/staging/comedi/drivers/amplc_pci224.c +++ b/drivers/staging/comedi/drivers/amplc_pci224.c @@ -1084,8 +1084,6 @@ pci224_auto_attach(struct comedi_device *dev, unsigned long context_model) if (!devpriv) return -ENOMEM; - comedi_set_hw_dev(dev, &pci_dev->dev); - ret = comedi_pci_enable(dev); if (ret) return ret;