From: Al Viro Date: Fri, 21 Dec 2007 06:20:33 +0000 (+0000) Subject: typhoon: missing le32_to_cpu() in get_drvinfo X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=fdcfd77c813ef7997a60856812805f4cfbeb6222;p=openwrt%2Fstaging%2Fblogic.git typhoon: missing le32_to_cpu() in get_drvinfo in typhoon_get_drvinfo() .parm2 is little-endian; not critical since we just get the firmware id flipped in get_drvinfo output on big-endian boxen, but... Signed-off-by: Al Viro Signed-off-by: Jeff Garzik --- diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index 67f31a21beba..497c5846ded7 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -1056,7 +1056,7 @@ typhoon_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) if(typhoon_issue_command(tp, 1, &xp_cmd, 3, xp_resp) < 0) { strcpy(info->fw_version, "Unknown runtime"); } else { - u32 sleep_ver = xp_resp[0].parm2; + u32 sleep_ver = le32_to_cpu(xp_resp[0].parm2); snprintf(info->fw_version, 32, "%02x.%03x.%03x", sleep_ver >> 24, (sleep_ver >> 12) & 0xfff, sleep_ver & 0xfff);