From: Ben Kao Date: Tue, 15 Jan 2019 09:36:07 +0000 (-0200) Subject: media: ov8856: Modify ov8856 register reading function to be simplified X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=fa6527340141bfec061db2f2a9cca7f82584f94e;p=openwrt%2Fstaging%2Fblogic.git media: ov8856: Modify ov8856 register reading function to be simplified We use put_unaligned_be16() to be simplified for setting register address in ov8856_read_reg() and use sizeof() to be better suited for bytes copying. Signed-off-by: Ben Kao Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c index c0d44082c003..dbf1095b9440 100644 --- a/drivers/media/i2c/ov8856.c +++ b/drivers/media/i2c/ov8856.c @@ -605,16 +605,17 @@ static int ov8856_read_reg(struct ov8856 *ov8856, u16 reg, u16 len, u32 *val) { struct i2c_client *client = v4l2_get_subdevdata(&ov8856->sd); struct i2c_msg msgs[2]; - u8 addr_buf[2] = {reg >> 8, reg & 0xff}; - u8 data_buf[4] = {0, }; + u8 addr_buf[2]; + u8 data_buf[4] = {0}; int ret; if (len > 4) return -EINVAL; + put_unaligned_be16(reg, addr_buf); msgs[0].addr = client->addr; msgs[0].flags = 0; - msgs[0].len = ARRAY_SIZE(addr_buf); + msgs[0].len = sizeof(addr_buf); msgs[0].buf = addr_buf; msgs[1].addr = client->addr; msgs[1].flags = I2C_M_RD;