From: Eric W. Biederman Date: Wed, 29 Mar 2006 00:11:01 +0000 (-0800) Subject: [PATCH] do_tty_hangup: use group_send_sig_info not send_group_sig_info X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=f96a795d4f6a8a13abe4b0d3c5d1c28ea8d7ce4b;p=openwrt%2Fstaging%2Fblogic.git [PATCH] do_tty_hangup: use group_send_sig_info not send_group_sig_info We already have the tasklist_lock so there is no need for us to reacquire it with send_group_sig_info. reader/writer locks allow multiple readers and thus recursion so the old code was ok just wastful. Signed-off-by: Eric W. Biederman Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index 811dadb9ce3e..bd73242fe159 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c @@ -1094,8 +1094,8 @@ static void do_tty_hangup(void *data) p->signal->tty = NULL; if (!p->signal->leader) continue; - send_group_sig_info(SIGHUP, SEND_SIG_PRIV, p); - send_group_sig_info(SIGCONT, SEND_SIG_PRIV, p); + group_send_sig_info(SIGHUP, SEND_SIG_PRIV, p); + group_send_sig_info(SIGCONT, SEND_SIG_PRIV, p); if (tty->pgrp > 0) p->signal->tty_old_pgrp = tty->pgrp; } while_each_task_pid(tty->session, PIDTYPE_SID, p);