From: Kuninori Morimoto Date: Fri, 28 Jun 2019 01:48:01 +0000 (+0900) Subject: ASoC: rockchip: rockchip_rt5645: consider CPU-Platform possibility X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=f94d7b6e63b7323e89e9797dbdf6e56a3ec5d490;p=openwrt%2Fstaging%2Fblogic.git ASoC: rockchip: rockchip_rt5645: consider CPU-Platform possibility commit 27a37973a6f1 ("ASoC: rockchip: rockchip_rt5645: don't select unnecessary Platform") Current ALSA SoC avoid to add duplicate component to rtd, and this driver was selecting CPU component as Platform component. Thus, above patch removed Platform settings from this driver, because it assumed these are same component. But, some CPU driver is using generic DMAEngine, in such case, both CPU component and Platform component will have same of_node/name. In other words, there are some components which are different but have same of_node/name. In such case, Card driver definitely need to select Platform even though it is same as CPU. It is depends on CPU driver, but is difficult to know it from Card driver. This patch reverts above patch. Fixes: commit 27a37973a6f1 ("ASoC: rockchip: rockchip_rt5645: don't select unnecessary Platform") Signed-off-by: Kuninori Morimoto Signed-off-by: Mark Brown --- diff --git a/sound/soc/rockchip/rockchip_rt5645.c b/sound/soc/rockchip/rockchip_rt5645.c index fe533726d288..26b67b245484 100644 --- a/sound/soc/rockchip/rockchip_rt5645.c +++ b/sound/soc/rockchip/rockchip_rt5645.c @@ -125,7 +125,8 @@ static const struct snd_soc_ops rk_aif1_ops = { SND_SOC_DAILINK_DEFS(pcm, DAILINK_COMP_ARRAY(COMP_EMPTY()), - DAILINK_COMP_ARRAY(COMP_CODEC(NULL, "rt5645-aif1"))); + DAILINK_COMP_ARRAY(COMP_CODEC(NULL, "rt5645-aif1")), + DAILINK_COMP_ARRAY(COMP_EMPTY())); static struct snd_soc_dai_link rk_dailink = { .name = "rt5645", @@ -177,6 +178,8 @@ static int snd_rk_mc_probe(struct platform_device *pdev) goto put_codec_of_node; } + rk_dailink.platforms->of_node = rk_dailink.cpus->of_node; + ret = snd_soc_of_parse_card_name(card, "rockchip,model"); if (ret) { dev_err(&pdev->dev,