From: Linus Walleij Date: Tue, 11 Dec 2018 09:53:19 +0000 (+0100) Subject: regulator: arizona-ldo1: Rely on core to handle GPIO descriptor X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=f306d76082358fa9a3fb3e66674a5852bb48845f;p=openwrt%2Fstaging%2Fblogic.git regulator: arizona-ldo1: Rely on core to handle GPIO descriptor After making sure that the regulator core always take over handling of the GPIO descriptors, the gpiod_put() on the errorpath of the Arizona LDO1 driver becomes redundant. Reported-by: Charles Keepax Signed-off-by: Linus Walleij Acked-by: Charles Keepax Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c index 9a72eae4926d..b9a93049e41e 100644 --- a/drivers/regulator/arizona-ldo1.c +++ b/drivers/regulator/arizona-ldo1.c @@ -283,9 +283,6 @@ static int arizona_ldo1_common_init(struct platform_device *pdev, of_node_put(config.of_node); if (IS_ERR(ldo1->regulator)) { - if (config.ena_gpiod) - gpiod_put(config.ena_gpiod); - ret = PTR_ERR(ldo1->regulator); dev_err(&pdev->dev, "Failed to register LDO1 supply: %d\n", ret);