From: Lubomir Rintel Date: Tue, 28 May 2019 09:07:27 +0000 (-0400) Subject: media: marvell-ccic/mmp: enable clock before accessing registers X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=f12fb2849b11b4c571a32d31ec51eabd70ab8193;p=openwrt%2Fstaging%2Fblogic.git media: marvell-ccic/mmp: enable clock before accessing registers The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs the machine. Enable the clock first. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c index 25a4e2b580f4..bd2934a4d7ce 100644 --- a/drivers/media/platform/marvell-ccic/mmp-driver.c +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c @@ -142,6 +142,7 @@ static int mmpcam_power_up(struct mcam_camera *mcam) * Turn on power and clocks to the controller. */ mmpcam_power_up_ctlr(cam); + mcam_clk_enable(mcam); /* * Provide power to the sensor. */ @@ -155,8 +156,6 @@ static int mmpcam_power_up(struct mcam_camera *mcam) gpio_set_value(pdata->sensor_reset_gpio, 1); /* reset is active low */ mdelay(5); - mcam_clk_enable(mcam); - return 0; }