From: Łukasz Majewski <l.majewski@samsung.com>
Date: Mon, 24 Feb 2014 12:33:08 +0000 (+0100)
Subject: power: fix: Do not execute pmic command when not all necessary parameters are passed
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=eae745379d4c6453d8f8888a8003a1c1ebcfbbd3;p=project%2Fbcm63xx%2Fu-boot.git

power: fix: Do not execute pmic command when not all necessary parameters are passed

Lack of this check resulted in a data abort when CPU tried to execute the
following command (without further mandatory input): 'pmic MAX77686_PMIC'.

Only the 'pmic list' command requires one passed parameter.
Other require at least two valid parameters for correct operation.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---

diff --git a/drivers/power/power_core.c b/drivers/power/power_core.c
index 29ccc831af..fe1f316021 100644
--- a/drivers/power/power_core.c
+++ b/drivers/power/power_core.c
@@ -140,6 +140,9 @@ int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		return CMD_RET_SUCCESS;
 	}
 
+	if (argc < 3)
+		return CMD_RET_USAGE;
+
 	name = argv[1];
 	cmd = argv[2];