From: Colin Ian King Date: Fri, 15 Feb 2019 09:45:54 +0000 (+0000) Subject: regulator: axp20x: remove a redundant null check on rdev X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=ea7b971cd64b45c6be08c02e14d30ec3c9a5b336;p=openwrt%2Fstaging%2Fblogic.git regulator: axp20x: remove a redundant null check on rdev Currently rdev is dereferenced when assigning desc before rdev is null checked, this is leading to static analysis warnings. However, rdev can never be null, so the null check is redundant and can be removed. Detected by CoverityScan, CID#1476031 ("Dereference before null check") Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3") Signed-off-by: Colin Ian King Acked-by: Chen-Yu Tsai Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c index 98efc28f65ed..fba8f58ab769 100644 --- a/drivers/regulator/axp20x-regulator.c +++ b/drivers/regulator/axp20x-regulator.c @@ -372,9 +372,6 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp) const int *slew_rates; int rate_count = 0; - if (!rdev) - return -EINVAL; - desc = rdev->desc; switch (axp20x->variant) {