From: Alexander Couzens <lynxis@fe80.eu>
Date: Fri, 29 Jun 2018 03:27:16 +0000 (+0200)
Subject: swconfig: fix un-initialized return value
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=e37ad4e5ca2e70387656da81704ee4d4589c6d70;p=openwrt%2Fstaging%2Fthess.git

swconfig: fix un-initialized return value

Fix CID 1330844

Found-by: Coverity
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
---

diff --git a/package/network/config/swconfig/src/swlib.c b/package/network/config/swconfig/src/swlib.c
index e6e9aead47..0fb8ebb392 100644
--- a/package/network/config/swconfig/src/swlib.c
+++ b/package/network/config/swconfig/src/swlib.c
@@ -92,7 +92,7 @@ swlib_call(int cmd, int (*call)(struct nl_msg *, void *),
 	struct nl_cb *cb = NULL;
 	int finished;
 	int flags = 0;
-	int err;
+	int err = 0;
 
 	msg = nlmsg_alloc();
 	if (!msg) {
@@ -105,7 +105,8 @@ swlib_call(int cmd, int (*call)(struct nl_msg *, void *),
 
 	genlmsg_put(msg, NL_AUTO_PID, NL_AUTO_SEQ, genl_family_get_id(family), 0, flags, cmd, 0);
 	if (data) {
-		if (data(msg, arg) < 0)
+		err = data(msg, arg);
+		if (err < 0)
 			goto nla_put_failure;
 	}