From: Jiri Kosina <jkosina@suse.cz>
Date: Mon, 30 Jul 2012 08:40:28 +0000 (+0200)
Subject: Revert "backlight: fix memory leak on obscure error path"
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=e1c9ac420ef15e39c2ead879cda1677d1e5cb2b6;p=openwrt%2Fstaging%2Fblogic.git

Revert "backlight: fix memory leak on obscure error path"

This reverts commit 9ea3c498962bc63748e92c31c874169ab0726324.

'data' is being allocated by devm_kzalloc(), is it's actually
wrong to free() it in the error path, as it will be destroyed
properly later.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c
index f75da8758adc..f49181c73113 100644
--- a/drivers/video/backlight/88pm860x_bl.c
+++ b/drivers/video/backlight/88pm860x_bl.c
@@ -228,7 +228,6 @@ static int pm860x_backlight_probe(struct platform_device *pdev)
 	data->port = pdata->flags;
 	if (data->port < 0) {
 		dev_err(&pdev->dev, "wrong platform data is assigned");
-		kfree(data);
 		return -EINVAL;
 	}