From: Markus Elfring Date: Wed, 4 Feb 2015 15:32:15 +0000 (+0100) Subject: cw1200: Delete an unnecessary check before the function call "release_firmware" X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=df970d39b90e0c316c62a9db6d796edef2a31526;p=openwrt%2Fstaging%2Fblogic.git cw1200: Delete an unnecessary check before the function call "release_firmware" The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/cw1200/fwio.c b/drivers/net/wireless/cw1200/fwio.c index 6f1b9aace8b3..581dfdedd436 100644 --- a/drivers/net/wireless/cw1200/fwio.c +++ b/drivers/net/wireless/cw1200/fwio.c @@ -246,8 +246,7 @@ static int cw1200_load_firmware_cw1200(struct cw1200_common *priv) error: kfree(buf); - if (firmware) - release_firmware(firmware); + release_firmware(firmware); return ret; #undef APB_WRITE