From: Fabio Estevam Date: Sat, 9 Jul 2016 21:57:42 +0000 (-0300) Subject: drm/imx: imx-tve: check the value returned by regulator_set_voltage() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=deb65870b5d9d;p=openwrt%2Fstaging%2Fblogic.git drm/imx: imx-tve: check the value returned by regulator_set_voltage() regulator_set_voltage() may fail, so we better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam Signed-off-by: Philipp Zabel --- diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index a293a7dad0d9..fe36309e18c1 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c @@ -628,7 +628,9 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data) tve->dac_reg = devm_regulator_get(dev, "dac"); if (!IS_ERR(tve->dac_reg)) { - regulator_set_voltage(tve->dac_reg, 2750000, 2750000); + ret = regulator_set_voltage(tve->dac_reg, 2750000, 2750000); + if (ret) + return ret; ret = regulator_enable(tve->dac_reg); if (ret) return ret;