From: Sagi Grimberg Date: Wed, 8 Nov 2017 10:00:29 +0000 (+0200) Subject: nvmet: remove redundant memset if failed to get_smart_log failed X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=dafc040ba6d813df225a25f8b4bc3eae2207a6be;p=openwrt%2Fstaging%2Fblogic.git nvmet: remove redundant memset if failed to get_smart_log failed We already allocated the buffer with kzalloc. Signed-off-by: Sagi Grimberg Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe --- diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c index 9a7d6917e190..dd087be395b9 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -144,10 +144,8 @@ static void nvmet_execute_get_log_page(struct nvmet_req *req) } smart_log = buf; status = nvmet_get_smart_log(req, smart_log); - if (status) { - memset(buf, '\0', data_len); + if (status) goto err; - } break; case NVME_LOG_FW_SLOT: /*