From: Felix Fietkau Date: Sat, 11 Apr 2015 10:51:55 +0000 (+0000) Subject: netifd: fix start_disabled 'sh: bad number' in mac80211 setup (bug #19345) X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=daaed6f251c7714cdf7aec6dc2940a605e82eaed;p=openwrt%2Fstaging%2Fstintel.git netifd: fix start_disabled 'sh: bad number' in mac80211 setup (bug #19345) Two errors "netifd: radio0: sh: bad number" have recently surfaced in system log in trunk when wifi interfaces come up. I tracked the errors to checking numerical values of some config options without ensuring that the option has any value. The errors I see have apparently been introduced by r45051 (ieee80211r in hostapd) and r45326 (start_disabled in mac80211). My patches fix two instances of "bad number", but there may be a third one, as the original report in bug 19345 pre-dates r45326 and already has two "bad number" errors for radio0. https://dev.openwrt.org/ticket/19345 Signed-off-by: Hannu Nyman SVN-Revision: 45379 --- diff --git a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh index a7848bd8ad..ec0966ea8d 100644 --- a/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh +++ b/package/kernel/mac80211/files/lib/netifd/wireless/mac80211.sh @@ -318,6 +318,7 @@ mac80211_hostapd_setup_bss() { json_get_vars wds dtim_period max_listen_int start_disabled set_default wds 0 + set_default start_disabled 0 [ "$wds" -gt 0 ] && append hostapd_cfg "wds_sta=1" "$N" [ "$staidx" -gt 0 -o "$start_disabled" -eq 1 ] && append hostapd_cfg "start_disabled=1" "$N"