From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 17 Jul 2016 20:52:49 +0000 (-0300)
Subject: [media] cec: Delete an unnecessary check before the function call "rc_free_device"
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=d8eddb15e4e436ec44464783687f0057a38fb013;p=openwrt%2Fstaging%2Fblogic.git

[media] cec: Delete an unnecessary check before the function call "rc_free_device"

The rc_free_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---

diff --git a/drivers/staging/media/cec/cec-core.c b/drivers/staging/media/cec/cec-core.c
index 112a5fae12f5..80fcb692f4f5 100644
--- a/drivers/staging/media/cec/cec-core.c
+++ b/drivers/staging/media/cec/cec-core.c
@@ -354,8 +354,7 @@ void cec_delete_adapter(struct cec_adapter *adap)
 	if (adap->kthread_config)
 		kthread_stop(adap->kthread_config);
 #if IS_REACHABLE(CONFIG_RC_CORE)
-	if (adap->rc)
-		rc_free_device(adap->rc);
+	rc_free_device(adap->rc);
 #endif
 	kfree(adap);
 }