From: Steven Rostedt (VMware) <rostedt@goodmis.org>
Date: Fri, 24 Aug 2018 20:20:28 +0000 (-0400)
Subject: tracing/kprobe: Remove unneeded extra strchr() from create_trace_kprobe()
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=d6b183eda466415bb5defcf9afe4cb64734839e8;p=openwrt%2Fstaging%2Fblogic.git

tracing/kprobe: Remove unneeded extra strchr() from create_trace_kprobe()

By utilizing a temporary variable, we can avoid adding another call to
strchr(). Instead, save the first call to a temp variable, and then use that
variable as the reference to set the event variable.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---

diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index c30032367aab..508396edc56a 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -749,10 +749,13 @@ static int create_trace_kprobe(int argc, char **argv)
 	}
 
 	if (event) {
-		if (strchr(event, '/')) {
+		char *slash;
+
+		slash = strchr(event, '/');
+		if (slash) {
 			group = event;
-			event = strchr(group, '/') + 1;
-			event[-1] = '\0';
+			event = slash + 1;
+			slash[0] = '\0';
 			if (strlen(group) == 0) {
 				pr_info("Group name is not specified\n");
 				return -EINVAL;