From: Petr Štetiar <ynezz@true.cz>
Date: Tue, 16 May 2023 18:41:05 +0000 (+0200)
Subject: phase1: workaround gitverify 1st build failures on fresh workers
X-Git-Tag: v4^0
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=d47fd60cde0df5103add3402f76e5d2b84013a83;p=buildbot.git

phase1: workaround gitverify 1st build failures on fresh workers

Currently every 1st build on ephemeral build worker results in the
failure of the `gitverify` build step as the stock buildbot Git() build
step for some reasons just clones the Git repository into detached HEAD
state.

On the 2nd build using the same build worker Git() checkouts the branch
and thus makes `gitverify` step happy and the builds then continues
normally.

This needs to be fixed properly, either by adjusting the `gitverify`
check or adding suitable `mode` into Git() build step, but this needs
more time and testing.

So for now, lets simply workaround that issue by running Git() step two
times.

References: #5
Signed-off-by: Petr Štetiar <ynezz@true.cz>
---

diff --git a/phase1/master.cfg b/phase1/master.cfg
index c392c5f..1658a91 100644
--- a/phase1/master.cfg
+++ b/phase1/master.cfg
@@ -725,6 +725,16 @@ for target in targets:
 		haltOnFailure = True,
 	))
 
+	# workaround for https://github.com/openwrt/buildbot/issues/5
+	factory.addStep(Git(
+		name = "git me once more please",
+		repourl = repo_url,
+		mode = 'full',
+		method = 'fresh',
+		locks = NetLockDl,
+		haltOnFailure = True,
+	))
+
 	# update remote refs
 	factory.addStep(ShellCommand(
 		name = "fetchrefs",