From: Sudip Mukherjee Date: Thu, 16 Jul 2015 11:28:10 +0000 (+0530) Subject: staging: rtl8188eu: remove unneeded variable X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=ce806322730a2b29fd15c7873c09335a49b7a941;p=openwrt%2Fstaging%2Fblogic.git staging: rtl8188eu: remove unneeded variable The default value of status was _FAIL, it was only changed if kzalloc succeeds and the check for status is immediately following kzalloc. We can have the failure code in the else part as the failure code will be executed only if kzalloc fails. Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index f68875bd9511..2d75c77c8cdb 100644 --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c @@ -55,7 +55,6 @@ MODULE_DEVICE_TABLE(usb, rtw_usb_id_tbl); static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf) { int i; - int status = _FAIL; struct dvobj_priv *pdvobjpriv; struct usb_host_config *phost_conf; struct usb_config_descriptor *pconf_desc; @@ -117,10 +116,7 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf) if (pdvobjpriv->usb_vendor_req_buf) { usb_get_dev(pusbd); - status = _SUCCESS; - } - - if (status != _SUCCESS) { + } else { usb_set_intfdata(usb_intf, NULL); kfree(pdvobjpriv); pdvobjpriv = NULL;