From: Daniel Nilsson Date: Sat, 2 Mar 2024 10:35:04 +0000 (+0100) Subject: luci-base: use correct regex for time validation X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=cd7e519642ecf37d1f20cf4707b1c1f80c89cabf;p=project%2Fluci.git luci-base: use correct regex for time validation Before this change, values further in time than 23:59:59 was allowed, such as 24:00:00 and 23:60:00. Leap seconds is accounted for so 60 is allowed in the seconds parameter. Signed-off-by: Daniel Nilsson (cherry picked from commit c68ec2f910007c77874816fc0b829df78ca47aa0) --- diff --git a/modules/luci-base/htdocs/luci-static/resources/validation.js b/modules/luci-base/htdocs/luci-static/resources/validation.js index e4f8c7a201..5719031cb7 100644 --- a/modules/luci-base/htdocs/luci-static/resources/validation.js +++ b/modules/luci-base/htdocs/luci-static/resources/validation.js @@ -563,7 +563,7 @@ var ValidatorFactory = baseclass.extend({ }, timehhmmss: function() { - return this.assert(this.value.match(/^[0-6][0-9]:[0-6][0-9]:[0-6][0-9]$/), + return this.assert(this.value.match(/^(?:[01]\d|2[0-3]):[0-5]\d:(?:[0-5]\d|60)$/), _('valid time (HH:MM:SS)')); },