From: Geert Uytterhoeven Date: Wed, 31 Jul 2019 12:47:38 +0000 (+0200) Subject: spi: core: Use DEVICE_ATTR_RW() for SPI slave control sysfs attribute X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=cc8b4659491d23577eb8992449d82c7f4f4fc170;p=openwrt%2Fstaging%2Fblogic.git spi: core: Use DEVICE_ATTR_RW() for SPI slave control sysfs attribute Convert the SPI slave control sysfs attribute from DEVICE_ATTR() to DEVICE_ATTR_RW(), to reduce boilerplate. Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20190731124738.14519-1-geert+renesas@glider.be Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 75ac046cae52..9fd7926e80c0 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2105,8 +2105,8 @@ static int match_true(struct device *dev, void *data) return 1; } -static ssize_t spi_slave_show(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t slave_show(struct device *dev, struct device_attribute *attr, + char *buf) { struct spi_controller *ctlr = container_of(dev, struct spi_controller, dev); @@ -2117,9 +2117,8 @@ static ssize_t spi_slave_show(struct device *dev, child ? to_spi_device(child)->modalias : NULL); } -static ssize_t spi_slave_store(struct device *dev, - struct device_attribute *attr, const char *buf, - size_t count) +static ssize_t slave_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) { struct spi_controller *ctlr = container_of(dev, struct spi_controller, dev); @@ -2157,7 +2156,7 @@ static ssize_t spi_slave_store(struct device *dev, return count; } -static DEVICE_ATTR(slave, 0644, spi_slave_show, spi_slave_store); +static DEVICE_ATTR_RW(slave); static struct attribute *spi_slave_attrs[] = { &dev_attr_slave.attr,