From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Date: Tue, 7 Aug 2018 12:19:35 +0000 (+0100)
Subject: nvmem: core: return error code instead of NULL from nvmem_device_get
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=ca6ac25cecf0e740d7cc8e03e0ebbf8acbeca3df;p=openwrt%2Fstaging%2Fblogic.git

nvmem: core: return error code instead of NULL from nvmem_device_get

nvmem_device_get() should return ERR_PTR() on error or valid pointer
on success, but one of the code path seems to return NULL, so fix it.

Reported-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index aa1657831b70..6f064002f439 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -679,7 +679,7 @@ static struct nvmem_device *nvmem_find(const char *name)
 	d = bus_find_device_by_name(&nvmem_bus_type, NULL, name);
 
 	if (!d)
-		return NULL;
+		return ERR_PTR(-ENOENT);
 
 	return to_nvmem_device(d);
 }