From: Tillmann Heidsieck Date: Wed, 23 Sep 2015 20:07:54 +0000 (+0200) Subject: staging: wlan-ng remove redundant conditional X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=c739c987c1e19b924b252ebb12ffeac3ef9b1d5c;p=openwrt%2Fstaging%2Fblogic.git staging: wlan-ng remove redundant conditional We exit the above loop either if curroff >= (HFA384x_PDA_LEN_MAX / 2 - 1) or if we found the END marker in the element beyond the current one. The first case is checked for in the preceding if statement, therefore the second if statement is redundant and can be removed. Signed-off-by: Tillmann Heidsieck Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index d357b7ecb1fc..f5b97273164d 100644 --- a/drivers/staging/wlan-ng/prism2fw.c +++ b/drivers/staging/wlan-ng/prism2fw.c @@ -631,10 +631,8 @@ static int mkpdrlist(struct pda *pda) curroff, pda->nrec); return 1; } - if (le16_to_cpu(pda16[curroff + 1]) == HFA384x_PDR_END_OF_PDA) { - pda->rec[pda->nrec] = (hfa384x_pdrec_t *) &(pda16[curroff]); - (pda->nrec)++; - } + pda->rec[pda->nrec] = (hfa384x_pdrec_t *) &(pda16[curroff]); + (pda->nrec)++; return result; }